From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11FBC021AA for ; Wed, 19 Feb 2025 02:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FB402801D0; Tue, 18 Feb 2025 21:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AB282801CF; Tue, 18 Feb 2025 21:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 472FE2801D0; Tue, 18 Feb 2025 21:26:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 287FD2801CF for ; Tue, 18 Feb 2025 21:26:16 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A54A8B186C for ; Wed, 19 Feb 2025 02:26:15 +0000 (UTC) X-FDA: 83135104710.15.63D20DA Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf23.hostedemail.com (Postfix) with ESMTP id CA3A0140005 for ; Wed, 19 Feb 2025 02:26:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lft+X4la; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739931974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OKAu9cP1VyXXRGu/Q46hWn+GVwoDBvQa3gtfujndEZY=; b=ZjbOzvoVvh1ammPegoLzJfh/yRmuMbCl/D3aC/B2IQeZ966cOnPpFEzWmsXYW5aiGu/Qzl zXqcEGYRkVJaT+u/vIndU/l3+D/AdiiBT9goi/rT4ZQIPJUXNXX8T/H9P7mFHoa+5yOfZi LvMVDX8GqzyD47TptbPzIDGgH6cSM0U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lft+X4la; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739931974; a=rsa-sha256; cv=none; b=0QCqR6kqK8ibkLXM+qhQWKLgeey0gRV/25ako4ZdsMhRNOOCZvnKn8PuaVGpLhrBKei0Wo ttrxApZf+66RkB20kpM3HeSd3+NMr+eQOEv7lBlRy1tueMIa8ojveBrKvIvKvXxKMZBjUF 5qzdtG/J93OlSw8gO42LyBbgD+RXj7o= Date: Tue, 18 Feb 2025 18:26:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739931971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OKAu9cP1VyXXRGu/Q46hWn+GVwoDBvQa3gtfujndEZY=; b=lft+X4larQiMUh/x7eGgPYKGgRK5qk7Ily0Tw2UXmNOoq4q9SNIo/V+zAaaU7am2N8xPas JUpvkTiJhYObGKOuUtsnu0Pab6e27Zgjsn7HH/ZG9U5fZ26ZbCWE7wKamt30Ceeyh6B0OT erUFtnTvpmLnr6zbkSfteWeFiRKuFec= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 02/11] cgroup: add level of indirection for cgroup_rstat struct Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-3-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-3-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CA3A0140005 X-Stat-Signature: qi7o4gyd13pe57hi3fk5c6crjjeib7d3 X-HE-Tag: 1739931973-329120 X-HE-Meta: U2FsdGVkX1/ibvGYEyzJxoB8Gvmc1mAK8aNT7qilWBvEi47NzwKTNgBqp8e7MvbK5oFfGVBcUs142qx3XFz0PXO/rn/c7MQPJS0GPaQahhX9fY2lGdSQA8Ifa7ks4psuZGrNIrBoVJoAWdlCwp9YdM2HEcrLYevPM6RUrOgUG7WOrr/dgNrytdORcdXZfG1RZcxE6OrkfAgcOSdXpGKVZTlgb9639j5PtlqcSTU92kC3Gk0abkLpixeBfs6p1RdKjX42PGc+mtrQn6Jrccp2olGZnFAJRRKvJUG5ct3M1EFC4G9LUpNkFGs8YqzOg3FCgRU/t5DJimgG2KhhPtaYDFoJw3gLx9JXWSyx+4k3aFNwqW0bUdtrk6aTGduK3D36Helv0mTlYPJyghNKzvuLgxiLe8HMpL/z0Pyu8jq0B+JDQAJQDoYtQAcrmatiWgVG2dszzwHWZh92ZpRq7Ogc75r4yoq/5ApqaNvlTurpYwImb3iCX5reDT0U3S5fKSV3dal4/FwS4qf0rBfSv4sdUyT4zmEuN+NAF8LsM1HFvH3ilzjjgoXyv86I8RwOsjgyAzdEXCgy0A+RmIahx3F0aXk6OANhUn97SWBX6s9TTKhXcJQFtihcp5XvIXX4mgtzToUO41YhdOMaqhREv+7uwasp7lIs9xRVeAavIEI0pVQIlo4l3lKXTuBUJtpnf+VsNnmm8QFHxz1dys0wE7j4IAd+eLKCOVDQlzLN8COsrt6WRNBH2FHQ9JbE5X8CspLCpI/a/ZrtWM5ApPpeXy++uV/Hg/E4lpiDsy+3Nlwh0TI2j7T0zm6ustv6mbvyGnp5cTPp+SnHg8Nxvt2qsLRoc7bezf8f4gjiDvti1wEqjiNOHJdjvEFAJbhwS6LauuLrgZ2JDvSZTJUZ/1RD4zl4h/+dLU9p5oiXWwX0kZNB4+219gy030eAPICNTQEMuMLIk3nwSSoHzh6H6ZbD6HX ZkM6a0lc 1zoV1mZnBLnEpIS62hoQMTWjDpw/VzX04eDn8CY4/Z3DB0jQK67o2vzs9+d4MEL1eEidRgcVtZg/0s0X4h5FWDpbMpLwtFaTxsQ8WH4Xs4AvHWssKXOHsqdmLAgNwZVTrr9FBoCGKQK9j0DberK0/BcbfDkiRO0L/t0YCWlC7gvOm4vmwxhH1YWhTnyhEvWdw5kIcKC2NI/XIuxqKwAhhA7wyaDfc9KD+ZSQ+gCz7Su2ZQROWtDQa5FNYpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:39PM -0800, JP Kobryn wrote: > Change the type of rstat node from cgroup to the new cgroup_rstat > struct. Then for the rstat updated/flush api calls, add double under > versions that accept references to the cgroup_rstat struct. This new > level of indirection will allow for extending the public api further. > i.e. the cgroup_rstat struct can be embedded in a new type of object and > a public api can be added for that new type. > > Signed-off-by: JP Kobryn I think the code looks good here but the commit message needs some massaging. From what I understand, you are trying to decouple struct cgroup_rstat from struct cgroup, so later you can move struct cgroup_rstat in different structure (and maybe later some new structure can all include cgroup_rstat to take advantage of rstat infra). I am not sure I would call this "add level of indirection".