From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C21EC001E0 for ; Mon, 31 Jul 2023 17:21:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6A1128008C; Mon, 31 Jul 2023 13:21:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B19F328007A; Mon, 31 Jul 2023 13:21:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9937D28008C; Mon, 31 Jul 2023 13:21:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8AC6128007A for ; Mon, 31 Jul 2023 13:21:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 605D51202EE for ; Mon, 31 Jul 2023 17:21:05 +0000 (UTC) X-FDA: 81072572490.29.7C4BCBE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 33D0740006 for ; Mon, 31 Jul 2023 17:21:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h6A+vpnZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690824063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n5ngqZBDf0cyFOLr/EV9FYkGhOEjZk258ZtGJgwKwNc=; b=ByY98KGSCcBwejPcD5UGPd3+RO2domKeZ6zMMwORqQr+2B4kKbBEvh5bb79OWh70HqkGr3 Hhp3eyBQ3kVPpUL2tDPWRh8yyGjxw5isvZMrXwzEmPTVXPtVKtBedV8mFZ9KCqkI61OYSk eRXUnsMGJ1SbVMnIBNjGJVwUM6Dh6RI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h6A+vpnZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690824063; a=rsa-sha256; cv=none; b=xERT4CPJ5BIhtLms08lusmjEJ86x42xsGG4DiRtojibW7PwJLfApl6109Gi5yg688gh7XM lTmOUX6muBQUxSa5zpNRfnMAFeU3zM/BxL+LcZToI8pypX4gbXy++/6Nanv2Gbhs43mtZZ Ib1/CX0dzUyY0wWgBT5piyLTej8K8iU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690824062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n5ngqZBDf0cyFOLr/EV9FYkGhOEjZk258ZtGJgwKwNc=; b=h6A+vpnZFCGjhKUPtElFri3jfAIAScSxK3BmnlqM9CVa763NaPv/yWG4N1Z1AaEJGsaSJJ bZW2kn/8ihoRVdWIbVeqHKb0V7K8imbA0r957iJwPKAfGuqC9Fya1HusnNxu0ifROaOEUC ZzopbwlD8wHwd7MbpGmhTVazOZ50a28= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-cuDq6LqePDeXb-aXM-TSMQ-1; Mon, 31 Jul 2023 13:21:01 -0400 X-MC-Unique: cuDq6LqePDeXb-aXM-TSMQ-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-58456435437so57292017b3.0 for ; Mon, 31 Jul 2023 10:21:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690824060; x=1691428860; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8NfShcrH5vNeU09yfaTlylFugR/gu1+MgjXGX+9Q5ac=; b=Zuekrr1oZuH7X3qK8k3xIhFf/AtJZridocMqeqqarVHAL9VtRI3WuEP79z5p0zt4LF IOIcpjgf7SrFRNvH2Mr1LzoCuDWBIMl0up2gzuhvJOr5bPsWD0Edrt6yWR2VGPAv1Zqq DuTqHNpF6XO32KcmSkRnm9k+b/kQtsVhL3DPsoYHRVYFxSskBOh0mtp5jhd/IynxhskB zuLVjKAWp1Jt9at0xaa5UJhCGMUx6MIyvmEnybksk1Ac6q/nHgjaDR5ay956PTZh6m2x sGTxw6hLkirHTQ792mSoiSMU1rNENlTZ75ei+svYbnUPbvUNflA4J+yBOn8dTWi0zzaG aeTw== X-Gm-Message-State: ABy/qLYbB/YsO85aVsiJQKQ2YvGemsMeu5T8pDIZ/V3mIYW/QrjKI5iA 3S60OZXHswYQsb5iOsuIAVm5jDxA6dlOBERulYOFC6mgyeasP1zPC0eYEtgyjqF0kNok5hCHOyL 81SPiPTlEees= X-Received: by 2002:a81:c24f:0:b0:583:4304:75a4 with SMTP id t15-20020a81c24f000000b00583430475a4mr10696675ywg.29.1690824060489; Mon, 31 Jul 2023 10:21:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbVJszIfUaYg4Uc4+wm7XQPO4r+bpFj464rdlreCyyKuJOaZIruagzYqntofPsjWen070/Bg== X-Received: by 2002:a81:c24f:0:b0:583:4304:75a4 with SMTP id t15-20020a81c24f000000b00583430475a4mr10696647ywg.29.1690824059920; Mon, 31 Jul 2023 10:20:59 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id 10-20020ac8208a000000b00401f7f23ab6sm3744764qtd.85.2023.07.31.10.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 10:20:59 -0700 (PDT) From: Valentin Schneider To: Dan Carpenter , Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU In-Reply-To: References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> <04f20e58-6b24-4f44-94e2-0d12324a30e4@kadam.mountain> <20230731115453.395d20c6@gandalf.local.home> Date: Mon, 31 Jul 2023 18:20:49 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 33D0740006 X-Stat-Signature: 1xw1t7hr77exr7qgr9n1s3e7wosnri9x X-Rspam-User: X-HE-Tag: 1690824062-823958 X-HE-Meta: U2FsdGVkX19t7lYHchu55YbpuwS7S3nK9D4b/qjFGTMiRyLm1Gkbhc9jFEOVzfM1OulyFU+LjZ9Af7FAhZEYZCSwTC27X9F7tMAf8cjwx0fiSVfOGTzgrNRftkmWtvWD+wFqBr1LtMynr9nTA9yxZj68rBFRajjx3jAAQoBbNdJDsEpnPcHRKr74OvptQNU8Wr/pKEqhJMrz0cc2iwGYpdF7WHRdV2HeDNuFDMCIwj0O3WRtmQ1G2T9m4fqjFt48b49iAm83kKfX5PHHisUe/PiHF1WRgnZUVVnXdftrITGNE3NP63QFMYURalUKa67aP0OSRC7/5x9KxXaCZX7VjxADctPDcW4ot7OxD4esB3MyWCeF64NGQpuB9SGydn/oJsn2jUMAa+rSlilX9cLvZ2Dob8ZsZXz5D4FGXdOoOwlGWIhq0ACAEDTNmbPJ6Co/eQqhq7fuTxU0V+Qzr61ZA97hW579hKwoeQRLy+wsGmL83zXLmpcGJ8uPK2493/81tkF5vrDMnzkri4TQbf/32BQu6WXJ8/9Sv7cdDqC6TcosIbZJ736NlxG+UZ34v3oAUeO9f4iioZpDxe7UXmO0b6rXyE8sQB//QwTUHGCosCG38ZDDkO79vwsdyFSK/Q3xitxJ371SUJXJa5H3uIYsBWJYxIt+FV8Uq1VsNXKhgcmcc4u6xXDXAb5Wb3pFsksu80dSt06AxKzP3Ank3HdPC2n7IXfGrNfRCKCiisJqcM/xvGCU3xDu5QcYgFdnGhQKCvnxlNNOdReLdowbuyf1/e8Rlo3ucOm/QPC/VVtAL9Yn8hjRo1G+GdFCx6uOLA3SiguqpDI3gOh5pS0SsrW4VhVmw8WQ54yxmu+DCujDVTVjZpBOSHb1/4qhD7ldXsQx4bFJl7RvM7rYNO5Z2FsagnjaKyrmI6jePcoEM5YApZQGfEJuMO7CTpyMC4T8IRiooWjG/ql0CeYpq1HZEv5 lYlHnLJ9 0KeMUiYCPi2TdiAY/Q3pSZ6myLBl+xMJr7vLn6mfRC0NCsbs+Sc7T9fu3Bqfy0FeaaV5dB5PacLgiZFAS50MvVBuTj2rgyI70ngt6EIUjeO2Brtlt5GhpjnzF1AKBGycjd+OKVB6uOdHMxO21SpXlydTc7PjRYD/loFPVIi+EV68SfynhF64mk73b7EkdWwt6ed5qyzKZt7jach3O0DhwFTbxpGBW0QJXT1JxgRUt8w5MC/zzP4W0zbhfjKcvBgDByfRAGYUYZ1F7PkFHxg6WhKFl18WIsY0f8aK3e+Wjxo5QSqzM+2IVrSQXegWceNcc+98A+rpK5lyXySs0hDJR1qofCTm2VnSdQG22KPD06aRJaCVAKLv286JYbIzL1/oNTwzv3rB6ki0gmRbyRntBIqLMM9Koj8TdaYYQzLWKu8NQIZKf4QUhOFCWKzrItO0icH5E8+UvaAlgCqFTuZYh3idIabMlQ8Zs49POrATgFVEZcbRpKWXtNwDmAscM5hMo77qMJqFq1QMV/v0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31/07/23 19:03, Dan Carpenter wrote: > On Mon, Jul 31, 2023 at 11:54:53AM -0400, Steven Rostedt wrote: >> On Mon, 31 Jul 2023 15:07:52 +0300 >> Dan Carpenter wrote: >> >> > On Sat, Jul 29, 2023 at 03:55:47PM -0400, Steven Rostedt wrote: >> > > > @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void= *data, >> > > > FILTER_PRED_FN_CPUMASK; >> > > > } else if (field->filter_type =3D=3D FILTER_CPU) { >> > > > pred->fn_num =3D FILTER_PRED_FN_CPU_CPUMASK= ; >> > > > +=09=09} else if (single) { >> > > > +=09=09=09pred->op =3D pred->op =3D=3D OP_BAND ? OP_EQ : pred->op; >> > > >> > > Nit, the above can be written as: >> > > >> > > pred->op =3D pret->op !=3D OP_BAND ? : OP_EQ; >> > > >> > >> > Heh. Those are not equivalent. The right way to write this is: >> >> You mean because of my typo? > > No, I hadn't seen the s/pred/pret/ typo. Your code does: > > if (pred->op !=3D OP_BAND) > pred->op =3D true; > else > pred->op OP_EQ; > > Realy we should probably trigger a static checker warning any time > someone does a compare operations as part of a "x =3D comparison ?: bar; > Years ago, someone asked me to do that with regards to error codes like: > > return ret < 0 ?: -EINVAL; > > but I don't remember the results. > FWIW this is caught by GCC: error: the omitted middle operand in ?: will always be =E2=80=98true= =E2=80=99, suggest explicit middle operand [-Werror=3Dparentheses] pred->op =3D pred->op !=3D OP_BAND ? : OP_EQ; > regards, > dan carpenter