From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF177C36008 for ; Tue, 25 Mar 2025 17:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E740C28003F; Tue, 25 Mar 2025 13:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFDB2280005; Tue, 25 Mar 2025 13:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28F028003F; Tue, 25 Mar 2025 13:52:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9A161280005 for ; Tue, 25 Mar 2025 13:52:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A2B11160AB5 for ; Tue, 25 Mar 2025 17:52:44 +0000 (UTC) X-FDA: 83260818648.06.A5F0814 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 592BBC0008 for ; Tue, 25 Mar 2025 17:52:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G12cdrLZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742925162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=58+r+FAQ5TTby/P3+2e15XArHywgR9oB31F4zzKw58o=; b=z6bZhjx8SiHaAFiww+n9eUMWwcDWWkERVSqYKS+uBUpntUxXqhKUbIvhCpfdHWjobOcLq1 Pvp4GqEsbejIFkFGEnmYvqWyPqcl+3GCaIpepudGlkgURz0fqUPIeZ2etk8W2UHEKAmaP3 MBFIDKH9u7n3c8yDUDEvzbuMt4E++Rs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=G12cdrLZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742925162; a=rsa-sha256; cv=none; b=cZvJ4EYtw3IL+KWoCxklWZuHbL0TGAo/HI7g7WfP0c29vSpA+bPVjpZxi9lO7MviXIi0hB fOrmu1yV1/0sSTiMbCEj9rdCC+CyDaElWimx9HyozC5i8uprL5ZoJFJCvnBzOwz9YSUZK8 oNz1YVpOyZPXcoF/vhvn/Irl87q5HDY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742925161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=58+r+FAQ5TTby/P3+2e15XArHywgR9oB31F4zzKw58o=; b=G12cdrLZiH2O0I4Fg9LV2QgbNKilLkFryvzQoZqQyrdz4IU7BXV+H8AgVX+ixYY3mzjs0J pr8rcxZr3R2Od8PodkTO80jh4WHY8KNzNIjFL+0u585isJEqAChbTEthKR4TJWoPYyrqkh Lpm5nAIXo8zJzGyw9V+1NuhsjdY9mtU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-0oBut2l9Os28_10ftvhF6g-1; Tue, 25 Mar 2025 13:52:40 -0400 X-MC-Unique: 0oBut2l9Os28_10ftvhF6g-1 X-Mimecast-MFC-AGG-ID: 0oBut2l9Os28_10ftvhF6g_1742925159 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so45854435e9.2 for ; Tue, 25 Mar 2025 10:52:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742925159; x=1743529959; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=58+r+FAQ5TTby/P3+2e15XArHywgR9oB31F4zzKw58o=; b=Mrgwf8/+h6DhhgS5g/7U5Q58THMmJmntBFXZzIPR/vTIowArn2jcal0EADvJgi2aDH n5yEcSg1MyCFF2cqNsJY3bTdcSDiRd5lxsWUY280bEKJY5N7Pnrd+MHZbvC5k0ROPkQ8 qy+2Y36gZuxkARA/eI/T2ELh8R7O0y9A1jM9esMDHbuiJVPHrLOxQmgBZNechJ14MxKC Fw8eEjIo18DKd/Ju3EhmLb1/pOKyVZVS3I78t7lX+ID3hKxFcTo+7iiKXZcI/2aJB5Z9 cQ884qXlG3hyVZiZGksu1QhSa28ulLTgOdm+tnQQyAGZa3qe93C0pwCGvdn94urgHsZ/ 3Zrw== X-Forwarded-Encrypted: i=1; AJvYcCV0Qbs2q+fgk7Jdl9D82QXwlee3XNyQnH+IRE8BG99vFcp45e84L7X5eG+B2t7XTbr6kPYC/x0KDw==@kvack.org X-Gm-Message-State: AOJu0Yw/uaPVpaX9hKwMUE6IjM282gzJ5gZrd2jJhzuuH56f1TD9jIdu dkqs3aYl/HeehHVtn6IhjRDy6viuV/CPfszhdp868ZVjOBhw4R7iBS0MC4euFlLZL/63P8EH2SA rbJHlqvbxAx6Tlgf0SJKH4tYutfg82LzpUzoZs6AWsZJQ0bxi X-Gm-Gg: ASbGncsT21zLE4ik6DmcH1LpLxqUMyLPZpZ7MrEjnzUvKjQk6AMWPs+5RmQEmkTLGrh dILOZqJhnY1PYAxo2LfF1Iv3gwB7nIU51o69W8CoVnl/V8pktLDul3c2jb6wi6r+zWOT95c1XzE MVvKKblJpMeUlHQJiPsArEjr6OwEhmAGhQv5GZvPl24eXBZ4X3rbjFnviqWtedZHT8SSMgGTx4m OPsZMLaOWhLjuwqxzHzpUsaiCRws5LnD2iXn8/XBZu8LedP1jAizbOHs76QGGaCbpa30c6ecynV T2UAfSsRz/kQ6fYpWYeRSuM5ON4Fz9JcUF7e5k2Y7pRVIqQqvykKiGGu4P8rJJ4z/+ttrrGsDjQ C X-Received: by 2002:a05:600c:4584:b0:43c:fe85:e4ba with SMTP id 5b1f17b1804b1-43d509f4b25mr191666315e9.15.1742925159164; Tue, 25 Mar 2025 10:52:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE+waNkOHjpFuU78xXxVfBVrthL7+/n2itqapsAHnKkAlkbjOyC6OGUhEtlUEcPF/6kvS3dA== X-Received: by 2002:a05:600c:4584:b0:43c:fe85:e4ba with SMTP id 5b1f17b1804b1-43d509f4b25mr191665765e9.15.1742925158655; Tue, 25 Mar 2025 10:52:38 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-141-166.abo.bbox.fr. [213.44.141.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9b409fsm14543767f8f.50.2025.03.25.10.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 10:52:37 -0700 (PDT) From: Valentin Schneider To: Dave Hansen , Jann Horn Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: Re: [PATCH v4 29/30] x86/mm, mm/vmalloc: Defer flush_tlb_kernel_range() targeting NOHZ_FULL CPUs In-Reply-To: <408ebd8b-4bfb-4c4f-b118-7fe853c6e897@intel.com> References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-30-vschneid@redhat.com> <352317e3-c7dc-43b4-b4cb-9644489318d0@intel.com> <408ebd8b-4bfb-4c4f-b118-7fe853c6e897@intel.com> Date: Tue, 25 Mar 2025 18:52:34 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PnS1ZRUrf1VfwCVmcgK0VugWUALSaTDOeCIZ1k85u4Q_1742925159 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam01 X-Stat-Signature: bdp9d9pi6n5yjbsjew5zhjk8gap88g1k X-Rspam-User: X-Rspamd-Queue-Id: 592BBC0008 X-HE-Tag: 1742925162-989549 X-HE-Meta: U2FsdGVkX1+ZeM2A4zEzco6vB5rtJm1c+a+GoePt3IJumWgsjw+avZiEjUqjNL9PnTBG5h8/UaJtWRFJhxg+RDuNYO717KzyaeTQz40ezBLvqsyd2KuwbkYnMFCma4rlcpDKqFpK6LofeI7rLyltESS/1553Pgr9oucmHd9eO9UGb/ShIeFFXmq59LtYDpmUWF0Psua1N+B8ncH9zz98stfOnjhmYOrOJ/g1fixI1skD7/XvCT8P4+vM/w8jjb0+H17cMhhI9C2lAuJN4vUgRI/qprGyc22KqNofo/P/oGKzpzHaVXk0yaAu3uXPKEWDhf4Qwws4JnjuqZUh6uQVYRkRGO4jk/ILlPGhRNXDA4e3B16xVjN8ssxmRzNzceVa48lWfXaD20G6zANpBlB3v523ANDZ+SLvm5LB3/KwJcvNS9hFP1P8EirBrO22qtScGgw+nOC9xE+3ndx04auEhgV++b/P15EjtJOT2aESG++Z6locPg9WuzRsE4Hdf2Gycq5pYAaL4bSQvPMCLXal1h2ZNTrOoMwl0fHQ3/UZHagGkB6pDEMFy03puy7U8vr5JWDFo31qrZMp+ZkQ7YWSG443odkjeI0J6tXQ+IM52pvqkumwYJ8zMnqSn2t8QyG0z5acCQLuJWDaa3WIMAt5slFu9+KqpUTXAFv/A/BITxo2WaDwH/i733K3a5FI8fWuw0zeD5asbxv2pFPWEhmBTRDtmy2hZ5liykH75Hi0scihQEpeMaNTAz1fcjTULE175R9WB7r13KU27qjq78KLyxzTHYh5k2k5ObVSfNcH+QWwZZTOcwROTJuEMPxxS2ey0xdySxlx++BGxc+DxYGp26oEkR2ujCjvdDmWYNzL19T5NYXjDyRpkbPCctid0ylp/QI66drHAPOgy/fP/UaXmUaGiWY4cJ6NBEAnsA9W7qMFQAzIuWpoUPdFwIK7GJHgYRCGSHKLjO+sjimJBHy YdAI/cJT XandZeWFlgPQm7Zwc8LUj4b+tlLttTUMPgB+btDNo1sg4wLQv9la4dKWgn1/C7CgxU6dab4ICyIaBNUGziaqW1g9RLTIMUcvNIUdb/aqfvPt3LnMa732tBCDpfbXWUPICP2alGUITAqPuTQvM/ZvoRDANIbZt5SJILGhY8cxm+il6X+cImI+SY3oRoWlzSsTQWObr7MGtcXvnLe25DP43Lax/m6DdeZwnVoxKqkI6wYXGwVKH/58co25IzbGBUtD5EX5UnmeORfqlj+YwH/SQxO8CEoVeXwaOniDHxZ7EJhvu6VdD2dUaee4tgeG27Gz0BRrYLzYsM4kQuVQTSAcdBEvfzD7Y2poF02oNtAFjKmqDEKJMhtz7twCcrfoeiwI0bmyYhdsx4oUTyJg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/02/25 09:38, Dave Hansen wrote: > But, honestly, I'm still not sure this is worth all the trouble. If > folks want to avoid IPIs for TLB flushes, there are hardware features > that *DO* that. Just get new hardware instead of adding this complicated > pile of software that we have to maintain forever. In 10 years, we'll > still have this software *and* 95% of our hardware has the hardware > feature too. Sorry, you're going to have to deal with my ignorance a little bit longer... Were you thinking x86 hardware specifically, or something else? AIUI things like arm64's TLBIVMALLE1IS can do what is required without any IPI: C5.5.78 """ The invalidation applies to all PEs in the same Inner Shareable shareability domain as the PE that executes this System instruction. """ But for (at least) these architectures: alpha x86 loongarch mips (non-freescale 8xx) powerpc riscv xtensa flush_tlb_kernel_range() has a path with a hardcoded use of on_each_cpu(), so AFAICT for these the IPIs will be sent no matter the hardware.