From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B37C6FA8E for ; Thu, 2 Mar 2023 14:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5C36B0072; Thu, 2 Mar 2023 09:34:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6FBF6B0075; Thu, 2 Mar 2023 09:34:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9E06B0078; Thu, 2 Mar 2023 09:34:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 792786B0072 for ; Thu, 2 Mar 2023 09:34:34 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B5B412086C for ; Thu, 2 Mar 2023 14:34:34 +0000 (UTC) X-FDA: 80524204068.24.5C801E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 14E88140003 for ; Thu, 2 Mar 2023 14:34:31 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XdbpboV4; spf=pass (imf26.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677767672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5V3alQcVkOJNOkTm4XGYWiJj17BscHIm8UZULKEJ6sI=; b=Pb3kbNxVHrZTH/HKRbSb3eSpRNz6xjvVAcWIqh+z//jyW9iUyms/boolrf7HUI2dLZT8E4 Djl9+WbDh7nhzlyG+Amrns0fbguUoa+zDaaRNJc5BvFJPj96ymSTJJzsmDY+1cXQwFhLug 5dnmFR/stWCO1awxTZqWeU7TFgsVQrY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XdbpboV4; spf=pass (imf26.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677767672; a=rsa-sha256; cv=none; b=J4arcUwz1+qLHkVbEy7qOKtc/asBMQuW7UxfW3T8PBX8a7LRRKSqbe3oUIZ/8KTrPYt5py PjKwX9+g14I9CUa1/gArZJ+OAjj8m/O/j/dvhqJMg0ljlzbpPNoxOCQUSAcuv87DRjssCO uhZxJU2Joabqn3gia29EV7Q7kdR+b28= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677767671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5V3alQcVkOJNOkTm4XGYWiJj17BscHIm8UZULKEJ6sI=; b=XdbpboV4fI0FRVC1qBqcHhqMMyqXHQyWpm4wt1c20e23xq8R/4BReU84m3V2l+3wfi2O2M IHaYld+7yrgIX8PFpNVejnT1LupsueTikiWcq+e9f2jxjjKihWTDgxLAV/o2S12LkgmTpm WNqPxfcrEMAmp8cVAfGKTCaZrwOzLdc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-564-JIHWPS10NQudaB7CiWuxwA-1; Thu, 02 Mar 2023 09:34:28 -0500 X-MC-Unique: JIHWPS10NQudaB7CiWuxwA-1 Received: by mail-wm1-f71.google.com with SMTP id m28-20020a05600c3b1c00b003e7d4662b83so1372031wms.0 for ; Thu, 02 Mar 2023 06:34:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677767667; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5V3alQcVkOJNOkTm4XGYWiJj17BscHIm8UZULKEJ6sI=; b=gBvQp8V4OQJQyMJ1cf/MwbHsESxUGrIYzRrFJHrnglxsYKJajFWcddpMAGx+pxyMCI NfTWZN4l2AW2jowXuAn7II/gR6Rj8fvSyB+M91ZaDvuLHe0Uf5lP54QEGoW7ZZ942nfl 5zNE3PFZ70hkni6ODg4BMmxT4kKacOXxEMHI7Cm7rP6RYaNctXrGMuosBcRI8WBrSxHn A+KD/JKonIeV/iXt8w/IR5OGNc3hsJhvBHU2xqfnOcQKje5/qxcHw/Hy+RZxbH+mnSga iw+KgfbGVK0T6k2h9Ap5xupNiDzBTUAfXtzXIf3l5q8ZpCs49WGGeg+x5DC+VbawlJgk 2alQ== X-Gm-Message-State: AO0yUKU7QxFKDlSGfabGSIyyBzJNAoYuxYEg3vnc99wtV2RJa7B9iDWt gTrcYz4QZlbEMWt2swJF9L0wHmskBSbmekoTFacnUvcMjUFL7RY2O2hueq5HT0dvR9kw3M3vjFh ePKCPjLmzs3k= X-Received: by 2002:a05:600c:920:b0:3eb:36fa:b78d with SMTP id m32-20020a05600c092000b003eb36fab78dmr7097997wmp.23.1677767667065; Thu, 02 Mar 2023 06:34:27 -0800 (PST) X-Google-Smtp-Source: AK7set/4wSWGfskIqZwg2PojVYKWuDr8WCSFjAix0fVOutM6MiZoj7w/IS6U3kZIOGQxTqcYrTZwJQ== X-Received: by 2002:a05:600c:920:b0:3eb:36fa:b78d with SMTP id m32-20020a05600c092000b003eb36fab78dmr7097979wmp.23.1677767666831; Thu, 02 Mar 2023 06:34:26 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id bi12-20020a05600c3d8c00b003de2fc8214esm3227766wmb.20.2023.03.02.06.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 06:34:26 -0800 (PST) From: Valentin Schneider To: Michal Hocko Cc: Sebastian Andrzej Siewior , cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov , Waiman Long , Roman Gushchin , Shakeel Butt Subject: Re: [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT In-Reply-To: References: <20220226204144.1008339-1-bigeasy@linutronix.de> <20220226204144.1008339-3-bigeasy@linutronix.de> Date: Thu, 02 Mar 2023 14:34:25 +0000 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Stat-Signature: pzy173jhgpju8659rghtj4khnspqhj9d X-Rspam-User: X-Rspamd-Queue-Id: 14E88140003 X-Rspamd-Server: rspam06 X-HE-Tag: 1677767671-654693 X-HE-Meta: U2FsdGVkX18kqNUXBE7aXDEoyrst3SfxwJTzsqbNh/5et4GVxK1KqWV6z9DsUBbws4mWpk4mSjCEh80wddL7ZrXkTVWdcDakAOcwRw8kApyr9blpTVf+LaEPRNsjFqAEhO0C2RUgquCrV12poyTjlNEl3F52R4bktYZ4LNpKlZF06nuryKMmvcucKz5LqzVz25t5VbqgAbdJYui5hmtv0w/Zoc2TXulZKW/3xqUFfaIvLvUKnYvK3AcEGcpJmew3MEKwuX3uX+29a8nkLIaEDrvcZkL7F8PGJKQ5Zj+puYFzMFB9VhK+o3/w14yXaBpNh9AhaQSOfAsUHsg6iT89q81WZnTUao/te/UcOqBkYy6ZVmI2yESxhf6TDWdT+WXlZFKYn5YYI8ppejHTIPh+RFJUnsEOLR5nbZi5OGZyRHYjJorbs98Yk3GoHl64OCh35XFywzqroGHVv8fQwYYnSOfUFL0Aqv1l7PnAc+rETYGMzVepAO3Iavm+fvqC9YfZ0JIEcLe0jcFG2h20TuQhG9kQyJNoOa0Nrd+VgwM5tx+T99aUE2V9y42kB38i7WD3U7SxcU1kfkjQ2DoZ2m9W392XBS8/qZ2GK1zsiF+mBYu2Z7mKls3t5TazlvUEHom68oyoJlLtCbGPtPumkpZgQ0AkAeU5AKJ8mKDxac98eAK8UOI04DhJ82CQz4cbtrZmbktNJG9kkU4Sdb4S1t9I+wjUfdvtNm+Fh+a40l6gCjM3CQoqh4idWMoKqoEgzBduvEH9jB1NCZJL9zljDIB4LR7QMttC1Wz4zn7OFflXTE9FXTWbBrFREwSvuRRlLiETH0YQwuVRSSnSwoQ3/ooecQ4Zn5fNMb5NMy3KKwBQXDnXkio/FLxuLFjFnqW2bkEAjAd/dDTlP5E958Dnu/0tPv7kir5XoEgDuZTOUB9ZFR/XcWWWRaBDRovF/Bj7qvGHhkSZr8RtSwSZWyN94rH n8VsZGJM HddNwxQj9dCl97KPWtfrSv7K9GbKfFkTxjIfqCH6d0oEwC4HR1Wsr1ITcjul6VmEJp5mgqlcT5wPnLJUULjfr4zTzpeXrL0CHoRfp/xOei5To4RAdZO9LPYJK4Cz/PEzNALNDXvMcignKWclSiTTjEr0O1mYN1GmVrnG/yxy877tkXVxBeOCnty0hBY5ieS5BCRBjXbTgVDhBiI1EqXUndQVda9Z2j9/fl6a2HT/5axPrL4jqq4hNRX4Cfbg0520YwPKJDtr9f4Khy9+1gfDQ/LRskY4kOkqFzutAHnbvmeiYciu19MBvZCoeYhYdhV23ZV0pSjqY0PlTMAky4/S0K6IydF6J0h7HxM0ttqm8hTzeMoqjiaQNRlFf4epvZ369Zn84mLkomExg3GIkPAKldh+ZX4Q204R2dyR1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/03/23 13:56, Michal Hocko wrote: > On Thu 02-03-23 12:30:33, Valentin Schneider wrote: >> On 02/03/23 12:24, Michal Hocko wrote: >> > On Thu 02-03-23 10:18:31, Valentin Schneider wrote: >> >> On 02/03/23 08:45, Michal Hocko wrote: >> >> > On Wed 01-03-23 18:23:19, Valentin Schneider wrote: >> > [...] >> >> >> I want cgroupv1 to die as much as the next person, but in that specific >> >> >> situation I kinda need cgroupv1 to behave somewhat sanely on RT with >> >> >> threshold events :/ >> >> > >> >> > Could you expand on the usecase? >> >> > >> >> >> >> In this case it's just some middleware leveraging memcontrol cgroups and >> >> setting up callbacks for in-cgroup OOM events. This is a supported feature >> >> in cgroupv2, so this isn't a problem of cgroupv1 vs cgroupv2 feature >> >> parity, but rather one of being in a transitional phase where the >> >> middleware itself hasn't fully migrated to using cgroupv2. >> > >> > How is this related to the RT kernel config? memcg OOM vs any RT >> > assumptions do not really get along well AFAICT. >> > >> >> Yep. AIUI the tasks actually relying on RT guarantees DTRT (at least >> regarding memory allocations, or lack thereof), but other non-RT-reliant >> tasks on other CPUs come and go, hence the memcg involvement. > > So are you suggesting that the RT kernel is used for mixed bag of > workloads with RT and non RT assumptions? Is this really a reasonable > and reliable setup? > To some extent :-) > What I am trying to evaluate here is whether it makes sense to support > and maintain a non-trivial code for something that might be working > sub-optimally or even not working properly in some corner cases. The > price for the maintenance is certainly not free. That's also what I'm trying to make sense of. Either way this will be frankenkernel territory, the cgroupv1 ship has already sailed for upstream IMO.