From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B26C00528 for ; Thu, 27 Jul 2023 09:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4855C6B0072; Thu, 27 Jul 2023 05:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E9D8D0001; Thu, 27 Jul 2023 05:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF546B0075; Thu, 27 Jul 2023 05:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17A126B0072 for ; Thu, 27 Jul 2023 05:46:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D8696B1E79 for ; Thu, 27 Jul 2023 09:46:42 +0000 (UTC) X-FDA: 81056912244.19.29993E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id BF207180005 for ; Thu, 27 Jul 2023 09:46:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WBxm/GIC"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690451200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/ZtPwamYEdAIqsg4Eha/G0ZWoXDeFDSv2EcRY5ZelM=; b=yYsSth6y+j+Ds1h04wpk46AXvDTWpbV74iK0+CI/vGqYzmt8URr/jo2e4pkuo5QKlhBORf rRLPggfCBbDi1drpsD6YvSYtRpfNJeymwgDM7ILSjriN1mmAD9gTtzQ4YnCBvMMF2r+ivR Isk8u02rklemgbOB143bfuY9xv+RbGs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WBxm/GIC"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690451200; a=rsa-sha256; cv=none; b=yWybYgsK+jkUQYCaEeVL1Kcc9UYviUW+I7N/ZULAGTGWQNnWkcWevtEsqAAD698/6xiBWF nqTCiKE82Sy11dhmrRIA8EOKwsvnZuGv1licOIssxqw/cW3yrFV+NX5ccsg11Kd7XEpz0T C/K+X1FnsuiNqhlMXinKAQqP/9WsTBI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690451200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/ZtPwamYEdAIqsg4Eha/G0ZWoXDeFDSv2EcRY5ZelM=; b=WBxm/GICrULU9Q4b5gRPGiWaJjiSO1esm0u94/+8NL7GaArA5pJSOWpL8V3521BemGZode liAjk7xCACW6h+HbwIIQcDRuR7LYXaaK5pow8N0tixopgJBJvyyJToUHeukCNT5x3LZBpc er8qwCcesThVPTzarY9yCwSUHEy3HVI= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-WLVNBpn_Ni6KAdsIJKk6mg-1; Thu, 27 Jul 2023 05:46:38 -0400 X-MC-Unique: WLVNBpn_Ni6KAdsIJKk6mg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fbcdca9082so671286e87.3 for ; Thu, 27 Jul 2023 02:46:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690451197; x=1691055997; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9/ZtPwamYEdAIqsg4Eha/G0ZWoXDeFDSv2EcRY5ZelM=; b=PwpYj5k+R0xO2x+AnucQdYwrP9DKM2eZKFW93Dg6cNF1prm3xDZy+0Oa/ooUHwBSlH 57BrODC/eBngJYM/mao94mi/jBHKEGQPyW5K+0c7lAKo8NGKtfb56mqlK7bWJfuO0NDz jIpupDRQZAIqdVuJRRcH0UKTY3f6o4bhapQCTUqgaVzHKEd6Iu8/IKnHgfxrTfILrkH3 UI1lJ5m+5hMVAvITUAJvjF4zv5px/WMg3caSduV+nq/QeMwCxnzPjVEcfbs3UYfrGk2f qlmoxNSdIosCUQH37HP1U6a0bYYPh/P0rBjlvE05QbLnjIyWKcUeSwVdlu2dFWSrmHmN wxhA== X-Gm-Message-State: ABy/qLZnrnsfmffqJFR61XkGQUcoVHqaqS3mUklmN64/y1gLU67XrcE4 RR5ZK7PND+ias3C9/vWWtcJ7gN2hOpyHjvpbH8Z/UU0HXRIHotjkBdnQmFHxLwDYgPZoaJ7tPU7 nQ6KF30E6H70= X-Received: by 2002:a05:6512:3186:b0:4f8:7513:8cb0 with SMTP id i6-20020a056512318600b004f875138cb0mr1763698lfe.2.1690451196879; Thu, 27 Jul 2023 02:46:36 -0700 (PDT) X-Google-Smtp-Source: APBJJlHWfc8e6nRRU05KgrIaBfOnm87x2dNku7t4qZB3XfKVqk/Go7XcWjycqa01reYQ5M3BH+RFoA== X-Received: by 2002:a05:6512:3186:b0:4f8:7513:8cb0 with SMTP id i6-20020a056512318600b004f875138cb0mr1763631lfe.2.1690451196504; Thu, 27 Jul 2023 02:46:36 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id l10-20020a05600c1d0a00b003fd2d3462fcsm6308442wms.1.2023.07.27.02.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 02:46:36 -0700 (PDT) From: Valentin Schneider To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 02/20] tracing/filters: Enable filtering a cpumask field by another cpumask In-Reply-To: <20230726194148.4jhyqqbtn3qqqqsq@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-3-vschneid@redhat.com> <20230726194148.4jhyqqbtn3qqqqsq@treble> Date: Thu, 27 Jul 2023 10:46:33 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspam-User: X-Stat-Signature: 8sznhaazogqo3urd3hdxfbftmyeh5ykg X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BF207180005 X-HE-Tag: 1690451200-577074 X-HE-Meta: U2FsdGVkX1+S25Z6JLthbiBPobZAucQMLe/JLUbl8rpybSNyLE2FTRj9rXdJ6QqJszJ+2SzbKm+0tyZwNCiAtWckSqwI8xwocqWdyqEs1xcX9Zx6hMV/mCdXsUK4gOZ2gHEP2bemesjSJ5Jqy9gex3XXxxpdk0l6TEyUHtCLm38MgSVQZcytstwqzrU6gf1prkPMPD46OpOvZasBWBjLqESOTdIWLyhu8wq/c2RC6LFvx+eEr4zvhisoZI07iUMuIa98NHgDBL4nkN4Ta43Cvhzb4lpSi/5q62Bfum95WFvGXCJ7hxOUoslauOUgslXIox2EfUHi43mVYzCQZKeTaPAwTSlIkOtPNr9JPVBpAJ+iQveG9BYH32JzJRcKIG50qdaLoGaFSuUzd4b0/lypBvFPTxyxThVYtUPi4WEMCe9dNa/hzZyWBwOjfAAxSRe+hrlede1artP+CJyqL/64+34n0Ihf0Rdy+wiWz5Jw+ZdCjfnMHV7/CwfSAyD7d67IXKmKUi8rftPC9jQzzYYNllknaj/VZFuHgPyOfjFjJUG7+rRXQlC83RF94pJVLYC1Khh+1jmslrEqjnjoZUBOIJJXtNTINbUjsd2TVzw761rEMdtuyioGg/R6ZyuYmYiorA+SOKUzJ+Em5ctjXso7gHuZ1NkBxY1on+0KgRk67BB0v2wub/bJ2utRvqv9dTBdL9dDUf9FOnY4LWDi3JbOMn4ZpLxfy6res5DKTrZgMSq94ffClNm2zysDrZIPqqct8pxo5ugqb8MOM94H7ROrIdh4cfVfiKdqQgobNI+S1JGKXYYaSthVZh/fJDrgNixu3Cj5J94x0NPj9QSRJeQua2HiKCp/klrOmJYMrdbvvkHo3c+1xi98cMn/liorqa9rw8Jx5tWzMqvigfDYCTrlMQQUk6zcgpOVjOm9zSwP3S1KZfE41cSQ6kmAMb2L0mmfftXgqckV1e10h23zKHs row6cw87 fuFAMSSfBuQgn5ucwjcAmkde43ncK0DofVwD+MKou7hs40tSRKmKe3SRsOFkobXsYjfp/Bd5HSjCVuzSpFjChsqIBsmRsQKHXnt8JTPdL/UgS4LOS6Dn+sVOBT5h2szU8gm4CPmzB4OHG2qkOWXOa7OjpSYjgqPtJBVUYr/kvog8Sfvkmi+IdwHkbLy/O2UfeqsnwekaRuekyU5nQUk5vp7aiYxOZBosg3jrSLAgsJW6h7yn3M/m8NbdG+4l6izOWJMt4dXYdjoCCDqXAIN3u11YWa1FSP3nkqVEyssbs2fk0gB/hq1Xy9YXAG/hqKkea7EGRkXXqqb63IsCFYocpCy86Tw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/07/23 12:41, Josh Poimboeuf wrote: > On Thu, Jul 20, 2023 at 05:30:38PM +0100, Valentin Schneider wrote: >> int filter_assign_type(const char *type) >> { >> - if (strstr(type, "__data_loc") && strstr(type, "char")) >> - return FILTER_DYN_STRING; >> + if (strstr(type, "__data_loc")) { >> + if (strstr(type, "char")) >> + return FILTER_DYN_STRING; >> + if (strstr(type, "cpumask_t")) >> + return FILTER_CPUMASK; >> + } > > The closing bracket has the wrong indentation. > >> + /* Copy the cpulist between { and } */ >> + tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL); >> + strscpy(tmp, str + maskstart, (i - maskstart) + 1); > > Need to check kmalloc() failure? And also free tmp? > Heh, indeed, shoddy that :-) Thanks! >> + >> + pred->mask = kzalloc(cpumask_size(), GFP_KERNEL); >> + if (!pred->mask) >> + goto err_mem; >> + >> + /* Now parse it */ >> + if (cpulist_parse(tmp, pred->mask)) { >> + parse_error(pe, FILT_ERR_INVALID_CPULIST, pos + i); >> + goto err_free; >> + } >> + >> + /* Move along */ >> + i++; >> + if (field->filter_type == FILTER_CPUMASK) >> + pred->fn_num = FILTER_PRED_FN_CPUMASK; >> + > > -- > Josh