From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A3CC02183 for ; Fri, 17 Jan 2025 09:50:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D982280002; Fri, 17 Jan 2025 04:50:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78942280001; Fri, 17 Jan 2025 04:50:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603A7280002; Fri, 17 Jan 2025 04:50:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B88A280001 for ; Fri, 17 Jan 2025 04:50:59 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6031512100F for ; Fri, 17 Jan 2025 09:50:58 +0000 (UTC) X-FDA: 83016474996.27.898C61D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 0CC4612000A for ; Fri, 17 Jan 2025 09:50:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Efg1gUZ7; spf=pass (imf29.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737107456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDQmnZNuWDRDpTPs8hGbe0u4gXPeipncYfFhncsjtPs=; b=0HNnk1pH9yuwhD5CE2yzlW0zjB9yAQ33Qzwq1L0N8m5f02dicHOo2U/4CGkTJaQ/3CbHIA iciubYnCiThwiK08ZkFgVFIvIvqCDOxYZQrQjAxx28KAJxbITeG9kIRUsHjGHKg5cdJXYv 3DmplhLCKHLi+6HPkJCIY2Qde1Woo28= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Efg1gUZ7; spf=pass (imf29.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737107456; a=rsa-sha256; cv=none; b=FQYyeX2qfZKGEc8RzeMg/iQRmRBbwG4BXv9H1WjH8ZCY3ShYNAF090to1uKcZiYb3uliBj WK30JvCbgXosuSLJt3xa8oKgdOWNTL4FFLRjnmebiUp6H2HY6BRJlpe//dop2CZVNe3kIa 8jyL8dAj95U4K301qKKBT39HekJcvJA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737107455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YDQmnZNuWDRDpTPs8hGbe0u4gXPeipncYfFhncsjtPs=; b=Efg1gUZ79jxEVw5YbXdYyNzBjM8xfS9nayXJ+V9O+VdSoRqJ5ZYmC/Pp97HRLEAbYBW6Av JDhFlV6dpcwGFD6Yf2lrM6Iful/jXFGCeIdz6X0xQf0haYHvh6k/y9F6YNakAB09Scc+LO lssds5SRlJryWh26U7wNhtPjNJMB/mM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-X2vTsQIpMoGPWnlC_LOlqw-1; Fri, 17 Jan 2025 04:50:53 -0500 X-MC-Unique: X2vTsQIpMoGPWnlC_LOlqw-1 X-Mimecast-MFC-AGG-ID: X2vTsQIpMoGPWnlC_LOlqw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43646b453bcso9307475e9.3 for ; Fri, 17 Jan 2025 01:50:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737107452; x=1737712252; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YDQmnZNuWDRDpTPs8hGbe0u4gXPeipncYfFhncsjtPs=; b=ADxNXFlnLn/lQko1eaowxdyZsrjA5FhI+i4BZwMxoHfkSLPeYyykLT085LALVr0OWm X3UBhkCFzaQNGZ9uBCHF3bEr0JfDlaFUWyeIiMEE1FW5JHhg/uuy77KAfFV19CRLXbXz oPQzYSNj54zjrQO5qjcsdt/fxe7nGi4606TN34wYg2LOr84Qh129YWRXoN2XxA4PbN5x lIxUZN+VWUwCUiG003jQ3NpD9iQ8pLfKdZWkW3wlcfxobvOPN5tBQ8bYSXEqSZUuiStB V/I8nlUx6KR46B/VfDQ9l4G4f14EbI5pMyU0OZjNvKnwT8NhBY6CAomwUrJsDnNL8q0B 5v/A== X-Forwarded-Encrypted: i=1; AJvYcCXrVyH6Yp4mAy9RH0wAk7wA4gv1DTMuTo1ijtRCvIQ5EQqR0xPzFgH+QEHMzQMUitjMl8l2csZgwQ==@kvack.org X-Gm-Message-State: AOJu0Ywvg95jAoOoAtqcTsgZUWmslXHNpkrsiio3qkWKzwWOnye8yinh 9UhgQX1qdDtk+8fuvGZsNITH2TA+Tgppj8rlB8iZqyL6QPPJPsRi+aSbc3bv4utXXB0TKnDZq4U CVeF+Va7zoTyAJMvCPRxYPXJrm1+oIgk0lb8t9GXugmHzhUHH X-Gm-Gg: ASbGncueyxa+J3ndXRODS7wV/cY6wlFscOyAyQ+z6aDghnJNf1q5/nB2xefafu72EGN kMsKaj2MY6eQXT79ky5qQSgJMG6CuftG7KbPg8hbe5gdAXvXtZOfOFtVtbhROcBTN/CIitJIs64 /tmo02p2m7Ll/GgFESlGyu4hG/pjfGTPmfuJEW+QGkllTd2gjKl8jfOPJRyKcNXfictlzba8Czt PFAnCqw5y/9XstCU6jMtj8It2IJVqfe+cxk8uDXQnu2uRDNaCA8CHLG+9PnGqUcUJcRCqZfdOrj 30fVosRIE5dZo3ushoOzAuBUDPq7hBnEPB1A7/AS7g== X-Received: by 2002:a05:600c:4894:b0:434:a7e7:a1ca with SMTP id 5b1f17b1804b1-43891427762mr17119905e9.20.1737107452072; Fri, 17 Jan 2025 01:50:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIrTJfr3xbQQG9oIc57+hAZrhxLTFv7PUY9ukHOiTt7KK/CefEP4sOd+O4YFea/uwaauu8yg== X-Received: by 2002:a05:600c:4894:b0:434:a7e7:a1ca with SMTP id 5b1f17b1804b1-43891427762mr17118965e9.20.1737107451685; Fri, 17 Jan 2025 01:50:51 -0800 (PST) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-141-166.abo.bbox.fr. [213.44.141.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4389046885esm27213805e9.36.2025.01.17.01.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2025 01:50:51 -0800 (PST) From: Valentin Schneider To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Josh Poimboeuf , Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Boris Ostrovsky , Pawan Gupta , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: Re: [PATCH v4 18/30] x86/kvm/vmx: Mark vmx_l1d_should flush and vmx_l1d_flush_cond keys as allowed in .noinstr In-Reply-To: References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-19-vschneid@redhat.com> Date: Fri, 17 Jan 2025 10:50:48 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3YmTt8eokpEUsCalRZCEixjMZmEQeGa-26jSBPoNN2A_1737107452 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0CC4612000A X-Stat-Signature: hidhud57ukj8tqzihj37xupe3w6queh6 X-Rspam-User: X-HE-Tag: 1737107455-131912 X-HE-Meta: U2FsdGVkX18gQ5RQ2wnBdWpAjnpXwvXaeb3R0ivvsUzRlAB0aEyvXUvRDhMGTd8N5y7cPP/LlpKLrB5FDKjtuHi1IHOR1ogYByNjeqQ8DivMm2pLo+I7FAE0Rqji0SqyuT/gz7cY1GFqdNeE7/Sqwy52vdn/8fm4DqGGfiVMVUBAaDLjIfKc3mcOAm8z5UQWcC/2D5LNxFbi5URro+ncXvQbSaFWAGu3Ky12wBmil/QJQdjeZ1LsKPG3cBneTIX968r/lCtiTHIyDJrrsn2tQzPMUQ/7CVaEPGMk8aXAFnrN2wrmDYWBieFJzQ6yT7JJf7EQM0w9NHF5oozCstAElEjEf8EacUdZGi16Km1NGy93OlXoE2GdzyUTHpnJXAI81DVzEaqn7aNCviMzqLjP8iNaekoT4q1EWAgeY86Qlj1u3UCXZJBiCndzdWmA9xDVFtRTWOS+y/Z5rDKAu3U3459dOjpaiRTy9QEE4uQHs2GT67LeYVL4UAj8fdyS0z9uSig8z9FULPejYMH6eNR56p7DIGvdPOg+wfUWLOyPIadogvKDM/aVvkdz61KBgAQSwGpx/kcar5TP3gXzTPjxRw+9Y5nI8web301FJoX8KEyVxlUx21+l5ixtBQHdo0iMU72FV0PzXOswAaOVBaa+EeEFGFchCdEN0787CHA+nSxw64GuTcvYnyCeaBVRBQHeC2o0hM9gHR+z2J6JMSAkFwQCqH2ZXA6vwQSZvzjJwE7kkLIEIZCd0zpLxnYphScY8C97o8A6excZHW/KSGLl8JiMILPAP4qQLSOKGI2719xMfV1vobuzSKJ/qmf5NCdzX3g3ghz/4rwqCV9ReFbihghlUa0HBYbdsnv98B2fRlG++dxM25ntB1go1MeGlvtvb588b1cdCgteA+1VVxZlJWWDRl9d/Bd5nBA3pakDzAEycj/ZyPz5xoq+BWryX6usV+5Wos8nvDVg9iYjbr9 AnpEv8Oj KnAbSuo71XwO7nI3wCgcW3R+8a/r+TgCXOHVDB/aVSO+dLQkKp2IEFoP/6hBAagqcBKSaPsUMQbc0rQPjwuMU5PjZpWG9I9v/MHzsTLvURvM2SbTZuckixeUahpy9ZFA67+bEOQ5et53eXoG2DhjqIlopTD85xfXujDAoiF+8/OM5dM/Tx5irBh+y982YCxjK7Ica6l0NYZI0bQAUndB1pzD/XeDu9C8M1WSU+tMp0TmcG3/gZbpjohLT6Mz4iSJsOs0+tjbU9nZAOATRpW5FBVNlxllgQTRCp4HZNTVn/4rUrWGcqeFlJuKG+v2ek6jaHhVZBAARx46ngWjppKIzaHkKlPIWUR4l2aP0lJurk/STiyGy0X5GwGElAceu8vnPmhPKWYPTOdXU0JrhozHNvcuUJssa+EYMhRz1Nnv/c8AR3+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14/01/25 13:19, Sean Christopherson wrote: > Please use "KVM: VMX:" for the scope. > > On Tue, Jan 14, 2025, Valentin Schneider wrote: >> Later commits will cause objtool to warn about static keys being used in >> .noinstr sections in order to safely defer instruction patching IPIs >> targeted at NOHZ_FULL CPUs. >> >> These keys are used in .noinstr code, and can be modified at runtime >> (/proc/kernel/vmx* write). However it is not expected that they will be >> flipped during latency-sensitive operations, and thus shouldn't be a source >> of interference wrt the text patching IPI. > > This misses KVM's static key that's buried behind CONFIG_HYPERV=m|y. > > vmlinux.o: warning: objtool: vmx_vcpu_enter_exit+0x241: __kvm_is_using_evmcs: non-RO static key usage in noinstr > vmlinux.o: warning: objtool: vmx_update_host_rsp+0x13: __kvm_is_using_evmcs: non-RO static key usage in noinstr > Thanks, I'll add these to v5. > Side topic, it's super annoying that "objtool --noinstr" only runs on vmlinux.o. > I realize objtool doesn't have the visilibity to validate cross-object calls, > but couldn't objtool validates calls and static key/branch usage so long as the > target or key/branch is defined in the same object? Per my testing you can manually run it on individual objects, but it can and will easily get hung up on the first noinstr violation it finds and not search further within one given function.