From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D0E5C001DC for ; Mon, 31 Jul 2023 11:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0AD8280029; Mon, 31 Jul 2023 07:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBA7E280023; Mon, 31 Jul 2023 07:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8264280029; Mon, 31 Jul 2023 07:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B6874280023 for ; Mon, 31 Jul 2023 07:17:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 937EA1C9969 for ; Mon, 31 Jul 2023 11:17:13 +0000 (UTC) X-FDA: 81071655546.02.D7E165D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8B12840022 for ; Mon, 31 Jul 2023 11:17:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iTfrUa/A"; spf=pass (imf27.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802231; a=rsa-sha256; cv=none; b=pe2PQc6oCIaAEhiB3feVciyWiOwKPNqg05RxTUWBCk68j1pAaY+izCZPIKQp5Mg8gpiDXG 2EucywPkFtmzeIE4Ckaus55HKKuAkQcMKkzPOvAnVJXxoc+SRM86aNYSYTeeNyVhAPCHZ7 60O3k8nOAr5eAswNgB8RtHcf2GshGF0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iTfrUa/A"; spf=pass (imf27.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M/35EV6KuQFV76XfAiI3kNPUCvGz0oTI5DQh4eGuYFg=; b=DtB+9fQQOh9rtDOQS91qrPIiH5vdYRKvK+L54uxh0MaZGkADsf3GYoStcR2SaCE0cxKE1A tdODWFzCUto0aEzyBBpISk0ok4f18iacdKzU6ZPwT8q8jMEyngOGdXFveEj+e7QLMS7p0O Zren9JA9aIcuORqnj6A9M8TmdzRg62E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/35EV6KuQFV76XfAiI3kNPUCvGz0oTI5DQh4eGuYFg=; b=iTfrUa/AKf4x1sPOKRAroR1zkzSsZkhRalGiSQMYejLoVSYCUTbMHLAqtl1O9j0w/jK39g xUhEifHJ3JOp8rNUa37qgHQnx0/Z07Y+fCHy3gyDjQNzEMwAvmTSK91sHF60cbMr+4XKj5 7aCe4sq0MMFM/96dBMZ8WPlnVda/+Q8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-rgMIEqoDMFiv3prSWjaYSg-1; Mon, 31 Jul 2023 07:17:09 -0400 X-MC-Unique: rgMIEqoDMFiv3prSWjaYSg-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-63d1bd6dfebso59315656d6.1 for ; Mon, 31 Jul 2023 04:17:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802229; x=1691407029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M/35EV6KuQFV76XfAiI3kNPUCvGz0oTI5DQh4eGuYFg=; b=ix0ld62xW/UJFLOPCz/YlQYyZRa09tqwTOjaPhJUb+OhoiTuiYcS0rE0vhOwQdTuUY 1rV0kAaojAwyXLT2OsZMTzTqMd/jFAOsKNHpoh4qoGDkw3ygu3i5FU3/CyAw0I+lVuZX Qb+9CBTDjmra7W99CyCT0oqUkx5ow5M1ASvGHqydagM/5yaa6ov/s2dKj8Ajg8JtykOU vgB5Z6ACHKTDXx/RfT0bJMNBfy4h5teJ9kRfCJh7jljzCWv6ily8lXXE2bUSNLNeHo3A jJvjjTtauKlgZncUhQMXMcxW5ZbetD6YIso0RuRCRhHcYNmjG08p4H2roeojV2D0eSqy FsHQ== X-Gm-Message-State: ABy/qLZrnNQXmIb8VOt3uYxBOUSOebiDpQbNibBAf8d1RiHbMFdf/1+z xFio37ztyiBF5mZGP7FElFmFNgr6PPlWO3RJzRuUwHZlHRZAjWSCLhKE6MFN5Fitd+wj8fKZVhf QndZIF4AUyDs= X-Received: by 2002:a05:622a:1a27:b0:403:cb17:c108 with SMTP id f39-20020a05622a1a2700b00403cb17c108mr12984369qtb.24.1690802229076; Mon, 31 Jul 2023 04:17:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGfjSM0EY4ReLF74gjgUvSgh5M/dv10+80eXvDCpwVYLgcCJZkRhEPkohi/ydjwax6EynCsig== X-Received: by 2002:a05:622a:1a27:b0:403:cb17:c108 with SMTP id f39-20020a05622a1a2700b00403cb17c108mr12984294qtb.24.1690802228754; Mon, 31 Jul 2023 04:17:08 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id o18-20020ac85552000000b00403bf34266csm3426262qtr.30.2023.07.31.04.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:17:08 -0700 (PDT) From: Valentin Schneider To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 11/20] objtool: Flesh out warning related to pv_ops[] calls In-Reply-To: <20230728153334.myvh5sxppvjzd3oz@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-12-vschneid@redhat.com> <20230728153334.myvh5sxppvjzd3oz@treble> Date: Mon, 31 Jul 2023 12:16:59 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8B12840022 X-Stat-Signature: q8sf6w9fgs97bb7u4oz744w746c9rtqt X-Rspam-User: X-HE-Tag: 1690802231-906710 X-HE-Meta: U2FsdGVkX1/VnvdXTa51qtk7mqvN5UQwRQwwtL4fj6SgMri6+JQEeqwOxs+YP280RcctJnZqvWkOgEeVU69A/HE2qKSnr6FZUJA+ois1EO3bsY5zZ43DxrrqB3mc8ayP1z23PTCzWpoiFEYsm8eldyuQ6yB0QT+XBrWHm1qssM3UyD6grRn5c0LoRsm+kiZkE1jp8R1TURbuLP0uFpe1Z1NAQN591+6r/i86wbshGQtBhv5dMNXIRiXuVO1QrOTljsTvCunwkk/eLZjQAG6T5DBYJAe+cuXQrFBU+Muw2XVkekvN8mMymSTngme5HdBJ0R4JLEcbLwwJuccoFX4knNvgA+9Yz1oDfuc3xmGllzxtwd6UYDzbA/rRv0HaEVoukJ5VbFgeygfiJgxh+9Vu7+jpm0n6v8Whf4uU44mI45JMx11uvJxWmnXbTyHqlwwQdmo/GJlD2qgnedSwGb2TwC6kh55l6MkNcRJ21cqdD4IGlwlkqEeOerd7xGZiErY8rfbLH0nU6Rr4aAbLu4dv6NQFxOMZv3BmmGZleyffmTc/fmi4m4Pk/Ra8hCkwhP3EvcDnde+N/dsAlAjj5T1bGbLkeEEswbys6YUTTktH79ATEQXUx0ReNVB7rbhPmUAjcdUUF7GCBFP6/UVpMtYJ8SjKncAlYwZ0FoV/sy3d8eL4r+mhOZYG+mGm+QZUmql8v6s+ENJLIuTUXvgiLbXITGfa5CZWq0w2kFItHmZGb745KFmmYhI9VbiLSjHhdrnV436ce8R7k11WwBvz3Abdf2iqizx1HY3HjqOVmE74lDFJVHseTs2HEvOZ2Tr2fnQ3RAteGGJPKXWJpcBR22KtF85rTGw8SVO8mpITMPP7wvp+KAcoXttzDZMWMR3bItzfJB4U6kbwsFWaDiyGjTjF27jJIzwgitl54ikBHD2Zdht3LyGx6Tig0I9fEORIOEb+QPQ77jdCm4N0jSF7zZr tBWEVyzw TpZrzTny1h/Zxc9QI0udyE63gymgO91ft6HuN2svpeuQajcSGDid0Gq6uYRPMd/g4Urizeu1X+EvRKgwmyLqXhh3NGuqB6eMBBcaKnqG8va+/gaXT1p7HI4CtYkdKypqDu1uYLkMZARR7N/+sCxnl/LkP8YZkuHQVScAg8dOBkd1CJUBS8ACTlikx+pMqJNmW8FppLG6EJJXekc0pOlM0w3jHwynuW0CUQD9a1+nbclWwmErvkzDja4mtckWtRqqZlRFkMEu362TSjfDlJ5UwATC42DA9g3h4N9YuRiwI91H7dH2+jFNXrE5fu8UL8lhK9fXY+Mj12pe6qFFNjX6qv64vW/Ik8SYmKahPiPXNaN4lvoaqSfPAYAKXWxI28CqAp89bsbzsjG73zR2sW1xjv5e5g/7vcXZo2AUf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28/07/23 10:33, Josh Poimboeuf wrote: > On Thu, Jul 20, 2023 at 05:30:47PM +0100, Valentin Schneider wrote: >> I had to look into objtool itself to understand what this warning was >> about; make it more explicit. >> >> Signed-off-by: Valentin Schneider >> --- >> tools/objtool/check.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/objtool/check.c b/tools/objtool/check.c >> index 8936a05f0e5ac..d308330f2910e 100644 >> --- a/tools/objtool/check.c >> +++ b/tools/objtool/check.c >> @@ -3360,7 +3360,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) >> >> list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { >> if (!target->sec->noinstr) { >> - WARN("pv_ops[%d]: %s", idx, target->name); >> + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); >> file->pv_ops[idx].clean = false; > > This is an improvement, though I think it still results in two warnings, > with the second not-so-useful warning happening in validate_call(). > > Ideally it would only show a single warning, I guess that would need a > little bit of restructuring the code. You're quite right - fabricating an artificial warning with a call to __flush_tlb_local(): vmlinux.o: warning: objtool: pv_ops[1]: indirect call to native_flush_tlb_local() leaves .noinstr.text section vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to {dynamic}() leaves .noinstr.text section Interestingly the second one doesn't seem to have triggered the "pv_ops" bit of call_dest_name. Seems like any call to insn_reloc(NULL, x) will return NULL. Trickling down the file yields: vmlinux.o: warning: objtool: pv_ops[1]: indirect call to native_flush_tlb_local() leaves .noinstr.text section vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to pv_ops[0]() leaves .noinstr.text section In my case (!PARAVIRT_XXL) pv_ops should look like: [0]: .cpu.io_delay [1]: .mmu.flush_tlb_user() so pv_ops[1] looks right. Seems like pv_call_dest() gets it right because it uses arch_dest_reloc_offset(). If I use the above to fix up validate_call(), would we still need pv_call_dest() & co? > > -- > Josh