From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7144C001DC for ; Mon, 31 Jul 2023 11:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E30328002A; Mon, 31 Jul 2023 07:18:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46D90280023; Mon, 31 Jul 2023 07:18:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6AD28002A; Mon, 31 Jul 2023 07:18:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 15803280023 for ; Mon, 31 Jul 2023 07:18:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B38B780AD8 for ; Mon, 31 Jul 2023 11:18:39 +0000 (UTC) X-FDA: 81071659158.19.9FD2F08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 5B3F380015 for ; Mon, 31 Jul 2023 11:18:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lz5B9a8t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Feb3SbI628V0M+Xl6cXNHTwh1emqN1pCsroF1cMMhXw=; b=BFJSP5jImDgBwwA7ULd94xiAotp5eibrlKueHJmLCrOJ5ux5WuRlw2v04a7rFApOIHy08H 9HqrwWkl6WW3qBuoP4ufKdeLp/iItkXSGbLVGsnJAdlevZvXcCpugc143JOAO0MuWE5714 hyt+McrUK9cOIWkdnu6tfnsOqrkBDZE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lz5B9a8t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802317; a=rsa-sha256; cv=none; b=dd0rEj9pn1U7FjtOPXoPiuhHxusdr8qZCW2F7ptBq+e9IbzOctDsMEJ7BvSmIGzAdZjWSH gUueWzhhqxSmge6SyNvk34Vx1i6uXIVoBMueo8oU0W5hb/o5v+uRZwuzhIhK/5z4Z3OP8n gX5rO6iGKmEwjGINJ9V6DIDcKHkze44= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Feb3SbI628V0M+Xl6cXNHTwh1emqN1pCsroF1cMMhXw=; b=Lz5B9a8tI/ubSSVOY7g9gMzwaa1MeAaBzaJ4gjvx3QdAJ7HMTB13ZG7DGdd3GCjO2DMBpo kq6YW7eNQHLJ2kywXHxFrCIfxLHmyoHHEO+ciwjZYwd9pm39YaMEdyZLTehiB/ShDBmqLO 4THpOJ/D7HR/wViODRlDt1t+pZZXIrY= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-GGpAgNbSN4GVPmCKuu3iTw-1; Mon, 31 Jul 2023 07:18:35 -0400 X-MC-Unique: GGpAgNbSN4GVPmCKuu3iTw-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-403b134421cso32218321cf.0 for ; Mon, 31 Jul 2023 04:18:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802315; x=1691407115; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Feb3SbI628V0M+Xl6cXNHTwh1emqN1pCsroF1cMMhXw=; b=Dp/a+uh4GEHbnxmZVIVDvGL+j3TbDJ+b9FrsMk0tDRTcJlOFaPCjVGkgCuwMMpTUmH 7EuJ0j6ZXrVx5+cEOL2lDU0Qd9ZHCOQ7ulzkc/pVzwovOfGcet+PElqkx/Om6oQvQaY7 2ePat26wbcLJHeCndCOOwv7LpEHqVjvCohZ1sV4MNJp8no7uqSpTiD2sYywvBMyUIlAs +rRnLitM0Fj2mUT+RBnM1T4RuVV1tWeocxREP3qKr46VxJMDckzsBNrl1Tq4Jyuc2yWc /lPI0exjGeq7Vh4sn3oA12w6FugfuJA5pnyjQ6EfdxUaaOFNNbiFqseKthWTTQFzO5DA k6lA== X-Gm-Message-State: ABy/qLaK72jMaaX9zLVLffyhdr+pXLZhXrPBoKtuBv1o+r9P2cQapm1f BHg8xoIbT8wwTAp8wq6wguUvqIAwdKrBQ44IWA5/9oBF423H2sI8LL6iSvB/fhnhVyO/DgDf4Rt 4uf24jSjD5x0= X-Received: by 2002:a05:622a:1806:b0:403:b23f:9e16 with SMTP id t6-20020a05622a180600b00403b23f9e16mr13377250qtc.2.1690802314908; Mon, 31 Jul 2023 04:18:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlEehrZuAEoVbTnlaVgIfddlc4rg89Sd70WHq1FBXragdFZy0TviERBFx02bWZYfpI2p+8TwzA== X-Received: by 2002:a05:622a:1806:b0:403:b23f:9e16 with SMTP id t6-20020a05622a180600b00403b23f9e16mr13377176qtc.2.1690802314653; Mon, 31 Jul 2023 04:18:34 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id e21-20020ac85995000000b003fde3d63d22sm3385798qte.69.2023.07.31.04.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:18:33 -0700 (PDT) From: Valentin Schneider To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 12/20] objtool: Warn about non __ro_after_init static key usage in .noinstr In-Reply-To: <20230728160247.multb2csnpa22fgx@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-13-vschneid@redhat.com> <20230728160247.multb2csnpa22fgx@treble> Date: Mon, 31 Jul 2023 12:18:10 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5B3F380015 X-Stat-Signature: mdx99c1pc67hef8od5gbddtea7cb89k9 X-HE-Tag: 1690802317-39774 X-HE-Meta: U2FsdGVkX1/+9TgUzheMGw7ZqzDRwUqsp3KTM6c58rN2NWLeTLhwKWZDIbtTYvOQgOH+Ek6ezwPU4NGbaVphElLT41ShFYRieClN1ZwxtU1r8mWArPXnEOo6M/8dAuF1dZt9S1P8n+jtL3h+MODVD0yGDFRc7geYchSl6OQTgQvoLH/nH5nQzvMPkdSN7+qiLtfcQOMACcHT/r6vIahQvqt7n2xnSUbUXDkicyy7G8FkTmFZkuaZ+PIcgAZzDnqfBVY9Ird9k/Cal51e2VS/6e9KXxqLxAvr1Sm7VejZ2dR+udnU569KPugQDnRnbdvix4/k7hDgoGV8gx/6YIBPrmNmAz3Ta9rwg+lsqzChoDjTgz0gLPuV3usErwCKTGJGHH001y+qeL4KmDZQsAkTHOK5yNyLz+grwXbiItR0UfNZ+z4skMc0wtzIfpxqkHlzyY9+E4qFOKZ8QFLBQZB2M6wHHEahXl5xIhyrKNoqSwx1SCSU5/ygpT7MHVYiA5stEXIWcKDWZrYsKwTEW6E1Hlk2MCZpoRcL452SUShNWupfTYGuyXTm8OY3LHaK1gcWm5LYwryCe30HY4OO328yZXwpb/oFNCIa6EkY62qrHPCvC0jj+NIBpckDjYeNRvpvsODsmpNxRQXJ7SNl9JBMsdVZaHtsEqMGd+S2Uz2AGjP+/0IHvItrZ8Tk/wlOvHJVA4IcnwVBe4JtaP40Lhz5ebfJnbpO2drTU15UAbL4Gswsb8QZgSTLtUTQF6beYCHQTNO2m633poTZVGVHcmH6az3PWbwBDCAMXV9VsLXnUp+ohWfNcz/fX6xnJgsb3mGB36Fipgn14F8g0NpW6tvlxcm5LaS8h3aCIb8UGismnq3RqcowbY6mFAMow7E7oAtKXn+HTireGpXramlOItDaSWizsmkRdY+fHf/cxeTlxdzQQ0seBiie8p8ubRBAgTeeePzouooPZg9QvNECVVk qO73KMNR sGvEFi4c1v/09LPTtduSro+hpHTY+Dl8bcsOdgmoYXoKW8i/R0RcLC9CCL+o49IpyBCf6ygNdCXr93sdLRb8N7tT/YWRLwO2TRzdhI48oMqN44t8ChqS3uBG1ipNu3DBhIpSLYl8/5/hG9r/WToVSaw3rsXplNPFL+E2le2uzAiFEHbVhrEgNq5/xyikAXSNQZOAEzgqcSqK9Uz5fk9vMY5/vJfJHRzJ8xhaOV2OcY0QkeaqwfmT1/2jjT3jkSM+fIm8flUFbrlkLH0NCzU46IZzsgzZkb1/fdUv3mFoUZOurbzxeXva/Mnj5/YE770ZEvGKjaUBkhAFrCWFPvUxIklR8j3WQ5EtR8i02xi0tZU/uoVO5zebOv7CvEy08a05ikPxCLv8e93Cd0TU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28/07/23 11:02, Josh Poimboeuf wrote: > On Thu, Jul 20, 2023 at 05:30:48PM +0100, Valentin Schneider wrote: >> Later commits will depend on having no runtime-mutable text in early entry >> code. (ab)use the .noinstr section as a marker of early entry code and warn >> about static keys used in it that can be flipped at runtime. > > Similar to my comment on patch 13, this could also use a short > justification for adding the feature, i.e. why runtime-mutable text > isn't going to be allowed in .noinstr. > > Also, please add a short description of the warning (and why it exists) > to tools/objtool/Documentation/objtool.txt. > I had missed this, thanks for the pointer. > -- > Josh