From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B15C001DC for ; Mon, 31 Jul 2023 11:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9295B28002B; Mon, 31 Jul 2023 07:19:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B269280023; Mon, 31 Jul 2023 07:19:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72D6D28002B; Mon, 31 Jul 2023 07:19:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D337280023 for ; Mon, 31 Jul 2023 07:19:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 167B6B1F5E for ; Mon, 31 Jul 2023 11:19:14 +0000 (UTC) X-FDA: 81071660628.18.1401F1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id DF68140007 for ; Mon, 31 Jul 2023 11:19:11 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fV7LkYrf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802352; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=liRJKw+opNrXfUwr+Bq4QbRM7UJXeuw3tZj+4BJUEBU=; b=ONMWup+cGvJMWhwyHLbCl1qyUVs9vH5xFQ65hBUMl8w2vIlOosXm7qoId+CHHynsO16Pms K6oKVfPLXxcyqFmm38Xqwa62fiH/mbGUGA/4IVBNxquwkM6qnCx/eE6sU84/6c59Co2XLb 8NL5Vu3SQcjn0K2a1SBvH/+gdfL4aFI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fV7LkYrf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802352; a=rsa-sha256; cv=none; b=rHvEk8Rp9lMnpoUdD0KTYL6GckCryy/qm0x/ahH2XyzO9WP2E7xIkURQjE9aB4DjaTKyBx EogUVgBelRX1Z+bUxEY6hmXe2VXCvGuhhLuv2/JuHalFlw5fnoo4T+V/YcZV4uHL8DqGf/ GW5Msv69AksiR3xLVM6gNxZrGg+4fT0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=liRJKw+opNrXfUwr+Bq4QbRM7UJXeuw3tZj+4BJUEBU=; b=fV7LkYrfjv766Ebrpe/JYdgr2MR4grOn4qRWzD/dDd9XgxBb+wusuQAl+SE6MFgfKp5mXI w9UySOGpM32XmR4YEyKW92J33QH6s7kxn3ToJAjB6JSRquP9N0dHx9pnHOgstiD5zJ2nlE p6wyEp2aO9sTaovh4WABQ4igfqHdF+M= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-BU1nXbADMU2FXY3h2VfSVQ-1; Mon, 31 Jul 2023 07:19:07 -0400 X-MC-Unique: BU1nXbADMU2FXY3h2VfSVQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-76c7e6b9e16so205628785a.1 for ; Mon, 31 Jul 2023 04:19:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802346; x=1691407146; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=liRJKw+opNrXfUwr+Bq4QbRM7UJXeuw3tZj+4BJUEBU=; b=as4/S0FN3bljEJfY3tkRzMUT++USMQm6CRUK6ufNQhG+PwwZicE+XxUrFq2vWex1BR xq9tr/pkovSDdd6gRRrDkTX2C2gciSdVUsa5Uh/VJJrStHIVyWE13rlIOswdciS3YI4S nbWXXtMdacsii9fSmWTDRgsE5Bw5OeHnCJZ8YFaYWBr2FVDd1ZGXi9GEhYy5r4cZWQKc 0vkCRHYTYojfVKkax42c4T46OhhBKU1AZYBOiy0J7syEykuYkoSIJXe0JwtfMpD5mMNa njjwNp4pO7UCkz0SXjyObfbyJz2UDmAaw9lIqFdJIqOMg/qgYOyw3XGMdbOrYtBk/LCS 3GLg== X-Gm-Message-State: ABy/qLZahUGBBRzzQipM8vTcGvv5361M50LwnpLXPawK5lt0YEmkFfbj iV7l8cd/XIZjj4htpWmpb+iJE6U9M4pVHEyDajsmio8P0X14poBecp7yX0g9blTeeVFiFGAtZot Jo63U6Z57HDs= X-Received: by 2002:a05:620a:4083:b0:766:68cd:d9dc with SMTP id f3-20020a05620a408300b0076668cdd9dcmr8634460qko.19.1690802346570; Mon, 31 Jul 2023 04:19:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlHxRoj22fts1ZRiVdo7BaEAZi0l1tMUruIOv4Nb34gy9lu7KljXIlDPd8x8zhbGrKa5lC+fNA== X-Received: by 2002:a05:620a:4083:b0:766:68cd:d9dc with SMTP id f3-20020a05620a408300b0076668cdd9dcmr8634382qko.19.1690802346102; Mon, 31 Jul 2023 04:19:06 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id f7-20020a05620a15a700b007682634ac20sm3177128qkk.115.2023.07.31.04.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:19:05 -0700 (PDT) From: Valentin Schneider To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 12/20] objtool: Warn about non __ro_after_init static key usage in .noinstr In-Reply-To: <20230728153557.frzmaayyy3auibx3@treble> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-13-vschneid@redhat.com> <20230728153557.frzmaayyy3auibx3@treble> Date: Mon, 31 Jul 2023 12:18:40 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Queue-Id: DF68140007 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: odf41z4jgay3xn64y3pbwh65rm1d4fc7 X-HE-Tag: 1690802351-979904 X-HE-Meta: U2FsdGVkX184YJxmW3h4edKNevqj90S4y7CxDlj7AklXDU2Mi18mRPRAcpH40noRhsbM1tKHr8c588fBZ0eyrAqUMgDUTfqLjspFRROVzbuILyXwkqnBERvSAdNALOXOqfIUFY6a30vmKngXKsnm9XXdjKzHVd0cLxVjyFaSdw3DklcvYJ8wSKVziNomOvEqWjxrdAB0gVe55tem3P1Vfna8AIK/JF4UubwiHt3rph2J4jN6RU2AKZIFa2qbA4OKaKrv36rjJsdZZuuD7dgI5rWq5HRNkSyl2IiPXkZi/PKWQib4u5nTvqKD/n2AF+zSOOQIPelZl++Oubor9zjoYIlQvddtua5c9cwLQVTfZn6fvVLbPT7rvmViS/S3Blql9jfqcJ85EtMJ5yLKWpuzEqbtEelzpffrgwpXF0RUEHJfi1Lg51AJ1QPtrFPz+iBXv0NjAAP9uGpaKWiZScfQrqQ8c6JGkqJH6DAKdgh372FniPQVa+oPT5w3G0OEaw662ct1WfZiuptCil/tngi1aUDQpCjZV/omBEOmwcokKGSeeOeuSV6IbErkF51oW32d2SLUKRcKEIPb7a6TcFazUlEez7lBSYaZX/NwD9E/RsbHOMJJH0j7uFNHJHRkLid/WTkPnmNmP7RMpEtqlRp8iiDUOIMjgeoJ2I3OE4VyctKuYIWwwPFPgThatRwIf5CFl82CGdgjkoRkTXO2Ln1HRwX20rQABHY04A8rkkxPKumuTlrYaqQn0Zzmapwy5YrVoser0udSiHVo1smDioKZ0v23Xw1PbBQPOr7j5CGxi5IOye8/vXRUyo1brT5fwMRd41FOyOJ/m26A6d7GTTQNrvOHOLCQSd+ZRNa3p8FS4IRqMxX1cbwU0JWBjeF7wWun5OKxJ2dRE3sVA9jxKYIn42GumZeBQ3VSDGecq+6N+PMKd9bXUDUfalB+UnhpLCCtFFLSWVw8gCbY8IPdoqm t/LyPaFW iWXyCS6lMrcE3XaexB3EDqVS38bPQXBHgxFRIiayJ6HVjA0yDXWE4/WvASr6/cqTqR1nIYMFdQ30m5B1o0VXK7JfNclNVnMHgZeY3zMoIqXfGZtVKuJos6VojUU2psioPEgsMdsJKaAGvJBrqDMWTK/m9163SEh/G7VEhjNlAWI44HbKLPg7zgWC3QrUQDIFBS7MgK3qXAVQdtZ+KC8ld2aO1bq5hhAKbR8vxC7EL7FsscXLWSieq4SkOugO9NM5wajh3W4ev4WJlcz13zkk86Zcx+JjwwOzo28gjjHnRKK60AKjZh6kWYTA4j+URLCY9xqoS4EsifGKz5iQF1MH2o/3RR0G8tidxlm3dxXPq4SxiV9ahcz7I7pFqyy9vRedMT+Q+MRcAhIJPLcE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28/07/23 10:35, Josh Poimboeuf wrote: > On Thu, Jul 20, 2023 at 05:30:48PM +0100, Valentin Schneider wrote: >> +static int validate_static_key(struct instruction *insn, struct insn_state *state) >> +{ >> + if (state->noinstr && state->instr <= 0) { >> + if ((strcmp(insn->key_sym->sec->name, ".data..ro_after_init"))) { >> + WARN_INSN(insn, >> + "Non __ro_after_init static key \"%s\" in .noinstr section", > > For consistency with other warnings, this should start with a lowercase > "n" and the string literal should be on the same line as the WARN_INSN, > like > > WARN_INSN(insn, "non __ro_after_init static key \"%s\" in .noinstr section", > ... > >> diff --git a/tools/objtool/special.c b/tools/objtool/special.c >> index 91b1950f5bd8a..1f76cfd815bf3 100644 >> --- a/tools/objtool/special.c >> +++ b/tools/objtool/special.c >> @@ -127,6 +127,9 @@ static int get_alt_entry(struct elf *elf, const struct special_entry *entry, >> return -1; >> } >> alt->key_addend = reloc_addend(key_reloc); >> + >> + reloc_to_sec_off(key_reloc, &sec, &offset); >> + alt->key_sym = find_symbol_by_offset(sec, offset & ~2); > > Bits 0 and 1 can both store data, should be ~3? > Quite so, that needs to be the same as jump_entry_key(). > -- > Josh