From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4F6C6FA9D for ; Wed, 1 Mar 2023 18:23:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1A166B0071; Wed, 1 Mar 2023 13:23:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECA196B0072; Wed, 1 Mar 2023 13:23:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6AC46B0073; Wed, 1 Mar 2023 13:23:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C38646B0071 for ; Wed, 1 Mar 2023 13:23:26 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A69B40CD3 for ; Wed, 1 Mar 2023 18:23:26 +0000 (UTC) X-FDA: 80521152012.15.C78AC1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 20D7820019 for ; Wed, 1 Mar 2023 18:23:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hc76BNDg; spf=pass (imf03.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677695004; a=rsa-sha256; cv=none; b=Tu2GaAkTa4EBwzdXr12/V0+9lwKfPx+jPA05xb4qeZ7Q5+f8d+TpVdPRSUxHquPVTRySKs pT34wJ68gMgOFfOg2jDa3jnjLx8jC02cS+bkTNgZMd7zCdfxYRC3VHtuwKUR7a1jdIP6Dd n/xP/QjODfHpsERBDn6cvn7W43aA8jY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hc76BNDg; spf=pass (imf03.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677695004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JZOs1ZrtyzBGWlUNy3rirmBNUl52qHVNx2XoNoPG8A8=; b=Kc3HI1xgWXXYZaSsKvTa7ct7gTr2KPxO6h4jvY20aY88x7gIXmThDRdYU/Gb1TT5+c6W/K wx5SyATbIc8kMCZMTNQE/3IBtwyxNMJJhEj5084PTDclncI3rP7jGNVa+wSfynE+2JtXm9 a/MIXfaRxVn1DxZQKxHfZSwj0Ty/Spg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677695003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JZOs1ZrtyzBGWlUNy3rirmBNUl52qHVNx2XoNoPG8A8=; b=hc76BNDgvY8IMQpJNOk3dV2Yqfhm5n4/YEELrTkp5pC3ZaZfhb7ANwv7ONetCJzdnInxJ6 tZp9yvzKIB03Ch0M5RUV5MaAThn+e4X0yx+//mOzUAq2BcHqVzcbhF20UU9ftVqy0n8PuC HV+jAxZyvaOppOFlVNkQPut2XKvWp6A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-326-sKgyCd-tOY6R2zxmhjh31Q-1; Wed, 01 Mar 2023 13:23:22 -0500 X-MC-Unique: sKgyCd-tOY6R2zxmhjh31Q-1 Received: by mail-wm1-f69.google.com with SMTP id bi21-20020a05600c3d9500b003e836e354e0so42625wmb.5 for ; Wed, 01 Mar 2023 10:23:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677695001; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JZOs1ZrtyzBGWlUNy3rirmBNUl52qHVNx2XoNoPG8A8=; b=RH53Zo1kHzC2a7NQwXsCumQPu1SChS9WqzZ59NxpRWEosSNLeWRgGlLVN7H2FkS5sp MkjmLuqfCjnbHRAqyj+yvErn9rCPVsCuwbHIOQ2YLhkAmT9P8IlDIwzB3opvn4IJIJor fZZ5ArFCZULWWg52yJsX9+MbjiEtP8tQx0x0gbxwj3SQkisYt6f/jweLkwxBrZwcwAXG LFP1zVlfywiRirK2Lv0q3qAfxvcEEJ5C4WKl/MT55/ZT6u+eX5rw0d76FG2pACeSjAkH 0ztwuXvN27miEcJOUCEgydmH0l5SQRDg0aZ04KRRIqhGX6JNmQETx02LOL5ZXkLZsCCe cnyA== X-Gm-Message-State: AO0yUKV8njrJYsO+l4CiRfoZfOV+vdh6q4i7JC5ozwbxomkJ40iRIy2G 404BCdnD+C1rS2YZX7D8MClToYYZvq/tWFSeqVZWG8bKVmxkPYmiGk8a6njC29qwS5mf2R/sn43 720E6ljHYYT0= X-Received: by 2002:adf:dd49:0:b0:2c7:ae2:56df with SMTP id u9-20020adfdd49000000b002c70ae256dfmr5831049wrm.70.1677695001015; Wed, 01 Mar 2023 10:23:21 -0800 (PST) X-Google-Smtp-Source: AK7set+hh4qTKevxZ2Zg/AVz4ilic3h8zzImt+NubfkZPcwe1MT8NeAPx2k+sDTtoLXldr+E7Zd09Q== X-Received: by 2002:adf:dd49:0:b0:2c7:ae2:56df with SMTP id u9-20020adfdd49000000b002c70ae256dfmr5831036wrm.70.1677695000749; Wed, 01 Mar 2023 10:23:20 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id f12-20020adfe90c000000b002c3f9404c45sm13221718wrm.7.2023.03.01.10.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 10:23:20 -0800 (PST) From: Valentin Schneider To: Sebastian Andrzej Siewior , cgroups@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Michal =?utf-8?Q?Koutn=C3=BD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov , Waiman Long , Sebastian Andrzej Siewior , Roman Gushchin , Shakeel Butt , Michal Hocko Subject: Re: [PATCH v5 2/6] mm/memcg: Disable threshold event handlers on PREEMPT_RT In-Reply-To: <20220226204144.1008339-3-bigeasy@linutronix.de> References: <20220226204144.1008339-1-bigeasy@linutronix.de> <20220226204144.1008339-3-bigeasy@linutronix.de> Date: Wed, 01 Mar 2023 18:23:19 +0000 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: 20D7820019 X-Rspamd-Server: rspam01 X-Stat-Signature: siego5fkige6orxz5boeysn6wo8djokj X-HE-Tag: 1677695003-113561 X-HE-Meta: U2FsdGVkX1/7QOHo0k/3QxJhB26Ra1gkgje4dHiLkD3TEJBOBd2TkIHj/VlaoLgd4vKkrhsa6d8MnARIN6uGhOwnE+INoLHrms5ULqzIKFCpraoEE30kmBfOl/0CUiesQUB6v3gaLqpia7g+gxZBK3AY6U6cFxSSFRY52dIJP1Nsfg1aKQGEYIX18bwb2u9yi6gqXPcYFZ6WGXd2cXzdNwyUfCZ+0+fW6t1JbraPix4i+CooOeV0LeodC5J9bch55O0nz9/CazaxpvF+ekAo8CQKcV0aB6S5DHqms/xW/UxP8jSyOQXKj9Xv4WYOi4IbmDxMJc7TDL8czcWkB94rDaIKoWzIGCT/86WMgtc9Rz5+5J/u9VwfRppFxUfRWttcPPX+RoUdP90SSgweqNhVuzTNEtwcW4koDkPdDYXMQjveo2Mq12/TNq6SXXw+cu+V4Ps94C6x5+k6fcvnyku/YVLB6zjYNe68kHEQJhNrbCCMYoK0gBHCB+bAd6Lgbxk8t7skZrGkvHVuBQbsM1hIy5bHdf1wRoxcHh3NKJdHf+Nsw1K9cMcPRp4XTzeDsVBwv77ilNw0B5GLyQH1iaY+ADt1qJBpTsFDyoCZj/DoWmYFQBkJRRQutdUBroFBKd8qzk6JH4xi2KX+lRGpAxXovU7wQQq0bhaP3pY/5dnbYGsBWjTiuz6v9qm4C8/fLim8xGusCj5R0gugbYR5rTukxVWIuTn/5UZVeR0yLwzcOQzNhhy/4Tk98baCidPiQ78+JMK/rXwqT7v2JXywkZ8k0cqLvBaYQTxxpIdtgLXQQgvo+H593bHrvrOpR6AYRRx3HDjG7xo4ZkdOejZLU/ka0e5Fnu8DrJYvds1MeMxaVMjssZctiHXBr6L1ae9fier/oPvjn9sdBAkO18nBtqHlCucs4n13fF8Qc1n9/ilqmhA8vpwWfbRbTGRLFSBG2k/i14cL78Lqq+ff2vq2MMH Oy/wz1YL eKCL2+r7HW7ZXb1Pan2EdF37XnYRZpMRZEu1mmDR9F4IATpEJP/OrB1ywYF5qXF6O5I/cEwCBhL0xU/PMoqPallpw+JBbzKJdEjmqTmYoLyM/9A8kTPzHMeuCZyh1harx0H4Z7TlmlzMrWFA4sBS+6MViGyNuNZsk2ftcxCp7l1/DjUTo4dm4i2etqFHs0j+jln3F+FhuMw3npjxiJIl6n5u494QyHQZLy7p3YjW31UTA9v0HuTTpubbyNrkMi3TGaFh4rMlvwqurYFiXgxdYtIpvsJcyIurZFgpKm7M0bHOdGXrrJ66sflZ5eVE9Gl8LOkPAbtYALkaUE/IWAWwUTpj40T/hWU6XmDV3rUi8SKJdxGZlrtXX0o2oIGOPpifakeCAEBQE2zETBwFtw5bcgn7rCMRs9GVVAvj9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002165, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/02/22 21:41, Sebastian Andrzej Siewior wrote: > During the integration of PREEMPT_RT support, the code flow around > memcg_check_events() resulted in `twisted code'. Moving the code around > and avoiding then would then lead to an additional local-irq-save > section within memcg_check_events(). While looking better, it adds a > local-irq-save section to code flow which is usually within an > local-irq-off block on non-PREEMPT_RT configurations. > Hey, sorry for necro'ing a year-old thread - would you happen to remember what the issues were with memcg_check_events()? I ran tests against cgroupv1 using an eventfd on OOM with the usual debug arsenal and didn't detect anything, I'm guessing it has to do with the IRQ-off region memcg_check_events() is called from? I want cgroupv1 to die as much as the next person, but in that specific situation I kinda need cgroupv1 to behave somewhat sanely on RT with threshold events :/ Cheers