From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BFBC001DC for ; Mon, 31 Jul 2023 11:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F2C28002C; Mon, 31 Jul 2023 07:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF9B6280023; Mon, 31 Jul 2023 07:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B729128002C; Mon, 31 Jul 2023 07:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1AA2280023 for ; Mon, 31 Jul 2023 07:20:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 69456A0210 for ; Mon, 31 Jul 2023 11:20:07 +0000 (UTC) X-FDA: 81071662854.14.17AA178 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 65096140005 for ; Mon, 31 Jul 2023 11:20:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KNr1ZOZt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802404; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5VMLpHOhxXlUy0bWDF9kXZ97zc/VghMcLBrU5Ym92c=; b=ENjKnDAGZVgzR9ex2ddwdaCcu49nrpTlz64Q47FVoZdKdbm744nwuW/DW/MHD6oLL1r0cA yzuSyw+lGFR/a2+QT2xJh15B6WgvjN7MV6MSmjxFBREhBm22N83uW9B95yThVbzgVoLa5a /Q4O8s9mncr22RvqJfch+hX6VoLTsQM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KNr1ZOZt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802404; a=rsa-sha256; cv=none; b=F+VbMq7SaYzHon7D25341tlpSdJtd0yXUAQ0DPBePq7dFs0dKlwNJcubkMd8bWsUeRXCQm NUY5JMvfAat/HOe6GUhDzorK5lo8dmSVntKsuVXdXqJod+oAcvlZ+K95IhSs9CIwSnYwpB gyaGj6ZMzT4386QDfrDSo/4KTg0U2wo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V5VMLpHOhxXlUy0bWDF9kXZ97zc/VghMcLBrU5Ym92c=; b=KNr1ZOZt8BHe9a9IfvWLmd6idJQ1b5fadL7pqUG5MP2af2rlu5ZkO/Efin4UqQiG+czwot TfWvrchXUOMxxLvAdWRGI3ar3Qch6z1eu3ILZ/x2sQmkBQ/wiYZsUW49zFYQCS1cnh2gW6 p07/AuHmHRN8lC2ysCU1WQMuC8PwWBo= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-r4oObiEXMDm4i3Lguy5ubQ-1; Mon, 31 Jul 2023 07:20:02 -0400 X-MC-Unique: r4oObiEXMDm4i3Lguy5ubQ-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4053d7854a9so56880701cf.3 for ; Mon, 31 Jul 2023 04:20:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802402; x=1691407202; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V5VMLpHOhxXlUy0bWDF9kXZ97zc/VghMcLBrU5Ym92c=; b=CGl2kUotalTQt0sm+uZmDJZoIS6uPffZyisNmKJrCnsztjqpxZkncO9bUjOIXJgIY1 yKLXSEt05auN4vRNzqh0BsipyEcu18SWugj48SZTt0HP2jXy4S+IHck2c3S/kdVEcVch csFXmJJorcXlWQUeEWNzj6NYfH4HspDC0nHLoHjforz3UWhV24mySg97YsokVogikuOu kvk9Upv9OQpMC1UUjNOkmKvztHpVy2F3QlD0UohSbhrP+xoa5a8HjJfzXZPJWZIn/wEB GcKd9XZ3RLYoo6goc0v8T9FN3ADN3Yv7ocUkrHCZWZVx6NvM6tvqXo+fhgTWnHJAbVMD wQ0g== X-Gm-Message-State: ABy/qLYdIki2WSwtHqJITgoaZ2/r8r8nbSsuV3zNSZMJnKFVhx8eSIVJ eNRD07r+h5Fs59JDLaED7XhKFQ/rBffKSFpd8S7dg8AypDuGhVwI9gZI1+GpEHy0eAlPjOYweqZ o3X7MUAu1YgM= X-Received: by 2002:ac8:7f08:0:b0:409:f273:e28d with SMTP id f8-20020ac87f08000000b00409f273e28dmr8487944qtk.62.1690802402008; Mon, 31 Jul 2023 04:20:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEVg6/rKm0s9MUEi0BGjFI/ks14KzdgpHID8GGIpvi7qxLN20fQB6V4fe5ZTG4d6GXjiIiI+g== X-Received: by 2002:ac8:7f08:0:b0:409:f273:e28d with SMTP id f8-20020ac87f08000000b00409f273e28dmr8487873qtk.62.1690802401624; Mon, 31 Jul 2023 04:20:01 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id x7-20020ac80187000000b00403f5873f5esm3447309qtf.24.2023.07.31.04.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:20:01 -0700 (PDT) From: Valentin Schneider To: Steven Rostedt , Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 02/20] tracing/filters: Enable filtering a cpumask field by another cpumask In-Reply-To: <20230729150901.25b9ae0c@rorschach.local.home> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-3-vschneid@redhat.com> <20230726194148.4jhyqqbtn3qqqqsq@treble> <20230729150901.25b9ae0c@rorschach.local.home> Date: Mon, 31 Jul 2023 12:19:51 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Queue-Id: 65096140005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pgniiwsyyyfdm9gwsm4dcmu9gadgxwsr X-HE-Tag: 1690802404-85251 X-HE-Meta: U2FsdGVkX1/7kVTUKRepRp7CIk3myu4Y1/9SLfJZtR6Fgt3jP0g5HpWa8AAV3sJQ7TsnZaPtCFx8ItfjHQLz9Fxk2046MnWG0bzvC6ZILyeZgA/uuG4OegAiXk2WPGUA5vaKlekQdJ71iTifBCL2gKJ3hSe9tgLe/o6MWC1una9CB/NK/obwp9blUqsfuvnP2PFhb74c1Cu8l6l0m6lc1lR8d69eCQcBfqUSbm4jIHnnlDQAd590yRdvNmY1mihUBummj6oY12uIU5arP8lxTBPYSKu56WFDgPd7vKAESXRYbmwgXtHJ7nia4SWBJp6B/pEsAN2zH3PIvrYDGNQXF2ZL2vltBgR2Z3NoWO7cyifBsTdw5Jv6ZHlAh/jKP5eTLzyrPDrcuU45hsyInJ0AMUdO0dztZgcMWwAxuOZJf5g4rGSsxn5r59CroW1if1w0rJRUTRtMr9gy7S2m+0mmixPyUe98iqUX/wabz/K6GsEXfVHddNPBLbJNxXmybymiePc+yyzN2KISMNMD27X98WBBJj4TX2pcaz/0de5PbzMjDKHMmeYE34Y5vFVmXY7kMGqilyWphkHHS/4WO+HBaMmHr4mNUHHP1cS3LVsUcbEWRI6SQrY2ZZwBGgP1inu9aXn+iU7WzkXNORd8Evg4C2tHaqChg6lFmlV6xRZr5FgGDJmmF462URd+3IPXST3DZhxFtQPakK6oy9J8xKgZ75xcVPTXSDjXN31c323iAxhcmt70NqO8cXnyhBsquTlZjYqTOK0/uB2LQIweCW7yRrAE1l3DV45kC1Bjzwre4PJfKj44kB4M7mlY05HDfeve7rYjVE6L+LPMHU0duteL2yF4pXgsm8pflUNQZP4EfcOZSXRiK5GcQHvDXPgBlllZ+D4CRnW1RI6t+em5Qad/ynz6pxt+zjjoK/CEW0F2VFqrTaYxkzi+RotpQqEZj+bT8Wk/H+Yp8CppX9ry6KL 8Xpr+Myh sYMoFfZTo15Bp2ur0zV++hAdINiR0QMPd48MbIOshn2EOOlYbH7QvjeenH7OciRUCnBg/iXIynS9knbiv2/J2UJ+pumcWGBKuiclBz1A8FpEzKm5+KQOgnSnlDSFzmrQ0by1McQ2lTXc9eqXmDBPXGLzKP37sAICshPKP4vvO+NqdLrct15pT1eeEyDnB6y48uO4bIQUTE70kbH8bMCCXoEI23RFqj3c4gXeq1Mar+Dgovdlg6KwicHMRaVk4qgUw8kHcSJkU1ORZlQ/9hhPy14g14wrVWpVL57B0wfps1TsxZYn0vdeYFigs2815FR4e3xipk+YeNdKBKvV7AmII1qynsESnK0bTFaA0lGjSsN/8cMQo9F7hwL+N9MSEG71q+8jli9my4kR/5WQjYDB1Nn+SLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29/07/23 15:09, Steven Rostedt wrote: > On Wed, 26 Jul 2023 12:41:48 -0700 > Josh Poimboeuf wrote: > >> On Thu, Jul 20, 2023 at 05:30:38PM +0100, Valentin Schneider wrote: >> > int filter_assign_type(const char *type) >> > { >> > - if (strstr(type, "__data_loc") && strstr(type, "char")) >> > - return FILTER_DYN_STRING; >> > + if (strstr(type, "__data_loc")) { >> > + if (strstr(type, "char")) >> > + return FILTER_DYN_STRING; >> > + if (strstr(type, "cpumask_t")) >> > + return FILTER_CPUMASK; >> > + } >> >> The closing bracket has the wrong indentation. >> >> > + /* Copy the cpulist between { and } */ >> > + tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL); >> > + strscpy(tmp, str + maskstart, (i - maskstart) + 1); >> >> Need to check kmalloc() failure? And also free tmp? > > I came to state the same thing. > > Also, when you do an empty for loop: > > for (; str[i] && str[i] != '}'; i++); > > Always put the semicolon on the next line, otherwise it is really easy > to think that the next line is part of the for loop. That is, instead > of the above, do: > > for (; str[i] && str[i] != '}'; i++) > ; > Interestingly I don't think I've ever encountered that variant, usually having an empty line (which this lacks) and the indentation level is enough to identify these - regardless, I'll change it. > > -- Steve > > >> >> > + >> > + pred->mask = kzalloc(cpumask_size(), GFP_KERNEL); >> > + if (!pred->mask) >> > + goto err_mem; >> > + >> > + /* Now parse it */ >> > + if (cpulist_parse(tmp, pred->mask)) { >> > + parse_error(pe, FILT_ERR_INVALID_CPULIST, pos + i); >> > + goto err_free; >> > + } >> > + >> > + /* Move along */ >> > + i++; >> > + if (field->filter_type == FILTER_CPUMASK) >> > + pred->fn_num = FILTER_PRED_FN_CPUMASK; >> > + >>