From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21A0C001DF for ; Mon, 31 Jul 2023 11:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A9FC28002E; Mon, 31 Jul 2023 07:20:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 530BE280023; Mon, 31 Jul 2023 07:20:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D44A28002E; Mon, 31 Jul 2023 07:20:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2997B280023 for ; Mon, 31 Jul 2023 07:20:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EF0651A012D for ; Mon, 31 Jul 2023 11:20:30 +0000 (UTC) X-FDA: 81071663820.04.A960E4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id AFFFB40009 for ; Mon, 31 Jul 2023 11:20:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VdUBK3yH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5vaUW0ZFNoavCkOsFWH4xJQw7j0BCOKV0sVk8cbQiFE=; b=VkGsWXM3YMXNu5jplhaTzDv+OLI66t3nfRFpjaFn/jvfm7PpP6kEOZ4WH1k1BkpRgz0BTg dbXJNMJvTHiErA1JplEauyqI69QRyRHhuW187QV0e/su6DBTrzk/Wqq583TWgrIQrpYn4a JhPfvYA/o3oPeTKm3zgPYwXR++nf/do= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VdUBK3yH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802428; a=rsa-sha256; cv=none; b=gEYdxKUOEU7jazyORPEGb0c8dZSdMw+0Gh7UmmGcyex5DdJ83Ba7FOBEFkBNlDyIGNXa7W qhClh+I5W8FKvcwk/ohw11a0qVlWysHilDD/z6vq/JOcEnpejTrHkcwVnY17cKlytWNaYT ZG8stgelqFAqV8yRlfABItYBc9LoTGE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5vaUW0ZFNoavCkOsFWH4xJQw7j0BCOKV0sVk8cbQiFE=; b=VdUBK3yHP0pAs0bpjWl950KSPW6X4v6wDUR5EHsDLNWrfqR9QEnQBVbtt8LYEot5UB5A+K O2vsChg45kYT2AIj1JySUJweSmETtYDNGDW1cF/yCCwK+p0f4Lyvita8k9iOICF2YIlXMu TaPPYadEN8x96j8senQAoTLbzH0GYhc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-7dJxb61VOb-h4y4EC5DWzw-1; Mon, 31 Jul 2023 07:20:24 -0400 X-MC-Unique: 7dJxb61VOb-h4y4EC5DWzw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-63cf3d966e1so56909416d6.1 for ; Mon, 31 Jul 2023 04:20:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802424; x=1691407224; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5vaUW0ZFNoavCkOsFWH4xJQw7j0BCOKV0sVk8cbQiFE=; b=XG2hrDyHa54ck+DzIeORKPVVbX9IMLwyOQDTLUgcRsqFO0uN8Dy7/sslp3RZm++E/y Kse3v4v6F/rYn7CLD8u4xQ+6kFWo6U+1QqVnD7YTULv9+o05wOrbfbTNCloD5qJBKxWg 99/rXgcihGWlHSP9VaaJo24OPDbKpXtwfmMIrXzfreYoqw3HVIACtGMFp7YKzq7lifTZ F686C7/jAX2OWzEIAExSYgr+sn0987AfgDrJqtWfv+6oQeN7VXkLTi9m6185nCzyh2ny ywBRDQH3LV+r6I1e3USLsXTAcoJx/fRSDWfAgk1s0ZxC3wV7mcNC0sLl+DX/ckbVkOBt O7Og== X-Gm-Message-State: ABy/qLZZX4kesjsFymBAunR8TPxKKKiYnDCwkn1g5hLhCENufKBgOkpW QMlxa0wfAaOnQJLO1JPolrIcvWCMAMScJGXgKhyuWn4VYLPEClfdjdfGBS2tFv2efdQTZG03bkR z75Pva7VyTuk= X-Received: by 2002:a05:620a:3199:b0:765:a678:977c with SMTP id bi25-20020a05620a319900b00765a678977cmr11440919qkb.67.1690802424241; Mon, 31 Jul 2023 04:20:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4PsqV0GfIB6WcE+e1KZA+Ob00KHOmMkV0SPV2mk8Z9iXGAjuozcLuEeBrBpyr3ypNADcfxg== X-Received: by 2002:a05:620a:3199:b0:765:a678:977c with SMTP id bi25-20020a05620a319900b00765a678977cmr11440851qkb.67.1690802423943; Mon, 31 Jul 2023 04:20:23 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id c23-20020a05620a11b700b00767303dc070sm3206663qkk.8.2023.07.31.04.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:20:23 -0700 (PDT) From: Valentin Schneider To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 05/20] tracing/filters: Optimise cpumask vs cpumask filtering when user mask is a single CPU In-Reply-To: <20230729153436.1e07bfa6@rorschach.local.home> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-6-vschneid@redhat.com> <20230729153436.1e07bfa6@rorschach.local.home> Date: Mon, 31 Jul 2023 12:20:13 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AFFFB40009 X-Stat-Signature: zk8xyr1a178trfrf3rpzcqqzuo83of8n X-Rspam-User: X-HE-Tag: 1690802428-67012 X-HE-Meta: U2FsdGVkX1+C2u+RVQVmJptWwY4GB+ZbqxgBxOq518Pa8+GD1lH6LYmVvVKOdFhCVsXzGhm8WQCQ4L+synluqMuoxCaGRGr9lYPNEFPC1EtnpIryA5dMm9qVoBQFrDIqhmBygSkOlpwDpaMURhbsdT8nJ/L3JQLgm+EvBYFNavNRaPjzrxAyru64VJgLLXkekuRrLlsk+KUuWKeCxiwA2sJRTPFUXZ5MEWZ2BQRXe2xA2V5nvUoOg7+7cAlf4mfKRNwrTS74ilmQYkTwUS8YDQADMutDXs8Vz3GPEYDFe4/anEBI2sXrLYuZDzcx/lzjSPocVp4fT90Tf6m/pZiT1QMhrpkTJPLGOZ5lNYkrz5DGYi+hU7WiPiYKwP/l+AEx1FBeIxISGkQKRwMcftw05/t9zV/i2zIfa8avAvdWya/4eY/8cAHgLRBzM71Jh/JzQ5UDHbWwFzy0hHlhov9RpeJLodShN5xhdRGn68N1NbG0r0wOPNiYTnLd+Dp13ZzMCdWKRwFYIQHUct3mhNOnxBijfEJUbVk6e+TY0Nc54wm40e2fFYTrHv9FL34dOQWCd22/bFQJJGrPZlLLsODPnPbEMUSjaYAwKd/jAo9v9KluMsQCL/r0MeH9SaT35SGuVoWnv7lw4ho8PIWpiQ0Ap9jEGHvTbfiTSKCBC63ZE8XPJozzCSp+c5IbRfcYeT1IITzw1HF6bFfaOnYaz86sOmgLhy3yMNTyDrBznRbRGiT2qh+7yeo4sq4iJiZMcCpz0TaE6juXE6dcKwKUKqpxyXe6UQGIM3QOweWjoTLKyta9oqnBFS7GMpoCzJKUPN5t2/kgZ94aG4n1bSPu6F/vmf3IZMrWuNzzwTghL5t/Bmm47DWQDxaLvmmITEKLy6194tfjhFhi7pKrN1I9BnT38ZTmWQepxXnS1rTsobUY1jQrD0u835thwS9qb7ySayh9258arQ1+j9GN9RhhtTI JsIKVFFT 0Kkq23qXwu0ZNEoIuo0N2yE9T57JlPXja4inlbUyqXjXt7iPzZHavKhr4NOXlkeNI17tTjX3NxkiDqWruYX4Pa6v3ftpj19aKHY56TqImcvu9dHm5c1+XkjrIpcxA/fdnTZeNFd2bcdUdrmCJI2oHSecxUHq6Q7RCkWIdl9klXniFc9z3wGLOLuRXuXM/RNk97USB6NQ+8g5sl4xOUUpuf1VbOHGQLTVt1SdIuL4CwxeglgBq4yJgYbzZL0GMBr4aJa2GJatvX+wsEJkNwaaA/17IRLEI0K3POrnmO5vlfR+8v1fT2sWoS1rQv6BSjko5EiR+EQ6z9x3XjeM1HJl2QKNdjcebSJGLpxycpFR3jwe0Ntw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29/07/23 15:34, Steven Rostedt wrote: > On Thu, 20 Jul 2023 17:30:41 +0100 > Valentin Schneider wrote: > >> /* Move along */ >> i++; >> + >> + /* >> + * Optimisation: if the user-provided mask has a weight of one >> + * then we can treat it as a scalar input. >> + */ >> + single = cpumask_weight(pred->mask) == 1; >> + if (single && field->filter_type == FILTER_CPUMASK) { >> + pred->val = cpumask_first(pred->mask); >> + kfree(pred->mask); > > Don't we need: > pred->mask = NULL; > > here, or the free_predicate() will cause a double free? > We do, thanks for spotting this. > -- Steve > >> + } >> +