From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B87C001E0 for ; Mon, 31 Jul 2023 11:20:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 420FF28002F; Mon, 31 Jul 2023 07:20:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AAFD280023; Mon, 31 Jul 2023 07:20:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2260A28002F; Mon, 31 Jul 2023 07:20:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0CAD4280023 for ; Mon, 31 Jul 2023 07:20:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CFD49C0AD6 for ; Mon, 31 Jul 2023 11:20:56 +0000 (UTC) X-FDA: 81071664912.04.BEDE23F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id DBA0C140011 for ; Mon, 31 Jul 2023 11:20:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="i884zA/q"; spf=pass (imf09.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690802454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=47HAhqvJlrFOjF3d3mT+sXNh9SqjQbM0s/wrTjkOtJg=; b=Z80wNZ1rXnXuKUWPqNHXm7Sjw8WsM4dUUkBw5r8qQ8Du9Ewbvlj+MsqJNGbkX4rb4Z/bbJ 1hCBkCX0tczCXdbk/ZjjIVkoiGjDVPJRB22F85VCnoDkMke3Bf29G7EZjxCCq0WO4oIQ+a U4+LkVewWpJFv2M2ae/vh+X+WZK7OfQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690802454; a=rsa-sha256; cv=none; b=HUS7BjcM1KuuXeQRbCfeuJwk3w5SqKY2eqzAMq7vEiMuDGnhtF3xf+VDr4fJ0q0GuYkV2D GUw6k5ecKomT29nuMwKrvD2x95+1C2ilEHXk/mFEFVxCzRc3eLYc2Eo/SSUYXOctm5Xlxb 3Z4ZIDFWZlN7UrHuxZjM5L/v73dxYPA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="i884zA/q"; spf=pass (imf09.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690802454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=47HAhqvJlrFOjF3d3mT+sXNh9SqjQbM0s/wrTjkOtJg=; b=i884zA/q0qcP8cVnklnRkqGFucfkUGfvK7wvaYeRfGvH0v5btCjeJko+jL59jUXEjgv2qJ MPRE9bRchFfjhtldOnlZjW/z4MQfoKk9X3i254FEmWGuMp6bis0uH3kD2TJVA9OVvafBdu cvHkLTqJEERxMkTOxNDOZBYeEqHfCf8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-ufbVn1nYNjCiuGDrJ6uY5w-1; Mon, 31 Jul 2023 07:20:53 -0400 X-MC-Unique: ufbVn1nYNjCiuGDrJ6uY5w-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-63d246654dcso33291446d6.1 for ; Mon, 31 Jul 2023 04:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690802452; x=1691407252; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=47HAhqvJlrFOjF3d3mT+sXNh9SqjQbM0s/wrTjkOtJg=; b=iMVkUO1GAEuXDbBgnhafdcxnl3ohmd/E0z/RSVQcKuHRGGq3LVsHDSuKLGptBRIs28 Ny5cicLdGuAM4RdAd3oZNs0HnCoLiTVRl4pmmc5JJ2RJvkhwQ0nxbUxPtDE0lJTXVJet edws92kYMvX1zWKElg1ydp/TQTO/bzOXVDbgrxGIuvnm13559VZqkhEjQpgUlMGCOKwW 1LUMoX48Tgi0vGe4RRpjJgfhlf6gdqLS3KhzpQn9tI33Nu+G+np+w0bpzOCRwH0av0lc ptS0mn2OPCTx/y7bub/DJ34MDbrEXa29amPXxdLMMT5DYMA4HoxJEBB4ruhaLklZ84PL 95BA== X-Gm-Message-State: ABy/qLbOna4PWvhyNs3wEJfVEf8t89zZISmrVG7Ai9nydLXpN22fnn3b HUf+TMKPzMMi9dk/2TnPzJGoLoroYLw0F9C1hkWX8gp4WRoH9wn6maXT5IHoGr9zUjDbt789o3Q m0p5jBBytrq8= X-Received: by 2002:a0c:e14d:0:b0:634:20f:471c with SMTP id c13-20020a0ce14d000000b00634020f471cmr6609389qvl.14.1690802451995; Mon, 31 Jul 2023 04:20:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlGQmknuNkpt4OdqMMs+lcZsPQfXQHCOzlkWOeCIE2fDz4iRThyIeyibV6Yi3WqcRw7uGfKfaw== X-Received: by 2002:a0c:e14d:0:b0:634:20f:471c with SMTP id c13-20020a0ce14d000000b00634020f471cmr6609334qvl.14.1690802451661; Mon, 31 Jul 2023 04:20:51 -0700 (PDT) Received: from vschneid.remote.csb ([149.12.7.81]) by smtp.gmail.com with ESMTPSA id n2-20020a0ce542000000b0061b5dbf1994sm3583834qvm.146.2023.07.31.04.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 04:20:51 -0700 (PDT) From: Valentin Schneider To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Josh Poimboeuf , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 06/20] tracing/filters: Optimise scalar vs cpumask filtering when the user mask is a single CPU In-Reply-To: <20230729155547.35719a1f@rorschach.local.home> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-7-vschneid@redhat.com> <20230729155547.35719a1f@rorschach.local.home> Date: Mon, 31 Jul 2023 12:20:41 +0100 Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Stat-Signature: 7s3e6qz9i643uuiaimo6bru7sxfi4nqc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DBA0C140011 X-Rspam-User: X-HE-Tag: 1690802454-996233 X-HE-Meta: U2FsdGVkX1+Z0iB82kMXX9SCCK0m1DW1IdORY+SVS7Hozh56nnwfbeKCC0GqScel76uDqh6Y9syZjgmNd0bHYKD6j5EPN9tIOaYptlFSQv7kWraEet4wWKuvrUQvLaEH+VyYkSUAPmkcSkBqszSCEvnJBngEZm0fWxDEoof3BaWG77m6Z3TFFdg1iupjyYn/VLJlA1DLhEjsQkQsyNlCOsAQKcpFgXRIqd1ORQZDf0I276wIaNlbbnHseouo4w27l6K4BttEQMvZEbUY11E1P8Mfc4+1djFyAqEHjzs8Eow4Wk6wMIVOakOjfBexLNmoJy2tbLjwjvS9FEunxvyS7oldnMf6mpR63G3e0vgFFseJIhsNmz9iMApQo+WPvKfWSjd51x8kYxkJimtg/qi5ANuW/yRmiqIsPxlD9zNZW+YtplxCLLHtYaBS1kP/M8rn8QR2XG7dN6cbhFco84FalBFG8yOejJp1J62j1rcvTx47Ftw6mUMzrOsb4X8Kgfqr707zWj5n9iXGPfSETKK62B5QAs4pZLUkyzYNb5LUzOukDtfi2KOXIR8SGFyDp7fUQnRMz3GLtRG/pRElyh/aztuVJ0lLDnUCpuNA+y6bqBrid+XBs7kaS/sLkaQIwo8DfYnXraZlN4pbEHUn+QIwMpchxYLTLCO1pzX7x3Mt/093jRVYANlR3i4CzY6trtTm4t8YbE2gPbmepk9PuVKsl98XU9Z002RoaKj9vAswkpO85coK2gSRqtgvftPeqUlxMrI0pOEG45KO8RhxseCmKNU0qImTOne022QpbkG8zXZ0FctjAuQFVZSjXFIZSZt9rkAM+XFvcbBXX22JjbD/yIqeP57oW7qhP76f/SxrPzrQo35V43/HrL+VKjhnFUOU5d9o713ru92l29Dztm+0wHyGdx0xF3iYyOLFlhDVgKr7Y42DtiofUge+IxaU0LgrCaOcMVwqmfgjn9SmiOa dVXgRaYn BpztgjjpxeEe4n8ZvjUqVypoFT5ESJzjlf7TnISvwyEs1Gbt7llDLT1/dJSQdHEAvP8XSPD+MYIGPKNGXlJQAl0phhZaUM05OdgafkAOTDdd8WIlU+Ijh8vx8JnzKsSlYXf3TPxxrn6t6MG/2HYQoCV0Of4yBdQpt4cRIqu2f+kA1iqpaoaci3pLLrBNyrL5uZX6Uw0H1SPI/xIm3qpd0StSd8F8ShVLgRM8Hq73JJDQolaNevtUIZnwe1Ok7N2myE+o2iOqgr0QU2cnf5fdPPR4Pyg1Gizic00qcm1EljIv86U+FmHKNjcqze7QPzyNKri8Be7UMJoCHE4QTmHCzzg2lRLwwIimep/CBMtmpPJ5QpP2UOlO4/0ZJXN/dDe/QCEOMDDL/6ByVAZvqargsZVEdkN1eHScBmzGo/qo8Ry9sjIMlMrxLWKfwZzdFOve6D+C8cvHlb5+l8huog29hiqsxn8GMpDDObu25Dprl/gof1IKJp3iARh/pOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29/07/23 15:55, Steven Rostedt wrote: > On Thu, 20 Jul 2023 17:30:42 +0100 > Valentin Schneider wrote: > >> Steven noted that when the user-provided cpumask contains a single CPU, >> then the filtering function can use a scalar as input instead of a >> full-fledged cpumask. >> >> When the mask contains a single CPU, directly re-use the unsigned field >> predicate functions. Transform '&' into '==' beforehand. >> >> Suggested-by: Steven Rostedt >> Signed-off-by: Valentin Schneider >> --- >> kernel/trace/trace_events_filter.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c >> index 2fe65ddeb34ef..54d642fabb7f1 100644 >> --- a/kernel/trace/trace_events_filter.c >> +++ b/kernel/trace/trace_events_filter.c >> @@ -1750,7 +1750,7 @@ static int parse_pred(const char *str, void *data, >> * then we can treat it as a scalar input. >> */ >> single = cpumask_weight(pred->mask) == 1; >> - if (single && field->filter_type == FILTER_CPUMASK) { >> + if (single && field->filter_type != FILTER_CPU) { >> pred->val = cpumask_first(pred->mask); >> kfree(pred->mask); >> } >> @@ -1761,6 +1761,11 @@ static int parse_pred(const char *str, void *data, >> FILTER_PRED_FN_CPUMASK; >> } else if (field->filter_type == FILTER_CPU) { >> pred->fn_num = FILTER_PRED_FN_CPU_CPUMASK; >> + } else if (single) { >> + pred->op = pred->op == OP_BAND ? OP_EQ : pred->op; > > Nit, the above can be written as: > > pred->op = pret->op != OP_BAND ? : OP_EQ; > That's neater, thanks! > -- Steve > > >> + pred->fn_num = select_comparison_fn(pred->op, field->size, false); >> + if (pred->op == OP_NE) >> + pred->not = 1; >> } else { >> switch (field->size) { >> case 8: