From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01167C3DA63 for ; Wed, 24 Jul 2024 16:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E0F56B0088; Wed, 24 Jul 2024 12:59:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 891206B0089; Wed, 24 Jul 2024 12:59:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77FD06B008A; Wed, 24 Jul 2024 12:59:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A6F66B0088 for ; Wed, 24 Jul 2024 12:59:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2211A1A01CA for ; Wed, 24 Jul 2024 16:59:52 +0000 (UTC) X-FDA: 82375258224.01.6F5D7E1 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf02.hostedemail.com (Postfix) with ESMTP id CBE758001E for ; Wed, 24 Jul 2024 16:59:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=myGZ76LE; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721840366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anlDKMLkZcgUI4vplw8kTnoSMhJcwAjX082W+0ru/8c=; b=i3poLK/dIQatJBejSmu+1G3BkBvcUrEtI9pRHLIlPpozdfNsl9yrFiY8EZnTSKN06GDW1O GFY1ABR1UlCLrm4fkS/iHbzN6txEJgXmOM3MMZU66VqHbZeH1Z81RQUb+e0KVtrIE91QUC gJDBRRWFDk6xYfpBjCGv1ifFiMEiA4I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=myGZ76LE; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721840366; a=rsa-sha256; cv=none; b=kHyXbBnb4eKWVLqcYSgCUpRrl74QhF8Nrxa9S1CRQuSYIdZUALtM3N5OKayXDXXStC8Kj3 M3M7oXrVAcM0BX1o0MIRWY/Y2jhISkRwobi6GRDkp4KNQ7mr8YVdKyzuWESVCcCWx4UIWH D/7VC9qCuQITiqIHcdLesVdvXEBrLx0= Date: Wed, 24 Jul 2024 09:59:41 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721840387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=anlDKMLkZcgUI4vplw8kTnoSMhJcwAjX082W+0ru/8c=; b=myGZ76LEVmyQmlm1mpsq0MdwnJoq2wYQNWaal9vHy+hiQQMLShCjM5PBvJntSVfEaqzSJ0 vH6TbX89iEN8GSL5fSDNGkvRo1OAzXROdkTe1/4TdN2QMsyxhZwRX1/+ML4uWrE5eEUg3L a1V8eL5J81kOCxQmfMAGTbGDslvb6Ms= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: Andrew Morton , jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram Message-ID: References: <20240718202611.1695164-1-pasha.tatashin@soleen.com> <20240723234600.d05817293ec1eb2d4ad87be7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CBE758001E X-Stat-Signature: peuaupspsfepq64iwtp6k997oerctuxw X-Rspam-User: X-HE-Tag: 1721840389-964215 X-HE-Meta: U2FsdGVkX19cdDNA/coCziLcHf5W5/8uaJ+N8QEbiPLs21E9/c6Q46WWNsD9yd+rmd8ygaHke8+/yiLLx33zGvNGiJGi935DIldTSCHtVpT68Y+tYIQITvQNgFFJifChfy2Xm9PU2fP8ufxXIvmDSiNdQpK+yKTWFHJVwsoR2yG6vBjeReI0m8jU1bW6d3Y+NuPPG5KMGZo0I9JIxmrfial5Ir7V9M7F97fskBcndlqMMZFvmOFSMYzR+l08W1dF2bpyAQysTgljTfcC74jpaz9qJctzLPw13Y619VOGmbgRNAhR7yf2f9Vww35yLGv5ufTlwNDxYMvTYuMyOaJegaTLTy24IOZ3FUiT6jyvPhFmk2w1QfYPlXx+/N4BPw10+VpqhMeEII+j3q/RKWQbW4yIHPW4RaElDcK4xlROI00mBRtYLYoUhIo0Hz7Yi9YsiLcxz2EYas3ypSEgN4dePKUN5SW7Bag5CjbKR0ccjpGw+WZ/2yCT0Q6C1jVmGgnn9YBTocAZR/Lffe8a72ld8KVnW3ZTG8bt/s+7mq2djxkIOojL88Y0Jn+A38KP0QftV7XWuDbCymMwy0ZExVoeavn8tiFeuXFOBb0dy90kFQ4e/cFAUTwrc72Immz+rNNvNwwc/7aozqGUW1x96ivZ8VS6F+zbfe9Pf2jXEceX930qKBCgnN5d1mfp7vL7bUu5STFPmRl0UJrymGUrymuFhBYhz9PgmPRkvLOnqzy7Y2xU1pnVnbW4LZEh3Grr9m9cq0SZOPzYDRF1+pcEv7S+ONPeHCzjSSNfA+WNmLsQw4nuYCQZqaY5DRVwxaxmWIYeOo659+UfOeNAuC2tbmHe8d8DPoXRFOEI+khXvMsjxKpT2Wjp0R5Sfx6ZaGZVSop+ceBHnAi6nBD4skq6YphQn4YyHJlyFWG5OMxWNzaSJbIA7DH4AmLNJHUUkUDPPE0cSIl6gaUhoK3utsWM3Uf 9Q5MkQal izeQ74O62mNwR8KBAEbL+uS3WeN5/8/6BiAOl0/EYlVmoNdNXtO+STrSJ4FCpl2fv1h0Ndmr6FagNsbhFUS/KqfKeCBKZksCDvz5WIqNWHBpC+iG86QCEZjUYW7MqomfNsZGMJkkjGWc8ruBm54g6ATTD5GAKwa4umGh5pIu6pfyDcW+4XfjHQH/J8r9QdlfspbTLHRSbdxQdB10YNG3t61tAzm/zfan/WrPN/kOdodfU9keMMMW+jD17dkLSOdSat35r4pFNSwZG8tk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 10:43:59AM GMT, Pasha Tatashin wrote: > On Wed, Jul 24, 2024 at 2:46 AM Andrew Morton wrote: > > > > On Thu, 18 Jul 2024 20:26:11 +0000 Pasha Tatashin wrote: > > > > > As part of the dynamic kernel stack project, we need to know the amount > > > of data that can be saved by reducing the default kernel stack size [1]. > > > > > > Provide a kernel stack usage histogram to aid in optimizing kernel stack > > > sizes and minimizing memory waste in large-scale environments. The > > > histogram divides stack usage into power-of-two buckets and reports the > > > results in /proc/vmstat. This information is especially valuable in > > > environments with millions of machines, where even small optimizations > > > can have a significant impact. > > > > x86_64 allmodconfig: > > > > In file included from : > > In function 'init_memcg_events', > > inlined from 'mem_cgroup_css_alloc' at mm/memcontrol.c:3616:3: > > ././include/linux/compiler_types.h:510:45: error: call to '__compiletime_assert_2305' declared with attribute error: BUILD_BUG_ON failed: NR_VM_EVENT_ITEMS >= S8_MAX > > 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > | ^ > > ././include/linux/compiler_types.h:491:25: note: in definition of macro '__compiletime_assert' > > 491 | prefix ## suffix(); \ > > | ^~~~~~ > > ././include/linux/compiler_types.h:510:9: note: in expansion of macro '_compiletime_assert' > > 510 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > | ^~~~~~~~~~~~~~~~~~~ > > ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' > > 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > > | ^~~~~~~~~~~~~~~~~~ > > ./include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' > > 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > > | ^~~~~~~~~~~~~~~~ > > mm/memcontrol.c:444:9: note: in expansion of macro 'BUILD_BUG_ON' > > 444 | BUILD_BUG_ON(NR_VM_EVENT_ITEMS >= S8_MAX); > > | ^~~~~~~~~~~~ > > > > This looks legitimate - is it time to switch to int16_t? > > I am looking into this, and will also uninline stack_not_used() and > kstack_histogram() as discussed earlier in the thread. > Let me take care of this specific build error.