From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5059DC4167B for ; Thu, 30 Nov 2023 19:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD6616B043C; Thu, 30 Nov 2023 14:16:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5F746B043D; Thu, 30 Nov 2023 14:16:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DA556B043E; Thu, 30 Nov 2023 14:16:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 785E16B043C for ; Thu, 30 Nov 2023 14:16:53 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 40B04402E8 for ; Thu, 30 Nov 2023 19:16:53 +0000 (UTC) X-FDA: 81515577906.20.6C2B5C4 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 26D48100014 for ; Thu, 30 Nov 2023 19:16:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CNNQeAyw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of fancer.lancer@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=fancer.lancer@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701371811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=beTU95GN50GYTXIaXw8asjQyUJ5kn1rsDTKmhhbRSLc=; b=7pzZaQJUsyPMImdCfGmqsdsTBHp9NtWWli4xZyHjLFB/+hBypqsYyZLIMtYJdtTNsbgkXm 5z8uK4Uj1aFoI7OUAj6xxFiqm0Svk56qvqcNtBFu+GKEP479eT92OzXuiCZ9HoYlmFXT8H 9zIBYyKmGc2LCjtAKyiS2B4O8RvdtjE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CNNQeAyw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of fancer.lancer@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=fancer.lancer@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701371811; a=rsa-sha256; cv=none; b=1yyJZ3newQjQsMQxYrBgEVc645kr+fdKxVVS3Exps07J58ws2aaj+kTqVTbjKJYCJ9OXpt R2VRS/O/pyXtgdfFSPto/fPpeUiUsFRikGtk/oYa46g8+lVfIXBJK+FZLk67XcJ+bBQFhE DUFnG0tQPHxJCLcCYizFzveXkfCC8yA= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-50bc4fe8158so1879610e87.0 for ; Thu, 30 Nov 2023 11:16:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701371809; x=1701976609; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=beTU95GN50GYTXIaXw8asjQyUJ5kn1rsDTKmhhbRSLc=; b=CNNQeAywv2HsGmygcvn5xAri7gHeL1Xvd7TwnEadpP9oqIwJkGYXoWVuKNn6QItLsG xrj9Xj7DxU8+2a9kadjoYe82KbWZq2BCOnk2hsIANvaVPR0mRSAISK7v92LjN7jGLZti mtMZ8gAs42VzErWdTnmvqdSNjfklKYmi8G1vpeQQDX6LPM0LaTKD/r6hndn5rJhovB83 exRyJ5mxmDvGvD7v+ybVWmk9E0Bst/PMmEthnsSCCKToQd1lMvuV3+eumQ5v+bZ2Garq PI/+pLHIMfzHgr9Dcnxv/DTGEdDrxI3yqNnBK9L6i1xsPQAfdEv8hFODu0Qa68TK+LsC +95Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701371809; x=1701976609; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=beTU95GN50GYTXIaXw8asjQyUJ5kn1rsDTKmhhbRSLc=; b=LHQ12xiEnlnfg5OSwCd48U7Iu+A6paT2aDOuBQz45YQrPnThZPHnzu9DeStfvCN3Kz LcpGTVTyabhaSDrWXXMfiLHshnoZQhvLPZkJPrXSTAU9mdlMSssmwRL7u2cf4N0hbqYm TMdh+r+XlHWkR6G0Y3gT5jwmxRcfnniLFKbaQ7B7sWbjXFW6h4pEcXo7B+u4ARi0fCfp CJErajgjQ9bSLWrjE6I/9u5EAuBCwzmOC3d2FfrTRDMK731FGGqLgXkaSaYSnIKCRto3 ABO4VTRVCtxdVl9xJ1dIxC2FGLvuC7YKg0AC8rzd58SKy2bxpGqH4ufkgt6NBDwXvJSI 7kkA== X-Gm-Message-State: AOJu0YyTJlrKSjmWK2Iw4jeqNQuWA6p8yuC1K8sgsV24X0bYl0rnAFG0 XKFQuduwzNEWz/ACsYbdyDw= X-Google-Smtp-Source: AGHT+IEjI7GCoxUOOVd+G0oM4OekkSNj6mkZDuZl+LhOwppbLSARI3DeRgkKK7Ms62A8NDUSE8hsMg== X-Received: by 2002:a05:6512:36cb:b0:507:9ef2:fb1c with SMTP id e11-20020a05651236cb00b005079ef2fb1cmr10846lfs.2.1701371808553; Thu, 30 Nov 2023 11:16:48 -0800 (PST) Received: from mobilestation ([95.79.203.166]) by smtp.gmail.com with ESMTPSA id dx14-20020a0565122c0e00b00507a089caf6sm230827lfb.219.2023.11.30.11.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:16:47 -0800 (PST) Date: Thu, 30 Nov 2023 22:16:45 +0300 From: Serge Semin To: Jiaxun Yang Cc: Thomas Bogendoerfer , Arnd Bergmann , Andrew Morton , Mike Rapoport , Matthew Wilcox , Tiezhu Yang , Huacai Chen , Yinglu Yang , Alexey Malahov , Aleksandar Rikalo , Aleksandar Rikalo , Dragan Mladjenovic , Chao-ying Fu , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Message-ID: References: <245d3985-9085-4be0-8c74-d95d06334584@app.fastmail.com> <3iksuovvsln3cw3xpmjd7f7xixfvwaneu4ok56fnookvyolpco@wrxxew3thgnq> <3pgnihbrp5orh4tmj45fipbfoxdwzjh6uefitdpcea2vgkarcm@d56gv3areswl> <2148a67f-bd4f-432e-aa0d-c914a4bd5e0d@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2148a67f-bd4f-432e-aa0d-c914a4bd5e0d@app.fastmail.com> X-Rspamd-Queue-Id: 26D48100014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: m9k83rhnik78zo85pkbn1k9hhinz6hrb X-HE-Tag: 1701371810-557650 X-HE-Meta: U2FsdGVkX18ap4Aw7VgTwA1YVFXb297gNAODYq0GKn4Um3NZFJS5Fgz8DmeDtXAlWLX5NCv2X6DKvjfXKw88hi3CfAa1l9QhabEYYuoeeRKj0lrOjvMerYNvMRfPlkhMm4oHSRpplDJ3TP6/ge15+QhclTFkpW2UxJGtmXjdyTdHXENidsEzKWyMRNLHKh7S1B00SCxoN8DfeCz79B3vmiSGfjJWPNMhfdLeK+gkcCJ4m3BeZf/tk1deLaRW3scKhUCntXZUlmzGoOqGJDisyXNDC0VVhmOX7jecPVB1XnjoXIAyjwLx8X4gOCqVJ0jb0/FxyBeFJcQdKk318oKFjtbbEaUfLlJgsptAT6htIn9R5aK991SokXQgvysPoykTk94BRKOjjxxBCIBFI23z8mT4XJm6aXpHULUwcA02tBxMVXv8HENrC+MlmYO136Aglt8+ASKoPvJOX/5KQvaX9GuN6Z0OnGLk4J/lWiN+S/A/MOJnJ0JNThSjw1yE0FP04lRkDsgwuU37lbzxMDqBcbKNx0LM9XRl+orlzsExWRh/4CZmho8kx3DLxu3bnnjuenduR6wCAAYMW1qo4gsjOI1jJV5wJ+YqJh+rzfCFDnu1nEymQXFBgkdUrcHEieEVFLG5P6jFcDTvjdwwOFRjS6psIOAOJKrCtzQbINedWZf2s+r+8KnIFvEaKvCrXOROma4cVpvgdZ3QaKEjkGO4bcBNHo8Vz2TBxGz0lu7JRREKSNp44Xc4ldbPVAisVPBib8aimQASk3ZuqKZeSD14rUdT3KDWS0FwKUYgZUoxoqv63otDM3P7W5IhJmp98E2Z8wdAQPxJHo9aiKStK1vwziPRx7Ly7BXIVfTmKCQ665r81SUNxpfmUbf8L+xEOBHZH3RjLOmCA77nklghtWez9SPE4I35J8jqmndsnm2l8j0h2e+FKTLmOQwkMYazWmtvg8znbzonxXbShCyjbzK 2UM2cA+Q xnLUbyQBVl4bk8Bzxwn/HRGwtWyJ4ShXi5bsHLsQJn4nwMXLjBttJNv5bThKZKqXGSEgoXFhmesmn+r6mdstXAZbExKMM+Lc/71sGhNU4K9VF3Fx7jJFy4l4NPmL6zop0w/Tjf+wBY9m3nz4uvBhgwxkmZcSdiOUE/DyPorlmot7IqCP1W4fkJr7WIPCokOsfix5PzwSGcS5qVHpzLkGpW3KUDTohiq06yW34ZciviJzl36CQvG38Dj8oBmCmpSWCEHpPh404Tw6Ge4V2IXogIHoJrwgq9XHQmP+j7Z3QHrrSRg0oINrKI87XtOKXDVC17bFrBcQ1/CvY0P+0icResIzMwOMtw+VbQtR+2OFK2/HLLGOGtACXTFQvWJ2XwVpruhcJojqHrViGTVBhnbytASH530Z1lkfZt9KIZPV5JJf4kJE4Bh7o2kzf032mS6uhsNgaeBbfe7GlHwdu+/MVUd5ria7u/22kkzLAjbCfLCUIQV8S2VsoY7eRA/c76pWhIOnT7aR/cR75sOCvE2HVWGPx6ymjMwIlYSXRem93hDfyODaVvQ7EsZu9MA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000081, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 28, 2023 at 03:46:37PM +0000, Jiaxun Yang wrote: > > > 在2023年11月28日十一月 上午11:34，Serge Semin写道： > > On Mon, Nov 27, 2023 at 09:08:11PM +0000, Jiaxun Yang wrote: > [...] > > > > Indeed. Thanks for pointing that out. In the last days several times I > > was looking at that line and for some reason UNCAC_BASE seemed as > > CAC_BASE to me.) Based on what both IO_BASE and UNCAC_BASE are defined > > as of the uncached region anyway, then it should be safe for any > > currently supported MIPS64 (including the Loongson's) to use ioremap() > > in place of dmi_early_remap(). So basically my current patch in the > > subject won't change the method semantics. Let's not to try to fix a > > problem which doesn't exist then, and keep the patch as is especially > > seeing that the alternatives might still cause some troubles. Will you > > be ok with that? > > I'd say the safest option is to use CKSEG0 or TO_CAC here, I would have agreed with you if MIPS didn't have that special _page_cachable_default variable which is undefined for some platforms and which might be re-defined during the boot-up process, and if MIPS64 didn't have ioremap_prot() always mapping to the uncached region. But IMO updating ioremap_prot() currently seems more risky than just converting dmi_early_remap() to the uncached version especially seeing it won't change anything. MIPS64 always have IO remapped to the uncached region. MIPS32 won't be able to have cached mapping until VM is available, and paging and slabs are initialized. So on the early MIPS32 bootup stages ioremap_cache() wouldn't have worked anyway. > but I'm fine > with ioremap as long as the semantic remains uncached on Loongson. Ok. Thanks. -Serge(y) > > Thanks. > > > > -Serge(y) > > > >> > [...] > -- > - Jiaxun