From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A8FC3DA49 for ; Tue, 23 Jul 2024 17:59:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 637246B0082; Tue, 23 Jul 2024 13:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E55F6B0083; Tue, 23 Jul 2024 13:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 411946B0085; Tue, 23 Jul 2024 13:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 220276B0082 for ; Tue, 23 Jul 2024 13:59:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BE4B0120335 for ; Tue, 23 Jul 2024 17:59:20 +0000 (UTC) X-FDA: 82371779280.22.7C41469 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf28.hostedemail.com (Postfix) with ESMTP id 6BA3EC0021 for ; Tue, 23 Jul 2024 17:59:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QPKrdkAQ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sU6zP6cK; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1721757522; a=rsa-sha256; cv=pass; b=jCbHfzdhH1BDCt89tOq47Pv8Z2ZSLZhI+oT1iEnZBdOaPG4lvklKr1RsvYgFIgpZw/qAsy XljAE4SavEdyC7gJMU4Mm5OcbQa91+LoFRZto0Z5phOhjeEEU22OKSIdv9Nuq8GP1hpwK0 I/CM6adoMWbkKBlsbcdH3fTfXwkry7Y= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=QPKrdkAQ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sU6zP6cK; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721757522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oCqfMqzsNlInPMh5iHHKvuPEq8lIdx7kk3lcR2sOeyo=; b=JF4w0uu9lu6OBgQ5s4zLmiiyiNslsrCB/IdPH63AjXLGfZsTe7Fu4nuFkIP2dbUdK3bKuY fbDa+sLWTOycJqPtsUWuqMK3JaBhoTt41Iu66uoPhwemFMM6CV9ZbBSJm7nZIHp4lXsZPA peo0hHucWB6mroIWFiN44417OUVXb0w= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46NGQTLb022868; Tue, 23 Jul 2024 17:58:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=oCqfMqzsNlInPMh 5iHHKvuPEq8lIdx7kk3lcR2sOeyo=; b=QPKrdkAQMuZ9xUSOFYmReUIAI48cYaG OKpKY8dqQkwU5hS2vWkgGNl7yFzfGBCy2lVmmF4WqGz3+LX9yQuhOLbhF1a/x69N VYPvGw01l4wWFcbqyHrEpuVeI10kyuxYRLg+fHp76WM1pVrOp2hJ/uyjlHVBnM9K 0pRFxjN31JqppIPgytUdOFRg5sc8crUJXC85Tgaf2KfR2XE4BbIlPE1/JqxyEnNQ 3bAH1948ydMXPe2p+Fv85uJzfbsYaAkhkXMCgaNy9iazbpnORNU2VXgd5/ca4Awk U+vIsJRmGquPOxrDkSSLlPCBL9c1NZLa1XrR/4XR84oxaDTmFghYfxA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40hghcq2h3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2024 17:58:50 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46NHq1Mj024602; Tue, 23 Jul 2024 17:58:49 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2049.outbound.protection.outlook.com [104.47.70.49]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40h2a1sq3b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jul 2024 17:58:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cIJp2mQUnc1xBXckViDSL34CqEHVBNtpJWEKtqmHmApWJDSCVM7hRnczNoQpQJy1SDKvm9QV8YfSoROwJBDm6IszcvJuzDo1f89RQ7+ctvIqzqgacYAWCA3S4vzdU2joJks64QbnUM8kUHuJwLMWjz+ao6cpkwkV54tqcWc6naaOcc2zhf3yoH8hkmX10EmJrzFgV7FZKOPyAMryY8G2AjF41D2Hr8ppSyIeqoe2axcb7q56ym97pELQ3WA4uBySZlNsXZp3C5hY0DBxVqr5c9EIduwG280V0wXWKzRAa3YGBKgJwXcIyrE7V0RKVfHOwh6YCFX3NUGsm/H/OQxsGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCqfMqzsNlInPMh5iHHKvuPEq8lIdx7kk3lcR2sOeyo=; b=gm3m1Q+k8rbYUX/riqnBaQ3tL64YqdBqG0EfQlTAL5s2mJTEf12LuBAvBVOJ5ewnhdgcFKpTnvTpXxm2dcudFH4AxlEVKsayK5AxylFOBi8BpZ9O6ikZ9SVmcSe4B9LUisNBEQEu6vL9wFDX7GWwnUvmqfU0/HdUumNE8AKNmduTL+MbP+ndeig27y1rCIdPPG4NzNy+GRYjPtxVPaRtmQkPrrK3Kkq8vMtIwGcGmh4f+yDPaxWiGEUSzGUYAqHe359fNU2JJzSbcr11DTpHz/DkTedCu/zym9qadwGHCI7IvVCsuMHchQT6ngWiJ7uY6afYjh25TCLABYi5HZuYeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCqfMqzsNlInPMh5iHHKvuPEq8lIdx7kk3lcR2sOeyo=; b=sU6zP6cKN18yirmONLQpNWruJ77iISqi66tSXcVrtd6Pw0SrWPHr5tWTKbycqzUzliYUAMhDytkoOIliVX9Vw4/WH4mqVlBT2SArRj1JnjlCSPER5eCCrD1DJ3lmktQL9qSx0hflhK0Bp5B8ybu8H4WSQUGe9HJ+JL2FiADAdy4= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by BY5PR10MB4178.namprd10.prod.outlook.com (2603:10b6:a03:210::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.18; Tue, 23 Jul 2024 17:58:47 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7784.016; Tue, 23 Jul 2024 17:58:47 +0000 Date: Tue, 23 Jul 2024 13:58:43 -0400 From: "Liam R. Howlett" To: David Hildenbrand Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , x86@kernel.org, Yan Zhao , Kevin Tian , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region Message-ID: Mail-Followup-To: "Liam R. Howlett" , David Hildenbrand , Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Alex Williamson , Jason Gunthorpe , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , x86@kernel.org, Yan Zhao , Kevin Tian , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky References: <20240712144244.3090089-1-peterx@redhat.com> <50a581c9-0e59-4282-859b-922d02b3870e@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50a581c9-0e59-4282-859b-922d02b3870e@redhat.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0412.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10b::11) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|BY5PR10MB4178:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e107e4a-29a7-4671-b13a-08dcab41196a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?50IHmp1idakCrn1mk35oz+QpaNBdBNEPEKmOjzXtO+dPd1YEP+SKJx/wdOOU?= =?us-ascii?Q?0g/v9dKXUMKKktT7c+ikqLQI7tQF+bd4TIFSoxqipIVWkAvVvGcJFl6rgD57?= =?us-ascii?Q?F2PA27/OMA197+eggRNI7CxZwCyE/fwqAPU0lcL8iRdfCwH6eNdiFSoFKQCi?= =?us-ascii?Q?YZm1NumD+2nRqUqWfzwInSC2vjjO96BX3JGMe3skj4wMnjvf5895OyJ6l9gQ?= =?us-ascii?Q?GtrYxHtt6LYF70keHMzyf15K44nacaUeq8edVNGF6L7NrvXykHSf560dmJgu?= =?us-ascii?Q?UsG3Y4BSft7MPeOKfwHwVbGGFELTT7rTKG67XeqK3q2p9MoYFcPnmGGD83u6?= =?us-ascii?Q?EV8PWak/ytuPZ0K6TNnFn1MlGrC5BBdgv0g8tys41+1orvBLmqITT8VxHsEh?= =?us-ascii?Q?nh3zhJomLdisBCiegXiKq9UBY7QmK19ja7jNpQBbwx9l+tON4ulsub2xQa2u?= =?us-ascii?Q?qiv8uwgjbcV3WsUA7/Z4Uo5UczDQha4NE8wxYQ4pNzNGjcGyYwl3Q1QMLEri?= =?us-ascii?Q?PegE3TuTB45rQi7/q9PzVZvZ+NVLYHSWSBAFE4Uucgqa69bI0DmhuEy1P4X4?= =?us-ascii?Q?zKd95m4wLLpISAJKFozL06hGflnce1toPKZlRiDNEG5qslPL7wV51eyqZ9DI?= =?us-ascii?Q?fwOB2ej3jDPdUHg01dfvbtmYJXbUQ/6/SBY6ypkhzNgefPPbfsHG9OMsbb2O?= =?us-ascii?Q?R84dWt623ZftQqlN7g5+rRkfDZT7QmpBqyOIfCLCgtL2Hjdvm2A6DwNZw1Cw?= =?us-ascii?Q?wbIaCoujzo1iJmZ2VCzPuUAAFwHemlhczsPa1J7ue1iUklAsTfbkrOAJjg3k?= =?us-ascii?Q?6Map/PG/zeynRPAtrXd3nu0VaIg7Yxhu9BrPNc+5sx7C4krwvP/0Yj3DTkfS?= =?us-ascii?Q?fZVF857mni4Zs6o9ZJjXmKWQjCNQe3e8aarvD33/N+cOsG7BSJeSaB/BmFwq?= =?us-ascii?Q?iCRdkY60ziimjonTQAQnRMQakblN6DhC8rhbJXHqXUoWcy8N3E1sMwHg/Aja?= =?us-ascii?Q?jgjoAusmmOcwlv5lVe8T6Vq5NmJbsG0c5FoPdP1Xz6uoMwmPcot0OALXuubR?= =?us-ascii?Q?clPTVmXg8dx2VNUhBU2MXd0v24VK8FwAdVEj3pgqTygYYURU3YeBdmT7Ajlb?= =?us-ascii?Q?ot+/ioYVkV/y+LXv+5cW0dHuoEu2RX2x4opS2PnqjnbxH6EqVnqdLj4U9Jaw?= =?us-ascii?Q?59MWFv47SDrbvD/uxmrlHfEJ37pXsL3GC76P5ZMmwTnbk+pSmzbxp52pVGF2?= =?us-ascii?Q?Jc/5zdW2yrMOwDYmczFubtPvqWARVK8howGqREb3B4o+uElfrJkY2V4ILiKP?= =?us-ascii?Q?dzR3F/wvnHU75Sh+i9sTZTbH7cI18HgN0CVVNT3mJ1r6CQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ENwuG1qDzPbe44JvIn+8fYyP9kvg3arttUJUNjZ0RMKU3Akvi5xpq98WhMSx?= =?us-ascii?Q?3zXeTDONXy41BeFstjZ/882DqKvYNmIzDdf0tigxm9GErNuzwF8IK7Gc1Slx?= =?us-ascii?Q?CjnwATYdbDpm1MrGDBk/BByA+TsCN/bKpp3usxZrgkQioYuHbewGT27Rq1ld?= =?us-ascii?Q?4XlN/jvzd1B+6nMpvq3cCCtL005i4LLvr9ESO/oGce8w9gKWNyPthDl8IWCc?= =?us-ascii?Q?GwzYyk1rmZ9OGG8oaaArKL/1sq/S85uzpd1g+zMtcpkouYwZPpUya0Vms7s4?= =?us-ascii?Q?XyG+ID5qlHuR2ifW4gzb33FU2UD5xgxuEcdisFQfWeOLW7Zak/yJdslE91hR?= =?us-ascii?Q?s21e5TRfwZ20ivSvhgKwbzkL1XK3L79ZyYv7KhSGTBzIsXnV+GlOue8kd9bW?= =?us-ascii?Q?7rb0UXa1HIUwNOwhYm78jyW3iaDTSpCUwKh9zLCAUi7bETJfk5DfqjhTOfdv?= =?us-ascii?Q?Al9fxqjqtuCvCBBI8FNGOSXL9c7LKCmwjBn38Hzt0/ZOEGAmOc9Ez9awrhcD?= =?us-ascii?Q?Wh0V/RT2E5bXvzVIZxGALutpp0/AEAQnbi5lxyQJaS1FQgqQAU/vagro8vAT?= =?us-ascii?Q?Q0v6KVEpuFUjSXBsYy0qJIX1AhAixg7KNfv/f05/cVHUpHZ09B7dSICA43tU?= =?us-ascii?Q?gsPaC+NVycDchwLvszgz1QRGu77AzqU1h9drxUY0ZJ0kbENHLFoAGcwlYEl4?= =?us-ascii?Q?P46hr6rXzWLKUOXABxZWIG/q92Berouvjmhx90Qa67bN7cybu0mIIwyu1TWZ?= =?us-ascii?Q?sdmudJYDtT7GfNMsGhAm6jaEq7zpnTbu4g02/Bi8OIiRSdXfFbLQofwnDjId?= =?us-ascii?Q?X/Ck0GI1C4rCsC0Gvbn6Grrs+scPJnZxsNMCLSJvFHu6HUjTaS5rt1BqGt+g?= =?us-ascii?Q?GaMUZ31OAUlVrWLnBKHwLk9VCoj3ycWiQmMHgC2epHnaSNqH0a/d7phTnOPt?= =?us-ascii?Q?4xUdFEER33nLztC/l76B+SX2pr60XYsiPDZU9LUOfMFvMJhS2mhJCjy/mBkp?= =?us-ascii?Q?J9YzBhJ5He/M+S+AlKoNMAXj9Ms//dVByNrJbNQAVCuEVSvilfoC3rpbVvw+?= =?us-ascii?Q?BBUNoNTqX2JNvvNj1srfQDLXPsl0WicEN4CB44d0oIb/4T04cuGPwV25+cWR?= =?us-ascii?Q?4mbLR6hddSpcdavEtLf3qwfvEpBRLlmSTEY9ZN+LjW/t9+lQlJ7fn9ig0Owy?= =?us-ascii?Q?j0VOaNI+5ND+h1dDsoFn/8jhfIMJLm/N6TJB8g4yME4g1PAO0CoSfG5Zon0H?= =?us-ascii?Q?mZFunrL5vteok1l7dnmjz6npNBHutJE3k9t9CY7r7pAXk2ivPH9CRjm8D8Dw?= =?us-ascii?Q?54LIeVlCmFlr5ueCxNTUqr5srKo12PFpZ9KtxSA5ENG1XIBnUlB3s8jEEADv?= =?us-ascii?Q?4tTFaKjHt2vIt5WHz1PghSzJ+/IMriQV8Bsx28Kt5GQxpJSHbFMNAYaYrz82?= =?us-ascii?Q?PU5tnqnW3Sw81X9bQbxdvYEOB5wNC80rAferEne5QlDqHZh7T1x1Rx5uattb?= =?us-ascii?Q?2xVMKtmS1rFtwUW6VetNeF/XmIsDjIUId6RESbakbH+jQqf53TJIROs1d4om?= =?us-ascii?Q?WKEOlcmJzFW00Wcrod3uMnlXnW8sNebXNKybCK86?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wg33Upmajs4YiQdl7ox3dfhaksidFwZtwh8I4+ueIXhTwNQrtcvNa8eHZ5tuZRP+GzvzCvg8UCV8nh6e6dDc9Tx0ifTGa+/EoXVKwJvTVNGCrTA5M5znJ07PkJgIgP/Rsv+cpRXbxan0BWxw/HNlJ0aiKhLR2+FGU0CZ+Js1J8OoiGeqoWlwNngU3BNbtJyJHrEdL8MNrwphZWVNTTyRqn+SRnhslnSoRLKPNlA1kV1ruh860O1i5G6YnvrW1ZxJ/YeTbVYYCto7y/x4bo6jHpF4p9mW5B2bquMuxRRsEHkepb94AG6ziKAkbZio1bBlXzyBYoZ3wUfnJYs15JyrymJuUgCMwkBKXzK2VPUFPfyi3t5LRM1E62r7OTlzk+Fqulfm8G2O8RRgkn6RmbHVHrfHB4thOLGltl2kvfNRkcR3ApxkDlB5EQR36rKOSiAQbyzxsUBTUSN96Y81mLFMmVYdH0EMIT0kD7rBmO3u4TpI5zgW1so8tqwvAN6hMJa9BtFbEReR87JWpUG6lprogvRZXf9amIuT+RSkvAySgruY07Y+OSDHeREyv4+ihkGjzmxewuDy0b04izFVaTurzdUqS80jDNZ/Ivv2oaqtNfE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e107e4a-29a7-4671-b13a-08dcab41196a X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 17:58:46.9605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5NslnylB0RHGqkBhP0o2foBR2SSHP3yfXtw2Zh3gHWWXXIuHnv0yKNmEbnGmujyyeRjHfc1FGiFHLRPAAzk9bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4178 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-23_07,2024-07-23_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=993 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407230125 X-Proofpoint-GUID: 4lzBWl8I1hfTXoPD0K-Wl1E-APDq2VfO X-Proofpoint-ORIG-GUID: 4lzBWl8I1hfTXoPD0K-Wl1E-APDq2VfO X-Rspamd-Queue-Id: 6BA3EC0021 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y6iskdkah75j9prr3wasduomqhnckzge X-HE-Tag: 1721757557-738869 X-HE-Meta: U2FsdGVkX18qAzKIhpkImUKSyxjiHSeKy4xJudcSdV+lBo5xQEOg/HPXzx6JIvCK+OwvNTO+YdoR8fngy/J5ukRMfuz+3ME0QNIhae9h1luLOAZOIZcNp/Mw7QXSX1CV2F5ez1jtudlnTPvlMGRaGH40wtnnTDzc5IchckT8KhBx95M82ooRN7KEhBZ+2/l4gE/CpnrjoAaKj8DfsnY7jEAP2BDPgaulh5eooLh0K0E5JnYdcdwkRIA/S8iVo5Xodiwx4q+2KQ8xiRynTp82Qb4gSkF9Al7ewHgfuyc4soAdG+RitnUoA1oDFnP9IPv1ActhSuE/AtN1kApNuIjhydjiganrLKxR5VKUcgiVv4GOqskyy5j8imwE6FrFM3zR6ndttps12jVQv51LBcd2+mpx0BK1IRBe5PKtqpLlXWR6fifjC32aRDLdV3BImGBSAZLHHJzGZiqHNvxN5WsetcVhopUW/EHYwWnPvz1CUMd5us2pqr/AjZgMT5cMa1/KxV23zNA39ZzheDNP+xJ2A3NkcZ9FZwEF9tX6Nq7WmW0IG7O699TZpr8KKZYq2BiFBAjAYWDfgki7rL1MXvKsap3j2ky3d8/mA7ukddEpXnxZ+ExahdhA4uCJTiikYSRNtZMKrhFEu8hw3YlhDl+Kl4QzgANixXozsDfVSLW6rFr8I4zvKGxLjTXx4O3OfLg51RMe0p25dR9MnHweycWrhaWzDvysVXdc6OYFC2LCoP0Xr/eQeMzieozxPrmIK6StwWdh4M3SN4q3WMtFHFlqqcbHsDFEXb5ciZypMOIP79REAAiZa4cy46v/lyHxlixg4TNGsYi9XoHx+l/1HoljXVywuRydFSPrj4VgxUPfFEAm90M22gPVp6Tuxkt6JeagkaYvbLhrfbpMiZI+Z10HqHjiN3nKJz4Uh8GLu6myBosMrpisNxgUa3h+rulYZttiUlvmFgwQK3nMVzYMPES /jouiCAI o2Zniz0wofdgx3rn/H3j1Tg+da8fnUXH/U4GdXktpBLiSW4u+5yhdDPHaTu656PgBFqiFHQTPM0WtYx7hEnlQajDf0eYIJIyJkQYTLAMGxlRJ31o6TRKxXqtgvHPlftwLOV7sUDw7Jri10or7mnCtiOHqI2DegEQNuBCxXSfrZ5szJDKFdkj0WBCG4rVB1JHa2/MQW5lJrsm37xsIvdqD0nLcHa9Ql455BrtCGdfNfO4nHCglW+z5wV3QYZzupZKH51uNnGzZzjBKwGOIC9JafQjbpN5lO1MwqbPOC9enCoJ9GYFdiHCP2zW+eAyCYKuVq+YjWiaTAOAqgxHPyYjyXFTKe17P17HZQyA8p9QHccu8ZNQymPl4JFJiVzIGqVisN7yJyEOUnSTswH+Q3P7Q9IxwlviUpM9wallRM4hbNaPLkkKZ1QuVEG/7f6QVAAqpvXMqWb7o9CVH+pZK5Bgz+Ca2DHJf8MYTHe+6bq+poY9JN851O18Es011pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * David Hildenbrand [240723 06:12]: > On 22.07.24 23:17, Peter Xu wrote: > > On Mon, Jul 22, 2024 at 04:22:45PM -0400, Liam R. Howlett wrote: > > > The problem report from [2] and [3] is that we are getting to a call > > > path that includes unmap_single_vma() without the mmap lock. This patch > > > fails to address that issue, it only takes the caller with the assert > > > out of the call path. > > > > > > Removing the function with the lock check doesn't fix the locking issue. > > > If there is no locking issue here, please state the case in the commit > > > log as you feel it is safe to use a vma pointer without the mmap_lock > > > held. > > > > Could you please state why there's a locking issue, and why this patch (of > > a x86 PAT specific issue...) would need any documentation on that? > > > > I thought it was pretty common that file truncation (or anything similar) > > does a file rmap walk over vmas that mapping this file, and vmas need to be > > alive during the rmap walk, no? > > Right, I was also assuming that the rmap locking (from where we obtained > that VMA -- rmap interval tree) makes sure that using the VMA is safe. > Ah, that's what I was missing. Might be worth adding to the change log. Thanks, Liam