* [PATCH] mm, cma: make parameters order consistent in func declaration and definition
@ 2014-10-24 9:47 Weijie Yang
2014-10-24 16:37 ` Michal Nazarewicz
0 siblings, 1 reply; 3+ messages in thread
From: Weijie Yang @ 2014-10-24 9:47 UTC (permalink / raw)
To: mina86
Cc: m.szyprowski, iamjoonsoo.kim, aneesh.kumar,
'Andrew Morton', 'Linux-MM',
'linux-kernel', 'Weijie Yang'
In the current code, the base and size parameters order is not consistent
in functions declaration and definition. If someone calls these functions
according to the declaration parameters order in cma.h, he will run into
some bug and it's hard to find the reason.
This patch makes the parameters order consistent in functions declaration
and definition.
Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
---
include/linux/cma.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/cma.h b/include/linux/cma.h
index 0430ed0..a93438b 100644
--- a/include/linux/cma.h
+++ b/include/linux/cma.h
@@ -18,12 +18,12 @@ struct cma;
extern phys_addr_t cma_get_base(struct cma *cma);
extern unsigned long cma_get_size(struct cma *cma);
-extern int __init cma_declare_contiguous(phys_addr_t size,
- phys_addr_t base, phys_addr_t limit,
+extern int __init cma_declare_contiguous(phys_addr_t base,
+ phys_addr_t size, phys_addr_t limit,
phys_addr_t alignment, unsigned int order_per_bit,
bool fixed, struct cma **res_cma);
-extern int cma_init_reserved_mem(phys_addr_t size,
- phys_addr_t base, int order_per_bit,
+extern int cma_init_reserved_mem(phys_addr_t base,
+ phys_addr_t size, int order_per_bit,
struct cma **res_cma);
extern struct page *cma_alloc(struct cma *cma, int count, unsigned int align);
extern bool cma_release(struct cma *cma, struct page *pages, int count);
--
1.7.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm, cma: make parameters order consistent in func declaration and definition
2014-10-24 9:47 [PATCH] mm, cma: make parameters order consistent in func declaration and definition Weijie Yang
@ 2014-10-24 16:37 ` Michal Nazarewicz
2014-10-27 12:13 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Michal Nazarewicz @ 2014-10-24 16:37 UTC (permalink / raw)
To: Weijie Yang
Cc: m.szyprowski, iamjoonsoo.kim, aneesh.kumar,
'Andrew Morton', 'Linux-MM',
'linux-kernel', 'Weijie Yang'
On Fri, Oct 24 2014, Weijie Yang <weijie.yang@samsung.com> wrote:
> In the current code, the base and size parameters order is not consistent
> in functions declaration and definition. If someone calls these functions
> according to the declaration parameters order in cma.h, he will run into
> some bug and it's hard to find the reason.
>
> This patch makes the parameters order consistent in functions declaration
> and definition.
>
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> include/linux/cma.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> index 0430ed0..a93438b 100644
> --- a/include/linux/cma.h
> +++ b/include/linux/cma.h
> @@ -18,12 +18,12 @@ struct cma;
> extern phys_addr_t cma_get_base(struct cma *cma);
> extern unsigned long cma_get_size(struct cma *cma);
>
> -extern int __init cma_declare_contiguous(phys_addr_t size,
> - phys_addr_t base, phys_addr_t limit,
> +extern int __init cma_declare_contiguous(phys_addr_t base,
> + phys_addr_t size, phys_addr_t limit,
> phys_addr_t alignment, unsigned int order_per_bit,
> bool fixed, struct cma **res_cma);
> -extern int cma_init_reserved_mem(phys_addr_t size,
> - phys_addr_t base, int order_per_bit,
> +extern int cma_init_reserved_mem(phys_addr_t base,
> + phys_addr_t size, int order_per_bit,
> struct cma **res_cma);
> extern struct page *cma_alloc(struct cma *cma, int count, unsigned int align);
> extern bool cma_release(struct cma *cma, struct page *pages, int count);
> --
> 1.7.0.4
>
>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm, cma: make parameters order consistent in func declaration and definition
2014-10-24 16:37 ` Michal Nazarewicz
@ 2014-10-27 12:13 ` Marek Szyprowski
0 siblings, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2014-10-27 12:13 UTC (permalink / raw)
To: Michal Nazarewicz, Weijie Yang
Cc: iamjoonsoo.kim, aneesh.kumar, 'Andrew Morton',
'Linux-MM', 'linux-kernel', 'Weijie Yang'
Hello,
On 2014-10-24 18:37, Michal Nazarewicz wrote:
> On Fri, Oct 24 2014, Weijie Yang <weijie.yang@samsung.com> wrote:
>> In the current code, the base and size parameters order is not consistent
>> in functions declaration and definition. If someone calls these functions
>> according to the declaration parameters order in cma.h, he will run into
>> some bug and it's hard to find the reason.
>>
>> This patch makes the parameters order consistent in functions declaration
>> and definition.
>>
>> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
Applied to my fixes-for-v3.18 branch.
>> ---
>> include/linux/cma.h | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/linux/cma.h b/include/linux/cma.h
>> index 0430ed0..a93438b 100644
>> --- a/include/linux/cma.h
>> +++ b/include/linux/cma.h
>> @@ -18,12 +18,12 @@ struct cma;
>> extern phys_addr_t cma_get_base(struct cma *cma);
>> extern unsigned long cma_get_size(struct cma *cma);
>>
>> -extern int __init cma_declare_contiguous(phys_addr_t size,
>> - phys_addr_t base, phys_addr_t limit,
>> +extern int __init cma_declare_contiguous(phys_addr_t base,
>> + phys_addr_t size, phys_addr_t limit,
>> phys_addr_t alignment, unsigned int order_per_bit,
>> bool fixed, struct cma **res_cma);
>> -extern int cma_init_reserved_mem(phys_addr_t size,
>> - phys_addr_t base, int order_per_bit,
>> +extern int cma_init_reserved_mem(phys_addr_t base,
>> + phys_addr_t size, int order_per_bit,
>> struct cma **res_cma);
>> extern struct page *cma_alloc(struct cma *cma, int count, unsigned int align);
>> extern bool cma_release(struct cma *cma, struct page *pages, int count);
>> --
>> 1.7.0.4
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-27 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-24 9:47 [PATCH] mm, cma: make parameters order consistent in func declaration and definition Weijie Yang
2014-10-24 16:37 ` Michal Nazarewicz
2014-10-27 12:13 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox