From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68251C02194 for ; Mon, 3 Feb 2025 04:30:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 818966B0082; Sun, 2 Feb 2025 23:30:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C7BB6B0083; Sun, 2 Feb 2025 23:30:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68F426B0085; Sun, 2 Feb 2025 23:30:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4BA2F6B0082 for ; Sun, 2 Feb 2025 23:30:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D206FB23AD for ; Mon, 3 Feb 2025 04:30:13 +0000 (UTC) X-FDA: 83077356306.15.3369D43 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf22.hostedemail.com (Postfix) with ESMTP id DFDE1C000F for ; Mon, 3 Feb 2025 04:30:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QwPWyA8A; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738557012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LSek/aw1RhbQazdMucH99fMhafUeVbuXI/DmPJuxos8=; b=Ozdfru+SlvQVeyHS660A66UiYkqo7I90jaAwEvwofVZbBZ+qhl3HB8Y5+2p1MsTQHoxKi9 jrTJzY8aLKss5D/vhJ1LMT+eR4jrFreJa/nMChwCH62Tv4GjIU3d0YRt56UU+kbghO4yH7 B6zRNDeJuYOaABJ9PEcr/xjmbtVttqA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738557012; a=rsa-sha256; cv=none; b=u0lfB9E16ZptuDZMUuQ5UtOn/XaR75KgqmcvLncI10Q0ffKBzvORsxusKFO0IcnesBwyzE LKE8TF17E2nyZX6YmUCl43M4pXMqyv5tWN5MJdXdO5sGtv31+asNLYxzQdsqJ7ySnwZT7I oqADZJfJW3TSB9kJgYKqjJHEOeDPGKs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QwPWyA8A; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sun, 2 Feb 2025 23:29:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738557005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LSek/aw1RhbQazdMucH99fMhafUeVbuXI/DmPJuxos8=; b=QwPWyA8Aa3ZDAulTtrwivT2Ijv0b1E6Yo44peGm6CwTZtLO+roBh/zYf4Tt4vdQ57MfD9U j0MIjvrO2vAzLsS3jstUq6KLCHKeIqfpTpsyLT5gxkWLGg7WvHWK7U5akr9BpkIy4iBEoE Tr7Gqb5qCXv1kpT1YeTfIgstgy+psj0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: syzbot , akpm@linux-foundation.org, hughd@google.com, linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] [bcachefs?] UBSAN: shift-out-of-bounds in filemap_get_entry Message-ID: References: <679fb148.050a0220.d7c5a.0074.GAE@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: DFDE1C000F X-Stat-Signature: mk7dayk3qdjpszhrwdrxd5oh66413y5q X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738557011-398551 X-HE-Meta: U2FsdGVkX18e7PVbdfI9td4v9aXoRvGHJbtMRhB3KkYV85LRu58Zq0oml87Cqm9VAt93dY3z91gp20V4ZuJf1aT7RDrTSxC1QIMTuQsd2Rz//YoQ0pDK/Bj/Mi2z7Xaxztu+m/wzL17uhRAE1xQf6ENhGQbchJbYuZmC1V2jM4cbCeN7JQ+oky1EuDA0wdWRBb21uuEr6cnXheYjouVKYSLe3utCJCh4USvBsZt3bDndQHrAw4ELl+2Z9T+PU1oLD9sPEjG3BDXt0rnvMsDPdsHj9CjZhkvAb0vLoc2nwrdVsDAqpX9IHHsacDICQ43Ap8KVg5aTFG+LWz0fv9FqQyCrb/xGE84AQAJCA/wa1zlqxO4X3iZosRryM9FtGB12RdCXZMGlxJ1m+He5pEpr84xzsgdijv89WzHxOOx0kVao9GF25Gm/RbADEP7wo3LN6PBPpTRTVpj4faJfKg7sj5v6vcBUwry82r3j6F1jC+xZ5QNJ8pjUVB8SrT2ZAKVXfFD6M/yrrYr3S3LE71aruO3/JiiQWcS1iw817Kx4AB/oqiVJjjJIseL2p1pHrZlL6fiB0vAFMV90uoqwreZp26SpA7f7BfQp8oBz1QSku0TcWuMuvnCXNlOVP1kdfAKe7wL+WDYg254IWmVbJ+ekv0TyTFA5hfnkUu612RFXvqPS1zkIAK7TL9Oh9cJsiwr7lp2X4Cgb5K2QQvMl0h1bY6KMQ/bhKHirxFqGN+Ykc5Tv3m1gIaVf4GwuX55GqeYMVJQBu0iLrpBN3bW3HmqLRPQcWgw7jr33loDIPhyWnw6c+aVbx/6C3t2zheoRrUc0+KnsjWttlE4u+W7GWr66Nn0c7FLPXjQLlcyCyvbvRjgCLU2wHbe5r/c+6BqbjBQ25ksOwXw5sidQiyYKH6jOrNe7uirQeb+wNsx9MPijfidsyFw8IopBPviLq6qWFEc4IvCgJg+QhOngX6YLwwk qqO6iA6K 6WOoVR7UpLZKAHxx+68+eOblCOBUcy20TgZLCaeAxahk5hhCkuHqxM8TeeKULWUYOR+fm1bSyrU5HKRGS093XHy+nbKynjSGuoD4Of7ZnV2Y0BWEFWviyVkQcNf3NezzA6TwB8+k2mapuKpKu345RXIQZdzIMfiwsf1ovj+YSxMQh7EZODLTCQWLMmR6dqnbx3/j5oN26+6jaRaBe09lqsBIhMz24FuSAY9U8dwtccpLbPO7pbT1OwkMxRxeZM5v2AnVjuw2mVkntzeH+36uccR9rlE+lI3KG5t3KlSVwDaj/wYi0WqiTo/AUbRtB3dXbrplbPvE+i0PQo8UpTZN9S7Ee7+J4o0562X7f0haCXShrsxcD/qMIoM2MlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 02, 2025 at 10:11:32PM +0000, Matthew Wilcox wrote: > On Sun, Feb 02, 2025 at 09:54:16AM -0800, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 69e858e0b8b2 Merge tag 'uml-for-linus-6.14-rc1' of git://g.. > > > > ------------[ cut here ]------------ > > UBSAN: shift-out-of-bounds in lib/xarray.c:147:16 > > shift exponent 192 is too large for 64-bit type 'unsigned long' > > CPU: 0 UID: 0 PID: 2666 Comm: kworker/u4:9 Not tainted 6.13.0-syzkaller-09760-g69e858e0b8b2 #0 > > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 > > Workqueue: loop0 loop_rootcg_workfn > > Call Trace: > > > > __dump_stack lib/dump_stack.c:94 [inline] > > dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 > > ubsan_epilogue lib/ubsan.c:231 [inline] > > __ubsan_handle_shift_out_of_bounds+0x3c8/0x420 lib/ubsan.c:468 > > get_offset lib/xarray.c:147 [inline] > > xas_descend lib/xarray.c:207 [inline] > > xas_load+0x583/0x5c0 lib/xarray.c:246 > > filemap_get_entry+0x1f0/0x3b0 mm/filemap.c:1860 > > This is an xarray issue. I suspect it's a race condition, although it > could be somebody doing a misplaced DMA or something. How easy is it to > reproduce? > > (nb: I am on holiday for the next week, so I'm not going to be focused > on this, I just don't want other people wasting their time looking for a > bug somewhere that it isn't) It's got a C reproducer, and you already use ktest, so build-test-kernel run -IP ~/ktest/tests/syzbot-repro.ktest a0ae55e3dde11d2d790c (it's the extid from the dashboard link) If that doesn't work ping me and the syzbot folks, there are some improvements that could be made and I'm going to need them anyways since I have a ton of syzbot bugs to start cranking through soon.