From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFB5E7718B for ; Fri, 27 Dec 2024 10:01:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8BF06B007B; Fri, 27 Dec 2024 05:01:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3BD56B0082; Fri, 27 Dec 2024 05:01:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D03586B0083; Fri, 27 Dec 2024 05:01:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B3C536B007B for ; Fri, 27 Dec 2024 05:01:13 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4F50C120FB4 for ; Fri, 27 Dec 2024 10:01:13 +0000 (UTC) X-FDA: 82940294766.22.DCD8772 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf06.hostedemail.com (Postfix) with ESMTP id 4DAB818001A for ; Fri, 27 Dec 2024 10:00:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mpu8pNwe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735293631; a=rsa-sha256; cv=none; b=CoXkRvPJbN5xBcv4PoB9yxv+iNS4ujry2T9AbaFhMbN8AuivsE7AeMRFa8mQOFl4TICF5q qscyEb+jC8mpyPJgg3ogGC80PIYpF7aCxpmWQ3KlzDr0E30lnXcP+g00SJL+Fi6hcytJzD 3lNejslduI/vLvdmgPfy0ChgWbtFLGs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mpu8pNwe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735293631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H1bXOt+/SWNE5B0Rro5sU1k0ChxZ3dWUrzRCpSgWNGs=; b=z4unURSm0LE2IxLcPrh2vicszy5eRnxiU6UaVRj9+JMp5Lagfk59duV+KXiiFhGFuYjPB+ 4LawsSk1OZldAE/7aXyHmYlDNltVeKN9lG8MlifpMVq9ez1w8jMJAxiEWvmAIBqr5KBzUR x5XMIU2CipRSnpkdJOygJysEpdWTPQ4= Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2ef87d24c2dso7270892a91.1 for ; Fri, 27 Dec 2024 02:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735293670; x=1735898470; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=H1bXOt+/SWNE5B0Rro5sU1k0ChxZ3dWUrzRCpSgWNGs=; b=Mpu8pNweL73I8orSqq2Yo6cYkzhtNMCH8WOPneYgpRzJ9F9fu8wrkmEBaGae+3JSv9 4tCLO8z7CndvR/sqsetxrZdtBfJm+Ag8GdNJQ59rJF5KNIQIZ3DL3tYwIQevN91IRM6n Ey01oCL5SF19GYa04Wut7TY3v4UoZEyrpMDbhewvWMTk7/G0o7nPRuWsp5mQADtomXQ3 MhreyWi74wNE/eSSKTkDUfI5WZx78790zA3obOxR2oen6XIGrQxBz7SqMy4DA672BL7I efF0PhVLNm4ofGjA9oq3DMjdloO4kI7nZEeqJU76CKN/GaiIwCMzyMNfyyWEMHP5ixxr ew+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735293670; x=1735898470; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H1bXOt+/SWNE5B0Rro5sU1k0ChxZ3dWUrzRCpSgWNGs=; b=IsF16bDQsh7sasBdFw295ZocEUZPvAj9ww8UfOJzrCqANG4Ee8vhm509Y9KWTP38/7 rjUDZVBphy1BCZRMl6oFIperMdOyw/epg2FXzT/g/RV0yRhfGkDYAv3oYzx+U1ZKeyN7 QPGcJLNEYyz4+vI2XvOI01gCeH/hmTIZeFdVSCyIzDMRL+ojcDAN45muZ+8YbYipAgT7 2qWds8B5zm7YRLt8RQO5Q1wZKAQKNkyUJ2+8ZLEc5yT5cTVLx3hxUzQjzKJYRFaB8ZRz IPKRLwb7B/KtanYpA1RJdKZusb06/zGCSzPuD3CT0gKlhBBBhvE+MDVClnu5h4BAdXgu cf5A== X-Gm-Message-State: AOJu0YyJCGDaMofmeyWjbr+qMfqPpcMV2J5nNbGCPa/kTePs1/fGyDk/ zKJVd7oqZgRJepLtKsMBJqCMR6xa7pVfz9YgAB5v61piiPL+ll7E X-Gm-Gg: ASbGncsnUdIKncuNZGFsRpC5ofm2uk3Y/ENBGPfurdPB8o5IWr8GiXU97AtB9+2FFvY YdabCj1yk9sCA+Fdr1GpNBhqbmR2XA3ji2nND6f93hl6ssCip6SMjSgLoeTv80hRq8NKaDHT/A5 VOumLw3uhyxnc/W4KuOowi1WaCZye0o8hRQlgyieTMwfDoiy0BYlbAiexAoJ4JeyZTFH8fERMTW f9sUgbgIJR2dKMyezend/Ax8IefCWVVDPB4xcLBEbBgpbkxVptMHCU= X-Google-Smtp-Source: AGHT+IGyKeQI9g4XvkvB/XxW5qo9GGOQvVVbo0ijj/HFtnarQ+Nte8qH7wrecnKYDSaTlFelfAvBoQ== X-Received: by 2002:a17:90b:528a:b0:2ee:8619:210b with SMTP id 98e67ed59e1d1-2f452ec3589mr39117284a91.29.1735293669826; Fri, 27 Dec 2024 02:01:09 -0800 (PST) Received: from Emma ([2401:4900:1c96:94e2:5054:ff:fe53:2787]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02ac2sm132110855ad.272.2024.12.27.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 02:01:09 -0800 (PST) Date: Fri, 27 Dec 2024 10:01:04 +0000 From: Karan Sanghavi To: Markus Elfring Cc: linux-mm@kvack.org, =?utf-8?B?QW5kcsOp?= Almeida , Andrew Morton , Christian Brauner , Gabriel Krisman Bertazi , Hugh Dickins , LKML , Shuah Khan Subject: Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions Message-ID: References: <20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com> <57318436-1462-4984-a863-8c8da4e96792@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57318436-1462-4984-a863-8c8da4e96792@web.de> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4DAB818001A X-Stat-Signature: joi6pnxdz6qwcc959rxe3apf3q8dda3a X-Rspam-User: X-HE-Tag: 1735293641-195392 X-HE-Meta: U2FsdGVkX1+BtqbLXSGy9hvz0MjJMzqVhVEOISnyT3zr7NBO2OlPb20pmQgfNz6xKBvo9G1fRv8WvrNMyExb1FbSEaSP+wBeTUJTzfNA/ksu3azF75U1v27YpTCooZ/8IBxuho4RVfuO6Pl5ETDufEfbGvtoYAHSFZoNdUKHCnVbqdZHZqhwfO6kfuSTbH3GVf/B0AOIZXsTaur5HAYU8BVUaafX8zbEhNgzX9AXvAqnbpLeYvPPH8o/Lmz4ULj1HDQlO30X1iZipe1ZgV/F4bUX/fQt2ZLQPtvogqda3MNjyuCEeYClufttnvMn0pZ4gmxwTQjjAiBIOuwAu7Asjoz1dc4VmFBQVJxhf84JDV3R0hiE4+BN25JKz05QGF5JEjU8NijcI6lS24HaAUFA9emXZmwIuEi83oXWJa9zrib1ZGo+Yj1u912AXYSWoO0VW5Cu2MWA6aKXOxuoHyKQgcKztN7rzBVyawA7MBJdDen060h6vyjos8FlYlczVVYgR363VrPXbDtWv6OfGCNTok1EIVvyFQJzGirXuPK0hVzh23ah+jL/Ixz5u+Xj12w9aCgJ3UmIJBBSLqaygMT3gVx3k7llC57sBMMfHmP74CKAZm244JPgzXFigl/K3IBFx0RXnLxo1pc7DJ9Cp/GZTivh27d2Faaun2GxmUdUxABpWcTCopFLEcD3kk+d2kTtAM4ucD5GzlAEvc638RsVoaCkQUIAT6/6aZTmA2CcaIxvdRa2Thv9qydIMewtwhXpm8lUX/YFKdSM43xk/q8KTCmeRVvGqqf1qCQ0YV2QYYtx6Z36dX1T+x3BbzZnmndbmOsBtnckj9kp/pliHK+JHWeaZuUIrHHYeXXDQ5GRI1EDdwJ3n6TR+5cY9bbJot4sb2K9piEDY7GgSlQH/HHcBso+5SS6Bl/KhTOLh4KzYymKScFhg2XlW9Xk1Lcpsp2GXiIPkBSNXaQruT5PnQB VZQi7XFX NVgwO+D3iXh6T2ZkKSStjBwEBMXpjK6nlQSUDq1kPFMA5QggHlb98UKsUD70bCs6Wc0KlyhA7KMnrscUd1RmgqlhUVkl9p8iPafnZASZZ2vrQsDtrCl4GRpWBTxPLt5PxIFtaub7VPlw65WmDlL7XTE3v8suW9eYWdRtmJ3Mt0QpBoFbjmR7k2vvddTyBhaa5g8OjA3fM9oGxcMh9IjtFE+1z7eLV7HyosnKfJNMvNsThoOg6q/ql2qvLrJyNaIAL0Q+TioXogOz8P6IxVx61nZp0osK3mKAw7UIzAeQUPtNCrCqNSdp+2z+f70z6W3OijyS+TGjwbzNfpi+usHYk0dqYJTMe7hhbNc3NZCrr17SPv/6RWqWGtfU856B22F+YReEb4UQ09Qteb3KDpbLvinIAClA6NvbUIvsOVU1rEu2vl0cRnZBstg/VuLVnVJhw/T3LBQ/lDt1VnG8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.397325, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 23, 2024 at 01:43:09PM +0100, Markus Elfring wrote: > >> Use signed data type for version handling > >> in shmem_parse_opt_casefold() > > How do you think about to move this information into the summary phrase? > > should i add more info to this? as i am still not able to understand what i need to do here. Can you please suggest what changes are you suggesting here. > … > >> --- > >> Coverity Message: > >> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) > >> unsigned_compare: This less-than-zero comparison of an unsigned > >> value is never true. version < 0U > … > > May such information become a part for the final change description? > ofcoure not, as per my understanding, text after '---' are not included in the change descriptions. (Do correct me if i am wrong here) Thus no need to worry for them getting added in the change log. Thank you, Karan. > Regards, > Markus