From: Karan Sanghavi <karansanghvi98@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-mm@kvack.org, "André Almeida" <andrealmeid@igalia.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian Brauner" <brauner@kernel.org>,
"Gabriel Krisman Bertazi" <gabriel@krisman.be>,
"Hugh Dickins" <hughd@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions
Date: Fri, 27 Dec 2024 10:01:04 +0000 [thread overview]
Message-ID: <x66swoe4pvdfrnsm5ruq5fd54shfoqz363p3r7fschn6m63qp2@waljdkeoq4eu> (raw)
In-Reply-To: <57318436-1462-4984-a863-8c8da4e96792@web.de>
On Mon, Dec 23, 2024 at 01:43:09PM +0100, Markus Elfring wrote:
> >> Use signed data type for version handling
> >> in shmem_parse_opt_casefold()
>
> How do you think about to move this information into the summary phrase?
>
>
should i add more info to this? as i am still not able to understand
what i need to do here. Can you please suggest what changes are you
suggesting here.
> …
> >> ---
> >> Coverity Message:
> >> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
> >> unsigned_compare: This less-than-zero comparison of an unsigned
> >> value is never true. version < 0U
> …
>
> May such information become a part for the final change description?
>
ofcoure not, as per my understanding, text after '---' are not included
in the change descriptions. (Do correct me if i am wrong here) Thus no
need to worry for them getting added in the change log.
Thank you,
Karan.
> Regards,
> Markus
next prev parent reply other threads:[~2024-12-27 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 18:07 Karan Sanghavi
2024-12-23 11:52 ` Karan Sanghavi
2024-12-23 12:43 ` Markus Elfring
2024-12-27 10:01 ` Karan Sanghavi [this message]
2024-12-27 11:08 ` [v2] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x66swoe4pvdfrnsm5ruq5fd54shfoqz363p3r7fschn6m63qp2@waljdkeoq4eu \
--to=karansanghvi98@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=gabriel@krisman.be \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox