From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 369E3C3DA5D for ; Fri, 19 Jul 2024 22:38:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CEF36B0083; Fri, 19 Jul 2024 18:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F796B0085; Fri, 19 Jul 2024 18:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36E126B0088; Fri, 19 Jul 2024 18:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 166F76B0083 for ; Fri, 19 Jul 2024 18:38:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AC98A16099C for ; Fri, 19 Jul 2024 22:38:37 +0000 (UTC) X-FDA: 82357967874.25.9BBC6C5 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 1B085180003 for ; Fri, 19 Jul 2024 22:38:34 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=flyW6R6x; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721428684; a=rsa-sha256; cv=none; b=xbmiyMO+x2ln6txx0JJLGi4x2F4GLG12F5FSoSNjbF+m5HMFlqFs0zzfhrUqUs/Zq8eqJY 56V6ZSBFnlBGXn6RFVQyKOHqmeoT4+V5CABz17+mZRDJnXgkWReM11S0ZRj7LkD/bYUYBM XIKYchuPVcqv64Wk9gYqmcCWYoOKXLI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=flyW6R6x; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721428684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VY4/Hju5Y9WjjUEbutvnN+TSGFpL24vOvQj6GSXvk90=; b=Bec968qq5HSZfhnRWvqB2Swjd8XpEWu6CwonYarH1oiZSF8Psc+wEnCUylM/+5Eeck3L/6 8gNpjcwJ/A2BNBT4Y/TKFsUWyet0IP5BzaYYEQWmSRHEOvKnLEYlf2Xa23XYVwe9HWhusZ WErH0+DPfBC7RuemAAVlyVZT5pnsfzM= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721428713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VY4/Hju5Y9WjjUEbutvnN+TSGFpL24vOvQj6GSXvk90=; b=flyW6R6xKncUCwD2FDk4Ewhyf20qukFAeY7JK2qSIKabuKNSgrq6U8k1dA16zHUI8XqwWI t//LodQVNk8G84y+ogKmxorE9WF1csy+3UBuS44ivOfE9dFD49zNbnQq3YCEP5RiO3xOJR FWUhsjGFzEHkpKbyFgOv4OKtz4QcD30= X-Envelope-To: oliver.sang@intel.com X-Envelope-To: oe-lkp@lists.linux.dev X-Envelope-To: lkp@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: ying.huang@intel.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: fengwei.yin@intel.com Date: Fri, 19 Jul 2024 15:38:26 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Oliver Sang , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [mm] 98c9daf5ae: aim7.jobs-per-min -29.4% regression Message-ID: References: <202407121335.31a10cb6-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1B085180003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: huzixqc78zrtp8kguhwggjrfmrgx4ri9 X-HE-Tag: 1721428714-804841 X-HE-Meta: U2FsdGVkX19IK/KE+1mYJ57SxW3tN3HepvWe0CaioNWbegw2gUKvNo1I9g2vvlVyoIKbAOl3rBuADh7xedwVGHu4TA06EWEZ7Ay1v6c82iekP0ZD3EXD4bMRFYsu/uqrxo0BCwWDqD3obU6/kcUGpGwmQK5GPgGrBM+T4xwqYoTng7Sq+Ce8zmVjyLQsmrfTSDyPtzWlUWTguGsp0l/Jty24EklxiHxwy0mYTNsh+e/c9zlZfSsb9JcnH755fJMRQnnPCSUC4sgoCzjCGrfZc7Vy93mW42xXSgkHczJGHDGGYgsBoIhS6T3R8vwQfiBpEP55D6tfNHQzKnojK0T1EJG0tkLCKf+DVcHosXZoB0BFU/bS+sPEJNO8UDyzCIhKl19PZMYEFkn8YRVG+A3y8r7eAJhaCM2IyDziG0Ez8vKZZyHjpz4ewARoxpILtRvU4w7zmjUdqtoM8e7DtB/jykLSp+XVQzfW8cUjvudLgtQi9RWHFUtFZuXJ/6ugqb7ZfzBOmZT/crsQFf4ztnWsx5fl7HqKDADXsQe0UnLdlxw8Zr7X2cdptE2D7uKeecUA241l2SzhfLfzRw423jEF17Lydyietty2vO5Dj3iwt7RFPgq4KyXBOQjgv0prDMfVarn6qhpGAJ6vgXbEkIk5wzklvmdbURPNJGJJINGMcM2k86Y6swuD71BxU7cvpUlxcUXRonvn4R8nBqx9OX3HFrrF74wm7lQqla5FsdJHmv50xvBoBx/VdUXzu+zOE5by5ogNDFXuPkG8ivztKaInDRrvlUigFL4PJ8N8gMqcmp8+6OrOG6EYcmXtsSq6ZEIoBUG3Qc1TgkhIkmJzWzuFY1alyDik3b8TN4PAkQApJEksux7UoVr9aPIYj4nzAeL0VrZ7Ru1CTVjMkvQW+Lj0E8jfJjdtBSCic1qERzPH/Xe8ywQ1LWh+bQJMawQIz+JNn1LrddlE/ENn9hu8zSE Uxxj5ubc 6V6TDZGPBO0wf7cVQPcXk66Y78vDijlQDd8Csg0aE/YX62uCf8L86s4XNoWvi6P9/I6mW3UTiYx9BPXS1eE0OcaDdnJHvwrYRSnawlWg1I1kScMRxLKRjhN+G9WzEsculontz0k8K1IP/ZFZwSHgAnklrm1Fykgmm4uXF6zYlf7IogVG0GO7gOtOp9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 05:14:16PM GMT, Roman Gushchin wrote: > On Tue, Jul 16, 2024 at 03:53:25PM +0800, Oliver Sang wrote: > > hi, Roman, > > > > On Mon, Jul 15, 2024 at 10:18:39PM +0000, Roman Gushchin wrote: > > > On Mon, Jul 15, 2024 at 10:14:31PM +0800, Oliver Sang wrote: > > > > hi, Roman Gushchin, > > > > > > > > On Fri, Jul 12, 2024 at 07:03:31PM +0000, Roman Gushchin wrote: > > > > > On Fri, Jul 12, 2024 at 02:04:48PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > kernel test robot noticed a -29.4% regression of aim7.jobs-per-min on: > > > > > > > > > > > > > > > > > > commit: 98c9daf5ae6be008f78c07b744bcff7bcc6e98da ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node") > > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > > > > Hello, > > > > > > > > > > thank you for the report! > > > > > > > > > > I'd expect that the regression should be fixed by the commit > > > > > "mm: memcg: add cache line padding to mem_cgroup_per_node". > > > > > > > > > > Can you, please, confirm that it's not the case? > > > > > > > > > > Thank you! > > > > > > > > in our this aim7 test, we found the performance partially recovered by > > > > "mm: memcg: add cache line padding to mem_cgroup_per_node" but not fully > > > > > > Thank you for providing the detailed information! > > > > > > Can you, please, check if the following patch resolves the regression entirely? > > > > no. in our tests, the following patch has little impact. > > I directly apply it upon 6df13230b6 (if this is not the proper applyment, please > > let me know, thanks) > > Hm, interesting. And thank you for the confirmation, you did everything correct. > Because the only thing the original patch did was a removal of few fields from > the mem_cgroup_per_node struct, there are not many options left here. > Would you mind to try the following patch? > > Thank you and really appreciate your help! > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 7e2eb091049a..0e5bf25d324f 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -109,6 +109,7 @@ struct mem_cgroup_per_node { > > /* Fields which get updated often at the end. */ > struct lruvec lruvec; > + CACHELINE_PADDING(_pad2_); > unsigned long lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS]; > struct mem_cgroup_reclaim_iter iter; > }; > > I suspect we need padding in the struct mem_cgroup instead of in struct mem_cgroup_per_node. I am planning to run some experiments and will report back once I have some convincing numbers.