From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5E5D3DEA4 for ; Fri, 18 Oct 2024 18:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78B9B6B00A4; Fri, 18 Oct 2024 14:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73BBD6B00B0; Fri, 18 Oct 2024 14:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 564646B00B1; Fri, 18 Oct 2024 14:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 317916B00A4 for ; Fri, 18 Oct 2024 14:12:35 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A15214054B for ; Fri, 18 Oct 2024 18:12:27 +0000 (UTC) X-FDA: 82687518102.02.8F9224D Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 2A6C0180013 for ; Fri, 18 Oct 2024 18:12:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aUp1UgYJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ajV5nbJo; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729275117; a=rsa-sha256; cv=pass; b=7QogJuUq1C8gen/9a8BKCIneyMNpR9OHlHfIdwi6WIBRfyqnK5fs609DbGy0ACl1FjW3xc a7CnKduhKq7N027qJGz428pg9uGpq94KurDp5r4qorG4dXI2apclaKSYahvJhLlGoMCoZm Vaho87OPZLOhZBTq/JcItKJJsGes39Y= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aUp1UgYJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ajV5nbJo; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729275117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fyJU9/ICB0j+qdeNO1MgLTnXRBVZ2g6qOStbpTwm3II=; b=Dipf4ZkOS76CudON6S/sP/6SxFWu0/ElvO5YLekjLQ4yF1zoJ1xaucLtlUMqnZs2jo7ZHy evLJ2uPjB1almnCYcar5dI+SV7+XcDFB2NIPARO01TGIdCSgLWIdkXz0q/igyACTROBf6z k7p1qUnCWCpmao6Ki/PKgiJsbXv4K/Y= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49IEBi1H014134; Fri, 18 Oct 2024 18:12:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=fyJU9/ICB0j+qdeNO1 MgLTnXRBVZ2g6qOStbpTwm3II=; b=aUp1UgYJGqN8Ha77boq3b8wU1QMGcg5ETF IcsLQDBOHIzsuY8xqGEYj/xnkUwrcbtY3IqutaWPZGPAeh0+Y6z4hqeHZZBJA/nD NMfmwNEsh0r6Qi0aAbOLuv/8zcknH1g3X2o0ggg6DXjPgWb9Byk4ws61IODVZtb5 O2/Ge6vSAZNEccx0ViuSAuz3NkKJxqc2OJpjnvm2NQsZ9XvwQGBtGi5zLKTXppGz 0Vsqbvv+OGeEuRogwIoNIof1/Ap/7gu1T7yXASYLF5TiV6Nm2swYDdTwkJt9Txtj uglYpJN/WJRoYUxXfUf85cPKSqQZShymD0+A7+wQdJnAY00wyB/w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427g1as6wn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 18:12:28 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49IGcab4027065; Fri, 18 Oct 2024 18:12:14 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fjbwubu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 18:12:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ICIZo1XDkkF0uqFO69/8D2QVNQX8NH18qA1KPqlRGvHdmTP83l6KBguw1mg5D+BFzMKLsKWz3smUhGlniRwTw5XwFNthecvaFSy8HgCMRWqur/0SAQYbd3T9y47wiPZxaSluql34oxwvFxMo9cNQ0H1q0mLOphv0rDR0Fz+qby8pTAP6qCiR3rg6BF5O4wcfjTAYG17xUPc2aApyeIIU+Mnbb40Ss53mOVqHoV4HcVn2PeyQ1H7fbVZc9tG8R31FkjGF18qxGEfGwRME5Azp5j64aFaNb5Lww1yqNb94bTcYFcdrZw1OTabhbvvJOphF3tpfo7DktRPWm9ZZGaf/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyJU9/ICB0j+qdeNO1MgLTnXRBVZ2g6qOStbpTwm3II=; b=gWsJfPSYaP0ZVBx8g66gCSkb0Y42XDfq1kFO+wF93DIGpTXO/SnqO5HL8VwbDl+dfHKncqaxSahEAeMayC1Wo4aY0cXgLnjuzZk9/fObUYnNruH3pCcwfDye+ooaK0qf7AZqPUIj8p+Auc11l7lGXGQx32lpVH/5fW/7YQRkuhDB84zqbkTWb5F4+0ymqxo/sFkKfTGCiQvL4IDDefxRAJst9sLA7Svae32yyCQn5YgdBi8gM90yU3Iy7a6NKzo8QLSEVv8mTHKgDWSonH4NRWqOdaWbwDl60T3h1SeZu+dfxem9310cNav30KxO+O31OOii+itVa5UQEWDDKkyVrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fyJU9/ICB0j+qdeNO1MgLTnXRBVZ2g6qOStbpTwm3II=; b=ajV5nbJoN84ebimoQqxJfDz8MlJnWfmH08uSTflyP/YDaZLTiP9NTeAlC+b2UOO1Ko5eI6SpDogtXHaExA94v29MVUtVSiAZbCeC42tpBWA92RWXkfJnB/iGgfwcDgzF6xNwil7nfTaaH9eFnaWcTxgHdw4YBXuXUiTnrdMwvB4= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by LV3PR10MB7771.namprd10.prod.outlook.com (2603:10b6:408:1b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.16; Fri, 18 Oct 2024 18:12:11 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 18:12:10 +0000 Date: Fri, 18 Oct 2024 14:12:08 -0400 From: "Liam R. Howlett" To: Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v3 4/5] maple_tree: refine mas_store_root() on storing NULL Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241018023943.13860-1-richard.weiyang@gmail.com> <20241018023943.13860-5-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT3PR01CA0121.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:83::27) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|LV3PR10MB7771:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a9d845e-68a0-42d6-d469-08dcefa06293 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TS6AhNpi9+Xly/+l6XLvs88whwTcPAv3WL4vxx9DzOx3E//Gq9f8Oyky6H0T?= =?us-ascii?Q?6CNcjyrO5Pg3V/q6L5rsmUjdWKDJoLh0FBm+TrbevF3/67ga3uRgUthsu332?= =?us-ascii?Q?GraLlJks7XEeJ9mSB6/uo9OjXLhwG8+mGsevdob/LuhIlNMaFNlXzsSPRNQ6?= =?us-ascii?Q?xaZb/v+pGfT0SHQqMXkSc2dxh7bqcuwQDrLL7MFcrv4rd327q2YW/mB/WzZ8?= =?us-ascii?Q?VoEjIYiGjqrcaEgS2hREbPoem5vV2zVREBqAs74Ik6TOdTYjhHfqx3X8u0xj?= =?us-ascii?Q?yYjo/aMHyk1KvTP0hY86hWaNa6G/VZdARyALvBiyjhFLCGosbkVOgxO1pc+X?= =?us-ascii?Q?0HEXQX9rRM5+0HOsHUbSRGbN4VOChyvRw7PUyLd5rWFzuPehIJgME+1hnJ8H?= =?us-ascii?Q?6PZT26YsXLfSmtGSg7ls0OpDEbcMzNEUsQqYgHVWHA5OeAM3hNt9xNp2aZJY?= =?us-ascii?Q?X1N/W+Ddg+9IlxTFpolo+5qitDqgeWee4fZ55ZRVbRSDrr3W9Xl2gNzTInf1?= =?us-ascii?Q?RoVu1gpEeztTjoeBTsyul61H27bJpD2DHoJ+L723gACEqtLHvabbnvbMIas7?= =?us-ascii?Q?OLtgc/S9ec2OoEhF0iMMN4YePSnoCUIn2LmUF7Mg2JlrmcYaNpzzZiGgoced?= =?us-ascii?Q?uapiUu5gc8Hx7ghiJxBs3ZgtIJ68HEwd+3SDZr9l1ClhFVKUi1FCYP3oNBsn?= =?us-ascii?Q?n/whazQim8/Qrjy8Nj9Uu3AKYwJj4nHfUY+wUKNyauEazxovXjo76iCjq44p?= =?us-ascii?Q?vBBgt/GL320m7Oovz77NHd9LBpx9Hgm83DYe1Ae6ArfWkkmf2ED+pbu8GbVW?= =?us-ascii?Q?mgccrz3NPg1/J1cZDJB+SBB1r4TeGITYZiUYXM3vaxXXInHW3rywgS9dyVJh?= =?us-ascii?Q?y4Ayu1sXFuVM+WM1WSVHRGQKCCa3kBe8MDyBQFReTTdXUjXDiVD/0jTwGq60?= =?us-ascii?Q?rQoufzV5G/54i0GJ5YmKLDXiyFI0NbJM7swJWW4zGbLhBtkfL6okpRFyTYZS?= =?us-ascii?Q?AeyWWY43F6r5GN88J+hxwsjL0WrLYTMudaHuuXfkzvKYLN7UsBiiiptWt5mI?= =?us-ascii?Q?d5ClEVm0KNC1zXNm690JBJQUJ/lTa1wv3iJqA11iWzHNc2zR4VKi8q3gRz42?= =?us-ascii?Q?ypZvMj1fY5LkDDil2jwMLkQzSsV5sFI3IVrAUBpfUtZ3nfKDPjjfqGB4Iin5?= =?us-ascii?Q?jxB8IGddPus8ZByLffhyr1fyKpB+14I8tFUcz18ywufEVkxRvqBsaWpWaQhX?= =?us-ascii?Q?EIXwbV5AtLliEOe9L2RsXhE+HGZBsDn3L1r0Tlg1PazVm+rCQHZqocWZK4Q8?= =?us-ascii?Q?hiY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VxzpqqboOQfOkGSGQ2L/z4fbvx495DCvCfxvqtuGYhNC0dQuraRMqASUKPuf?= =?us-ascii?Q?3ETqpRk4SBrzVPTwvkllGfG0TYtMOJ0v1avEsemOwUme7OY814liHr3tVLG3?= =?us-ascii?Q?meG5v63tKgq35xGBRvP4NJh4Ucm2Zl2dKth3S0hcoFQXln+2dMLSOotWHewt?= =?us-ascii?Q?QTB00HHMXQxJn+afiBxnNmwFF4jmAYYU483f7j7p2mfPW+EMaRhE0JA3e8ef?= =?us-ascii?Q?wNCrowEfJvRbPwF7LOCR1fcFRcojeDZwRpb05b8u7lRJFgaLRDg1sI1PmB0S?= =?us-ascii?Q?gVIKeS6JyNbOLk2KiqUxmttV8nJ3Jy+aIWc0+43CM6nPXGBbdrGHPWM4+2pH?= =?us-ascii?Q?KXywcICshsOT87YUzPtaPuYpWBCRcYCcwkuSjtRTZFFV9BrkgD3F/0YEKtHU?= =?us-ascii?Q?InUGHKoAQJ7xK6qSoG9fPleLtZlmI689y6rcIiXyr3wXjDDDF0klKsRQo/jr?= =?us-ascii?Q?ixuEg+T/LGICfOf85Ll/rLAl5zCpuls6J+ZbMQiGBOoF1ZD7VYUWWj5vwaSo?= =?us-ascii?Q?TUp0CT4zbDSS+4gFdXzI40SJKQiYSghIWCf9pHgwEO4XCF35Y+YAMaB3/dPH?= =?us-ascii?Q?Zdm2XZzBOt0xux6jj+AKCRu0VBvrIlp3xSyaTQA2mFrhzrpn4GOuTsRSpaGs?= =?us-ascii?Q?ghuVH9UZX3lNRgbolRTERM2VoeNEBLp5MtNgWp4keiXbizhSuoIzvqaWcNGJ?= =?us-ascii?Q?IjqTveZ4nbDXhi7xgx0/SdYDaeRpWwHiGeE+M1/ZmFvt7VLIMOHc3VRzPksS?= =?us-ascii?Q?GaqG5QlbRh8UhFDcELb5+iBz8JS9qsblTIFTGBt3GswtjPfqE8BSIpPhrrZb?= =?us-ascii?Q?RE83qR88Ggr8MF98zb7Z3MNecf7Wq+3xoQaop7BPIH2YAerPKJz4WsHy0hgF?= =?us-ascii?Q?DcOqqm/uEAXjxtK60LkzBvuEyl5Jd4P1IjSN0PyJSjQrJI7lL/dQGP4fIIsX?= =?us-ascii?Q?M7VrDqsc3kyqnnU3OnHdysAJxrFGFqMZCwVyZMdIBKPmFORiGyXGR81NzyBf?= =?us-ascii?Q?1WxJOXM5mzWNAd/2WIgol8qNP1GOCyveKifq9xosAROqTklBJsGuUzs2iytg?= =?us-ascii?Q?bAP4qLOXi8wp/Yl/iFTafor24VQML5rHDs3kz5eN4oyipcdabXiQ+ft/TGs7?= =?us-ascii?Q?p2p1IHHHbfBR6SqTIY3xmsv6nlD/Sn4Mo1A5noBHld9PnqKGJYplprGs02kr?= =?us-ascii?Q?vVReXkyzFc9rUqmPEE5fu4nwORfs21/nrrcT1VzIwJtev508a88s2ygWtex6?= =?us-ascii?Q?Gtsws81UhOpXb2HX0ZyAaLS7SNBUjADErQ4ARhDN4o6wu8ltbmzt3vKFtL/m?= =?us-ascii?Q?iVqEOpNeaU5AkL6Xl4NPYB3LUDJofHrPPgWWLmd7BXY/p122LZHyaZfa01BJ?= =?us-ascii?Q?vTRNOM9A+p7KQawRS7c0r0C3RhStVkj3F1DGVKv7jTROKJdrAzzG1Zza+lrr?= =?us-ascii?Q?9OKZ8M8T3HZOJYMojXRcEExDVbnVFsOEhxDdm9foKCkFG89uSkWgqEUCMDfj?= =?us-ascii?Q?mkspHsvM22riyZQnBoMkraXY1ZCWaN1fq+msO/vHN3VkSBaKxq76MVBRywsu?= =?us-ascii?Q?yfhK6LwqpoqIFNu9tEE0gUA6FcfUwimSJLgZo6YB6muuanCx2mY67b9rZmI1?= =?us-ascii?Q?Tw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0qH5GDwdupY1C8j2EZw72vzlu5wWwqGmhSLA/5AlVu0/2Y4gkwtMn7mKW/e/4V21tM+kOrIq2nclJJEkO+QdV/iqESG+LQ/nFfbvGqveoUr5ndi3mrhk0hziM1LKFnLzUIaDlz69onhQiRA+m211DAYoG9rThUFjM3+CckbA/VyeKsrjd3wTi9bxIIi5b2w+/S6KYE5ev0Wut/nLl/fp4eSoaLHC3KDX7dle62/1lKE3hhj9TSaRvboVbtlIUuDD75RMdM6N+v9Zxs3tX0WjNAAUzZaMOB71zLA4lviocthh18cMw3hGkjC3GDMuMQDd1nGjMbXRTM/FSzBBiGzXvU+Am38FMooveWDTHshS7bt3WKjg4g32pQG4z1kZvaA5Gat67omdTftcKgE4r2lRC4QvxWuUNRS4z+M94/jEwclA0cAOLhGbSniu86gUgfLfaQ2rVIdj/HnJUW/h/Z1bOw83gB6ddxPkEZZNoeOHPJE/qUP79mjhTCD6yLmgmVtZC+8WoAgyB1Y8ATlLBQsq3unBB9t0u+e5G6tQ1pVxtAt8giWfzL+ltEKWq73mj8nJYCRHlv+UesJnrB+43EppXy+k7Qzrj4Ix7RSPBqJhqag= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9d845e-68a0-42d6-d469-08dcefa06293 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 18:12:10.8754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vH4RpkFRjK8KS/fDZx6KoQi/jRZ3O2o2sUFqLGvkV6TanLxXPuvUFzWmWR7syM5qfD8vhZCviweQ3RKRvpaYQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7771 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-18_13,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410180115 X-Proofpoint-GUID: 5r5ruy6q0SIm9UTUyiwWHAdyT0um-EYC X-Proofpoint-ORIG-GUID: 5r5ruy6q0SIm9UTUyiwWHAdyT0um-EYC X-Rspam-User: X-Stat-Signature: 854ztjmcp9fmw34wruuxyrmr7ip1mfop X-Rspamd-Queue-Id: 2A6C0180013 X-Rspamd-Server: rspam02 X-HE-Tag: 1729275142-335479 X-HE-Meta: U2FsdGVkX185Nmy37l++NMn/3wOgBt11srlwFhIjkPGNhzpQZPgaEBbaeu4qnI9JdgArZnSW/NSWvO056wXdRv9KwZIWUTYh2KiRABVWSScNnZkL/cxmgDNXvBCsCzyF4Imx6sfd8NUxxz5R0OIyAt1R/V0J3xdom+3iiStzLAt+QB/kzX0aUtesyyKFoRiMdj2yI7S7L5DSNHSTTN2Mjt+IOz3DB+ztQy4VZPgRCGc8LYmiiueuWaCOLRDxSl7LNRLuljP1vrcCCcGZmwja8M9b8ffKKeAbVnhEyoAkcUtdOFT++sBoULzFe+wj7yfopHlM7d/b5yX1rhERO2+u6wDmgZxykWrxxyi2JJqkCia1Vh+b0qdgO+BDtSe+ZDaxFtU2grPGP9yUapjCHaufwI8r2MhJM4J8A7NY/AB03rN68YnYf+2FpRu9NOwZBM11DsvjVqCG3vuQjmO+uSTNXYTZAsLeTUwGcQFtmlR3BK5Jz4qgZP7b7P33JYYwxVYVo2FWodFaLy/D62Gz0sRP1bWL+67Y7SwdJryLLp3bouA5RlNUO6fQYnpQwWF9Y6yCr+SVH8WZkxQ1hoSICAu8NS/0UUtAegJyZjd+Y9MWNaQhQhQUNHv1HORe9CesqstPgU6gQqGcomXgGdR0PnCN1n/KEAGtMiVupd3e7rsGMwEHRT2dAzeqULdv7aeQyy1MfRuMbjqcFm+1BKBX9Vbaw35wGmjl9ZvK0DtFNBcYvBgHlckG1N2LjsdVea/lJxzry4tlOPRpzOPOYuKfDPNvGeucf6AtkgFa5KFneSyiB7djVxLrCKedcliSBI7Q7UEiI/+y4zp150vkFr3GM0s0nM3ap1Ue419ZNVrMpaWtdi2BhfRvxXukAxvQeRpG2yzvzWFAJMuVwO6T91qUKKu1LPPflHxariwWJNBCmqllpuId+U3vnviL3fDV5uLjbtdZ6roQyHEayVea0UKz7Vr Pr5Nh8mi WObsObW0AVEuQXZ7nyS2GH0piIJ0OC1vb5Js+IqNKJrn6RxBVaAGYN0lBWoqNI19TYQmybyCXIXe8jG8kbx8K9aIeLXd5xjMpTRUL5Nb3axDhbV4Bzoxzl7cetA/9VSJc4suAGVEH1Gt5Q6B3sIWBUDoKm42C1PzZ8lprSfCY6UqmUNURk+GV3AgeFcgqGp34XDvqtPJ94jRA2jR6b/x4OZ+ROHQ5Da+5ywi8JpHiv6vBKfBOOa/gAJSfKWIvWd5O3P519wkeZlHRhwaQ/6isPu88vWbzEVlHbehunhHIvlxAZGsNyTQxZeE5exzh+ZIg3gmu3QqCik1OVcbXgbSafiqGaQTMQKNTDibErwGgH3Ejijo/Mwz+Pi0TIb+gXENrTqNaCbDUislwlfTi4+S0LpCgArOgeWP4vZBw2ym/oZKgOlTPlId4jIVqwbmWQmdvdTBomJQQUJb+Q+K4t10AmRMr5pgrGk71d++Y9nfsWc++uNm6cX9gb1N9uykYXsCwgEoBw39+PzCQaMIH+VW0PD/P4365eK9+plg8ME2KE9XyTJz2UI4tqbHuaRr4VDYialkriXCOb2/ziUiNLF3S5Fpmqm82vignSFfsZLyJdSnNouE4dj/BJmNgL3sQtxRdpjWFFafV9D9x8O3sZSFmg5yFDow4BnTA+uZg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Liam R. Howlett [241018 14:00]: > * Liam R. Howlett [241018 13:57]: > > * Wei Yang [241017 22:40]: > > > Currently, when storing NULL on mas_store_root(), the behavior could be > > > improved. > > > > > > For example possible cases are: > > > > > > * store NULL at any range result a new node > > > * store NULL at range [m, n] where m > 0 to a single entry tree result > > > a new node with range [m, n] set to NULL > > > * store NULL at range [m, n] where m > 0 to an empty tree result > > > consecutive NULL slot > > > > > > This patch tries to improve in: > > > > > > * memory efficient by setting to empty tree instead of using a node > > > > > * remove the possibility of consecutive NULL slot which will prohibit > > > extended null in later operation > > > > I don't understand this. Do we actually store consecutive NULLs now? > > > > This is a very odd change log for fixing an optimisation. Maybe start > > by explaining how we end up with a node with a single value now, then > > state how this code changes that? > > > > > > > > Signed-off-by: Wei Yang > > > CC: Liam R. Howlett > > > CC: Sidhartha Kumar > > > CC: Lorenzo Stoakes > > > > > > --- > > > v3: move change into mas_store_root() > > > --- > > > lib/maple_tree.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > > index db8b89487c98..03fbee9880eb 100644 > > > --- a/lib/maple_tree.c > > > +++ b/lib/maple_tree.c > > > @@ -3439,7 +3439,11 @@ static inline void mas_root_expand(struct ma_state *mas, void *entry) > > > > > > static inline void mas_store_root(struct ma_state *mas, void *entry) > > > { > > > - if (likely((mas->last != 0) || (mas->index != 0))) > > > + if (!entry) { > > > + void *contents = mas_root_locked(mas); > > > + > > > + if (!mas->index && contents) > > > + rcu_assign_pointer(mas->tree->ma_root, NULL); > > > > You are changing what used to handle any range that wasn't 0 to handle > > storing NULL. > > > > This seems really broken. I understand now. You don't need to get the contents though if (!mas->index && mas_is_ptr(mas)) will work But it's probably faster to just assign the NULL and not check anything. > > > > > + } else if (likely((mas->last != 0) || (mas->index != 0))) > > > > Isn't this exactly what you have above in the if statement? > > Oh, I see. It's the same as the line you deleted above. > > > > > > mas_root_expand(mas, entry); > > > else if (((unsigned long) (entry) & 3) == 2) > > > mas_root_expand(mas, entry); > > > -- > > > 2.34.1 > > >