From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC33FC3DA4A for ; Mon, 19 Aug 2024 15:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E44C6B007B; Mon, 19 Aug 2024 11:38:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 694076B0082; Mon, 19 Aug 2024 11:38:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5834F6B0085; Mon, 19 Aug 2024 11:38:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A69D6B007B for ; Mon, 19 Aug 2024 11:38:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B2368A9231 for ; Mon, 19 Aug 2024 15:38:01 +0000 (UTC) X-FDA: 82469400762.11.94EB28C Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf09.hostedemail.com (Postfix) with ESMTP id 23463140029 for ; Mon, 19 Aug 2024 15:37:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D0ZGlPSA; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724081800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EDoNKpYc2BhDlpHR6whjlONzdtHocWfp4rWQ/S2NQEg=; b=AeoZqt0G4/ZHfskoRZhUgxv2fBMjvGDWdRUHqdG/v6vSHgYF7F0BQJk+bXnz1C6lU83bF1 lp7tw53elBUzMjrswOsoyEM4HVlst3GnUIL58gFidT/tUANDhgHhgFgmXk5NR5THEDvcjy BXsB6tuQpfUH2AJIKQuJJwKCXKIsRqM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724081800; a=rsa-sha256; cv=none; b=UHJMmFPwh8PQ4WEU/lz98dhC5rLtvK+E2v/dRHw7u/aNi8wLyR2l1ZQj/1wfQ6/EcaWiFl uExCA9d3uJJv94hPm7s7TKSuukCS90k7LJUHzCiQ0oPzDfLKTNEVI9HsRvekigmsnCAro3 IPXHkCXy6PJSP4PvbRmImrdL11OiTAI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=D0ZGlPSA; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 19 Aug 2024 08:37:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724081875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EDoNKpYc2BhDlpHR6whjlONzdtHocWfp4rWQ/S2NQEg=; b=D0ZGlPSAieuHmaPEQGxbUufJC7QiTcywkSCjBQsQKkRshZh9x6q2butEwK+2sfXv6SECzU mW+catBrEdfUm78Ts/dRH390SkdZEXvxSSZTFSKg03obfxXizFXFF8KOSlv4Hm2BU+wM89 t+GbBR48gNA9XtDI8lDEOvhd1IYAd6k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Muchun Song Cc: muchun.song@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+ef4ecf7b6bdc4157bfa4@syzkaller.appspotmail.com Subject: Re: [PATCH] mm: kmem: fix split_page_memcg() Message-ID: References: <20240819080415.44964-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819080415.44964-1-songmuchun@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: cdx4sgked5jjtdt4pi5habgmbd1mhpze X-Rspamd-Queue-Id: 23463140029 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724081877-263079 X-HE-Meta: U2FsdGVkX19JjhZRNlI3NhnvhGgv+USZI8ONdAym3xyPKrOiM4jqMDwUEGp3EZ2KP0EDNbzWuN9x6SXqYngfCiHYmRl/yik6qYHu2MAEeehz2inC0rBF5Edx36X1mwKZZkwS0Zv/JhPJmEkwCh+uYs9UoKh3CWFjEFG6LFNzgXWUZRp/vg2m0hIwZdZIU+mxonmBuOngbPZWDr2d8p9Wx/fEnGZ63IpmRt4AJZdWvQ2XsFvDe2n04Wv+Hc2tkKIop4cQmOicBCqra2MfIIEoIBCcXr9pRaxo6reypaC9uOmk384ze6vIyuJwAHfXyibgZGU+oJ3molWW5Oo/0EywEdxuUYk4l8Y1RZJrASoWcBb8EyPjgkfc5vmKDa9MFJdnI7tn5ct8ZLHLHAk2EIjJnCz7QK3PyZ3ZlH1MyKXrq2emyq06qvssfmm4smX7bUAKc/qVE1BM1xlCg/hafvIbCe4j9JtXxH4QOBJwK2bfSvQVE91MvJ9eGM0g5o1kBPl5KLOqMhciq3+gCWO0tH2x87MB7lBYJYRwG8CAGJjyjH5H/LDoeMNELGrBEAiyTXsHWe5yBIbeXgrVJj32XQm10S6otfsctQPoHDUNz+qPdjr8qXKrzyRT6B+4eBD+XdKefKxzxe2PmC9DftQ7fCF1MNIWKmw3oMLTGAI2qGgpRzafcz9gAxU2fUevNKXhXxkIgYaZvOVzp99TTZsEfYXqEbfEK68F/bKQrqjMsVqWIueV2G70P5dL8qi4eDTl/bt8yQeRMCC2FTYeLOhBX2+nlhSrQVej8R/P+gEhK9C97nRKyG3XyhkKHkOD7cEhP2jm8DJ6p053KlTtV0izHP+3qWTcK+Rcqk7AJvS3t9kxNNKGevxLTotnkPUIa4ij/IjXr7+LKBnjvY3nSFFTeSFjZOFKxdBLu28Ue0Z2zDCm4RlqJEDiI01IUZMVvlS5RwlAXzJpOTKMH37+UaFqIBl pzKle/Zt x5kjGK/xjrFA/G49wQuwqff+j6h7Bf1Hvpx7cz/OkEtgAMFH8yF8NtSdnqC6b6HqFOo8yICJhQ4TrnyTEG9+3c+OJ3KiholPv5K751WuP8S+GMzY2/5gE8wP/pdy4klzB0GA+u+fQNFMLoAQ5MXbNvX4nkYfZaZoUdoNC0JO/w5r8QWhz3Kup3iaXqRQnkRtrlDIFK9bFGwYIFAfPj1C/qetzIzP5aMrJfhZzTizCUJ3QasmztT3D0aFMaJun2gop94yDiMHgOHsN6Vc3LthAz5G35dtwe9SQTJQKb5EC6v8iHzfwDSS4yPvSSi3o2itvGuT4hgmwyb99+NJ1rgfeK62KsA6leskxy/BNUoKoejIaI/hPsieoTl5RqZ/dd6UcO3y9e2Yh4pU3N5vfiK5KASx7ro/DZgK/pSLi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 04:04:15PM GMT, Muchun Song wrote: > split_page_memcg() does not care about the returned memcg for kmem > pages, so folio_memcg_charged() should be used, otherwise obj_cgroup_memcg > will complain about this. Basically avoid calling folio_memcg() for folio_memcg_kmem(folio), correct? > > Reported-by: syzbot+ef4ecf7b6bdc4157bfa4@syzkaller.appspotmail.com > Signed-off-by: Muchun Song Acked-by: Shakeel Butt