From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38B6C48260 for ; Tue, 13 Feb 2024 04:34:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD83F6B006E; Mon, 12 Feb 2024 23:34:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B87B76B0071; Mon, 12 Feb 2024 23:34:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4FD06B0072; Mon, 12 Feb 2024 23:34:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9200B6B006E for ; Mon, 12 Feb 2024 23:34:03 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0AEFD80186 for ; Tue, 13 Feb 2024 04:34:03 +0000 (UTC) X-FDA: 81785513166.14.0BBB6E8 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf17.hostedemail.com (Postfix) with ESMTP id 389214000B for ; Tue, 13 Feb 2024 04:34:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QwlyriZv; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707798841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DvjY8M+9GsBv1uGSt+JuoCXswHcqrEcE4jibODW0tFs=; b=GuNr4B9G0obUWR4JrJp337JbYqg474Fj+cx1GaQr8LfFCwaiiUUU/OdJ5WJ8wNY71L5Je7 mibm9mrLemxHGfSy4DrGmsDWCwPAGOdGymRmSgAuepLHfmAGq0WG4/9Mxgz4NOXxODUYWO bRWWykblBaSU9mha65UDSllFS/MdzX0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707798841; a=rsa-sha256; cv=none; b=WU9qA03bBNSZqKkPyKyny39AhpsaulVOANA2qBpEDxPUafXO85ohZ5p6O8VxDLcPVoBOlE 6/FaU36sdPB7sJFPGr6qm7tKG0ukUiDTX9UNxVqGNf3727pNi2tW2S7zKPtBb3+1uPR/hi FSW9R+J0EJoLaI0xh0Czd+iP+d/YKRw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QwlyriZv; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 12 Feb 2024 23:33:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707798838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DvjY8M+9GsBv1uGSt+JuoCXswHcqrEcE4jibODW0tFs=; b=QwlyriZvvUgEDsqDWM3/Goy6W6fpTusJKVxYVQG5crPdH4ZbzhmUYA2feK+/zjZ86yJTrY XATKCb+pnbT/aSunErorIF2g2P2QqZtIIfXF6eJUlBLMn/zeLgLoihNGacEQ0wos+JcJ4x o2fTwQd7WKn6r0nEY1D0LzT7vDzxvyg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Steven Rostedt Cc: Kees Cook , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 31/35] lib: add memory allocations report in show_mem() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-32-surenb@google.com> <202402121606.687E798B@keescook> <20240212192242.44493392@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212192242.44493392@gandalf.local.home> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: d8kzasowcnzgctmomurnw8wd6153o9n9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 389214000B X-Rspam-User: X-HE-Tag: 1707798840-957190 X-HE-Meta: U2FsdGVkX18B4rQy70F8jjsrcTj0Y0CVN90iXNvaCU3PxWBhNEKIyvCNypqWJ6etWwYGrb20jla03QmG3LZpwE8cn4dl5YFfuGfApDxgUUWjdSJF0y0vxGsje807V5AfnoFyv2iVwNRUPdR9eUyiOA996CIBK73smxi1IlnxJWFF3o51TlUf7pPHsjGRacuEEei0Qc4g0C4+fbZsqj42NLur3iBfHSnL5War/rGfi9+ll9zqa04WsL1BCctT29BHgbufqGqa3++/OMtENMGLvzw6thAftxIw5tJM8w5RSu/4dtL5IkRk0CHJXkjG3Y9DhMFLan25VabpQJRK2WJMifnNqUQi9oKQFFyVUB4779Nmu/L429bcOT1I5XOf98XLeUysj88GXQJdabg12hIekQ17lsIe2Umn8lknlkHpin62xOB2czKsXrUWug+94+lQGVgrxX3mPO4nT+LJcv/LvjktkptbE2gk/kRiXCodwQ3skmaim2srSA0/jNCAqBPj77wPpzzAjKqbeTghNcUetdTvXqZ3ep2a6N3N9H1jbEBwQU+oOcKgPTwaan+HoHggTjnSD4FBtGMj11T4wFEBYmwkfDnvcnF4njSP0oKbxKmNWrKikiUKpZCXPzypW2ClpLU/RCQIyIw+QRQGZam0WU3ME+dRxTzGHkdfp9NY0rmR1880+/R+/IdUV0ZEPqZTuSpExXImuCoofsz0V/gm4EJ/Oq8LO+y75DYRu1VnKvlg9ZdKhymwyuMEuu41iA7o5lebFmFdzEwOJYZNywIGyg2zFiPUPKQtEWZwXGz0Tl92bI2peWCncB2kfpU1TtmCmoBW7J9qcLH2DqoeCSfo3xe4/lzTQSGESJGztQbKACeF2ir45vN+FYp5SL62gtovSAe/MuSi+NP5YZ40HXnFGpL3+3YeVBnO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 07:22:42PM -0500, Steven Rostedt wrote: > On Mon, 12 Feb 2024 16:10:02 -0800 > Kees Cook wrote: > > > > #endif > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > > + { > > > + struct seq_buf s; > > > + char *buf = kmalloc(4096, GFP_ATOMIC); > > > > Why 4096? Maybe use PAGE_SIZE instead? > > Will it make a difference for architectures that don't have 4096 PAGE_SIZE? > Like PowerPC which has PAGE_SIZE of anywhere between 4K to 256K! it's just a string buffer