From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1D6E7718C for ; Thu, 19 Dec 2024 00:10:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67EAE6B0082; Wed, 18 Dec 2024 19:10:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 606D76B0083; Wed, 18 Dec 2024 19:10:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CF266B0085; Wed, 18 Dec 2024 19:10:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2BFF06B0082 for ; Wed, 18 Dec 2024 19:10:36 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD1D21A1277 for ; Thu, 19 Dec 2024 00:10:35 +0000 (UTC) X-FDA: 82909775760.08.C79E24E Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 9A35F160008 for ; Thu, 19 Dec 2024 00:10:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rr4UKi7K; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734567019; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9H/G23RzoGglbNUDM/QKZSt+D6Rd2u+7uEkML2i7V6Q=; b=XRGeKIvnOeBzs6QfQeMzXOICXvuV05yD2wcft30H0O+L5A2qnQWZjASBR/5UnYhqmU1/pT Ee3QsLrZPFtJ0ry2jT/bOKxANz4r9gKFUUUop56NLV5Rwcqefe7y6Mw12Mp2ILb/UCVNsz oxD6iNmgfpQaktK6rh79/sW0uVmgqnA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734567019; a=rsa-sha256; cv=none; b=kMS3DuqjYUfIRch9lfUE9hsxK07vInV28R+0ICwvGgxo0toIsjHFtrkHVtJ3SKVRrES562 T+2RVMPbn1asfFbmnuPy0fQzPuDPRN2ZwsL+PdxeEoeBlnEgAxtkR0oA6qvwrKG3FYBxz7 Naz+UNubv40Ef4EDVRpuSZQ6m/SlvwA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rr4UKi7K; spf=pass (imf08.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 18 Dec 2024 16:10:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734567032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9H/G23RzoGglbNUDM/QKZSt+D6Rd2u+7uEkML2i7V6Q=; b=rr4UKi7KpeV2ikBtwseWYwSpKUDk8dNPMuWCNGplSxj3NkgXPhXaKGY0NUU5KVHJo4zZHw cWFFQJxHWzN0PiUO8RUrzjbReHO+7dYJNYRdkoMayLKrkf9+JeGWDVdTRYDxTgFBM5AhJ9 kQspXGlSSJuXOkFkQMH7PWaDtzu6q2w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: alexei.starovoitov@gmail.com Cc: bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, mhocko@suse.com, willy@infradead.org, tglx@linutronix.de, jannh@google.com, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next v3 1/6] mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation Message-ID: References: <20241218030720.1602449-1-alexei.starovoitov@gmail.com> <20241218030720.1602449-2-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218030720.1602449-2-alexei.starovoitov@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9A35F160008 X-Stat-Signature: yw63hguiy86k3pshqnbsh6ifsau5g95t X-Rspam-User: X-HE-Tag: 1734567012-469261 X-HE-Meta: U2FsdGVkX19SnB1ngdhot/lQHRA5oZiABtArUYz0eSPhL+ulyE4NcweASximxY242Y/prNoE4UwDRwfFLdv8y2Q/avWAnfcEOnOnVwBvvgTyzlgnxsDhJTNlhxmF4JYWNJ2ewoJ6h2/L/iaPTGYuC+paJuv2xd+G1Gl2hX2exivFofO+xBp0wLcHLuocpDA/C1uzqRk53ckKsUFta8BTJeEUbKelUlYbpxwVer20nkvlpu7H5H/1Tbk2W/gYUQBVi4tQINISjdTg+jTouvruAk9Bgx/QvMAM8hY/SA0nuMKXtxacWnxrGb8aD3QctpFJQakCBjDdtzm0NLeAE4cZi3+VyEHmsrDjRjtaHyvPCMW6ArRqGZeqXGBTSVfQ6MCsRzpbiFGyHusZtdxIbfsWxMYliZxok2r5n98JVONZTcTPRK3my9+dSZtgbcFUqDvtrVv9am09n0HAGKHiZ4Tmykf/s9UcMM3RAxAWhWm9Q9R4ldA4UbHmoKNOTFusUJW84jXr0bx4flmF7OStOsleJWRT8ZZaACPktYlPR2mngSQnf2wzhxAwSiBAmroacwSVsSEj05/BmZ4NgoXSnRmnmNJnij9WVaWIuq7L8IUvKV5kdNoqJ3GENjpVzLkyyt3FZlssKnyTRHN8aAo75Ti6Vqnj5+ckNvI0CfhsnRsNihtBkaNBSSrNUOey7/VcTFmawxHGuZpnwBKXEJSqsinkDiiDjWwwwig6j5VGu+h/2oeXcfhnTLcBAxsn7uASe76sXgkL9c4qiH0YEcC/pHthqHNlkGGfo9sk6zuBtaqvTjZqtyftmCQtC0BxRDa1puQls7nSRDKBG5btMXJaj+xrsxzyurQojEMvvKDmYKg7sXqePZgdiBFhNFG5B1kCJmP2OVd+Zj8fcrEgICUJUduoDl5gjC24xfDvOVpvr2GFUBDAAqz5oN1/E2JUfW0Ms0lK817k2xCF151ybh1lCrJ rqiBuT5z 9ZrZIwwpO0XgOxhNDLjjJudMwKBjWmAn3I02x/OToEp4eIZhsyN3R5ijlX+3T16C31ug3w/VPjWliezXY2rXPoV27ljOwxY08If14uC/g1Px6jApur2Vo6P/v1PXc9e+Z7F2FFvMDw4D5Zy/lmbF7Y7lgulG+Uzn4Xje4bpDusOLyzrHsBzvNZAY919O/2KUXHaoQL9ZLazRAp5qc9Cs1Ql/T9AduRxiO4l7p8dSUuggvrCjv1Pux37gsHW8pp+uhL0s6H+UpRJ6eAC5zpPRnLHQYJzri98xFfd+THNXXSXN5YKQzDjaD7hroxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 07:07:14PM -0800, alexei.starovoitov@gmail.com wrote: > From: Alexei Starovoitov > [...] > + > +struct page *try_alloc_pages_noprof(int nid, unsigned int order) > +{ > + gfp_t alloc_gfp = __GFP_NOWARN | __GFP_ZERO | > + __GFP_NOMEMALLOC | __GFP_TRYLOCK; I think the above needs a comment to be more clear. Basically why zero, nomemalloc and no warn? Otherwise this looks good. I don't have a strong opinion on __GFP_TRYLOCK and maybe just ALLOC_TRYLOCK would be good enough.