From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chris Mason <clm@meta.com>
Subject: Re: [PATCH 2/2] zram: fixup read_block_state()
Date: Fri, 16 Jan 2026 07:54:25 +0900 [thread overview]
Message-ID: <wstf2ujpdkz5evedgqr2awze7wdwcmcluxntkqk2eifp5axjpu@lawhwffyeg72> (raw)
In-Reply-To: <20260115140743.f7ada77bc912595a580eaf7c@linux-foundation.org>
On (26/01/15 14:07), Andrew Morton wrote:
> On Thu, 15 Jan 2026 12:30:06 +0900 Sergey Senozhatsky <senozhatsky@chromium.org> wrote:
>
> > ac_time is now in seconds, do not use ktime_to_timespec64()
>
> Please help me out here - which patch introduced the issue which Chris
> found?
This one:
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-u32-for-entry-ac_time-tracking.patch
> > Reported-by: Chris Mason <clm@meta.com>
>
> The Closes: link would be helpful.
I thought that for fixup patches that are still in your tree we
don't need Closes: tags. If you prefer to have them, it should
be this email:
http://lore.kernel.org/linux-kernel/20260114124522.1326519-1-clm@meta.com
[..]
> > - ts = ktime_to_timespec64(zram->table[index].attr.ac_time);
> > copied = snprintf(kbuf + written, count,
> > - "%12zd %12lld.%06lu %c%c%c%c%c%c\n",
> > - index, (s64)ts.tv_sec,
> > - ts.tv_nsec / NSEC_PER_USEC,
> > + "%12zd %12u.%06lu %c%c%c%c%c%c\n",
> > + index, zram->table[index].attr.ac_time, 0,
>
> local `ts' is now unused?
Oh, yes. Somehow my compiler didn't notice that.
next prev parent reply other threads:[~2026-01-15 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251216022727.578BFC4CEF5@smtp.kernel.org>
2026-01-15 3:30 ` Sergey Senozhatsky
2026-01-15 22:07 ` Andrew Morton
2026-01-15 22:54 ` Sergey Senozhatsky [this message]
2026-01-15 23:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wstf2ujpdkz5evedgqr2awze7wdwcmcluxntkqk2eifp5axjpu@lawhwffyeg72 \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=clm@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox