From: Kiryl Shutsemau <kirill@shutemov.name>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Rik van Riel <riel@surriel.com>,
Harry Yoo <harry.yoo@oracle.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/5] mm/page_vma_mapped: Track if the page is mapped across page table boundary
Date: Mon, 22 Sep 2025 17:13:26 +0100 [thread overview]
Message-ID: <wnenjcqvr2lzqaqnxyc6tbtd7smv2hepajtjxl72kundsfaisk@k2mlxpzuzhbv> (raw)
In-Reply-To: <7qkpt4ia3qryjp2xo2ywy7qydav6nijghasr7biwctd5ah7dat@t3epq5dzt2sd>
On Fri, Sep 19, 2025 at 01:25:36PM -0700, Shakeel Butt wrote:
> On Fri, Sep 19, 2025 at 01:40:32PM +0100, Kiryl Shutsemau wrote:
> > From: Kiryl Shutsemau <kas@kernel.org>
> >
> > Add a PVMW_PGTABLE_CROSSSED flag that page_vma_mapped_walk() will set if
> > the page is mapped across page table boundary. Unlike other PVMW_*
> > flags, this one is result of page_vma_mapped_walk() and not set by the
> > caller.
> >
> > folio_referenced_one() will use it detect if it safe to mlock the folio.
> >
> > Signed-off-by: Kiryl Shutsemau <kas@kernel.org>
>
> Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
>
> > ---
> > include/linux/rmap.h | 5 +++++
> > mm/page_vma_mapped.c | 1 +
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> > index 6cd020eea37a..04797cea3205 100644
> > --- a/include/linux/rmap.h
> > +++ b/include/linux/rmap.h
> > @@ -928,6 +928,11 @@ struct page *make_device_exclusive(struct mm_struct *mm, unsigned long addr,
> > /* Look for migration entries rather than present PTEs */
> > #define PVMW_MIGRATION (1 << 1)
> >
> > +/* Result flags */
> > +
> > +/* The page is mapped across page boundary */
>
> I think you meant "page table boundary" in above comment.
Right. Will fix in the v3.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2025-09-22 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 12:40 [PATCHv2 0/5] mm: Improve mlock tracking for large folios Kiryl Shutsemau
2025-09-19 12:40 ` [PATCHv2 1/5] mm/page_vma_mapped: Track if the page is mapped across page table boundary Kiryl Shutsemau
2025-09-19 20:25 ` Shakeel Butt
2025-09-22 16:13 ` Kiryl Shutsemau [this message]
2025-09-19 12:40 ` [PATCHv2 2/5] mm/rmap: Fix a mlock race condition in folio_referenced_one() Kiryl Shutsemau
2025-09-19 21:18 ` Shakeel Butt
2025-09-19 12:40 ` [PATCHv2 3/5] mm/rmap: mlock large folios in try_to_unmap_one() Kiryl Shutsemau
2025-09-19 21:27 ` Shakeel Butt
2025-09-22 9:51 ` Kiryl Shutsemau
2025-09-22 20:16 ` Shakeel Butt
2025-09-19 12:40 ` [PATCHv2 4/5] mm/fault: Try to map the entire file folio in finish_fault() Kiryl Shutsemau
2025-09-19 21:28 ` Shakeel Butt
2025-09-20 7:37 ` Matthew Wilcox
2025-09-22 16:16 ` Kiryl Shutsemau
2025-09-22 3:19 ` Baolin Wang
2025-09-19 12:40 ` [PATCHv2 5/5] mm/rmap: Improve mlock tracking for large folios Kiryl Shutsemau
2025-09-22 3:20 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wnenjcqvr2lzqaqnxyc6tbtd7smv2hepajtjxl72kundsfaisk@k2mlxpzuzhbv \
--to=kirill@shutemov.name \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox