From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org, Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH 3/3] maple_tree: we don't set offset to MAPLE_NODE_SLOTS on error
Date: Fri, 22 Nov 2024 10:18:52 -0500 [thread overview]
Message-ID: <wky6ghuq4fvzhv6o2qf3p3gf5ffauce53a4or7y2xvowij2l5q@maumukdbj67k> (raw)
In-Reply-To: <20241121071516.v2m3z5sls7j2bimz@master>
* Wei Yang <richard.weiyang@gmail.com> [241121 02:15]:
> On Tue, Nov 19, 2024 at 08:58:06AM -0500, Liam R. Howlett wrote:
> >* Wei Yang <richard.weiyang@gmail.com> [241118 21:15]:
> >> On Mon, Nov 18, 2024 at 03:50:49PM -0500, Liam R. Howlett wrote:
> >> >* Wei Yang <richard.weiyang@gmail.com> [241115 20:48]:
> >> >> When mas_anode_descend() not find gap, it sets -EBUSY instead of setting
> >> >> offset to MAPLE_NODE_SLOTS.
> >> >
> >> >This is for mas_start(), which I think is not necessary anymore.
> >>
> >> You mean mas_start() would set offset to MAPLE_NODE_SLOTS on ma_none and
> >> ma_root?
> >>
> >> Thanks for the information, I didn't realize this.
> >>
> >> These two cases are handled by mas_sparse_area().
> >
> >Yeah, I'm not sure that needing this lived to the released code.
>
> I don't get you clearly.
>
> What should I do next?
This looks good.
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
prev parent reply other threads:[~2024-11-22 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 1:48 [PATCH 0/3] mas_anode_descend() related cleanup Wei Yang
2024-11-16 1:48 ` [PATCH 1/3] maple_tree: index has been checked to be smaller than pivot Wei Yang
2024-11-18 20:53 ` Liam R. Howlett
2024-11-16 1:48 ` [PATCH 2/3] maple_tree: not possible to be a root node after loop Wei Yang
2024-11-18 20:49 ` Liam R. Howlett
2024-11-19 2:10 ` Wei Yang
2024-11-19 14:12 ` Liam R. Howlett
2024-11-21 7:13 ` Wei Yang
2024-11-22 15:17 ` Liam R. Howlett
2024-11-16 1:48 ` [PATCH 3/3] maple_tree: we don't set offset to MAPLE_NODE_SLOTS on error Wei Yang
2024-11-18 20:50 ` Liam R. Howlett
2024-11-19 2:15 ` Wei Yang
2024-11-19 13:58 ` Liam R. Howlett
2024-11-21 7:15 ` Wei Yang
2024-11-22 15:18 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wky6ghuq4fvzhv6o2qf3p3gf5ffauce53a4or7y2xvowij2l5q@maumukdbj67k \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox