From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C1ED0BB7A for ; Thu, 24 Oct 2024 09:00:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB4296B007B; Thu, 24 Oct 2024 05:00:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C64606B0082; Thu, 24 Oct 2024 05:00:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDFF6B0083; Thu, 24 Oct 2024 05:00:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 452556B007B for ; Thu, 24 Oct 2024 05:00:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5275FA114B for ; Thu, 24 Oct 2024 08:59:35 +0000 (UTC) X-FDA: 82707898476.15.5347F26 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf21.hostedemail.com (Postfix) with ESMTP id BDD8D1C0016 for ; Thu, 24 Oct 2024 08:59:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=PKWcctag; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf21.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729760237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4aMns0vuxoj2DGKLLnGNiIIfjWEYlc98f5DfBMf9BA=; b=ium+3uMd74sWVJh9WieCmjWdTTNpdcDJx5IDSW0fm8HAHN4zt2PrCPaW6caRqNDef2cFcI grXbgNBsfDhamPb+sJuePJnAySlMXJxwBDgGA9uUKuTCfk4btUrHLd7RpsrCKwLd4tz9D9 1R+KnuqiEkqms6VblS0F3avj/qA3sow= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729760237; a=rsa-sha256; cv=none; b=QQ5n1U40soTZ4t+PinO9UuXvn9P1TPQY+qkeXRtpuIMJI9EgsMxYI1KU3ya32n6zOeUu3F +gwI4qysWBmPj0i+WzHQpQ20iU9jAyp+yDXvM+42dR67f/C2lRZgb0K0jw+iqSCuiRr6d+ 3FPaDSK4xDIEAOyNGhyZdkUEK0YvC8k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=PKWcctag; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf21.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=j.granados@samsung.com Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20241024090002euoutp018a0108ce9bcef735dfc2001bcd9eb563~BV_v9kCks2844428444euoutp01c; Thu, 24 Oct 2024 09:00:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20241024090002euoutp018a0108ce9bcef735dfc2001bcd9eb563~BV_v9kCks2844428444euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1729760403; bh=h4aMns0vuxoj2DGKLLnGNiIIfjWEYlc98f5DfBMf9BA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=PKWcctagUKqph0utZfFpZKN3KY/qjUavkEMXcM5jAgjkTBCJp4r2ARpnEC7BANlm7 JkrukntINZ7KkZXYQxfxUDlegETw9QtlYjv92KU4Phx0kwXFVK8Cb6ddt5KslCN2Ql qnONcceyEgshb3vORqGH8/vgxFhRkUXBlqYCjLiE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20241024090002eucas1p29b6425c21e9270f2caf6bc3f05b4341f~BV_vl5fpu2350923509eucas1p2R; Thu, 24 Oct 2024 09:00:02 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id BA.A8.20397.29C0A176; Thu, 24 Oct 2024 10:00:02 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20241024090001eucas1p143fc38cbcaa9538710040c2d957e9f6f~BV_u8PgHB0678306783eucas1p1j; Thu, 24 Oct 2024 09:00:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20241024090001eusmtrp2dcdd7d123acd3c24d819eddc1fef8d71~BV_u1ZF280636006360eusmtrp2P; Thu, 24 Oct 2024 09:00:01 +0000 (GMT) X-AuditID: cbfec7f5-ed1d670000004fad-a5-671a0c92f203 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D9.E9.19654.19C0A176; Thu, 24 Oct 2024 10:00:01 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20241024090001eusmtip1faaa6f50c4bd058871f85094590722b6~BV_ujLojm1676816768eusmtip1x; Thu, 24 Oct 2024 09:00:01 +0000 (GMT) Received: from localhost (106.110.32.107) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Oct 2024 10:00:00 +0100 Date: Thu, 24 Oct 2024 10:59:58 +0200 From: Joel Granados To: yukaixiong CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 -next 00/15] sysctl: move sysctls from vm_table into its own files Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <79b33640-fc81-b4c1-4967-30189d9a4b23@huawei.com> X-Originating-IP: [106.110.32.107] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA02Te0xTVxzHd+69vfcCVsoj9ghL3GC6SRBksvlLnG4ak91tmmxZ9lC3jEZu ihnUppWhBGfrA6bII1WE0SpVnDyKAoWhiAQFBgNGyxScgqBjdBusvFpBAYG1XN387/N7fM/5 fk9yWNLXygSwuxR7eJVCFhtEe1JVTVOWVbpFAfLVpW1SMJSW0HCkep6C+domBCPORHCWzdHw T4MDwXzvXwTknaug4ezUtAj+LktBYLAepmCidJqE9qHTDIwcnKHA1tTPgH40GOyVRSSYzFvh VLkU9NmHCJi6UMzApdJ8An7Jv0fBpWGrCDqq0kVwWfOAgWu1LRTcumqgoa9k3jW43iaCseP9 NBienCShJbeIAuvViyK4k2lDcPO6kYDaPA0FTcYloPvTwcBkmx1B61QS9OiyKUg+X07A8Zos BNYOCwOj6dcI0JakknDXOkBDhTmLhNbpVgIcp+dEoNemI2g/WCIC62yzCLTO+whmHrucpJ1v YVxXn3C9SN0jGkzzlSR02jqod9Zzj46kU1zJmRLEGXs+4BrsoyRXWXSX4IzmeO52zTbucOOw iHtYnYG4isIQLv/aIMGZi4/SnNmhYziLfoziRiwWhvs5Z4b68OXtnm9F87G7vuFV4RuiPGNO 3rhAK9u995ZnnkMalOJ1DHmwWBKJG09YKDf7SgoRnjTsPIY8XfwQ4e4/xhmhcCLcXt9OP1Ok duUTwqAAYXv5FeK/rdmseiQUlQg35Y8jt4SSLMfmjAzGzbQkFFvt90g3+0tW4CHbNO0WkJK7 Xtg2bFpw4ifZgW/dNiywWLIVz5T/RArsg1u+H1jok66DjDUOl5h1cSAumGPdbQ/JBmxq7BYJ VoNwV2YvJfB+3FrZTQisW4R/PPqFwJtxW8ZZRmA/PNRc+ZRfxPPVeQvJsOQEwnVzY4xQmBC+ oJ14etI6fLhz4KliI249lIbchrBkMb4z7CP4XIx1Vdmk0Bbj75J9he0V2NRnpzJRcO5zyXKf S5b7fzIjIouRlI9Xx8l59RoFnxCmlsWp4xXysJ2748zI9efa5ponrqDCofGwekSwqB5hlgzy F/8as1TuK46W7UvkVbu/UsXH8up6FMhSQVLx8uhlvK9ELtvDf83zSl71bEqwHgEaQnVAHil7 7zPzFvXuvtWppM2RNbxW42jI0a9P6vG2+EzYGqiIqi/ftPxeRT0OaY7LexKQ2L93i3ZdgXpa 4ancuKwtMzrqwJJVCfTaG5P3V+aYZuv2J+nlQ46bBZeH76i9Ix1J4Yn2QK3nvqhc6Rsfn2Rb lL2NsqVdFYnv1z3enBC1aQP/Svds/wy70kOsOSW/qA+u9gpXp/Rs32i1TTlDz5z71L/20J4H fm+nvdTyw0dKHRu/bVzTgGp+G8x5obcsJHlz56D086vfdnzCOiLyGl8T3/RJGkhLKPNI1Y4o X9+R/apJYVCo3l2+yeosapTK5aGp3JBVOeg847Fm4qh3O86UBlHqGFlECKlSy/4FvpOZEOIE AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Te1CUZRTGe7/bLgixAcUXgmPbCMLYcl04MIiOTuNHDTOVAw1a4YorkNzc BUzUCUwyEQEJpLjEJsR1A3dBChdEYcUWgkVuBogJgdxBLqawwrawNfnf877Pc37nzJn3ZeOm M5QlOzQiWiiKEIRxKUOide3u4DuXjSyDHSVqW8itlFKQWKslQFvfjGB2MQ4Wr61RMNW0gEA7 OIZB/tUqCn5cXiFh/Np5BLnqcwQ8rVzBoW0yjwWzZzUEjDYPsyBn7m2Yri7FoVzuC1dkFpCT 9RUGy0VlLKioLMDg94IHBFTMqEnoqEkh4Zf4Ryyoq1cR0HUjl4KHUq3OuNVKwpPkYQpyX2Tg oMouJUB942cS/kgbRdB5S4JBfX48Ac2SNyD98QIL/m6dRtCyfBoG0rMI+LpQhkGyIhOBuqOd BXMpdRgkSC/i0KceoaBKnolDy0oLBgt5ayTkJKQgaDsrJUG9epeEhMU/EWie6ya5VKhi6Vp/ q9tIwzMKyrXVOHSPdhC7dzLPElMIRvqDFDGSgfeZpuk5nKku7cMYiTyG6VUEMOeUMySzVJuK mKoSe6agbgJj5GUXKEa+kM5i2nOeEMxsezuL+e07DfHBWwd4XqLImGjh1pBIcfRO7kEncOY5 eQDP2dWD5+Ti/qmnM5/r4O11RBgWGisUOXgf4oVk3C6iotpMvpClXUXx6PymJGTApjmu9MWe AiwJGbJNOT8hurNmFNMbVrRsqYfUazP6RW8SpQ/NI1rTOETqD9WInijo30gRnG20PDWVta4p zg5aPf0AX9fmHBt6cnRloxrn9G2iR2fKiXXDjHOQ7urN3dDGHF9aI7uD66nfYPRqUSWpN16j Vd+PbIRwHVWiWNCR2Dq9mS5eY69fG3C86XJl/7+jcumetEFCr8/Qi6uPURoyy36JlP0SKft/ kgThZchcGCMODw4XO/PEgnBxTEQwLygyXI50776mebn6V1Q6Oc9rRBgbNSKajXPNje+FvBls anxEcDJOKIoMFMWECcWNiK/bxWXc8vWgSN3HiYgOdHJz5Du5unk48j3cXLgWxlS3+qgpJ1gQ LTwmFEYJRf/VYWwDy3jsw6a8iTxVY6Jdgq1Xi1duRWixjbtH0Hv2DSc+bvsrrhKL5Z+yGrqv 8LSS3tTu1UbJS1TMnJ2ryGqLC1dCLfJLAiKatjGG96/vKyCLB6NsZqwbmrp2qwWmJYeVg75j pwzbfDL80QC5fUdC31rjkML2uMjv0P7rn3ymqUX3LJ8aLWmclzXbfeqPdRbZBlaY+NitjvQa +B8/yW+dV/jJRB8VB5i479ozPPjo3TMWNbEPP9dmKlUXshRT+fF7OrdeqT8c/rwvJJm5bTR+ YK9G+cppyYmKffVThRVfWu23HtD2bPHJ7LZWOrzabHFns/Jmh7+LzC87ubWtv2fXoudRF5OB sYZxLiEOETjZ4yKx4B/VplmkgAQAAA== X-CMS-MailID: 20241024090001eucas1p143fc38cbcaa9538710040c2d957e9f6f X-Msg-Generator: CA X-RootMTR: 20241010141133eucas1p1999f17c74198d3880cbd345276bcd3bd X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20241010141133eucas1p1999f17c74198d3880cbd345276bcd3bd References: <20241010152215.3025842-1-yukaixiong@huawei.com> <79b33640-fc81-b4c1-4967-30189d9a4b23@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BDD8D1C0016 X-Stat-Signature: rdj7tpqenj71cjwsjt9oizwhq33ppwtq X-Rspam-User: X-HE-Tag: 1729760370-575269 X-HE-Meta: U2FsdGVkX1+DE/Ol8ec8q3o83ovojRV4hbkM2ptQs7eRc5qtxWGC1Te6TYs6NBqsUkD8B3kwHY7IQz0G3NxtFti0mOnHx4KaY8JZNzKSznKlyJUA8yCiqRHPwV/GvyTAlXY/NuXHLH+KhS2s6D59LU/RW4Cqe2ghYBrG+TRY130r461M8iD9ONRNow6E7ilQ5MsuooCCATgWXAynoHR5k9MTHNFcsNZE1irPHfakX2c1LFfR0ycYjFutN+8tpijtwAK6cwbqZv5GrfiL9Ze1dnrIe0XItjAEODU6bvcke2DT47+EbfIlcpmQSgs2XVA74SVC2NdwSrdpd796PmjljZAxSBwl91bT+E/6CxpPbo7jlScMtyFEEyUrbshVNWOH91ZOd+NYIZw6/Opz4pfJfOtVWUYwpUf2CXLXo1mFA/7XcF+pFNyiGqJix8SLWSGJ/hDGz4q6CKtcyqs5qZwr7xfJg9x+WprPMdBkmhHBhp1pk6yRxAn4G/3sqA5VceXYxT2HAcmowJHEVj/J4i0V+05LGt7jkWdhS5OQVd3XHsNUiE9TpYsME14GnS3ZEDHtjk6gu+d9KF8NQnd+kn2e0RddSzq9ZTvGa/qDS83D5XpZGTJEdjTMKizCFQKYW6NKZOxInKEYQCJSUpP5KyOVPmAVvnXBE0ppC2LiPyMHBqGi1Q7i6hr9Z55CAojBVePASfGUXupWL9CnJkQfSrQX0yIFkP+Ob5FVHHqq6Xvmo9v1e3zdMye7/7bM9FOxyHKfLrJKB7Q23qmzan0Oafa3eDtpvBpUjSd5Zlom2an7pfoSLxV4YZx61MZFwHJXnN6xIjMtTRw5zs395SSlCehd4+FNugT2C94i7QkqCNU+h09gK/9E/UyQIhgQU8VBn047JuGv8we8kfm+4WnB1yO3mrrfNXD1cbez8yxJdy0wVVO7rihoaEh+cZzkyMluOJbiyG+lnTLwSdfAGbcfjIV P8F80Quv SmXwSEgPKFh6uvnU7ZvvK3nEDTVMA0FHQp7YIc0dtX9E3R7jtO+aaFW/2nIwjFs2F4bhzMC2VYJbhQzzBJzWGze1YPokqIAr8t29lmhb9hHKtqwWN4Ydi2GjjgAm08iH8UrlF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 24, 2024 at 04:07:10PM +0800, yukaixiong wrote: ... > > > >> mm/swap.c | 16 ++- > >> mm/swap.h | 1 + > >> mm/util.c | 67 +++++++-- > >> mm/vmscan.c | 23 +++ > >> mm/vmstat.c | 44 +++++- > >> net/sunrpc/auth.c | 2 +- > >> security/min_addr.c | 11 ++ > >> 23 files changed, 330 insertions(+), 312 deletions(-) > >> > >> -- > >> 2.34.1 > >> > > General comment for the patchset in general. I would consider making the > > new sysctl tables const. There is an effort for doing this and it has > > already lanted in linux-next. So if you base your patch from a recent > > next release, then it should just work. If you *do* decide to add a > > const qualifier, then note that you will create a dependency with the > > sysctl patchset currently in next and that will have to go in before. > > > > Best > > > > Sorry, I don't understand what is the meaning of "create a dependency > with the sysctl patchset". The patches in the sysctl subsys that allow you to qualify the ctl_table as const are not in mainline yet. They are in linux-next. This means that if these patches go into the next kernel release before the sysctl-next branch, it will have compilation errors. Therefore the sysctl-next branch needs to be pulled in to the new kernel release before this patchest. This also means that for this to build properly it has to be based on a linux-next release. > > Do you just want me to change all "static struct ctl_table" type table > into "static const struct ctl_table" type in my patchset? You should const qualify them if the maintainer that is pulling in these patches is ok with it. You should *not* const qualify them if the maintainer prefers otherwise. Please get back to me if I did not address your questions. Best -- Joel Granados