From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8FDC77B7C for ; Wed, 2 Jul 2025 16:03:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42FDE8E0005; Wed, 2 Jul 2025 12:03:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 408458E0002; Wed, 2 Jul 2025 12:03:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36C288E0005; Wed, 2 Jul 2025 12:03:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 26AB78E0002 for ; Wed, 2 Jul 2025 12:03:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C27B11602CD for ; Wed, 2 Jul 2025 16:03:05 +0000 (UTC) X-FDA: 83619793530.26.162BDFF Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf25.hostedemail.com (Postfix) with ESMTP id BC0E7A001D for ; Wed, 2 Jul 2025 16:03:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=J23fCSUX; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751472184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JmKpgw7JxflsdjAvdn78UOLyrgy5j/ltn6L9d5qwGqg=; b=ZwzwW+b2EUN5ffYxyLD8Q3taMHxmXcz+Qi4lZEQqQqebw2YGVjlhvEtZIcyoNFvffcisiq tLJzRE1rgjaEzQdkJTTexbOuNhXJXtL5BtVxbJX883geUEGfX+gd/ZdfcOpZL4Wle87Fbn PkOghf6VYD/g6j8MlNyuzMhH3DFwv7Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751472184; a=rsa-sha256; cv=none; b=JaRU1ABcBytNhfZtWtk7F2RLCo/e1HXdMDvZBO9BmpeQK6TDkJ4uRPvW4Wx/8HsCP0oBYo flNCJ0vG2xMIKJ1D0bkg4+np8dXCwDUjVj/zTXaKrsfimisLtJix0n/HkBbN1OcIrcDih1 wxOOkYcKzAoguRRA1iTX7yINTnBQ8nI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=J23fCSUX; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 2 Jul 2025 09:02:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751472181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JmKpgw7JxflsdjAvdn78UOLyrgy5j/ltn6L9d5qwGqg=; b=J23fCSUXkIuGwEC3bvhOwMbwNz0SefxLm8KigJv5REYSzQ5sy+aA9caK8ht+7c9lSQll9I 3f28xk/NNd7VO/GkScdST30K7NVx3ilWY28xuRI9YbB1deNpX6ss49dliGSvnqKa3L7kec QkZrQ9KhSf+fIq8/1MotwIEztGpsYB8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Dave Airlie Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig , Dave Chinner , Kairui Song , Dave Airlie Subject: Re: [PATCH 17/17] amdgpu: add support for memory cgroups Message-ID: References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-18-airlied@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630045005.1337339-18-airlied@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BC0E7A001D X-Stat-Signature: br4oak4qjft9mzwjci5pn8u611gu7147 X-HE-Tag: 1751472183-349479 X-HE-Meta: U2FsdGVkX1+CrlhnnGzWoQgqm7VqNtdCC5As8fqyZyUTOTMAjDScGlgiZJKl4DXeaVU9w3K3EVCqTW6efb1hrAJANNBEGj7WxiIkBz9gtyiBI7ENTLGxgZwU5Ur7QAip9TtqrqGoqT2Tq++FMIbZed8983H/s2QNcs1ihWphF8+HUmJHz/rFYft5k5/vCcjWcX3KeujOaZ7yNwBKN2bLbHFE7GSqJzbtHRja7JByNafHcupTuL9LqXCumUJu9yIvAiNgTFlza/ikSFYwI6yiB62JZfwHhclsCjYj0qdx09qyQvE3SlgDHgqPOiiXaFCx1l4MCf7YBQWPIALWylnn73txuQnxht0Hz9Vx62O/uLfYZ/6jd0YxAnAqkfltEDXT0SzpGKJs6H+3LhUf9Ke4f//PctGYzObS0DWrFaZNXlcy/puADDcK6puoGJiDU2S4Ki6hw2nN5HVu+7Tvb/LcxW9EnzNEvwQQOWtzsLEKHczra9QBfihwILN0Eh+izRdfkvO1lgUh7uY+HYtx6Vgov4dcqjLc/idBWdR+v/+CQc8b3EDLyQRxXki7E1StsR6PjLVJKQvkCSd1Y1gA297MD3of9RohV1x/op9IZMGHZ64c8Pq1NHdLfmBh2gJbZ0sssN5kjFfaYcSHR2817fAoanc4SPxFkVVxXZJFMeh3xD1kJcvn/NLgTc2MWW9rlLaUwsmcdNZ6hkjjGumRIlAqv73XnNwPmDiXjnhTNmuw0d81qdp7AJR6jaCb22J3SEH6L/UA2lNHhdNYuXRHDQsftNYzzQrAhSF9mjSQZHZKeBx902MrjjGTwYyzUM+T+o9jrG/l+UYd1nt2id6tBvs6q3TRkingbuUuTupkVolMUsz4ZsPhPEOtAWGNt6o7Qvz4VWntYsNiefyfohH5eL89jI8p7Sqcg/A620/CjAszD9/cZUg5iwamLuoadOI26qfCmzpIs+Wht3TmreXGO6t RIZsMFAn otAomUYhKPXtSDrbQwjOU0s0AvQkBZCp9gvrrBVsba3UaOu8c8NO2HjL8dxIOEJuyj/SfNEKtCGgUtHxe24JJOZkHCY0IYY3pqsP1iPDaHmGLeka4E8kBuKLsf5DNl70sVPQVhoh+X55MNFRwGCKdeetmWtdilCKcB2m7O0p3pBeIZ4EFGYbs1fQ8hQ9C1aHMNRbTdPnvY9xaG+pGi/8X8D9qHXuMi3hNish5gQbDz1RpyMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds support for adding a obj cgroup to a buffer object, > and passing in the placement flags to make sure it's accounted > properly. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 13 +++++++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ > 4 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > index e5e33a68d935..d250183bab03 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > @@ -198,6 +198,7 @@ static void amdgpu_gem_object_free(struct drm_gem_object *gobj) > struct amdgpu_bo *aobj = gem_to_amdgpu_bo(gobj); > > amdgpu_hmm_unregister(aobj); > + obj_cgroup_put(aobj->tbo.objcg); > ttm_bo_put(&aobj->tbo); > } > > @@ -225,6 +226,7 @@ int amdgpu_gem_object_create(struct amdgpu_device *adev, unsigned long size, > bp.domain = initial_domain; > bp.bo_ptr_size = sizeof(struct amdgpu_bo); > bp.xcp_id_plus1 = xcp_id_plus1; > + bp.objcg = get_obj_cgroup_from_current(); In what context this function is called? Is that the same for ttm_pool_alloc_page()? Is remote charging happening in ttm_pool_alloc_page()?