From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org, Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH 3/3] maple_tree: we don't set offset to MAPLE_NODE_SLOTS on error
Date: Mon, 18 Nov 2024 15:50:49 -0500 [thread overview]
Message-ID: <wd2v6aaokf5hu5qmrtna3axhj7zoeyavunxhkzq5sn2bfci3n3@t5jmjqyzy7my> (raw)
In-Reply-To: <20241116014805.11547-4-richard.weiyang@gmail.com>
* Wei Yang <richard.weiyang@gmail.com> [241115 20:48]:
> When mas_anode_descend() not find gap, it sets -EBUSY instead of setting
> offset to MAPLE_NODE_SLOTS.
This is for mas_start(), which I think is not necessary anymore.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
> CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> lib/maple_tree.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index ab235d0194f7..b67dae356182 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5011,8 +5011,8 @@ static inline void mas_awalk(struct ma_state *mas, unsigned long size)
> * There are 4 options:
> * go to child (descend)
> * go back to parent (ascend)
> - * no gap found. (return, slot == MAPLE_NODE_SLOTS)
> - * found the gap. (return, slot != MAPLE_NODE_SLOTS)
> + * no gap found. (return, error == -EBUSY)
> + * found the gap. (return)
> */
> while (!mas_is_err(mas) && !mas_anode_descend(mas, size)) {
> if (last == mas->node)
> @@ -5097,9 +5097,6 @@ int mas_empty_area(struct ma_state *mas, unsigned long min,
> return xa_err(mas->node);
>
> offset = mas->offset;
> - if (unlikely(offset == MAPLE_NODE_SLOTS))
> - return -EBUSY;
> -
> node = mas_mn(mas);
> mt = mte_node_type(mas->node);
> pivots = ma_pivots(node, mt);
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-11-18 20:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 1:48 [PATCH 0/3] mas_anode_descend() related cleanup Wei Yang
2024-11-16 1:48 ` [PATCH 1/3] maple_tree: index has been checked to be smaller than pivot Wei Yang
2024-11-18 20:53 ` Liam R. Howlett
2024-11-16 1:48 ` [PATCH 2/3] maple_tree: not possible to be a root node after loop Wei Yang
2024-11-18 20:49 ` Liam R. Howlett
2024-11-19 2:10 ` Wei Yang
2024-11-19 14:12 ` Liam R. Howlett
2024-11-21 7:13 ` Wei Yang
2024-11-22 15:17 ` Liam R. Howlett
2024-11-16 1:48 ` [PATCH 3/3] maple_tree: we don't set offset to MAPLE_NODE_SLOTS on error Wei Yang
2024-11-18 20:50 ` Liam R. Howlett [this message]
2024-11-19 2:15 ` Wei Yang
2024-11-19 13:58 ` Liam R. Howlett
2024-11-21 7:15 ` Wei Yang
2024-11-22 15:18 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wd2v6aaokf5hu5qmrtna3axhj7zoeyavunxhkzq5sn2bfci3n3@t5jmjqyzy7my \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox