From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 239C5C83F17 for ; Thu, 10 Jul 2025 23:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6CA6B009D; Thu, 10 Jul 2025 19:36:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E036B009E; Thu, 10 Jul 2025 19:36:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A921A6B00A0; Thu, 10 Jul 2025 19:36:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9A4306B009D for ; Thu, 10 Jul 2025 19:36:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F0F6160A88 for ; Thu, 10 Jul 2025 23:36:02 +0000 (UTC) X-FDA: 83649965364.17.5723574 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2040.outbound.protection.outlook.com [40.107.100.40]) by imf22.hostedemail.com (Postfix) with ESMTP id 9655BC0006 for ; Thu, 10 Jul 2025 23:35:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=G3UX+MoG; spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.100.40 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752190559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VDDsNPE9+iVqRINBmztKZzAT13hBw4XQ1G9oG5UPD7Q=; b=08H8ZD/07aMkxDfLSU7mPEOAN2ywvKIbNkAVMHJiSTZ9Ftz1/K5IERkBd8O+gdYaqI+dDN 0ATEnW4AZNzzMwsMtIWKG8QPFm3Z6OJrWew2/mKQUFL0wZWtpNxKtXC4AEsXNsFR6pdd6N 2f6dIUn0Vv8uRbrtYPBm7sAW8jSxZ6c= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=G3UX+MoG; spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.100.40 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752190559; a=rsa-sha256; cv=pass; b=l8SeIyE0wwFJ3hnu6goyZJmWughcgjl1t5bAuQECQCbOzN600+XCUReGVhKwDmKuWljt/Q lsNhZmNbhlbX22KkGS0O+H/bgKhVAuKh5n/18LeNL9RnRYyp1HPCSp5UxxdAPS7V+Vx7E0 tVVmEx8L7Ov8pagAb6irL7ZBxsAAQEM= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yK57MbH5ySi072QOTaAtO/SF+Usuz0ZY1NZft0pwWlfqBFWIAmZlmF4bLMP5WzJHB5mo/sHQSqi6qkb1Jfm/hD15273GGKGAvhy+U7+iotQYdWt5hCy8SXZ54Ckgr6G7sFMPQAQVsFnHkJDHM2SYyOLntkWBdwuK0Enxx6aynpu+3rnxeqcNqHW8PHB3SInrMf8UHw8nOD0KljvZGTdeO+JUEgU8y/hV2RIqrzUadFZGINIwdyUms3wX7gynsTjQlHj2UNxZDJHG8B5HEL2813Eah7+3KBQatT251FhmWwYVgghBA4M0/xwXupl6bMY+LOp9uzUmsoG0zXI1FP+HUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDDsNPE9+iVqRINBmztKZzAT13hBw4XQ1G9oG5UPD7Q=; b=MqTgsROZeIpVyKYeG5IfFtbBRycilzxfo3oq+GqIO8h2GiNCg+B2ph3GMMXymexndk5mVypBwpc0BP/NbCj6mQiT9HYkvUSDYKN/U5A4J/55t7kRxVr+/KTtPudInwQKbL0iT+vQ/uTergpPWlSwtcZoU8oHpE+M4H7KldOvUA9seI4ljLN/TBfPZ4caXoc7oXdKxB69aL7Ywa9vubHN4fzJqQY2gAZH5E1oZLuZh6jGJzaDKxcvzzBk8ikPD+nOlbC8Q4sdYta8W1u22SBrxhNv1bFOxDU+D6Lm/9ld9wVZR4uKVoSjdwV4NdDz2l/P69ajHkCYeE3jZlNxGh2rew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VDDsNPE9+iVqRINBmztKZzAT13hBw4XQ1G9oG5UPD7Q=; b=G3UX+MoGyLbm3itR2r/aFyrBY7QQFk5xAGojNAoCN9bWpkxAClIFXz4NhVPXzs3g1sVzlekhPZvtX40yPrWv8RIL3qLlzB/j7tP+pMilfFLk3oGYcWJkwlGgkSWMYHQsGGmEYmUJ5oECaGQtFc3PWtqpIaEKiDv8q2O/UVIZpR5YqztvtyDaiDQOZRtO42l9nikeaIaN0HELBB4T0HLpUcirPGZL9Xw/7CO4QzDBtRUXSEg6G+jj9qVPpsqz1oeHjto+gjhNhNk3smJ+//hOV47GSmit7tfTwFI3zQBv4NC0vA0M7lbdTdeh1bDNZzwhnO073OMiu72wjrTjt6syOw== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by PH7PR12MB6718.namprd12.prod.outlook.com (2603:10b6:510:1b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 23:35:56 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%3]) with mapi id 15.20.8901.023; Thu, 10 Jul 2025 23:35:55 +0000 Date: Fri, 11 Jul 2025 09:35:49 +1000 From: Alistair Popple To: Andy Shevchenko Cc: Leon Romanovsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v2 1/1] mm/hmm: Move pmd_to_hmm_pfn_flags() to the respective #ifdeffery Message-ID: References: <20250710082403.664093-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250710082403.664093-1-andriy.shevchenko@linux.intel.com> X-ClientProxiedBy: CH0PR04CA0024.namprd04.prod.outlook.com (2603:10b6:610:76::29) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|PH7PR12MB6718:EE_ X-MS-Office365-Filtering-Correlation-Id: bf889b6a-e793-4b9b-5a5b-08ddc00a8401 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?L/PV7SrfRlUP9xYFEaSzVQqKNxRNnOLruQsg7iTrZtLOCFRLVeHxE0Df/qnb?= =?us-ascii?Q?itWZsyHt1dTBXNn9g7OWG0C8W5SJpwfAv24HNcJOq9E1zlbjE3s72nQ7XLia?= =?us-ascii?Q?t0mly/faq95LoKS5Kb+O5xEmP9RD0WGSIWSbhfZkI+IUUqvBhly1JlEbo0sS?= =?us-ascii?Q?IHD+8gL59hgP0G7gzfkRymCShZwWQ0URmtMXJlaFugAk2UIIPMgf+8HOi9ps?= =?us-ascii?Q?kHTh/YC3hMmTHxGCgzv7HDgJzNL3CR6EX+CGODMyIx6N71jZyY4YNU0q623K?= =?us-ascii?Q?TTAfzmugD2NtSOG/hwgRf6GQ7Q0qmKT2wFjifMGnEcMD4VnTrHJB9zmtpRgj?= =?us-ascii?Q?gbh9GEMmb8GCv7CkeqTJS+zlSAN18OjQCgLymVG83mhhPTQ6rbjjgoxV1fgf?= =?us-ascii?Q?YnJyOLpuPsSnG4FhEp20/JuD8jn74lrDK0VNVrJdJek9oxmDaxsWme1DH7qB?= =?us-ascii?Q?fxnXD8wWPt1sdFKYzc8boh9squtp8pnrjq+WXbk1yBc8cvWTRkxHS/vF0Cni?= =?us-ascii?Q?GEoIwWCRjou8k0bLC4l9/Oxae41RRNLnEn4i7AvcPNRSGLtQP32Ws+ZNDeoD?= =?us-ascii?Q?nyfEfYKEYiHXW4ErkRSwKCNVRH+reZMVIov7hNj/KXX69kiit2YfdYq0b713?= =?us-ascii?Q?lcXrKcSttUoFuFhZpQGc0xZf1PArlELUxa7B4oEwqzNK980WoTwYKAgUk/8H?= =?us-ascii?Q?uBqBB82hIm4x426DWoe0a2v1ZXGfft01dh9Y/24mjeHAlAdVZEt983HKP9H4?= =?us-ascii?Q?47u3kZxnyAXsJ0mZAev1sYNtuvRas63ypZsFR3tZMwpZRvw5q3kFErJCE+I9?= =?us-ascii?Q?uXFg1zt7kOv++Tw4s8bXoy5gG7y7hP1f2fVH4X4FtMDS8p9lVUbuZnvVxO2o?= =?us-ascii?Q?GXEd7/TObSlmIr8ZVRMQmX02haY1pS+KHZlq+RFanIyfprHCcXHnrQBSZtEK?= =?us-ascii?Q?mw4aT80R46hv5BS+aAeMAFFRnZ0tIvqxnvlKvNywlYondm0zCjz63HHNYHms?= =?us-ascii?Q?PvnWY8iG3zwOmXggNKDpg0LpPxZN25XQuJ19yuw0YE7bOvS0zZ8OPUrEvoUi?= =?us-ascii?Q?XyjHyI8egPoAT6Q31Q/HAoL9n83l0RZmF518dWh5IoxEFRnBmcX6+JPbO9Md?= =?us-ascii?Q?2Hg29UQ9wyGByQDsJW0fc90/sHQZf5p6yEbZt0/mgwWgeiRrX+C6+hoIRtY8?= =?us-ascii?Q?DPu9cp1escvgo9lGWD6AZpo+f+TF631gRdqZAUA2s8xu45AeK58YU2/3F/KD?= =?us-ascii?Q?yR5dRLK5pESkxAy0J3D8hBjHwDPHouDBgQ6BAnJi630lM0sApmc8UThPr+UE?= =?us-ascii?Q?ji30gduaWPar8EsI8k/1Z38Ttg0+6IjurN/lxuABOjWJScIuAFL28Dl26wlI?= =?us-ascii?Q?YgxsbXfLOfnoH1PvHEqEQE42l2VydSXmboOaCqcu2MHXRq+AsnqYySPOdaOX?= =?us-ascii?Q?m6aSxHMgoZU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o+p2B56W4LWJvRNlNpQ/3QQ+AyxfBM8YGCnkNwCRbbZbWULadceG7bliC9kg?= =?us-ascii?Q?hz0FRVKiFIWWyLhXDQvtxVNfwHEjiQEs1FZ5W13t1/wztOOndXugRtEi0/vD?= =?us-ascii?Q?tboNLizIpbikxSd3PkPHrRXwne6udvzPTLMuE4JIfIRseRUGL5By5YdDxQB4?= =?us-ascii?Q?dFuecSIEYrfTlQsBk0TArEjouQadlr28TucGQHQybQ26Pnv3VAXbeAToVlS0?= =?us-ascii?Q?JHIxL5KiZVUfGnCdgmzXitqoeT70xEXWSUsqxzxpwR6L3mCvwT1VLRqz51HM?= =?us-ascii?Q?Xr4FjyJfa9s6RbAES9bLbNUL01DLU1a8I7jm1qk0wOJg+0ARLAqjmX+VYeoM?= =?us-ascii?Q?s1peYjIxMNzqqIx17Q/XxR4gP1rtWQNGEV+k1akIa5tfbNd7WyCLZ67TArHU?= =?us-ascii?Q?Bp6qseqfH+ocTPM4lTCAJOPgwONrncTvB9xjcOLmW7QoUo1N0iJmSHyHhfqy?= =?us-ascii?Q?E0q4qFNIBZeYWZfsQVh5DC9J4azsSp+kzE5ikoAjJWsiGe6PaoWgP3TGO/6Q?= =?us-ascii?Q?k/43Eh4P7WsiJ2lgK0MndZDco64qieW76BETG7pWH4EC2iSUR71dswWXo7L5?= =?us-ascii?Q?G8Ki7ZMhywpY4+pL4T3b4CphcTvat/tPS0aEiEpU+loJpdPaCKBXxPHWn3ot?= =?us-ascii?Q?F3CidbxiJCiddsIE5VoDHfegpyxAXbrniejfBSICb/XNxLNjA6S1+tYDfkla?= =?us-ascii?Q?MA5mHQQRS61MXuOKHMehw/GngvMG8tx77tlEf6OHETj5zo3bwZrXJCn37dAU?= =?us-ascii?Q?0/rNzP4PRDNwNLg4OIyd2fo6qy/IF0jPz0WHuKmYliOBchjoW+/rrzrYjOIk?= =?us-ascii?Q?P3MssYwuFV9xOG+flZYSJHhx6j0Qked/b+Gk5bhKCnADiOisMm4TIrnsE6sW?= =?us-ascii?Q?qpN4+BTUYKiIk7ZuxaCvPQbxDtqFRiQ3IU9UA4IEzV9P/0GEAmJdt7EV8+aU?= =?us-ascii?Q?+NkCRKkVq1tcHEJsWJpXpGEE74itkADjUo/L2fOcws8X/FV+c3J/TrH+UeT8?= =?us-ascii?Q?FIrJ2FYsHjzYme4WP6r8SmB5t4kjDCPjgKwOUUSfvgGfHSF2HuYyVEnZrdrH?= =?us-ascii?Q?jXCrrs2+rSNTiu0B8MvN0uNQGzAueYFLoDdlQMWXefcCtFgsCO5/7Z77T0jF?= =?us-ascii?Q?fJugQuMKnNtkRB8p/ZliRSnhSA5s50mgWVVmxIA9OD1M0bYJHVpaRWnjnJBo?= =?us-ascii?Q?NGakilVwMd8EfJ4Jd1SMx7exrqlktx+gffcVdIzqfrWDulnDZQJ+f1q8bK6f?= =?us-ascii?Q?YGqt/jdE5c810kWWiJOp17BwQ50hpKpUBl09ZxvyoYla5sUqVI3Z05ptptIY?= =?us-ascii?Q?IME2VRJp8VCjid1YpUte6pWkG8JKecK95UtKQ9luvNtGrNsh9ClaHyL8zY+y?= =?us-ascii?Q?OP1y6Bdg86CRv1pHnSXJI+HKXbuDDWuO7+9e02u5xk4X3mi/ULGVmEbw43zt?= =?us-ascii?Q?0Uczcjq+rWkA8ob4bhEpfH+tO2bdXTMbJqBeOpDfzWn9hTcGUG2BHKzHlDWR?= =?us-ascii?Q?/LR2P20ggSzFRrusqWxT1RSsyYLBIrK47YNpnomebqaJTYBGaCd6sbDUQodH?= =?us-ascii?Q?ayJEl4tVaXOuEdoYc31YNRO1leORX4dHqR7jSFRv?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf889b6a-e793-4b9b-5a5b-08ddc00a8401 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 23:35:55.7493 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R5PaqO9S7GV0UAh2dPh3B9OYpF72sbKKcBbJMhrPEvh2lcKJkmf33UfsX9FFVuZDylKEjgFv9ODd/SCcnmhwTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6718 X-Rspam-User: X-Rspamd-Queue-Id: 9655BC0006 X-Rspamd-Server: rspam09 X-Stat-Signature: 6kfym871suaji5y68an91d1wuqp3mzx6 X-HE-Tag: 1752190559-661000 X-HE-Meta: U2FsdGVkX1+i/3CmcKQMNvXt13eMP+dSOfbMYcpkZ0V+DaSFmdQtiefm5bLpjCNfWgjTXHOF+lNs+31QwGgLVKgn0pJNxh4q8vwrhKcpzTHGCoZJuOr/ac4OKNr9kasm/2ma0TpFeREwvuOJMgfaiD9Kx/pqNJKaVVKtukzWIQ2sQKmMuDLK5G/sQNId+TV8DaxFAOc+bPtUkuDTeDYRAEix4iBXvhF1z5CAh5R1OB66AQqG4Wg21bUkkX1+TFjpIRDAQhSv8AkVat6oIGq5jh6SCW40VB0PmA88FZ/3j8xhmWUC9kbTzbLFNU7JytLIQ8OcEswnVkR+CAfuqAJzZ4BGfRTl0m66UhRagiZTWmCjGx2k1bQh7401Vw0Fzr6XSnzY31OVqe/14Pi9+5N7nxeulLNhUEDj8iByAnXvem1QLz8Rp884nMOvidwhU+ANjYVQYZF2iBQ2H73kGCdi54H2wFzd6WyyK7gxyCTzD8JPzA1QeY7POJdUhgR9sPIy4LTOp3k7tjBu93A2ZKdavK/kFTNL0CcNUSHKRayki5eF6osLV2iLUTcrsak2w/vqADcv2BVhvxhi9dmAqFq65uW90V152sdCodFPasNbG9OLmOVsFNMXQEKzFFSjevvU2AJXRJQ8lUe5iS6uNUjAV1JVFQ8PNyTQxJHCWBOgMaXRdBCEUKcikvtlT5qCuRsJl84VP3iBkHxWUXlw2QjTOVLjXd+9bSyudpemf7H9NWn80QEp2/+kh4QNGbb0PXTs24uXEkiDxZiuQNyCriHYRg2/1nN+Gnt+N1WDi0J4xv2PCxaoXV9ijOUiys+FWIi2wJSXTzn//wxwNATvQx8rYqWAXWhUZTph1uOktkiANpRGOqZ79Y00ZdSfWjHkfMP0Ivwx6PLBoxhUxX6RU5GTPKqbQs6eyhF56K348cuc+062Acwg4PJFB+WAg+VRPTmCm/SvP8YI4oZ20hd2kaN vKiVkwoT OxMRBwJt1Zv6Md4/Bn3aLFiF9h26p2+QdyvgXFFcRgz5FwqVhImrKkCeG+HW6AnHBY4Hpu2qG6kK5KdZuyHX0W9IVRPpYq8CmlGSFeqTCbqcqDb0I4IJHSmkZW/ylAXdDm5J/MYGFudO0cnAmQKASxT3bVLWMm1GJB3eGhBampm+JItX9prDU6jza1F1QaPr852iVrQ78k7OQqRDS10ihDDPcUndIjaVpevQWywh77qZV3xsYjzIAS2xPTdPvIq9Pgvb2BFXzeQY6SKniRVHz7QaBohD9pagf20E2sSvq8caZHndUv6IA2uv1crg7mq12Sk1ZoklA8pd+k1cuXgJDOftVLD5oEnnSMYw2fTrj066TI1Oe/+/i6P453pW3475jRg11/hXKlHbwqZdbM09M86KA29Jjfe949RgMkp9lV6Co8pRy6GtJ06GgIu0yR5/xrF3Qabta0ENFZH+f8zIFfIw54nqzDesVFQxdfGhwhbgimXJ792J9ePAuGJKGiCObWhJ1Qg7G9bsaZmaEF040vbQ8IbmNjGkkHJSVyPZYB3tgfoeSFfwT4LXxq+V0pUYzTAKwtLARzcg1RX27EsOvbJ70Os+Wvibcc6Sii7DAoDq8sDGJxha4NF0dSwcQcp/2sE3EmLxnHmPVWUw1PmqHfqYUng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Shouldn't the Fixes tag be for the commit that introduced the #ifdeffery in the first place? Ie: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX backed filesystem") As far as I can tell that is what would have introduced the warning. Other than that it looks good though so feel free to add: Reviewed-by: Alistair Popple On Thu, Jul 10, 2025 at 11:23:53AM +0300, Andy Shevchenko wrote: > When pmd_to_hmm_pfn_flags() is unused, it prevents kernel builds with clang, > `make W=1` and CONFIG_TRANSPARENT_HUGEPAGE=n: > > mm/hmm.c:186:29: warning: unused function 'pmd_to_hmm_pfn_flags' [-Wunused-function] > > Fix this by moving the function to the respective existing ifdeffery > for its the only user. > > See also: > > 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build") > > Fixes: 9d3973d60f0a ("mm/hmm: cleanup the hmm_vma_handle_pmd stub") > Signed-off-by: Andy Shevchenko > --- > > v2: fixed Subject prefix > > mm/hmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hmm.c b/mm/hmm.c > index e8b26aa838b9..015ab243f081 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -183,6 +183,7 @@ static inline unsigned long hmm_pfn_flags_order(unsigned long order) > return order << HMM_PFN_ORDER_SHIFT; > } > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > static inline unsigned long pmd_to_hmm_pfn_flags(struct hmm_range *range, > pmd_t pmd) > { > @@ -193,7 +194,6 @@ static inline unsigned long pmd_to_hmm_pfn_flags(struct hmm_range *range, > hmm_pfn_flags_order(PMD_SHIFT - PAGE_SHIFT); > } > > -#ifdef CONFIG_TRANSPARENT_HUGEPAGE > static int hmm_vma_handle_pmd(struct mm_walk *walk, unsigned long addr, > unsigned long end, unsigned long hmm_pfns[], > pmd_t pmd) > -- > 2.47.2 > >