From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DCDC369A2 for ; Fri, 11 Apr 2025 17:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD34F680013; Fri, 11 Apr 2025 13:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D822868000F; Fri, 11 Apr 2025 13:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4A6C680013; Fri, 11 Apr 2025 13:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A6CE068000F for ; Fri, 11 Apr 2025 13:12:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D9632140627 for ; Fri, 11 Apr 2025 17:12:02 +0000 (UTC) X-FDA: 83322405684.25.C0B3407 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf10.hostedemail.com (Postfix) with ESMTP id DE206C000E for ; Fri, 11 Apr 2025 17:12:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FOZAYpFx; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744391521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TrunUqs/N09Jqukhxf1FYqRGiAYPy6gzssLwyfD3SEQ=; b=WwWbN/UIB4sdu/U+7fbPaWe3NWavMqDwqPiYv+inZv3rXrj7hvoGQoqP545qDlXCe7Dnex cL4KCo4vGWiDkK4U8EWymRBkbqNJi3qbuwAOxamNIn5ga5KEyE1yzBlb9vjKKrUGLbGoYd YCxAAfYdJ89Zh3kP31PqtPHC8ZKn+go= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FOZAYpFx; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744391521; a=rsa-sha256; cv=none; b=lsoKy+uWIlF0u8tegda0ReD2Q4UMT2ES8N5+bXvQiWuiZEQ8mfFN3jCXS39SdsA4K6RMvX LfWo30nMpAM2LHx38I8g1UKTbu9SXwrSRKxceKlHQEGvXzzitxt2KPg+w6+sZwbyhWtebV J6xqJXLs158n1kPM2r00wecNs27xvSc= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so23606315e9.1 for ; Fri, 11 Apr 2025 10:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744391519; x=1744996319; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TrunUqs/N09Jqukhxf1FYqRGiAYPy6gzssLwyfD3SEQ=; b=FOZAYpFxQHTLUubCOm8sN30b+EXSmfbfwQhO5HteQUBW/w0OGZPerBBAg6Bh/9Bqt9 tUq0rOvuI5Kb5LzsK6+QLyHb/IWBw4jhrPeEtSAI8rY+ePZm2InG6xp6EI6eqAVefPg9 S9/Gn8YxfmEkWmngxPdyspPwxUZqifLTzWHQamK08mMSw3R1+jGYt2Sqn1F05ekcoLR+ DMZ0JEnpMIv3ADnYielYwiJU2Eqbx7rpHoXtMpiR1ZLT5KYhhICzyOvP+a3f4XuuyDRJ tY851VODF85rkLnRCRFmWCXF7cNI8wHKqUW87zD7x2oUpduDdPUtOS3nqm2PbhN9ngw4 sJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744391519; x=1744996319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TrunUqs/N09Jqukhxf1FYqRGiAYPy6gzssLwyfD3SEQ=; b=mEmqpxB85BgRhLyh018otxXj0gA/e5D1FYLyeynmJAMj8LyZ2pBaIvEd0KtWEL+OUQ SXtK+aMgQ5C7kfYXB2wpCgboSH3r5nBOAM2tdCti/ei66b9Iu5cTMW6jtlhdSXxFUeOL Go65B4QHiyzCAaoVBjnXB85abH2QIFd/L5kYabpSVlNbWFAYYGhxA3WC6G2UJnw44dop 2W0kU75R8T79XHP1YFUxXo3demnjVbd1P2F20+Cp4Ss4JqZ3g3EELIcH1QYvyitMnbC3 I1ulKpR1GNPihneuRTSWqY8i1RecLRdss1y7QYN1yoxX/zoaxiE+Op3u0qR2D3RXnZ2y C5UA== X-Forwarded-Encrypted: i=1; AJvYcCW5WAjmkjZubJlIpK0djtXJg4M8vvlcl7n7KRxGJoj3iQ9IAgwOuO1eOBVe7Q5eCEh1BotH3ARSTQ==@kvack.org X-Gm-Message-State: AOJu0YwYhxy4x15RC/TT96neCg9QLkLmm0yjUx5yXpZvGwF3YWoVo1rl 6Sybvcc4Fs66D5igTeUvLkMBpVIxNELt68UcAPpv40LM4aJA2PimchJcfSdX1UQ= X-Gm-Gg: ASbGncuN8oNhsXm+MM7wcC/22/r4+XcULfA9Ri0iIsi5vAAIpwgxcMCq4fYPaBWmrYd XTTGELW/8AyhM/qxhB9evAgqAPBShJO4RHbm6PZolAlT6MOqCM7yM6pppsfao0dXlybZtrWudfk +SescQGOqQOPtOFW5201QnKNjGP6nnw0cxkeV7FpRa8S9zw+znZn/IcZyAh2L8qC3YJKH3BUX1h YRYOTdKD5GVd86OZWWdq4bPkB1NWINIm6Nifhs7nZhW7Th+PGYTg6iytLy8t3PrX0kY3GHhN3Rs 4vwT5q0Gcvmo7/tIDl8MvqFNJouuHHYJHqeqOAzrMfQ= X-Google-Smtp-Source: AGHT+IH0dLGja95QCcgcHh1wVVB1WPemcJDZs2T8C3sybPrHDMiiHlmMWJ7oUMDbKCpkKMWyzNOAAw== X-Received: by 2002:a05:600c:3ca1:b0:43d:186d:a4bf with SMTP id 5b1f17b1804b1-43f39420017mr32333865e9.0.1744391519127; Fri, 11 Apr 2025 10:11:59 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f235a5e9dsm92843575e9.36.2025.04.11.10.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 10:11:58 -0700 (PDT) Date: Fri, 11 Apr 2025 19:11:57 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-ID: References: <20250407162316.1434714-1-longman@redhat.com> <20250407162316.1434714-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t3lluon3t4cqfa5a" Content-Disposition: inline In-Reply-To: <20250407162316.1434714-2-longman@redhat.com> X-Rspamd-Queue-Id: DE206C000E X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: gztr35tcnyx7dxzutcgf58q14u4c4tcs X-HE-Tag: 1744391520-648914 X-HE-Meta: U2FsdGVkX1+bPjk29bIoACv2SPA8GLCemX5iki2ujT1zDCk5tbwVWr4RUknezBBbYyMAtAChwrTc0oiX5MTooGAR83WbPvm/TsWkp5tKITZSSPMaGj4DEY/S+zxZLXUiiIFVaklREoU76vqWWMXjd/gfKS84DOx+1iGBTUkSsbENAPmOc/Kr3J3m8y/CAH0LcKC5WC0HyfQ3YS5KgqFsTwzQr+enQtIjWsyx3XQAX01uCA3kauwko+2AqXFgZ7BmzL3f1J9y1tX6jc/eg83NddC37kGE5CeMDnz6WnaMlagJSMVe4IyP2bqM+xdX0yFYi0MLEYFNQU6no6AsHUiKdrf/mk2UlDxg7rdPgP2W5HHVAiPhtLeRf8UgXQIi2ZlrqV6BXJY7nPjC4oXLxBHsC3w/MSH3TzQd2VZcJq0NSU7LbsLhIFxTLh+8lR2ubf3PoBB4XWJweng2mR2+n3mahVsmzXe1n7r6IbYKAThYT0m0VpricEqBrDfpGMs3bCTjQSrVi9hDkSFEeBBt91Aen3y3jdsnmu0EN1BCZDYFB/U/YHqo/aY+qaEUFPyiVknb/XC24YM0+SUenBGYWLRZGtRX4UvmPQZ1vUNIYpMZ8itM9iiADsmMFSff/cxeiYWfDMLYoV/c8qK4YdWboFXDVIQf3O9g0qTiGVfzKrae454vDuQx5Oh6nPtyEaj+1TTz8w1fNrf/wdFdG7U/Vb4m3fsDGLY+4QOfFBaAUDib7fSrNr6byAUtA2fP4AzjzbxRS67htSvuWtXCbruCYTgJ3DHVCWCicRi7hRueH3c7OUbeGaTRXyqYDDuMhKw5w8ZLHEy6ZRA7Fd+dPZ7v3DOSmN32mZcTthtbn41K0goKf5laS+M0iYBtKO+0Ck6xYwL2D0Y1UzR+Pyr/buc2N21caq4mhxiVs6z3a/6ctKh6Rvllux0tTfHHvYecOGzmz09SO/Y+85whqniD04w98wp gxZvC7Ry LvOwf3yYixG/ljIIOASWCfPBJkKkcSZJPY44JCD2irX33VfN8ubY/ZO75jmXppax7EKXk44xWioUk33/6km66j1flG5kUA1mo8GB7O6vY89ttFiuya47LMVsj16UKND6FNqr61VmYlRJ3ifeCN5F4GKoWK9JcEE8I1l2Et6xNjHEAzESIoPXuSEDxEaUk7RyBRWK2nf12CKwv6/bBj0rsPMJDomWQz7jFqTColGPHCFTEcBQh5tlQ34gEOP55wWny8hF6YIGIzobXTaJTwOBt9lKGlNJaQP/MdHBJg8Fxq2VJjHlxN5GXnUUmY2u8Z4e2FVd1oMzLLY7zYeTOlu2jVj5Ho/o5rLZ20i0rjYwpqMCLfXKbMlKM1l5rGHyvAtEnJTav+ZEv4IStE46PdzIdB4J/wFH8vYoiSl+pDiwp22eOfoVHG7crvszpIQCV34YRBEnenzAG24vdVVN/W2ELgnDFf8lJC/TovE1in3KcZnODhcpg+tdARdgOvYKWG2cAHdfl/9h2CFAHQ9eSa4UlgiulS5wQfHlmj5NYk3n2Z6fz9IljFnyECCW69wSRAyIwXSUe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --t3lluon3t4cqfa5a Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() MIME-Version: 1.0 Hello. On Mon, Apr 07, 2025 at 12:23:15PM -0400, Waiman Long = wrote: > --- a/mm/memcontrol-v1.h > +++ b/mm/memcontrol-v1.h > @@ -22,8 +22,6 @@ > iter !=3D NULL; \ > iter =3D mem_cgroup_iter(NULL, iter, NULL)) > =20 > -unsigned long mem_cgroup_usage(struct mem_cgroup *memcg, bool swap); > - Hm, maybe keep it for v1 only where mem_cgroup_usage has meaning for memsw (i.e. do the opposite and move the function definition to -v1.c). > void drain_all_stock(struct mem_cgroup *root_memcg); > =20 > unsigned long memcg_events(struct mem_cgroup *memcg, int event); > diff --git a/mm/vmscan.c b/mm/vmscan.c > index b620d74b0f66..a771a0145a12 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -5963,6 +5963,10 @@ static void shrink_node_memcgs(pg_data_t *pgdat, s= truct scan_control *sc) > =20 > mem_cgroup_calculate_protection(target_memcg, memcg); > =20 > + /* Skip memcg with no usage */ > + if (!mem_cgroup_usage(memcg, false)) > + continue; > + (Not only for v2), there is mem_cgroup_size() for this purpose (already used in mm/vmscan.c). > if (mem_cgroup_below_min(target_memcg, memcg)) { > /* > * Hard protection. > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/tes= ting/selftests/cgroup/test_memcontrol.c > index 16f5d74ae762..bab826b6b7b0 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -525,8 +525,13 @@ static int test_memcg_protection(const char *root, b= ool min) > goto cleanup; > } > =20 > + /* > + * Child 2 has memory.low=3D0, but some low protection is still being > + * distributed down from its parent with memory.low=3D50M. So the low > + * event count will be non-zero. > + */ > for (i =3D 0; i < ARRAY_SIZE(children); i++) { > - int no_low_events_index =3D 1; > + int no_low_events_index =3D 2; See suggestion in https://lore.kernel.org/lkml/awgbdn6gwnj4kfaezsorvopgsdyoty3yahdeanqvoxstz2= w2ke@xc3sv43elkz5/ HTH, Michal --t3lluon3t4cqfa5a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/lNWgAKCRAt3Wney77B SQOUAQCqcf+/VLJ4QspbjJmrhi+j/ZGy+0Ms5yQ2UA3mfz96vAD+NYpSXSOXiT1r 0oyHlNs+QwiydZG2ffDsveeh1dl2ZAQ= =eMQ9 -----END PGP SIGNATURE----- --t3lluon3t4cqfa5a--