From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D31C021B1 for ; Thu, 20 Feb 2025 17:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 778A8280311; Thu, 20 Feb 2025 12:50:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 729302802C6; Thu, 20 Feb 2025 12:50:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6178B280311; Thu, 20 Feb 2025 12:50:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3EC512802C6 for ; Thu, 20 Feb 2025 12:50:45 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BCBB882791 for ; Thu, 20 Feb 2025 17:50:44 +0000 (UTC) X-FDA: 83141063208.07.DBD52DE Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf09.hostedemail.com (Postfix) with ESMTP id A03E8140011 for ; Thu, 20 Feb 2025 17:50:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OcGyZc8b; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740073843; a=rsa-sha256; cv=none; b=Rm0kcu+iobJDjfcPwJvU2zu95mK78asoLdSgWPWB+YEGouaya34LDg3eOv13xL66ON5Q0g IGBj3M/6lLsSRqSwPKnhlrrgpHvvjhVqWYwxP5T1Xp39WH8IF89qKy+6ZPGGoiIShnTKSJ UnGHBU7lVs6Fh+KcaOY/TqMwZhmxuD8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=OcGyZc8b; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740073843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q3hNmWXaYqJ7DNShWqhafehExg8veM1WntvF4qk2DYc=; b=CqT+YXJEoozktsxIOeKteRbEMNkjzqQ4Cvn2sJ1BWyw0gjV8CCptl8y+nkOMEkEDki2szq YJapy1D+72laXvyrNigQmb28hJj1uHxsGYcdqV7F3jAnI4p9fu7pjF9SxIzyPbfYpuEYXG TLO6MsHZL4OgenGJPLDV4uyblC+myIQ= Date: Thu, 20 Feb 2025 09:50:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740073840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q3hNmWXaYqJ7DNShWqhafehExg8veM1WntvF4qk2DYc=; b=OcGyZc8bNh1odFKW/O6xskh1aVp4KMre9lMHAlYzUzLbbYlqq0YY+FEWMRr1ziayt4xld0 Tuu//lASiV11DJP5pmlXU3i9OY6cMnIV6MjqKu7yfvkkE88XbBlMJCIMyzL+9zDJ+fIQdv bNsnXlVeha7MrBOPn0q0yLfSgv/exLc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 04/11] cgroup: introduce cgroup_rstat_ops Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-5-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-5-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A03E8140011 X-Stat-Signature: e3jto8rsczpbyuom4brwotkk4okhw1n7 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740073842-991633 X-HE-Meta: U2FsdGVkX18tyWzJQZ/XLCnPVTSjb0qWkYGsLFxN0DalCPeIW1chZTgobUIVs0YG06USs/JcjiJNBO4OUBCCW8vHNRI+JH3G2BERFBaUWcGXWKCyrLwEovDw0HopdUa2XIHvDHEW1tYSyIpR/zOvA6Qa8v0IA/PAxr3QUXT1/xWcPdx8TliaNyqGY+csN5x7tuhZT94czRQDSQ4PJOOyAi3XdMmQBLFBJogNCUMkqrnegBU2sgRREgumVDz5bAXzT7Yam9j49kJyJxgWsBuGI9yNGoEay3fBD/41R3h54c+LphMt2j1YM2DrbAzCxDlEc16jEBoA5jU7GNua9PknBnzQ0npQsX5vkGBWs1qWssMXAz7MQZR5JkL68wJhVuad1UtZ5LqJtK2ChTS4mlhcdMPV+yt8ylZdvrXUqKKxpODXQjkawQ/W4yda2RkdRpJKAKJjON5iEjRDuKohgaDrUTi9FjjM/CkdU8dqqvrGsvmX3rVwYpcJBUJHJd/xWzD7ZQEDgvs0GP9xSm1VJMbAfBltEBbay6moBd6F/eyTTKw7pvJ1RvZH6WTqyOxP3DviJOnuhD/pSMmEVCGdQPyMcqNf/5w5eyqftJZdC8lFLr9mjW1psM+rHehEWjuqIaIGeqrJZ98q7a8RjhJBfD5PpOYUdMLUJHrizxCXF8RBe3GSw0H8kFrM71Ev/UgWjhiuehpkGKh6MLfx2EziMQG02GWr2mU0IB/0SQ1dhbY9uUimwYcNMi7d9p0o4GfD75F/bXKJRqNpqsQ9E8RDfthspG1s/DXhwED823jiLCVwxcXw/EbAuO65m40J0Fur9BNawCXLo6gE8MjWzyZgUmngj8miZRhO7Nr84/p0hn2+W5dqOl1DSru8e///z0oS8wNQ6+CHmlB6K0TDOtMqBAJUwcWsQNM7OV30jJ0QhKSiKZoExpH59uV1BltySFZqhaRyLUl/e9Xg60U2U9Rz1UL T74Wvu37 taTNzcJxUsLZFz0bCgiFa42ORDez1N79sMn9x2PcVz4BUEtOSugs6NRA24NmRi3gNTfZS4/TYah04QzB2XyrHnBGMqXyUr3gDOX9WELG34U/EbB8G+FfOtrsvRCXj7nDTAIl4FUito30Z5t078hIe7nZYe02oion/zKuhl3cp5A1vreXvc9JgnbP/y4aCpW9ByxHfXBubp9qoXcrP0Jmt+Hl3xsJzPmchoAuG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:41PM -0800, JP Kobryn wrote: > The cgroup_rstat_ops interface provides a way for type-specific > operations to be hidden from the common rstat operations. Use it to > decouple the cgroup_subsys_type from within the internal rstat > updated/flush routines. The new ops interface allows for greater > extensibility in terms of future changes. i.e. public updated/flush Here you might need to be explicit what future changes. Will all controllers using rstat require this ops interface or some of them?