From: Shakeel Butt <shakeel.butt@linux.dev>
To: Suren Baghdasaryan <surenb@google.com>
Cc: vbabka@suse.cz, akpm@linux-foundation.org, cl@gentwo.org,
rientjes@google.com, roman.gushchin@linux.dev,
harry.yoo@oracle.com, alexei.starovoitov@gmail.com,
usamaarif642@gmail.com, 00107082@163.com, souravpanda@google.com,
kent.overstreet@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] slab: prevent warnings when slab obj_exts vector allocation fails
Date: Mon, 15 Sep 2025 13:14:52 -0700 [thread overview]
Message-ID: <wb63gbfs3x7hyhy6kzkg5ggn4mgngwrumkpvkg4fg2ju7oeg35@2ls4eggjpfqv> (raw)
In-Reply-To: <20250915200918.3855580-2-surenb@google.com>
On Mon, Sep 15, 2025 at 01:09:17PM -0700, Suren Baghdasaryan wrote:
> When object extension vector allocation fails, we set slab->obj_exts to
> OBJEXTS_ALLOC_FAIL to indicate the failure. Later, once the vector is
> successfully allocated, we will use this flag to mark codetag references
> stored in that vector as empty to avoid codetag warnings.
>
> slab_obj_exts() used to retrieve the slab->obj_exts vector pointer checks
> slab->obj_exts for being either NULL or a pointer with MEMCG_DATA_OBJEXTS
> bit set. However it does not handle the case when slab->obj_exts equals
> OBJEXTS_ALLOC_FAIL. Add the missing condition to avoid extra warning.
>
> Fixes: 09c46563ff6d ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations")
> Reported-by: Shakeel Butt <shakeel.butt@linux.dev>
> Closes: https://lore.kernel.org/all/jftidhymri2af5u3xtcqry3cfu6aqzte3uzlznhlaylgrdztsi@5vpjnzpsemf5/
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Cc: stable@vger.kernel.org # v6.10+
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
next prev parent reply other threads:[~2025-09-15 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 20:09 [PATCH 0/2] fixes for slab->obj_exts allocation failure handling Suren Baghdasaryan
2025-09-15 20:09 ` [PATCH 1/2] slab: prevent warnings when slab obj_exts vector allocation fails Suren Baghdasaryan
2025-09-15 20:14 ` Shakeel Butt [this message]
2025-09-15 20:09 ` [PATCH 2/2] slab: mark slab->obj_exts allocation failures unconditionally Suren Baghdasaryan
2025-09-15 20:15 ` Shakeel Butt
2025-09-16 12:35 ` [PATCH 0/2] fixes for slab->obj_exts allocation failure handling Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wb63gbfs3x7hyhy6kzkg5ggn4mgngwrumkpvkg4fg2ju7oeg35@2ls4eggjpfqv \
--to=shakeel.butt@linux.dev \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=souravpanda@google.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox