From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15DDC282DE for ; Thu, 13 Mar 2025 14:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92665280003; Thu, 13 Mar 2025 10:42:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6C6280002; Thu, 13 Mar 2025 10:42:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79FA7280003; Thu, 13 Mar 2025 10:42:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 607AD280002 for ; Thu, 13 Mar 2025 10:42:18 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 93D71120140 for ; Thu, 13 Mar 2025 14:42:20 +0000 (UTC) X-FDA: 83216793240.21.2D77D61 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 3C1AB8000C for ; Thu, 13 Mar 2025 14:42:18 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gMOxHgHR; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741876938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4RAcdHWt51v7tLhIYkLYH4BzZK7GOF69Cz3Sw2ySJM=; b=i6gIGTe5il9Qq6FWRnNo/fbG+MIMI/AEmIwd3+VRYaHa3xvfFAgSVQrojEX8I53AbS57o5 m9qeDgXiidmNdCnZMiELZhN/A+/p/swaj/UwnuGFOmp08Wf0VikjtXSVWy4/cp0T4oL8QL 4jgsNZyJA+74xoWk+xPGFfud+3s14dA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gMOxHgHR; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741876938; a=rsa-sha256; cv=none; b=bYXUqg7v9+rg9JU41yt0mkxQ5C61olyqfQ2qXO8A2CDS/U2gm1dFV3Yk3uWWjsPOQLTYY8 jc8O/ww/KgV1wMqKvPU3MWktJ5d1v+NCaQzmuHJoCA0J7rwqKnGRiKtK5Xd0hNX2KitK1U HClj2tKAxCJcR6cfBAoh/c9Shcv1rK8= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22349bb8605so22872215ad.0 for ; Thu, 13 Mar 2025 07:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741876937; x=1742481737; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h4RAcdHWt51v7tLhIYkLYH4BzZK7GOF69Cz3Sw2ySJM=; b=gMOxHgHRgHJayiSzbolsfSZ/xpqc2eNnN+8wv/2PjQtPPfKZzm8wBQMkL2SbV8QQo7 W71s5rFCLd3rCUv8OQQDAEaX+hYXaL+qscbj1nLxkSdLdCLwvRYJWulpV0DFykKjwM2g bW2b/NOu+3XyYZpdJMiDNtYbfYPr/GEhtHa2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741876937; x=1742481737; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h4RAcdHWt51v7tLhIYkLYH4BzZK7GOF69Cz3Sw2ySJM=; b=Pedqx2DAlz8H6WS4bKObFqNv2PbfB1Gz/aeDQXoMF44RP/oaD1oVI8IY8Wsa/JyUH2 ULKXQVJ5Lpm8Q4dwa1LaSyhFZg0AQxeP5rBhfmgND9GnMW+v03b4moA4kwTXyHwiPEbW upiugjfUhe6kZY5tJGeU8wHKGwsLBbkr2hqOWRy/Wc7Unp8qEjbrs4Elm6aFa9Hm6Ezj mW12QOfu+1pdMpmyfeoS171LCVLdvKjoX02y5GD9XsYlgDrmPuiYfDikxXU98FRfJuPR VBWgDwmL7eFZKJraY3yYVjEYhLrmE+Xt/0ge/IkMeaj1/jsGT5CjfiuSUqp9WgsAPxry EJYQ== X-Forwarded-Encrypted: i=1; AJvYcCWqfgoGaD/KBHUR8H1fgHKKGHmdoCCc04BVzJCEzyRzB9YdeAAkhOmTstzby1rIsuVgHev/ZPaCyA==@kvack.org X-Gm-Message-State: AOJu0Yznjegouks0uen4Pqm4HoXud3C+4nRt5S3OpZsxqJA0c/sqi1q7 Y+mLvrFGMIJBBuyNNYr4ivRvs+ISeU/NmNBgCDnf3rlMz71YB+lULkFv0ttTYA== X-Gm-Gg: ASbGncsP+7BjyDsT89I46Z3yGjGBzFXlBDDrx4AHy4R58IJdsepkXXpaginKrfbEASi tqUT5AS8gXt+IEyVj518RO67AExRpq9GMvwSthIf1lrCOXBFVaWxY6+kFABdtqdgGu0MoCFWRUk rwpbXMJ6b49XsHwsSLNm7FSETRbu7FRoYh4n5OYnaHDuBeubCJ93hlkg4qc9p6nea2GwAt8p7t6 ZNlM7F7/5mpFemtMhLNVKtd+EcIYeoas2HTrQbisp+VGxGFPFUvNQGIpZuiAKgdg//fEXyzi2nz 5Yq+GDWahgxhemm6TWni+2faBvUOfiCCaEc++Z9P44raw00= X-Google-Smtp-Source: AGHT+IFyACEHZ0RRWlOtfXTfMVStznnNSGYCYs2DoBDCthhX0Lr5bmyJsPFokwUzyYi3SjOlpOdoQA== X-Received: by 2002:a17:902:d2c4:b0:21f:4c8b:c514 with SMTP id d9443c01a7336-22428c0f48cmr368059175ad.45.1741876937075; Thu, 13 Mar 2025 07:42:17 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:ef7a:848f:3b9:98dc]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbe884sm13871045ad.185.2025.03.13.07.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 07:42:16 -0700 (PDT) Date: Thu, 13 Mar 2025 23:42:12 +0900 From: Sergey Senozhatsky To: Anastasia Belova Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] mm/zsmalloc: prevent integer overflow in obj_free Message-ID: References: <20250313115147.47418-1-abelova@astralinux.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250313115147.47418-1-abelova@astralinux.ru> X-Rspam-User: X-Rspamd-Queue-Id: 3C1AB8000C X-Rspamd-Server: rspam03 X-Stat-Signature: wj3jzsmuf7kjixj36ytriunrgm8zd4z1 X-HE-Tag: 1741876938-395244 X-HE-Meta: U2FsdGVkX1+EaYkeEltGiqWu2Wf4Rt7wLFqZ4uL5nHoff8S7N2deLB0Yz4FDTeM9zHG2ajgpMOw8uySuIw3ycMaHlrnqT1oIQkeWlGSjafNWHuV3rlt2H/U5NOPZ/MCyAFug+VPgyKML6s+PDzyrI919D+3IWogJmnKtFfoeWWwDcBmk/2Wskyj9A77cydxUsTvGgVwylUOxH73g4ZDvny/kO/4LaDT2gkOtHQLd3ugxiZDkUxqQ7RCTH8U/kD1L1jdJT9VNkHQfbbQKy5ii6a3j01rdmwyiwiVT6XHt3VtVVWziljC1xoZajq47xvvvUztQuYCbTfiKrwu42a/O/I9SzRlFuakz3hZFz80drNGAuBWWoZQheP4jHsV0p+5Og36OqqlwXTHdhf9EQXtv+uyxVVpZ6wNt0N74b1FitN5xjUni8LP7Yxc/Sz1/ctl4ddHR0yw2KZq4tZqoc6labo3JdhFHcKSVRSNqNj9a4y2ZAIIkBBTSjsIrQ4G2uUE0pk0Cotwo/cl0rtuDWA2Z7su0JS4XhRejEXgvUcWntUjaSuUZ2WXyDEs6LJ7Uwqp3F8kdJaRVrzVWIV3Uhu9peEClThLo+pyEU7ZqeopA33Zv0+jnudwW+BZpdwlZsFj3gpxeTzxvBkL06Sq89mtfkqFC5zgVskRXCnxoBJqJ3Gv6GCEUu8TYMkhhVe9KP1Yl+lN7ozJaDV611OaIQvSHjeCa2Z9zGwc8ookyVcWZLzDG6jxs5dvTe7wDNZhHoHwv73UYJS653tf6p85NHwBVCP/OpXZFnpuqeIC1jprGDFzugrzvZ1uSOPNztf+PD8BVXBKJaGZJHbZyOUKz7OLhBJFQi57P8Uo6as7wwKx5tOCn+RBUDnn4DCUucX+71s+W8k2YolRMSm5790duWIuuV9cISSouZr6wLtuZDLNUOryRx0zz8X3TBIbfvtXecObDGoapQtxNJxXfcQxGYlH psbnxoMc guRx5NVybCVOEwL4o0+WxGUbUA314xO8qASP3qv7fDnS8ndNICsJwTZ/u247813E2w0WBSwqRQEWpvuo4MN82bT8YqbGykRvTq4yZs72M47vNeWT+faUaSZggw8hsruU2TMe7Bp3TeTbJuA4q4NVxfdXVrzbn7Po50mo8IjVqdxqIE6sJkK//Qx0fNTyz9dNQrs49DbMUs1GmdsN2gdpAVVYEaBy9Xec888nTi2Zy7DOgGlzJoBX12ZajSY7MEvJ3AcUOvcI4ZC3H8gv0XMNCB8+NwI0lNLySzj8HKNODJWJay8onN/M3nEdK9jnZ94dwmeKCp1OUT+4L1L8/k1aSUZpoEkQ9IBmjtPlT9GT/gykqzPmAQEr0hqxKzNkUqENaveE3XBLTDa3LtyWMmQWVWc3m5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006797, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/13 14:51), Anastasia Belova wrote: > The result of multiplication of class_size and f_objidx > may not fit unsigned integer. Add explicit casting to > unsigned long to prevent integer overflow. I can't see how this can be possible. Neither size_class nor object idx can take values to cause mul overflow.