From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6798C4345F for ; Thu, 25 Apr 2024 20:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675FA6B0087; Thu, 25 Apr 2024 16:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 625FC6B0088; Thu, 25 Apr 2024 16:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 515666B0089; Thu, 25 Apr 2024 16:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34C836B0087 for ; Thu, 25 Apr 2024 16:46:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E4B1EA12C6 for ; Thu, 25 Apr 2024 20:46:01 +0000 (UTC) X-FDA: 82049236122.27.B700B1F Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf24.hostedemail.com (Postfix) with ESMTP id 207ED18000E for ; Thu, 25 Apr 2024 20:45:58 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PvQQ5M0Z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714077959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCNQR7qh6mKa3nVisqBeesg40dkL9Xi0s9DR3CFmfjE=; b=gOPsvz1IhoGcok2tbR0MSqjqwYzDkwfOC/iOPTHlu9gYZ4xKU2DqTar7QrD0dCEprytr1X ijQX6OFCC72Ift41Gcwi7fnX53pMRShSGUyHsKo065ZOVGjt7TVq3Acix1NYNJLdZQ95rZ r+M8hQCpjrTlEskO93H5WPGHankdktw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PvQQ5M0Z; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714077959; a=rsa-sha256; cv=none; b=dkzbWnMI2+xijy/ad0gFjwz9zlyPrPFwN0+rb5Q4B2CDgLsSqdtHdIVnqJqvac6j5QGU5A q80zu1T5CgEd8kW45t+nGRSYJCZa0z5uM3yNvI7EjynVzqCGT3qG7gzxuuN3URoYLHMaOs HYdx1LGylgAOzIQhqYne9kYutzdR+tY= Date: Thu, 25 Apr 2024 16:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714077956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hCNQR7qh6mKa3nVisqBeesg40dkL9Xi0s9DR3CFmfjE=; b=PvQQ5M0ZSVeu1joht4r0LISgeY+iMhdpXyRwjKxYOyEiUuhklCPcRL8i6+KzTdwuQB0dKW z83Qr+oXUiR+dZVTjEccBT+eJixfokS282a5PTxB/Y7He3oNMshdaoJa/6U8fz5ErJp0iW KJC5m2zK6++SrrlzeEflctZcCcC3T6c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Suren Baghdasaryan , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo Message-ID: References: <20240425200844.work.184-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425200844.work.184-kees@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 207ED18000E X-Rspam-User: X-Stat-Signature: 9ranx6rgwmft7bsdwfuo63ikoi113yf4 X-HE-Tag: 1714077958-774682 X-HE-Meta: U2FsdGVkX1/eCBb1Ohp58rs48MYl5nAWn5fC2lVKlEvJOCZTGdVMgS950LT/+dq58XaKKaXptyuUXYVCHnMAU71unUCzUBCxygS4trPfR/gDtfNJXle6hwp6uA1po2OCifpPcrVNUF0/pxCbpCeEUeuQs7FePa/PLItznfhMDFGgcObFzEDiOsRc7ed7mIvevnKVxqPMdsAql+RRgUSGZAck9FnCSZZzKUTo+Rj9MW9/88B6lUq/E4OiIZj3i513V24DhuNwZ066+7R0ZO9ffrs/+8khM63dJQiWNrvsnHEuGEmr9GjWHkuQVMSJZNcc5SkeLcPWfNd3lNKyKgrznbnyHjXG+6+GQzhMaZFK6PiHT+rNSHetY9wTAil0J9SAo80Ub9RlDXOxBxeOJIY/x1Hj6OePFQ9TUoeAj0s1PyAZgPc7tbopw7oQ376Ea2bsfZchQ6HHfTi/oIHw1nJFSaLMDkoue1q/xyL/TKJRjfnLNkvori3uvxRKL+PClSKDthK5eAVAZ2BDXO8Ndrj7vHiuMZ/PVoZxalHuFfSrPaP5ZICJJKl7WxS7KS6kKzIuKet9MSBMh/81Fv1QahCME/eXgB8sz3a9MKMbgDkKd/olrNq0PvQPhPTdMurztyEbvzI0gWrHU4Zoua3GTPSQMekFGREhM8utWc5EwCRcy0S/aFoEvKEb07F/AW0lE7Q8nanWIpdWcwBIxzAqd+RhOLUOwuzn7BpJvnFDuI4NODfRiXEzqbv/uQFMUkbs20TNv4v4aN6pZCm2HotzHLPkoz7jBf10YOsqwZlLSpsScFs2ehcqZLkPLBQ4FSzCFACmti5ESWZ52h/pNHZv2N7+Y/BCL/qL27OXl9BdfIA+ad4YhKnJtfE/k6gts779w1pElfgklNPSmzT9TFvZ2GNmqHIrvCfTmuijDEcl1d6xLe4EVgCKj0EzQD1McHYBiG042V9U6DNWTEHfaopXIpB KeMXKebr 0FeL/ayuIBB4GJ8zY1QcAG3os4YO69q5YAXykvRXzmyx/eaUkctUBsrNPi4lla/VNFZvP/gat/7eFU1FlZMzIDgFCZum0oqkjO/+9aIuNs926G1T6+6u7S3DcvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 01:08:50PM -0700, Kees Cook wrote: > The /proc/allocinfo file exposes a tremendous about of information about > kernel build details, memory allocations (obviously), and potentially > even image layout (due to ordering). As this is intended to be consumed > by system owners (like /proc/slabinfo), use the same file permissions as > there: 0400. Err... The side effect of locking down more and more reporting interfaces is that programs that consume those interfaces now have to run as root. That's not what we want.