From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C58BC52D7F for ; Sat, 17 Aug 2024 12:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 742696B042D; Sat, 17 Aug 2024 08:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2706B042E; Sat, 17 Aug 2024 08:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BA336B042F; Sat, 17 Aug 2024 08:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D5486B042D for ; Sat, 17 Aug 2024 08:42:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A77041C2D33 for ; Sat, 17 Aug 2024 12:42:03 +0000 (UTC) X-FDA: 82461699726.28.8CF444E Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf19.hostedemail.com (Postfix) with ESMTP id C32001A0012 for ; Sat, 17 Aug 2024 12:42:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UYZjFITp; spf=pass (imf19.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723898421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28ncRbCpnkLJ5/D26aUzNQlA5NCqwwwLXApZ4Hr03aA=; b=hpGsOPVJewOEJIfFPDuPMo4Nhn5KGhtusud5Hkyqgj6Vy553aPH3N/eNdV5zEBso5aX5H6 VlrdRfmuWA9SaUacJqPKbzsuaSynD0maVGvKd2egQ7h86hqPvSUaL+wzJuX/UCbXMc9gVo 2mXLg0UaiJMPS0tr1bSOzH60x6kWbYs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UYZjFITp; spf=pass (imf19.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723898421; a=rsa-sha256; cv=none; b=rNwOVO/xbF4AWH01OVGLmnPUqQLt/X1uhdtdrtyMYnnydijw7pzgy4gNmAqdukJKIGSSxu gGtW4LljfrnbV2zOsi7hXz/e7pq6s1yDg2WnckErC2GVhMjxfHDwptahp2PeJMl87oR1Ir 5BwLkKW/hSIK0y/UF+ooNs8GgeqH3hE= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-428085a3ad1so23081765e9.1 for ; Sat, 17 Aug 2024 05:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723898520; x=1724503320; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=28ncRbCpnkLJ5/D26aUzNQlA5NCqwwwLXApZ4Hr03aA=; b=UYZjFITpk0R6MFXuNwqNMC+Gt3JBTjNw6tMcO50qUunwoOpfwQLoCI7eEiJR66j10M V9H/3HKVMa64Tj0n9NxUlhuVNZSy4MYitdzjKWtJ50zlP8oileOKQMDzHYZVz7BXkeHR e6IMy0LvoohM/GLncZxERjFTt/K7W+8lnyR+6/jE5K2Pk0FrzE0RiAYE7Wo2k5XBDKIw PTpBle2cRMgiOw+Rh6y4X+ZwLOHaTiucHxGCPd2JFalm5R9QzrfdDkITwQ4M1PRRscoT uSf2QWTMgPxc3cBamlRKPE0L/sfnGZFpUEM4Ca0qVqvgZwwjJBHY8x4wXmmiibeb34WH /1zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723898520; x=1724503320; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=28ncRbCpnkLJ5/D26aUzNQlA5NCqwwwLXApZ4Hr03aA=; b=EdFsqLyhpfIHvAFm8YTSB5WRsIJxp57UR1BZwUxAAT+Tvj5LYLhXzEKZEzSr8CeBwD TTNHSPVpHJ/w+QnHf8aG/AWTAREke652D3a5PFSuDnN3aKAfZldyHvyEj437fESN/R/F iDKEHr3wuLpK2eC51pqxVQ2CMnFm8VkaCq+AEQNUYKa9Y5jxT+Ni4tHNmPkTVK2qVcGi VzyLABdtS4Mlptk6/poNAX4LHrlKAbF6Kpfv2zs8NQUcA8jkKrlPJDQmbfensDU+4k88 mExPbHyidpm0dHs8uDlptFNQYicLiQN41MTaQ8GfNRtBbPtDGVC2TfndQPAujSUbFzTC dGDQ== X-Forwarded-Encrypted: i=1; AJvYcCU4IVlWgv5GVr2KFTmG5vxQ44uq9XZDtVFLPUmZtGG552SxMvlb2Kn9b9h97Pq53zMLC5RpaSReHO0aspkHZCjTAsk= X-Gm-Message-State: AOJu0YxPgjMBHxRdgr9JycAPK3ON+pzPTyyRX6PivNQgvv8H7DxoJGxY EwSQbCaXWmQjmAC6afoYN3qp2Mx9TomTTrLKPPWV+70xBpDe0Q0e X-Google-Smtp-Source: AGHT+IF8JcFonXeS5BqsGkaj2afPjHM0G8puSOTREdxaWXTjGQ+eOU2zmGVd5/Y5DyiGsw7uW5UPyQ== X-Received: by 2002:a05:600c:3509:b0:426:6b92:387d with SMTP id 5b1f17b1804b1-429ed7b8860mr41405695e9.21.1723898519944; Sat, 17 Aug 2024 05:41:59 -0700 (PDT) Received: from f (cst-prg-76-86.cust.vodafone.cz. [46.135.76.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429d781047asm117761715e9.0.2024.08.17.05.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Aug 2024 05:41:59 -0700 (PDT) Date: Sat, 17 Aug 2024 14:41:52 +0200 From: Mateusz Guzik To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] ratelimit: convert flags to int to save 8 bytes in size Message-ID: References: <20240817123754.240924-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240817123754.240924-1-mjguzik@gmail.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C32001A0012 X-Stat-Signature: cqe8c54b3spyrqurwjicb5gjr6hxz4d6 X-Rspam-User: X-HE-Tag: 1723898521-439603 X-HE-Meta: U2FsdGVkX1+A36Sck6rZGLHa+AbF4VKYWaAB5J3s0jhE9wiGWdC/l+MNDUhnZLBD/ds0zncUTeB5Fq/4EcDD4PhCapUbwguavw2z/WWUnwXtzsBN0QOIGNU3mHnXUHU+8ov2Kbw68H1wopZ7aIDQlmAJ7DjqUgkULe8CEUJK3mhqkzAW0TbA3l0qjxz/xC1lIcPkL+lK/+435j1it2733H8y98xuPvid243h6DVkYq++AdC3M9QmlfiXid24Mj8SbH7AEUd9SuidEwOYa2hNOLLIgvO/PMMny5awAB7tzYqJwF1nszEFd4Em5CfBXhKTc+4DHKRdUrlQEJdtJOJhOlITyF83bfB6AjZA9zLL/ldmz4tn86SoLoPly1y/EaBjLb4wxVCE2KNmzr33JRtez6wv3KbYVbRqOeoWcnPL+VuNh+QDTQISN8LVC4alPQu+FuY3E/UgVlAK9l279qC7o2r4rEZNQBT6wN727T64D15DH/Wgx8wEjF4rNFVvxIEWWwUE9L4R5wnrC11EOfem8d3R6uh8cd5p2Yalg0GITt68CKHFTAb+E03UhSGXK7bz3wSnh7nQYxLJcq2JPQxiax55itwQAj3Hc6lw7gpt8JVCVFnjEoi33bge9EWk00LjgdQ3AaqX/1S0NZMJuXhw2gnmkRqJPYCg42bLORuhBs9jNMKlF2X0zoqoz6RxOcsbJH8DoTYIhjFdHePlajFw8sptfhyjm07sW3uNq38Que72a8B621g4Qo7zViINZjLvuXlXf2Pjm+uACC8+E4vWUhG/OOB1XqK2K9BNTyUUcPlRr5frkq/OZMWqJO5EzIWCmSwRa7sP5LMsq/V8zpSCQDg6BuX7kPpDBmQ6g5K1rCKvxTGt1ge/o3E+3RG7WWfCaSslggsieGOdyGueCSYfCO1SeHzD4+uQPoHLsivNnveZLjPoGKyKwuAz03PwWCeSfHoTlYzzr9NkhqsUOjf xNEyUmcB LsC3HA5MNInICCe6kdAj5HwZdSg8D0GCYVBz0hzuf3t7uBonuKJ0HtXffmjXcsiUTt/i6ZZdybWzOtCR2YfiRVbypdtbyZdssPNh8v5cWV9BAuP3foilHLD5PcWwG9ceOhGaU4hKoOzXLsTiom8Sux5+quN6Qz+3uhYUtbHukzHl1xhgWpUr0wZSrks4VXNhoCQpSG1nTs1wzmgLhvFWQy1pspSs8Ie7vRUbNnT9YEeSyWCP5JF8EwI4dLPVjJL3vY63RYqV1bSxcJ3JSqflv5GgV8wuEkpkqqSyIBwPL4M4ntVvtljTNThNCLvUB6sifhgHJ+jeTHtH7AwQTePrQuk3xlPdGh2ZMnxP1m8fvZoeOrHphhbDimxtWv5qodvaSG3Il5LGWfy3p3es= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 17, 2024 at 02:37:54PM +0200, Mateusz Guzik wrote: > Only bit 1 is used, making an unsigned long a total overkill. > > This brings it from 64 to 32 bytes, which in turn shrinks user_struct sigh, 40 to 32 bytes of course this is embedded into user_struct, avoidably pushing it past 128 bytes of size > from 136 to 128 bytes. Since the latter is allocated with hwalign, this > means the total usage goes down from 192 to 128 bytes per object. > > No functional changes. > > Signed-off-by: Mateusz Guzik > --- > > ./scripts/get_maintainer.pl --git was most unhelpful showing nothing > > I have no idea who to prod about it, I think it is pretty trivial not > needing any discussion. > > Andrew Morton pulled in some of the changes to the file, so that's my > primary recipient. > > include/linux/ratelimit_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/ratelimit_types.h b/include/linux/ratelimit_types.h > index 002266693e50..765232ce0b5e 100644 > --- a/include/linux/ratelimit_types.h > +++ b/include/linux/ratelimit_types.h > @@ -19,8 +19,8 @@ struct ratelimit_state { > int burst; > int printed; > int missed; > + unsigned int flags; > unsigned long begin; > - unsigned long flags; > }; > > #define RATELIMIT_STATE_INIT_FLAGS(name, interval_init, burst_init, flags_init) { \ > -- > 2.43.0 > >