From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A623BCD128A for ; Sun, 7 Apr 2024 17:01:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24C096B0083; Sun, 7 Apr 2024 13:01:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FC4A6B0085; Sun, 7 Apr 2024 13:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C4A56B0087; Sun, 7 Apr 2024 13:01:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E13D56B0083 for ; Sun, 7 Apr 2024 13:01:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79627A02C4 for ; Sun, 7 Apr 2024 17:01:44 +0000 (UTC) X-FDA: 81983352528.19.386C76B Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf26.hostedemail.com (Postfix) with ESMTP id 8AD15140016 for ; Sun, 7 Apr 2024 17:01:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a735W5ZP; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712509302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HDrRDB/UkXeAYx9XmDkaIFHSFf8yLRfaEqiA1CEB3hs=; b=cn9Zy8Hg/vPePUakQNSAoXGiuzUflV7KYac6GjSiDvIt3saAYeMlIEwaH40FHbKh+Rmk4m 1zaWOdE8OX2zsA6C+xAGfhTIS4zFzc6pVjG9ReiWZYXIBp+8vZ8hrc04nlVdvGYCogk3Am 6DO72q998p4hkZE3v86jz5kEGa1HmQQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=a735W5ZP; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712509302; a=rsa-sha256; cv=none; b=gH59Ung+xGXnEBsEkKu313S0ZsJhdU2ERzkKdYboydTrWmQTyR+kseqr97q09X8odEhYsF t6R5RMaiVMSO2umIDvLc1CbEudSowwsj2N2OuKJU0crXn8ZzEPUCfYRJ6efR1PP6zJxEwX YBQxNJd28sT3arpzQkQYR+PxnbopErk= Date: Sun, 7 Apr 2024 13:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712509300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HDrRDB/UkXeAYx9XmDkaIFHSFf8yLRfaEqiA1CEB3hs=; b=a735W5ZPKTAymghHVTT3RcykxqihE1oC4s8VX1VkaeZJyOC42aMaATXM3RC0h6NbQ0YoMQ FEDdL1ZpSOSnS8FsbH0ZhOMdEFBWZw3TjV+qUXAmlkDvMrR4hHcitgRdLu43lP5PXA+h+n PCtQaNOljcqWCj/zuGpPe+/rViVq8lg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Klara Modin Cc: akpm@linux-foundation.org, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memprofiling: explicitly include irqflags.h in alloc_tag.h Message-ID: References: <20240407133252.173636-1-klarasmodin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240407133252.173636-1-klarasmodin@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8AD15140016 X-Stat-Signature: sxsx5tbcgksqagzrx75uqu4338ckd83z X-Rspam-User: X-HE-Tag: 1712509302-607295 X-HE-Meta: U2FsdGVkX19b/V7Y4xT20F01377sge/Bwg9IJiQC1mVTxa8n0Dl0esyEG1pTbIZ7oGKW71pVNfHvUwnmoRSsJV79ILq0Izv85J6ANKPTDdC+JmW3z4xib9lmd+wnomlchPPuteqL2zP5C5GvCese8ZbO3hIaFuSOnUa1V5aShpRpNbM4y0EjCUwMTFIC1mRO11/6FcF/gOHDBKz4o0d9651oNRywNyhS/QQIx5XErus8r0eeB1kM2nKi44Q2IlmA8SOu803WsMgbo7AMtj5ELo/+NEgOWfmvs6jfIv5aByj2EIh1mjbFo0EBJb+PLy8EuzgLIfPQO7NbUxB6GPvtOb5vD/dO0bzkSxNsXyMmsmxqt0mtWsNTDW22fN+vLuCLIjReseKuUW9aE1JXV/0/6/19eqqZAgCL7unRxhGCUd+leQvjzUpYa2UECTestMC4WeO2VcUr0u7/eH0OM9c92SlyTpJ+5vgv2dqYC4WuoMP5ZrPXHn9XPQU1SLAKHupDYs0lq+9PL7MMUT6bJmvKVEFabyJ+65nLA3OgzIbg6KcU5Isd1ZGYUOKZosGAy7Uv72B/zu1KTTfrGeOKllU+7Kd+i+Yr279yEq0Ljpb7q8vEBnI3SCFfj42HYGpeWu8bGcqS09Y3QufDweOLTa3faCbBz+cOp/+NRjOZLy6MGsOa2DV6Z6Esyq/zThvhY4mh0bqyyiKj2+EZioN0qX2W2rokMew0JziN7XPfNpj81GzoC2ReQfJKucBBvYHeFXnqzfEL7HQxUh7k/H093/LWonlrPJF6CljCfx8Xc2+2TxI+7vk8ZCUp168aXNKqiWZpGn6JWDLEjMnsKf/EuP6nW5xlVgAxy5SLh9hOqPLTEHikAr/UDCc5GhmhiUXSK+d0qg+jhu8OjRyOpt3PNVhIkGOeCg+W5nd57/1AS0iCz21uv+3/ytsgp81Fmw5sq8kGTAour4tfQgD0HJUVe6d rfagqK0s P99gumC8meCfnjQ+vxmWYbDqGKKBXeniGLac92Euh/f6OjTrSJ4Mzf5ANMo5HNI9VeB7AoQaihOMSDhluPlF/NQTcDMwBhtWg4r/fBYStgceyBOFDqUg5/Ygxuk8qrNjAdgzPPZLltsnKDs2s034C0yZQNRd1Jdgwr3TQLMnQSThrTawyGiLWV7MsK53hT3ip8j9nmi4MOhDZSI60ydyqBaVdEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Apr 07, 2024 at 03:32:52PM +0200, Klara Modin wrote: > linux/alloc_tag.h uses the macro this_cpu_inc which eventually expands to: > > #define this_cpu_generic_to_op(pcp, val, op) \ > do { \ > unsigned long __flags; \ > raw_local_irq_save(__flags); \ > raw_cpu_generic_to_op(pcp, val, op); \ > raw_local_irq_restore(__flags); \ > } while (0) > > The macros raw_local_irq_save and raw_local_irq_restore are defined in > linux/irqflags.h which is not included implicitly on all configs. > Therefore, include it explicitly. > > Fixes: ac906a377c67 ("lib: add allocation tagging support for memory allocation profiling") > Link: https://lore.kernel.org/lkml/6b8149f3-80e6-413c-abcb-1925ecda9d8c@gmail.com/ > Signed-off-by: Klara Modin > --- > include/linux/alloc_tag.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h > index e867461585ff..afc9e259a2d3 100644 > --- a/include/linux/alloc_tag.h > +++ b/include/linux/alloc_tag.h > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include Actually, shouldn't this end up in a percpu header? Or was there a problem with that?