From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67E5C6FD1F for ; Tue, 26 Mar 2024 14:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4A96B009E; Tue, 26 Mar 2024 10:54:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A34A6B009F; Tue, 26 Mar 2024 10:54:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 292C46B00A0; Tue, 26 Mar 2024 10:54:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 122536B009E for ; Tue, 26 Mar 2024 10:54:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC616A0CB9 for ; Tue, 26 Mar 2024 14:54:33 +0000 (UTC) X-FDA: 81939486426.12.7EF8724 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf21.hostedemail.com (Postfix) with ESMTP id 354471C0019 for ; Tue, 26 Mar 2024 14:54:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=EkT1s0A3; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711464872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9Q/eCZ6v2bw9iLxiFT4xLPFqiE1zWXHKWDB+B3WRm4=; b=0l2HhhS+rY/7uASjHjq3HKgSJmzZi956n28po7TGHyLTsssqW8wDCwv+LojkrXgEEJPbP8 FU1ub+W+3TXNp3JCwjeDObD+kv7B5QRxlkT55cjXlxD75cRtqq6owzcSXhtJK3+aPN1kcE iOPCWWiusj8Hv2uD90MBn9KP1HNIIPA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=EkT1s0A3; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711464872; a=rsa-sha256; cv=none; b=UJwTbHkK94quBki2dVMRhCcyfvL2bfxE0kYggyMj48w4HAcjhBOjlX/Jwj1niDu5/g1839 UeOfSAPMkRRqAPZJnecBvGMYYWh+6qNc0g2TDa68ECOuUB8dbgLTwJ93H6e+5TN/qyAfDX hEobjip8/U1INIbRrJRg/Ha+9rjqsyI= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4V3t9t6lNtz9sJ6; Tue, 26 Mar 2024 15:54:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1711464867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9Q/eCZ6v2bw9iLxiFT4xLPFqiE1zWXHKWDB+B3WRm4=; b=EkT1s0A3EaBOYWBwVSwGLfqiEHDG+uZDtGtzy/KDIs8RhV5bdRzJ6KwIxFsimklA3dYay8 Fx26NMvyL6DDn/96RqgcluBtZTuDsuRa8L5V4NkAwvogES+w/a2iw6Er9bDSGcDvYqMlje Xzsh0Maj3QqdmaxBE5E04YMK0Gk5ToMq/xkZnjeVSZdWnfkR9+fSs+3tRiy5a8kOJnFWcW wj23r9krEvDL3Jm+zgyUsn1VQ/sAAdLkkBCT8wwUj/le62LJXWnl0Jc6g5xnN1039BO+Fq CpMEW6liJzT26NyWLn2fQPVBhJy7Fu0BwEfDUzYiFlcZD1llT5VvoC4qbL6ePw== Date: Tue, 26 Mar 2024 15:54:22 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, chandan.babu@oracle.com, hare@suse.de, mcgrof@kernel.org, djwong@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@fromorbit.com, akpm@linux-foundation.org, Pankaj Raghav Subject: Re: [PATCH v3 00/11] enable bs > ps in XFS Message-ID: References: <20240313170253.2324812-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 354471C0019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gjtebea88qgjah9bcpt1c5fk4dg7kjgj X-HE-Tag: 1711464871-343684 X-HE-Meta: U2FsdGVkX1/HU6nn7pAYzNpQeYKW/iMi8LXIEW3xau2aXbLuDk8yxeGqsuSLXpqYRMXAPvEC4zpXNNoVnthdwH17qUu8M/2/chbYNV7Y/r2Y/a3A2T36aNCiI43VqiDUI4k9F5HD6BMC+xQJvpvN/uKluMPWkt44/juoOmEFNCRHst9ONBuAYhA7LsNSbLNW9hZS3RL2YtePuKhMBYEPVw9VE1J8th+2ieNx6gOJIoKoBn3iWNEweA+RztKjSEnNoGdHXBdTSd9IGeBOF6b6h42HfRoUfYD+DVuPOMkDjKbv6ux/33CIoWvHwejhlOQnVpt0I1BbDYJgGVu8YN9vXJyuOEEwDHka0QSQlb95Afgz9fbIBz3lOouht4NaJ9rivVLFS4blYQJnV6uTbDumVyZqkRxZt0wf8rscdXBbRqyvBga6/NAdiH7g2JAddC7120ORWi5KVWa+kSYErfhR48MsS4L7WtptuCdlfcr64pbSWn0YFo+/REycJceF+mIhg2/ABLYVkeEujZEG0VOKl/UoPJnG90MxktieY2jikI5k/PvXxnZFCZIokrV7k5S9yj64jmOpF/36NDtsKSY3L6VJ3k4V1emiixh3NfnWoWs1yMsTDBXopm55FQr+ljAO3FPhj2Y+CPkTQZIPqndr2OyvjUJLp+jWF2eIE6EeL9nJuCZh62OVrTIRmpeTyZJ70lLENBfljBHPIkptlIkHv86ib8d/eNwT9gNKONn/5SicuC+bh/roKSPFeqEi4LrzIUrUY3uQvVbvQSJIqv7w/mU3q0Mn/3Otw85ccbBAIZS6GZPusXKYE/vW7mNugvKEwB/zhL6Zw5jmRSk2bCy033C5U/fJjR65KGniZcNIoXvHCjobkBHxhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 07:19:07PM +0000, Matthew Wilcox wrote: > On Wed, Mar 13, 2024 at 06:02:42PM +0100, Pankaj Raghav (Samsung) wrote: > > This is the third version of the series that enables block size > page size > > (Large Block Size) in XFS. The context and motivation can be seen in cover > > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > > if someone would like more context on this effort. > > Thank you. This is a lot better. Thanks. > > I'm still trying to understand your opinion on the contents of the > file_ra_state. Is it supposed to be properly aligned at all times, or > do we work with it in the terms of "desired number of pages" and then > force it to conform to the minimum-block-size reality right at the end? The intention of the patches is to do the latter. Apart from the patch that rounds up file_ra_state->ra_pages, I don't poke file_ra_state anywhere and it is updated only at the end after we enforce minimum-block-size constraint (page_cache_ra_order). > Because you seem to be doing both at various points. Could you elaborate more on where I do both? Maybe I am missing something and I could change it in the next series. The previous series was trying to do both but I intentially stuck to updating the ra_state at the end in this series.