From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA19DD743D2 for ; Wed, 20 Nov 2024 20:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27B1B6B009A; Wed, 20 Nov 2024 15:35:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22BA46B009B; Wed, 20 Nov 2024 15:35:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F3A36B009C; Wed, 20 Nov 2024 15:35:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E30266B009A for ; Wed, 20 Nov 2024 15:35:08 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C41D160FF6 for ; Wed, 20 Nov 2024 20:35:08 +0000 (UTC) X-FDA: 82807626804.18.D497585 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf12.hostedemail.com (Postfix) with ESMTP id 4E0A74001C for ; Wed, 20 Nov 2024 20:34:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pnI+EEGl; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732134703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mQ+UldOQJ74hVwhBLO/PFZ3KBYaMQ8Efc5gouRStEtk=; b=TvDanuPCXhhPMJvG5VlrSsdOiIj+lr4eV5H3wa/xxlZCrh0VK+n4IKwf+waQaOqTJ9YrJ/ EiedzMjUKLh2vpM1yj0BmQwxd5exHVYkX199Oxcn8T2dJ29DNMEUomAbyqy67kQta5MTET bka6XsF+vh/xiSTZ/SbONumdrXWbgrI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pnI+EEGl; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732134703; a=rsa-sha256; cv=none; b=UEVIkOV3CDTQfqXrJ6kltDhuzGP5uPajkASskJkHchBnxBC5aOPRCaF5Cp599v7l7UHG7h dD1HiGy+1kVhcCd8SzV0Jvk/MKk/Oa3z6eq2saSI1PK08mSpnGYgGW5f1PvLYPinnmrfJs L1PA1zS4HPcehiCcBr8XEtzOAW+s+E4= Date: Wed, 20 Nov 2024 15:34:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732134903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mQ+UldOQJ74hVwhBLO/PFZ3KBYaMQ8Efc5gouRStEtk=; b=pnI+EEGlgdXuiT/E/nI52ES+/DEYsd/ShG8CrVHdMOp4CbvYsrIznozRFsYRKEkFbFHwen nlni0gcGsp7UISAyLpJnog8UEF3vpy8kmcqezi15rH+CmYbMl1CNLMgcYcV6Bo3Ia7ZtGS 91ZjuEbZEW8q8lkNMpJ80YZ0UMeXYtU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Shuah Khan Cc: Michal Hocko , Dave Chinner , Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, "conduct@kernel.org" Subject: Re: [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Message-ID: References: <22a3da3d-6bca-48c6-a36f-382feb999374@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22a3da3d-6bca-48c6-a36f-382feb999374@linuxfoundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4E0A74001C X-Stat-Signature: n8ftsjyfzh4kp896knn3r19xn39ipuip X-Rspam-User: X-HE-Tag: 1732134883-551601 X-HE-Meta: U2FsdGVkX1+r7Whq39Pc++rlDMUOUnAMUrxE7naFmrQ20p0shxSVN2ujVGlw97mwoWVS/mBGgJdZGoJxzkN+kpHQDx44U4eVs8tvA5l8yXszYDiQes+F8CdeNvJdrjsHIY0bIWuInTMwmlvlGy9EE1N3ZFCOEZQdqv0+ZzENDb9QIOmgwvo0MOFPFrFbYSZokqEXA4m0lHLgHUQuiX43RAxgaE63Aq49sJacc/xVivjtcMIUvizZ5/tmfIKHvB1pEf1fnOyxNi1S1GsY26kPlFkgEWfTPUaQgMuVtV4xXWmQ73zCcfwN11h2y75VlmXSgni/YmdalmeI4o0gjVOlImUH4WctM0BRPO+NSzk/if3CFwpsXgmpZzNyBKtXsndVZTWrxaQFyOP39zKYyHicEUzbdWAZODvpc7QyYgMP1Sik9/sCVIv4yH88Amm366phGcgAr0ETc4y1gTYP5feMQT4I5dXo9cGF7ExwaeAjb/ax6JqGFyIp2gHrDkguwfGpyT3WAGeFCfTKmWkF15I29/tl1MbV/BB1G6LaN5UGMkfhuaE7Mlvw0FpznAD2yD8ksUfwcNhg8HDAqNm74ILAMvT3yCmrNl/hmuXBWaU7BXW/idysiDOLnrifK3ZplflY6yFOOZv7fDIUdAETqXKklZLpd8NedKdv2+Hx1DAxiBqSYu60eIDdkwwF35yBk1jkKFy6Dc14zNCEQlcxv4EPy9Wf+TRKMWY6iNzRVZJEiF+zywEG2rzPk4uytHGGftpoCzKFWRxgbxaDPo1SXjwFW1WZ1zXjYwpp5/o33Cx4ivIPASeu1YcAiKpBOl1uxdVAPpM4jm/KyAYL5O7XEIEgYfrtRrI34kSWi3AePU0cTjBKOgQg9jWnHdUzktRn4cAJbggvpwyg60msf4fewHBP+eIY5QxbKEez8ldOKaZ6go0vdWcQcfZvvzQj30w2CWkjzuALmUqWpYsQ4tj6OMx lu3G/PoZ 0HuAywmWI9YNGA0kv3/Uk7FcWoDio82oGOwfNhmmHmaA4GB4ThVy7TFfNADIrXZ0lV1Yj/DwzXbqEdu+ucUn2TEuJyY6ot49OyxurrVdZg6YU6mksLNzXwLge9mgvIK6wNttGaAVrL01ZfO+u+lOqPAbQbihw9dp6Jlt/7LKPVEA19b7x7J4GHPbfwx0dbKlfsJEsm2aqcJvESfbSP088KIoAP8OUQEXkUHREd1i7uWOoAsalV/D9a8R+RAsv1Lc4peS4rfw0HKWst7DNWw4fSWSaR6/e0qOcTKsV0qJ08we3G7Ed+01bU154HT0uKCnq9rmgfnJvh3XYmfuV8Gf/eR3IH0NnvjuxJjhOTeBeQSc56CJEHMho0H64Lad/BfbOMMK0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 12:01:50PM -0600, Shuah Khan wrote: > On 9/2/24 03:51, Kent Overstreet wrote: > > On Mon, Sep 02, 2024 at 11:39:41AM GMT, Michal Hocko wrote: > > > On Mon 02-09-24 04:52:49, Kent Overstreet wrote: > > > > On Mon, Sep 02, 2024 at 10:41:31AM GMT, Michal Hocko wrote: > > > > > On Sun 01-09-24 21:35:30, Kent Overstreet wrote: > > > > > [...] > > > > > > But I am saying that kmalloc(__GFP_NOFAIL) _should_ fail and return NULL > > > > > > in the case of bugs, because that's going to be an improvement w.r.t. > > > > > > system robustness, in exactly the same way we don't use BUG_ON() if it's > > > > > > something that we can't guarantee won't happen in the wild - we WARN() > > > > > > and try to handle the error as best we can. > > > > > > > > > > We have discussed that in a different email thread. And I have to say > > > > > that I am not convinced that returning NULL makes a broken code much > > > > > better. Why? Because we can expect that broken NOFAIL users will not have a > > > > > error checking path. Even valid NOFAIL users will not have one because > > > > > they _know_ they do not have a different than retry for ever recovery > > > > > path. > > > > > > > > You mean where I asked you for a link to the discussion and rationale > > > > you claimed had happened? Still waiting on that > > > > > > I am not your assistent to be tasked and search through lore archives. > > > Find one if you need that. > > > > > > Anyway, if you read the email and even tried to understand what is > > > written there rather than immediately started shouting a response then > > > you would have noticed I have put actual arguments here. You are free to > > > disagree with them and lay down your arguments. You have decided to > > > > > > [...] > > > > > > > Yeah, enough of this insanity. > > > > > > so I do not think you are able to do that. Again... > > > > Michal, if you think crashing processes is an acceptable alternative to > > error handling _you have no business writing kernel code_. > > > > You have been stridently arguing for one bad idea after another, and > > it's an insult to those of us who do give a shit about writing reliable > > software. > > > > You're arguing against basic precepts of kernel programming. > > > > Get your head examined. And get the fuck out of here with this shit. > > > > Kent, > > Using language like this is clearly unacceptable and violates the > Code of Conduct. This type of language doesn't promote respectful > and productive discussions and is detrimental to the health of the > community. > > You should be well aware that this type of language and personal > attack is a clear violation of the Linux kernel Contributor Covenant > Code of Conduct as outlined in the following: > > https://www.kernel.org/doc/html/latest/process/code-of-conduct.html > > Refer to the Code of Conduct and refrain from violating the Code of > Conduct in the future. I believe Michal and I have more or less worked this out privately (and you guys have been copied on that as well).