From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DE0C54E41 for ; Thu, 29 Feb 2024 15:43:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18C3A6B009A; Thu, 29 Feb 2024 10:43:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B3F6B009B; Thu, 29 Feb 2024 10:43:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02B776B009C; Thu, 29 Feb 2024 10:43:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E73D56B009A for ; Thu, 29 Feb 2024 10:43:22 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A7FEEA1A99 for ; Thu, 29 Feb 2024 15:43:22 +0000 (UTC) X-FDA: 81845260644.17.FAB4BFC Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf11.hostedemail.com (Postfix) with ESMTP id EB7334000F for ; Thu, 29 Feb 2024 15:43:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=yrMVoKsg; spf=pass (imf11.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709221400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EhY5acBq23AQHjFzA7rJoEyE+uhuCPJWo/OtOJ63pUc=; b=noIpj+tr80hk6vBAX23LIP951DdklJN6/iET2lzuAGsznCgVknuOCZdlLLuxE3QbyDr3qn JNNf06pPMEZ6aC9VVqencV7JrVVNRV8Tlvqhfhhd46sAhd3ZJNRnM7Rsi+2jlwNK6AJgAv fDrsV5TDr7pDwiBz9E74qbLMPw4tNKE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=yrMVoKsg; spf=pass (imf11.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709221400; a=rsa-sha256; cv=none; b=QC8c7rLY7RQNOO34Xg3lCoDpaCM5ga+/mzM7xkLQvZByN7SEISWfTyhg5SW9sOOrOWwAyi 14bERkIFt6hNIeM+Nya/KWNzQT3tTfJpadxZwVhampNxgJmwKH5Qgc9ZNFukHLJxOvnKjV tzRCK/dEC8SyHueSybdnEbW1lz1zFtc= Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4TlwVC1QM7z9t6P; Thu, 29 Feb 2024 16:43:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709221395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EhY5acBq23AQHjFzA7rJoEyE+uhuCPJWo/OtOJ63pUc=; b=yrMVoKsgLYtqPC0noCEFYpxcI4eYNL4RvpPE3EHHe1IZgGc77DfD9W3GJ2ZFzmZvcdx6bq EXIqpyUnv5jtqSB/cimAy3VXhxnxbWqd1a/sLukESkUQoy8tIuYYAve+SP0qr3A9d5fGBT +9fq3/Bi5sk8ptYXjOxLJZ74FyiA79OdM++m+S8IMAXRiAAdrEYHjz1PAONBcJiFKhFbWQ xsp8yK/QMaySSZpjTbxGAu9Un9TGYuthHaaewASPZHAQWUoNM62KlLbZYatGQcYicULHSc GmyS8eb6BMP1OpBIVqQiXr1SroVkPZPRAgI4D9q9nM3sDAx33dVa+yBa5t8OtA== Date: Thu, 29 Feb 2024 16:43:13 +0100 From: "Pankaj Raghav (Samsung)" To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, p.raghav@samsung.com Subject: Re: [PATCH 1/1] mm: Convert pagecache_isize_extended to use a folio Message-ID: References: <20240228182230.1401088-1-willy@infradead.org> <20240228182230.1401088-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228182230.1401088-2-willy@infradead.org> X-Rspamd-Queue-Id: EB7334000F X-Rspam-User: X-Stat-Signature: t7iksc95makh6a1rsx9sf9x4xwxk9woq X-Rspamd-Server: rspam01 X-HE-Tag: 1709221399-478919 X-HE-Meta: U2FsdGVkX1+YJTUr6OS2LAjeqfTyEQ/mUbnG8RSHPIgEJWdb/NOgiMEgCwfnve/oSjq2uRW5sSn0GJ4FoQU5CxWuR1fl71snsOSP0SyolKrb3UOSPq3bNF3jIFYL0I7PJwWJcTzh94+23thS2tihzVKWjIGReNr0H0hu9QoHmklGiY8nw8371UOFYctublDvBCGwmyH669tvI6X85wyb0djmdyGKfNseDnt4WGiED+aIAKm0OIr8DiLh/AbzbhsaUv3AXIbGLln5E1dR/XJN5M2xM8Nc7h1pS8Okp8w6geykADPsya8pwUoZSxRVVkesrCT2sdNOLZJcKZAoRCzzVTF8XHANqZ4gV8gXnFsFEaoW1G4hfWiKyFD9CYP5/6g30F45hGIBySdIgpTYQuAV2eJvxc75EXu7ZS8VizHqVp7gSo6PL4A6ZXWhFm/gYo3R0oosUpO+dzW43aOyfsuaj7zbJbG5sqtgNfcO7LdPfgIi0hGou+HsAtosGWt2PUkotpkXIR41h4BFAA36cAx9bbhRRIyJ5y61ZlE+F6F5FOaEYW24V7DlMyLLtvMqQtmb70nSOPFPaiSGOsX8dF7mf/UecDZuEzisq8UNZCLSJZEBdEjBgDw4b3T+byAvVswrB9DdCp2Xxt8svbOPcYFVVmvJ0esWuZjF9viG47A469pDaSo08ws1DtwL162+zm1mYrPET5lZX/ThGpngygL1uTG93pRXi16E2Jlc3e9nrXhCW/1IeFvTQt5Paf/hSIJUdPkKmPz94BCGqIu7rKdWBeW3BfEq7kwSdincKDY9xOGs4pwoDlra5g7O77yqiFJdZtU7/4UfgU9caSgr3z5tbUCBOeem+ApRxtirEAwsdJfrC6IxQ+aqeMZslN6W13rM+8SaGeKzfAf9lFGUmCr2pgRQG4opSQ7BNxPBx02lCi4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 06:22:28PM +0000, Matthew Wilcox (Oracle) wrote: > Remove four hidden calls to compound_head(). Also exit early if the > filesystem block size is >= PAGE_SIZE instead of just equal to PAGE_SIZE. > > Signed-off-by: Matthew Wilcox (Oracle) Look good to me. Reviewed-by: Pankaj Raghav > --- > mm/truncate.c | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index 725b150e47ac..25776e1915b8 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -781,31 +781,29 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to) > { > int bsize = i_blocksize(inode); > loff_t rounded_from; > - struct page *page; > - pgoff_t index; > + struct folio *folio; > > WARN_ON(to > inode->i_size); > > - if (from >= to || bsize == PAGE_SIZE) > + if (from >= to || bsize >= PAGE_SIZE) > return; > /* Page straddling @from will not have any hole block created? */ > rounded_from = round_up(from, bsize); > if (to <= rounded_from || !(rounded_from & (PAGE_SIZE - 1))) > return; > > - index = from >> PAGE_SHIFT; > - page = find_lock_page(inode->i_mapping, index); > - /* Page not cached? Nothing to do */ > - if (!page) > + folio = filemap_lock_folio(inode->i_mapping, from / PAGE_SIZE); > + /* Folio not cached? Nothing to do */ > + if (IS_ERR(folio)) > return; > /* > - * See clear_page_dirty_for_io() for details why set_page_dirty() > + * See folio_clear_dirty_for_io() for details why folio_mark_dirty() > * is needed. > */ > - if (page_mkclean(page)) > - set_page_dirty(page); > - unlock_page(page); > - put_page(page); > + if (folio_mkclean(folio)) > + folio_mark_dirty(folio); > + folio_unlock(folio); > + folio_put(folio); > } > EXPORT_SYMBOL(pagecache_isize_extended); > > -- > 2.43.0 >