From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] maple_tree: Fix testing for 32 bit builds
Date: Thu, 28 Aug 2025 11:29:38 -0400 [thread overview]
Message-ID: <vsd57szi5ymhqe2d3ydjgq66oqsrh2u4ep6rlwysm4xjunfa4j@cadtq3ai4lqe> (raw)
In-Reply-To: <b69c03f8-9de1-44a8-9e21-322b0816be37@oracle.com>
* Sidhartha Kumar <sidhartha.kumar@oracle.com> [250828 11:12]:
> On 8/27/25 8:30 PM, Liam R. Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >
> > Some tests are invalid on 32bit due to the size of the index and last.
> > Making those tests depend on the correct build flags stops compile
> > complaints.
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
>
> Should a fixes tag also be added?
Well, it's a test fix, so there really isn't an issue with the actual
code.. and it's for 32bit.
I don't think we need it backported, but I guess the tag doesn't hurt.
Thanks!
>
> Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()")
>
> Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>
> > ---
> > tools/testing/radix-tree/maple.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> > index 172700fb7784d..90a0db45a33c3 100644
> > --- a/tools/testing/radix-tree/maple.c
> > +++ b/tools/testing/radix-tree/maple.c
> > @@ -36428,6 +36428,7 @@ static void check_nomem_writer_race(struct maple_tree *mt)
> > */
> > static inline int check_vma_modification(struct maple_tree *mt)
> > {
> > +#if defined(CONFIG_64BIT)
> > MA_STATE(mas, mt, 0, 0);
> > mtree_lock(mt);
> > @@ -36451,6 +36452,8 @@ static inline int check_vma_modification(struct maple_tree *mt)
> > mas_destroy(&mas);
> > mtree_unlock(mt);
> > +#endif
> > +
> > return 0;
> > }
>
next prev parent reply other threads:[~2025-08-28 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 0:30 [PATCH 0/2] maple_tree: Fix testing for 32bit compiles Liam R. Howlett
2025-08-28 0:30 ` [PATCH 1/2] maple_tree: Fix testing for 32 bit builds Liam R. Howlett
2025-08-28 15:12 ` Sidhartha Kumar
2025-08-28 15:29 ` Liam R. Howlett [this message]
2025-08-28 0:30 ` [PATCH 2/2] maple_tree: Testing fix for spanning store on 32b Liam R. Howlett
2025-08-28 15:25 ` Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vsd57szi5ymhqe2d3ydjgq66oqsrh2u4ep6rlwysm4xjunfa4j@cadtq3ai4lqe \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox