From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E44C4345F for ; Fri, 3 May 2024 21:11:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 310C06B0095; Fri, 3 May 2024 17:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BE9A6B009C; Fri, 3 May 2024 17:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AD956B009D; Fri, 3 May 2024 17:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F34C76B0095 for ; Fri, 3 May 2024 17:11:26 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 98F87141275 for ; Fri, 3 May 2024 21:11:26 +0000 (UTC) X-FDA: 82078330572.07.715C417 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf26.hostedemail.com (Postfix) with ESMTP id 8A1B814001E for ; Fri, 3 May 2024 21:11:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HvRV8KDR; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714770685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rdXn9sax21XZKKXDAA9jeDaxTMIGpElRCzeux1UVVi8=; b=S0BKrd7zJWVl2RV75SL5rO7e3BFEFF5xtIf1Ontd4Hkic7mpvgAdk7C9/2Kx5WueBHkurV f+6kSyY3EBm34GQaaY/9cqj46Cb/kBMChmIC8+ozbIayE1TY40MGTIAwdFZkAIXtfBs/7c 7alGfzJKQKMkuLXLp0IXCT6dVGnJueU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714770685; a=rsa-sha256; cv=none; b=st1QouT/SMDQ9LnU+AYo9RnEP5Er6SBAaoRGUB+1/B1qYaEK9spoTrCvMBPSGc7VYyWW4V swM3lqn5QDo7UUXsNKGemA0rb6h/M3OICtZtvMWYDx7cehsZYnbBA6ys9ncxmt84+b54q1 aEEuhTsTaw2g5r1TYyodJe6SXNlVYO0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HvRV8KDR; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Fri, 3 May 2024 14:11:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714770682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rdXn9sax21XZKKXDAA9jeDaxTMIGpElRCzeux1UVVi8=; b=HvRV8KDRmn5xM1M6fSPYZy4sAHS+XgNcct797sVmrm96YD2iJ8aYfc/tqhjyiXKqP9tJeq vUBdXYCwnzPtpa9WXMzjAYTaNsMbwUuzDVx2yK6PXQGFxqhOoaW4MM9ML1+Rz3DXLBk2Wt QGY+1yNN0jZaP44O0LZPuGqtL45Mcvg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Frank van der Linden , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/4] mm: memcg: merge multiple page_counters into a single structure Message-ID: References: <20240503201835.2969707-1-roman.gushchin@linux.dev> <20240503201835.2969707-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503201835.2969707-3-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8A1B814001E X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 566zgnps4scuq157grihhrzff6okyqi3 X-HE-Tag: 1714770684-892629 X-HE-Meta: U2FsdGVkX1+EROMOkBX1ZQAdS25QB3OrAb6IWhGtyqsQyTI3C77Yi3OII9KTfHSirWiGYb/esEgRQWcCtWKKJRGQ4/ZYDOvTrUQry5l0XXZFB5CLqODuQVMXCmZV3czp/gPLVfAfKZsX4xTJKE18dNTdjpofNo3Ijv3SndtFe5EpikEW6m/afekhuvKoHT1e/0X0HF3gX39oLBu66Qic0inCzoEE8B9p7Ubo0C+pF9j19C8yvBIkyLyGtzH/b2FL7GsJEPEJZ5wcHlTI5V1Fg4Dhpt6H8LFsNEuAT+JX1OmEl73pi81EeSRX5GxO+bfPqw81ahKaD/EX1SeiGHt1wJ/KlAyq5rcJGBUeS4dRBBuZWb8Mcb3PtEO5qz72dQmPFv/2kRKX0KtRc0jLyE/OoXJOt1KhdWSXIh5SlAKLAeKWO0QvU8Tvxguo+CLLCAtiDwGlw29Ly5Obsz53IM5er4zDUt0agkD/ha21+AZpNJ4tKEjBELvRR5Vv8TODRH8A+zu4THOkG+oInzC3FAcO7iKyYJ+/+EshBLghiZni0Ip22WTL2td9GlFH+sIhaXpsRdweaXbMSJkuJabz7tDphUmzkn6JcXESJI7WpBjikS/h66VHqhjRfNuA4oOjPEXq2LRrSY5K25JgomObGGeLHvXpwMp2RuqDU+NOYnrGhyuj1X45O6CD7wZawcCnr1ufRbkRSFb8Nv06slSt6+h0zeriEfAKfY+ZzQVuoSbcb2Ms1ohkma0wkrPuAfyw4qHzvrLMcorYObBuHVdygwy8qYt4LQmezIOd0o6sbY0R3WdQI0zPW8hHpilL9AINFazlqgw6INNLMK93Bhobm6XW+ub5re5T0PbAYAogRpSe9wAAbW0mwi49ou0V1iFPJ7me//M5csdJLEzPY0m5jEe5qV+rup39awv7uWtsSxG2F7PGbszVLrh8GNE3VQz6baaI6U+3qMX2YEM+Ua+bwNG FI2TU/pL lcNbNzDg2yd4jR6dke+dDdHivqs7isbzSmRrzVWWo8BJxWCkC2eF/gvxJgD0ShigDUytviV0+D4hmDAs25wGcMeNuV4EjhjgCW2/sYV6gT+/XRc/Xj/NADvZKtLtlNDhj2sdA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 03, 2024 at 01:18:33PM -0700, Roman Gushchin wrote: [...] > enum mem_counter_type { > +#ifdef CONFIG_MEMCG > MCT_MEMORY, /* cgroup v1 and v2 */ > MCT_SWAP, /* cgroup v2 only */ > MCT_MEMSW = MCT_SWAP, /* cgroup v1 only */ > MCT_KMEM, /* cgroup v1 only */ > MCT_TCPMEM, /* cgroup v1 only */ > +#endif > +#ifdef CONFIG_CGROUP_HUGETLB > + MCT_HUGETLB_MAX = __MCT_HUGETLB_MAX, > +#endif > + __MCT_NR_ITEMS, > }; > Thanks for the awesome work. I haven't gone through all the patches yet but wanted to ask a quick question. In the above enum are you trying to do a union between memcg and hugetlb? It gave me a big pause to understand what you are trying to do.