From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA80C54731 for ; Tue, 27 Aug 2024 16:10:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D2D56B0095; Tue, 27 Aug 2024 12:10:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 582606B0098; Tue, 27 Aug 2024 12:10:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D4DB6B0099; Tue, 27 Aug 2024 12:10:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1AE436B0095 for ; Tue, 27 Aug 2024 12:10:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B8F6B141A60 for ; Tue, 27 Aug 2024 16:10:02 +0000 (UTC) X-FDA: 82498511844.23.2CBE52B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 0D783C0014 for ; Tue, 27 Aug 2024 16:09:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fjA8mL2E; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D5O4SVxJ; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724774928; a=rsa-sha256; cv=pass; b=butrMOd0ySBMB58LCqQerngf3v3zdBba0RYWL/2ZIxxlboAxunQaVN7aawlDQJy+aEjBoR 1QFeIK3Ffq9h7VswfMPt5rXHVyo5v6NWkLs1T6QwwB1iBzLX5v4nx9XSQfrF+4C8pjKGbn dOfYQNkxLLpbL5chSgB6SguCNHEz/Xo= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fjA8mL2E; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=D5O4SVxJ; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724774928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XPCWFTMchAAOY/GlQscs76dN26EXlw6RAupOiGem93M=; b=47oYEFBCIcvFrQ+aJrYYFl6U0YGyKrBQFDIl7HCxjXorg3o4erRWhcDQUnTflRVc2eKx0H 2nkqPRDfYL1x0g1l/TQC5VNublLyiEwfngdGpdaDcpr1kjw2iP11P43XtZOp29GpOXll4A cAiYtxf5QFMmMO8dkHGS1N+Jlhd8Juw= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47RCBUv7020376; Tue, 27 Aug 2024 16:09:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=XPCWFTMchAAOY/G lQscs76dN26EXlw6RAupOiGem93M=; b=fjA8mL2E/fhzXhHZOfHt4nD281kNhMw bZaWW+0XWfjtoxcY3Iw9PUO/g18RBYQVpShhf75BUjo5xb3oi6U5m2dQn6HB1nEQ T00r+nH05eCpRfogopYvzcWjrb/hTESFFsiSfRvVkmLhAn8cKVwPMWObGkR1ency 0q2vOElnWmuzf3UE0X0QJMjad3HtHwYiHu68Tys34+KAYkSUKehrJbwTM4OTM2Cp lStQeKIHAaL43rvnsKf81mB14CWKCe6wKHKwm4waFDLBzslT8fIQ7qx3wQIKQS8K pYNEGt9S5njZ8qsq+xqtQm2kT0Gk+sjLq0cZkQ1AR6nahVfoCEcEEjQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4177hwp0h5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2024 16:09:57 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 47RG4fSN017489; Tue, 27 Aug 2024 16:09:56 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2045.outbound.protection.outlook.com [104.47.74.45]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 418a5sjrru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2024 16:09:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XfrhsS7jOwwZFAleV3nRYxsbg6KupqrcQiWRzXpp3sNxV+4jUY0snAFrPurjCN/4euSYa14iW8Zag4WRto46A90jjPO3uflrmBcyV570cLD2LxJxVjANqKeBQY5wMAtkfcSWnMJ5XCR6QS2ONj0x4j6wWRGFfQYvMOuTcUVS6miaXLrZyKE5kZEp/Q/nh5GGKCQOnYfv0msyXGc9qAkacwiTUseJcx5YCqolIMZsPPyGz79jtnBy/AviIqNja8eTFfqXFu0bzKxlpeCg4+JV23bXpUR98t+1X63O/jgA90ycldB1uNAAP1eohljVyPplqHyEKI+huhHc+s6F+yPkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XPCWFTMchAAOY/GlQscs76dN26EXlw6RAupOiGem93M=; b=qJi3W3wqpmKCoOB6H3ihJhf17DYTqFHSH9AhLtG98PEEMUndSW6S18GVf0Rn63HnOpxM0Gbv9hcAmDvhHhe5xq7SiopG3GaXr8tLnquEu4Cruw06dz+0AQu1kf6NCMuOvc0E8xojeDdfMl8n4Z2eOMOR52PJ+2sKI83ghSP1yLVtQ2O5FRuEOrIfhn2EVGc9eExt/CtjBRXQmV36tfbOsYX2vhAJjcR4iBIl45Es4tQxnVTRrt2gq0IVmhYogpgmBGV9co6mxIpYBa4U4j6zjzV3o2cl3HOHUj+pifTQ+UHcBVmCne27zNWYbbjX6/917bOUtXaz+saKUz6A8Lr24g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPCWFTMchAAOY/GlQscs76dN26EXlw6RAupOiGem93M=; b=D5O4SVxJZ8BONDjFVsx4uzUOzaqNZim3/cVfnvQge7qxd9aI8ZZFXg8fQBidbAoGw+yIzYXXpoIh7juLhy7TaauEs7wOKeBHNdNmZo77IUpAPmhxy12n1Wy6CEygQ5CBivmyUxhP7M4yBcCaXtkzsAyThbl5zCUJ5sf69FuFZcs= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS7PR10MB4959.namprd10.prod.outlook.com (2603:10b6:5:3a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.14; Tue, 27 Aug 2024 16:09:54 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7918.012; Tue, 27 Aug 2024 16:09:54 +0000 Date: Tue, 27 Aug 2024 12:09:52 -0400 From: "Liam R. Howlett" To: Dan Carpenter Cc: linux-mm@kvack.org Subject: Re: [bug report] mm: change failure of MAP_FIXED to restoring the gap on failure Message-ID: Mail-Followup-To: "Liam R. Howlett" , Dan Carpenter , linux-mm@kvack.org References: <14c0c2ff-e414-4e6d-9029-b738febd4922@stanley.mountain> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14c0c2ff-e414-4e6d-9029-b738febd4922@stanley.mountain> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0141.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d5::12) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS7PR10MB4959:EE_ X-MS-Office365-Filtering-Correlation-Id: ee62a5ab-7ae1-47e4-f8de-08dcc6b2b01d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bbTzR/FxhDBHi/uhzQ1BYsZfscCS5kq/rF5Is68p8swoT+jcPFHmnxQY8+js?= =?us-ascii?Q?OsunMTj+vDpbVY+qoQT3ivwPA03917aySKO+NQY9/B63Sfblm0CsTihcmnaO?= =?us-ascii?Q?Yjwt9BeT9vjLi4zCxGIrz+LKS1wmvyfk+pjdMAUwD60kXNk+C77qO6uy24Pp?= =?us-ascii?Q?RJXKEkQCzfV4Epb33sxrkUmG95PAdUp38le2x5tN0ycCCxaTtDu28vHYO4Ns?= =?us-ascii?Q?uMVDsoYvYnIziODCb/62iY7kunR08quClS0Mj2Eey0DPkW7Tn7BGw4d4Fjwg?= =?us-ascii?Q?31KHfzw02bTNS/3bFaXIKeZgtjkvTqVBxzYv3Xm1Ue10rmoOg10wxDA9EdLq?= =?us-ascii?Q?hp6rZbRGpxJoXa19NjY0l1G/hfbSMNWcdsghR19QQP0IoPGmEsdcB4iGk3k8?= =?us-ascii?Q?TKy+ue1A7ajTTcTI86jfyyvTsrBVKbUYYnaK2EJm9qxoGPNNGjhz9CZoySxE?= =?us-ascii?Q?I8d4jAreKEbRy8hoZqkwC3/GlCq13FLEqF7eBFFgQIZ/8AFSN7igYZbbJINA?= =?us-ascii?Q?VcjuFycbcEXQNBipmoTIvPViHA92ze3xWDfVyGPZgJtoVA8yJVO2q+6DsnkZ?= =?us-ascii?Q?OU9m3qO6ofY9WqxA7oqJ/GL2H0L8n07fFvSg+FkmbYLnkDcdMSMgPQzqPfQ8?= =?us-ascii?Q?IAz8FHCT0YYaFLbTQfFQV+Y15d6jDutcoLqs/yLGlyelKyrVsR+jeUP1tATP?= =?us-ascii?Q?P0wS+shWLUCosR6fE028wmIrQfeU9fK4H6VYH8I0gE1hUGSbsCcoz1qS6DPn?= =?us-ascii?Q?+p4vb17HW+CndfYB67b0UX3LBVav+UykK89Ysihvx9EQXd29cLCVm2HOoiKV?= =?us-ascii?Q?gZYzb7N7jJuvtWEHBIb4uJ8K3LQGYCbN1bl/X8vmyowtiJgKKzQFWrQYi/0q?= =?us-ascii?Q?SB01DdijvWSk55cmFWff7E9pNd31b8AWEEpdDq7iemF/DlEWc2ZS/IJQamdP?= =?us-ascii?Q?EH+biVnK+KvZkDGvzZcCD3Y+9YdpV4q+S6tuhk2WMYeGSE8vDWzAZIAH4TTR?= =?us-ascii?Q?JTLZkuMenW7tLJyT9tF0wiuBBeRZ6qjLhaQb+/c0Swx/LHIyShGCasUugcqH?= =?us-ascii?Q?s8/FaoUjTfCMhupF4yChD72PYOKIWDB8yyOrht1S+iXmbTDOwBMStyeRmqvA?= =?us-ascii?Q?3f26EWasiOuY7oOMB6SNtGZFQsQPx18NF4tJAYm8II4TiplRsMjSb1X7w6XK?= =?us-ascii?Q?UCVMLHZqnnRxFppKVdrqRcjpxRADsbGtC9EO4TwUxgi2W1qGbwIy3vbDrCcK?= =?us-ascii?Q?H/aHGs2WNJc46GacOVs/TQ3cGWQYJ4MSSh/QKmkR8ZeqaNwDdeW4d59vKQy0?= =?us-ascii?Q?kst6ssLUaa4EytMdJICjD5/Gk+Y1PIe9JXBr+KVpHEhm5g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qYnNMnANsY2RnygGayFyOyehQOcmKaab0C0As3/xQal4rDP+rpTGQmycw64E?= =?us-ascii?Q?NHb+EJqwXCY97RmdsUrhlHrotU0Q9/IgDquT/4Oj6cfGpL0ue5brwUufwb9S?= =?us-ascii?Q?T4yaJwP2WNN8SoB24pX/moeTEwlyaphjvkoG9tuWh1xsNYDY6kQwPVwoW3MB?= =?us-ascii?Q?dx2xkYkhYl1STiQB7eUjNnFqITL4QEffOOXqCktXdD/Y6N6L+Jc+c9cH6iUz?= =?us-ascii?Q?O2iIXBQvklkXQbQJhDLkEwZkx4c+OtN7y6KMpefKODpdirRyzn0slNRNJtyT?= =?us-ascii?Q?0g4al9GF7TWTmqIxf/EPUbjBTm6CNUF6trY7RPCn+9Cyj6Ek5m+hq0XiHLiS?= =?us-ascii?Q?chHDr1sgFmJjWfa71PcYNvRTrJf9ur01izKlJsW0Tg+L8aiCcSsobzHnvDnk?= =?us-ascii?Q?ALcKEtImFbYB0gmu62aoWp3V481y5/fFZoAWN8Qpu4HMLk1ZnvuADaf9ehk3?= =?us-ascii?Q?tA93JVp7+zR4iHUYKswVzDSNRlO1+sjZ0Iv+AIJ4pSlKulhsV1SrqntKJtq9?= =?us-ascii?Q?C8WZzdqwYNs/9Xy+UHX+ZLHhYMNkqGoiamGh3DfQV1L434sQUVZ+2rG1pch+?= =?us-ascii?Q?8ln0N3bgNGOhnT2ke9kLiKkntRQafIT16QfvpKHkvWHDs/dI2joJLiZuoP/E?= =?us-ascii?Q?d2OPXZPrZjRas63cIJG0EjcBHKyNfhT/MaoDRU4OjDw9aKKM9OyxpZm3r6rC?= =?us-ascii?Q?s0OrvoQsgAg5KtfjmOAccugXIfqMJOUeYdA8iIO6QdLaQEVq9ZXOn8rzsORG?= =?us-ascii?Q?xPUJcaR2D0VGhK3WhOS1TcXbOBERDT4tuC+IuLoOHlymxxqiFWn23LnkTMct?= =?us-ascii?Q?zKTmWAgt00ZuTG/J5xVvLdIr5dWwcANTw8UBqaCCP4+7FnGfG1aJPOQEGx6C?= =?us-ascii?Q?3Uk+TuWOLeWTWaBMk0P+xG4g94S7wGi48YY6pxXoV+FTuQjNXcZODSZ0D/B2?= =?us-ascii?Q?CMTV6urF+QzX4EYc/Et5GRm+YKHOkZNxeAMupOI18jY8ga9dB19lM9NG2v7A?= =?us-ascii?Q?0WwV2Le7KeH80Ugb/I6ycYqGn7MvDR1o774Wu65UStuGRST3qjMLDTFodf5o?= =?us-ascii?Q?hQQFeq7PqkgOvTw/+w6zi50jsAoG0OlBHhwbX1oSEPyIjaVlN2F+c6calErl?= =?us-ascii?Q?GidKx7/aY0nHDeMouNmybWBasTnlf/Rnt4nsPmYZ65PeVZJaVPXyPeXx+3qy?= =?us-ascii?Q?WwVjqpYU0PT6RHCL7hpkziu/cQIET9mCuqBcThohsLyF/H7MhPrrWYkVUNCC?= =?us-ascii?Q?YfN241+8mMGMO8chgjrbXLRiE8Rjj/PnNoJYelwMYU3KGRsH77fGXkantZhX?= =?us-ascii?Q?qGeaE0zT1ZwlRZMC5+FowKeCWvtx6hZ9HG5H37pw9Q/RkCDgcYsBNUuH/RNh?= =?us-ascii?Q?yydVQ7pudEKR5LvVLiqd1BIfvH4/18lA2uRd/rSwtD2Deo5I7wh+RAChTba0?= =?us-ascii?Q?1CAFNCUZxXmsCxgbu1IPaYkv4y/Zo0cdneorMkR/e8UKcqVpsfd/5aYJ+bIM?= =?us-ascii?Q?KCR6GMG8La3qMrQXm/VcZaEzn45BLS9BU2jojqrWhXVQsinznUFBTs8QNbkI?= =?us-ascii?Q?ZMdhmFY9yH5TGl1D1YRrqwLF2xX3L1YmEMERj4ON?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7bJb/qDAaG8baMOv3KakmhsTb2l3Ozj7plozyrXcGosEM6ZQE0v3T7K9X0Q0aW7Qq/XiOuNovG01wkrliwbMC9MsHujd1NTUvSpFE4V1YbKAo38CnArxI3LYK+jExmiB3s+LhqgqahZNS5xP0Ba8cCBU7HT8zT2VnXZjfiLU8iUVWMF24xZ2Qtg/p5DGIPrYIwiuj9L0B2Uh1H1iBSynBUliKpxXVOEm3RN+RRoDqGqYYAYxr8PdBYdnU/7o2L7PKyiK5Oxu+RRvKc8CdvsxGcTaaDJO3jxE8odjGDdGJsWttclxhRZjWri8TG/KmwLjDT0z1Bh3WFJt29twp0FzmoJ6/ZwYXR2dO2E9licTzLV6Qzcur+RPel21zKx0YNessI61CN6Tmk83LsxHdLbJPcEwpA6NdAUgmpsRmBX0tQETZTA7B/1mXkM18KAgLBM8dSIjHUNJPVn2pgdC+RyOcL4Kp05OTmazAkG1scyF/iHLN8VxVM1y2O6xLCLfEAI+L/6au9LPXdpFPeRl21bj/JScSlNFjIIQh86tOx1gpXqQcjsGKalgfXyNavTDSlojjLKUqQfr87Q2m5ncyvWpq3kM9rfYggOUrRr/Hb7Frl0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee62a5ab-7ae1-47e4-f8de-08dcc6b2b01d X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2024 16:09:54.2618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G3vmHqxcFlXg6zEcJwtS/ckgn2ciEG58B3Sve4CsEb4oFgIvOd1sQaTAzSdoxYpgbH0Z5S+JJTuAFmWD563ckg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4959 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-27_09,2024-08-27_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=803 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408270121 X-Proofpoint-GUID: KFD7PRMiE4LuNSErUOIvAmrhHIbE6A_S X-Proofpoint-ORIG-GUID: KFD7PRMiE4LuNSErUOIvAmrhHIbE6A_S X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0D783C0014 X-Stat-Signature: 6ukbhuu91nmphkzwikwt8qz5z3hn9cwb X-Rspam-User: X-HE-Tag: 1724774998-178271 X-HE-Meta: U2FsdGVkX18SctGVln61XKQ+Uf0iRz5lK8ihC5Ot/DSUEoTnUxkgG0KDjAu1Z4f7JWZi+9KT8cCYNiz40OD6pjjyjYIJcVaaBF2dLVCauHn+HsNJS/fJ6oy6n8N4xnqUKY/A2aSS+5w6GZbogEf3Arl04sU+DDCZRl3LmEJ1cn/9ouQswV8Zn3+/F0mnWwj902tZZ6j215jyIaXDVgz+zg2lunuEiK2lKNttBJDgx68JniZ9/Z7Fxa+WNj1fB024vupiTXoMyHRxLyN7yn3NowXP5MGy5TQDrYpEe0JPzbFGllHO0Ww7Z6YbClSpoDBWNoTUTBGNKTiX0dxipst/lq83f11wpvaxmG7YGv56AUMQ0e9gClgWPhD4Y08lcY3rr3jAMk7pMVPEmMaVVotg5Apex+ZZV7Jg3CbBy0AmnQeBq5bfyKv5H+Rz3FQzecdjsS1P8Hjm44G61sZ3YvbYCLly41a3q1XOKLJDdhtOzU14rmahhkMgertp/YmikZFPnlwYHAYHTzIOq9TZXme3fi90WhkhkQvYQ5k7COwuCTLNQ13kMruFdcPxjDirsNCtZRADMzuOPFV/Q49k9C64xwVozCzoratfKg8T3AfNOPi6y0szAs6g9Pgv82w7Pk3CybEk5pzL0kgI95uUCxQinNJhwou4ipwyffoNR6NdQB/sghKH5slOGWvKy3MI6BEmBKMveRxEgE7+alOxglc5KcFP3WcG2WuBx0ELETBOmKjbA8+tVgKY7XedppgXDH26oJW2SYh41DGSVQoxiFPBvBwSw0+teH7+ixa+r1MdJc4iW9zGyGXURiOFUAkEAOOartYOQ1JLSZCF2I6R5iQ8oG7NhMjGokdG+ornWm5pennnnQ2VGDkxTEZrWEoUUsKPENoUz4aIyckddJTBGubq5ewerEHwLBubme82M/KSHG5mGcZWEgezt139JMEnYDCGdYlWK55Fk7q6TD5gAOR amwjRlor bCNiVuHSlQa+1tsy/BOKHzFhh6kveETtVBxx+VPrk+bYurrxTuvoscF579ucVHJcTdCZpHMqYAnlB2R00SMjcW43+kcPf6uNUJxLUEp782B8tCDHS/fhMoMuyr8mqL310CtGJ76A8mhTLao6Yux9ibae6nJvX9v2wvQzNDZQTUJRiKjQovMAh7sD7WQ6OFSTgCwYz8VxHmb0Ii23/Bz0DchUeMJ+CCqDLC4tC7ELhkaUmNd85Q9Cnu92Lu4pkXKjxLLiY9Lg9o79DicUQAyl9hw/SFVCFg5nsV15H2ihIMIrLXz3Wd+JJSinpsSWKw9A4XLZHpEO8qSy14jX9ftPrfA2SFOhoD00MWTmAtClqt076BSEyApYnjwciCqynM0met7hCn0SvGU2JsbIuh+cXObDJGnK5qhaW842duBIltG9WlX1bHHHg5bfkUdBfvRzWUWT9NLinvafqTIUTbPmvA696PSoGlOqj9WF0+sAis9anGsUW4g0rIHJ6L6aFWYY5E1Xb6rPFaxxhfNvMT8Eibfhf63rnp6hooQwHyZE3mr3qDbO9YYhgL6xlLSTk/WYQcx1N2+jvGFn1SHfQ07mc//Q1jb6kXrwycuHgIwlh6DLfmhjADBkFSs1RVcj6t/jFdee5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Dan Carpenter [240827 06:22]: > Hello Liam R. Howlett, > > Commit 131e4ef350fa ("mm: change failure of MAP_FIXED to restoring > the gap on failure") from Aug 22, 2024 (linux-next), leads to the > following Smatch static checker warning: > > mm/vma.h:240 vms_abort_munmap_vmas() > error: NULL dereference inside function > > mm/vma.h > 226 static inline void vms_abort_munmap_vmas(struct vma_munmap_struct *vms, > 227 struct ma_state *mas_detach) > 228 { > 229 if (!vms->nr_pages) > 230 return; > 231 > 232 if (vms->clear_ptes) > 233 return reattach_vmas(mas_detach); > 234 > 235 /* > 236 * Aborting cannot just call the vm_ops open() because they are often > 237 * not symmetrical and state data has been lost. Resort to the old > 238 * failure method of leaving a gap where the MAP_FIXED mapping failed. > 239 */ > --> 240 if (unlikely(vma_iter_store_gfp(vms->vmi, NULL, GFP_KERNEL))) { > ^^^^ > Passing a NULL "vma" pointer will lead to a crash. Ah, yes it will. I need to use vma_iter_clear(vms->vmi); Thanks, Liam