Re: [linux-next:master 7320/8126] mm/vma.h:173:22: error: implicit declaration of function 'vma_iter_store_gfp'; did you mean 'vma_iter_clear_gfp'?

["Liam R. Howlett" <Liam.Howlett@oracle.com>]

* kernel test robot <lkp@intel.com> [240830 11:05]:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   985bf40edf4343dcb04c33f58b40b4a85c1776d4
> commit: 59f8f23d91921f023428e34c061e8ee88b7670c7 [7320/8126] mm: change failure of MAP_FIXED to restoring the gap on failure
> config: x86_64-randconfig-x005-20230818 (https://download.01.org/0day-ci/archive/20240830/202408302337.xJn0kaJN-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408302337.xJn0kaJN-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408302337.xJn0kaJN-lkp@intel.com/
> 
> Note: the linux-next/master HEAD 985bf40edf4343dcb04c33f58b40b4a85c1776d4 builds fine.
>       It may have been fixed somewhere.
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/export.h:5,
>                     from mm/filemap.c:13:
>    mm/vma.h: In function 'vms_abort_munmap_vmas':
> >> mm/vma.h:173:22: error: implicit declaration of function 'vma_iter_store_gfp'; did you mean 'vma_iter_clear_gfp'? [-Werror=implicit-function-declaration]
>      173 |         if (unlikely(vma_iter_store_gfp(vms->vmi, NULL, GFP_KERNEL))) {
>          |                      ^~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
>       77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>          |                                             ^
>    In file included from mm/internal.h:22,
>                     from mm/filemap.c:52:
>    mm/vma.h: At top level:
> >> mm/vma.h:336:19: error: static declaration of 'vma_iter_store_gfp' follows non-static declaration
>      336 | static inline int vma_iter_store_gfp(struct vma_iterator *vmi,
>          |                   ^~~~~~~~~~~~~~~~~~
>    mm/vma.h:173:22: note: previous implicit declaration of 'vma_iter_store_gfp' with type 'int()'
>      173 |         if (unlikely(vma_iter_store_gfp(vms->vmi, NULL, GFP_KERNEL))) {
>          |                      ^~~~~~~~~~~~~~~~~~
>    include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
>       77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>          |                                             ^
>    cc1: some warnings being treated as errors

next-20240830 has a newer version of this code.

The fix should have relocated the vma_iter_store_gfp() function above
this function, maybe a merge resolution issue?  All of this is based on
v7 vs the newer v8 version, which doesn't use the vma_iter_store_gfp()
call here anyways.