From: Mitchel Humpherys <mitchelh@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Joe Perches <joe@perches.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: convert some level-less printks to pr_*
Date: Tue, 15 Apr 2014 16:58:21 -0700 [thread overview]
Message-ID: <vnkwvbuaywki.fsf@mitchelh-linux.qualcomm.com> (raw)
In-Reply-To: <20140414155526.96b0832bf4660c026bc3a1d9@linux-foundation.org> (Andrew Morton's message of "Mon, 14 Apr 2014 15:55:26 -0700")
On Mon, Apr 14 2014 at 03:55:26 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys <mitchelh@codeaurora.org> wrote:
>> #include <linux/mm.h>
>> #include <linux/export.h>
>> #include <linux/swap.h>
>> @@ -15,6 +17,7 @@
>> #include <linux/hash.h>
>> #include <linux/highmem.h>
>> #include <linux/bootmem.h>
>> +#include <linux/printk.h>
>> #include <asm/tlbflush.h>
>>
>> #include <trace/events/block.h>
>> @@ -34,7 +37,7 @@ static __init int init_emergency_pool(void)
>>
>> page_pool = mempool_create_page_pool(POOL_SIZE, 0);
>> BUG_ON(!page_pool);
>> - printk("bounce pool size: %d pages\n", POOL_SIZE);
>> + pr_info("bounce pool size: %d pages\n", POOL_SIZE);
>
> This used to print "bounce pool size: N pages" but will now print
> "bounce: bounce pool size: N pages".
>
> It isn't necessarily a *bad* change but perhaps a little more thought
> could be put into it. In this example it would be better remove the
> redundancy by using
>
> pr_info("pool size: %d pages\n"...);
Yes I noticed this in my boot-test... I'll change it to remove the
redundancy. The others all seem okay.
>
> And all of this should be described and justified in the changelog,
> please.
Will send a v3 shortly. Thanks for your comments.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-15 23:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 17:54 [PATCH v2] Some printk cleanup in mm Mitchel Humpherys
2014-03-27 17:54 ` [PATCH v2] mm: convert some level-less printks to pr_* Mitchel Humpherys
2014-03-31 18:35 ` Christoph Lameter
2014-03-31 18:44 ` Joe Perches
2014-04-03 16:33 ` Christoph Lameter
2014-04-03 16:57 ` Mitchel Humpherys
2014-04-14 22:55 ` Andrew Morton
2014-04-15 23:58 ` Mitchel Humpherys [this message]
2014-04-16 0:05 ` Mitchel Humpherys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vnkwvbuaywki.fsf@mitchelh-linux.qualcomm.com \
--to=mitchelh@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox