From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC35C3ABA3 for ; Fri, 2 May 2025 09:43:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CD3F6B0092; Fri, 2 May 2025 05:43:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1566B6B0093; Fri, 2 May 2025 05:43:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F10406B0095; Fri, 2 May 2025 05:43:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CEA356B0092 for ; Fri, 2 May 2025 05:43:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A59ACBDD5B for ; Fri, 2 May 2025 09:43:08 +0000 (UTC) X-FDA: 83397479256.23.5FC01CC Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf19.hostedemail.com (Postfix) with ESMTP id B91AE1A000B for ; Fri, 2 May 2025 09:43:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=C2RG1fqI; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746178987; a=rsa-sha256; cv=none; b=qjMLi19rlSv7uMhVKUOzT1X1yW4/EiVedmv647dbEX9P45USj7E0jMJg4rhWwzX5DSFIcD bBxFG12lPMijXUa01h38/LODFGF4PO1h8AqIyHkrakfTGpGe0Aeduc1g/10Icu+13dDcre ZP0cgQSAe2YX4dVZ0iMBje6MZP5DXw0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=C2RG1fqI; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746178987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EOXqPqomDY5NAmOBb/66KqDnP+k/LNaa1HXt0xFQ2zI=; b=wnFkJ4pRFt1mre4cust1caTBHDUGyeaJWfJwbuV51aNbNn+O8agQD4XPX8McoC3e7ZjWJJ CeaQUeWN7+SEIyCrdifDLQ3MVZBUCU/tyrF+GRzCUL1XjqRCtTuhYD3Je3eADosVyKduQx riPcCrstzriAZyvFZ5v8k3MOX/KvZcQ= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5f6c3f7b0b0so3621090a12.0 for ; Fri, 02 May 2025 02:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746178985; x=1746783785; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EOXqPqomDY5NAmOBb/66KqDnP+k/LNaa1HXt0xFQ2zI=; b=C2RG1fqIVNm0V1CW6h/5mAOJZkkxvhSot6VWdLB/ufWi5OykLyMZ2KZhvubDrANtjp BHO6JV/fyVjEbaunxD/BwHyMpokMoyjsTvAKlbS0uc2fv+U6bPnVdWTwFNCVl0B1l/Qg i/YEpdPm5/EfWrM+41ljN2svP5NyGhH/AzMHsQc87mRoB3spgxo74xd5n34g7LH3qMxf 2IeHLsndHTm2ELzjfg8PGGgSPwiqXB9bZ5Wg+Y59DEgvJkgqHIutUz6/u42B7j+FYgkX 7fyj6VTHcxdEpibcQ9trlvHqyzDYLCrqcMUrdFuJxpHdsvhCfiJSj3Lc3aFDacLD931V Zl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746178985; x=1746783785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EOXqPqomDY5NAmOBb/66KqDnP+k/LNaa1HXt0xFQ2zI=; b=TiQ8thjunX25JhA09Ym4Pwy3yckFKhlwpJmi8SkWY6CxQacNi+C3CIzKn+KsBp+0aZ BueQdUDls8cAKkeFmNTxd/CNYvPuSHf9a5IHaJGRgMlqoZeMWb33IQ3qrgqeK/HSwvUp OWISuBrALXI1DJ7zQGLeJIfoKGo0XLE94SDbkC9NZqX//eYNIg7MOP4kZawUl0Eg6nJV F6DBJBZZiie4CUco5vRtCNivqyLQKW2eAbjAQOgANFPAR4QABpdVKvr06B2TFe9GCDWX 4/WNumUjT6i+ovWwU4aEGGapt/QBc8w8q2kBlylYcvvgI25WmGGJBB8Hx5ZlHRaWWvxh GG1Q== X-Forwarded-Encrypted: i=1; AJvYcCUweXMxh0Jp1xccidm11fq+9TsNFSJYGoeMrrxM0txUTn60gRMkp4gzYWPEmXYPUBPSc71yo7nZLQ==@kvack.org X-Gm-Message-State: AOJu0YxfKuJUPdV0HbQgNcmdb0ynIzXdgpZ9sNUAeGLTL5S20H9yLNsj MdgUS+vPVa4SgZKNFoBC+yGinYTqC2KzuXkbTdHCXMbexqZrcpcrGGLmlioKFOw= X-Gm-Gg: ASbGnct9mDyqPDAucACsSbJBPWB3cBRYP1nxEHORARQfoSpXuwwlv4iFkOyKZB8+apt TlGZCQo9gKckfRHzE9+3N2akgna2Hw02A0fJjFpQmliAM8ifd21QFY1+RkRCCFEOJQ+2esYl0Ev gIr8YIfEWc0GuT6M/UD/lhyjlbgy9mLqSLrHmBoDQlLmrwekq2juAkktN1X0ZF4AyJ4u6waIK2R JQH/2Xu7ZjMSy2V9yNtI1GR+3IMZTP3UIC7mEqr1HlQRkT2KrNFvfpnP/xjoYSDbEjAk5r8/gPq D4GelK/1Iv0YJSaXrI/KCnUwmNR/c8Tbvx0xLn8JQaY= X-Google-Smtp-Source: AGHT+IFgoRhv9PuW/EWdVGOS2zvRloJtSnlLvctJGmfk/l9H9pNgE/zk8qe2KUDmO+lth2FLCAP8OA== X-Received: by 2002:a05:6402:d08:b0:5ee:497:89fc with SMTP id 4fb4d7f45d1cf-5fa7891aae1mr1661907a12.33.1746178985017; Fri, 02 May 2025 02:43:05 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fa7781bf5fsm942719a12.36.2025.05.02.02.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 02:43:04 -0700 (PDT) Date: Fri, 2 May 2025 11:43:02 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on Message-ID: References: <20250502010443.106022-1-longman@redhat.com> <20250502010443.106022-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="55lyjcmxpait3n53" Content-Disposition: inline In-Reply-To: <20250502010443.106022-2-longman@redhat.com> X-Rspamd-Queue-Id: B91AE1A000B X-Stat-Signature: mtaow8ij17fxmqyz1fap5f9jk4pwc4na X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746178986-286120 X-HE-Meta: U2FsdGVkX18RH/NP0qvf21h6zntQ0rw/y4b+BDFMerKK48BoA5O3c+4oARdaRXytf+AamlXf0mFPChyAlc1aGkrbZaBOMP5jKUnP9G/IrBlWTKERidiJlmARqdFPXDY0Uxb1Ij4wYRJl9Rj4deFy/Dbe3yxvql9gBULfX0z/TAoEIa19Y9dbWIY3IbXnJhf7ngbqQpoxURIqUQJJBaVyY7gk/91e7JSwtud5UYEvICxzpdaBTlVojWDFOLJAXUzwtU/l/E7GjNARw3RBKLMflsltabl1Ubbr9oXEABTcQmqb5KnhCK9pcd2Zau14m/mgoh4zCrkjaVR6Jlik2B0CXk+mrsQxB7KfEdM80XIprJmCRl8DU3pWKHiRAqgiBKcw9WKIzAl1sFyYnnqxmpLkTV0ztClkp0IuWHWKCS/k3H9i3vCoW/R23SAHhOA40TqyDUHDw3bqJe5+aXnw/Sa9U58psi0g0okl36JA2zP9liukPxcH35/LvWzK3t1ON5zv+xkAdBpNaZ1Cr/0ag/nvojJkuChN0E9RwXMX2bOdGjktA9L3RYzMatHqBe8+jKIcy1AIIQ+NZkPBPZu87BEKBuFNcjKgpvl44Y1mVfVRb09dCFwODLNqkOmn+c5krVrce9+suyP1m7A+NCLHrS6xBz17bxkEUpz8cpPiSDrKkbOKzcpWV7Cvt6d51sEfPpjy5yVm081AwU85WM01W9b9gBDRiWd3LUtiH5LwMnsW8i3/oB8h7xGMMhR0JX8IZBom4zMTkTOPaw2Jf1KYga/p1qE1UrG9lvh8NrcUCvONNsE/t460bBWMILf6cop3kFX5Pqjmn3yXoNocVkUPIGY2Qt9LaXBULaqhrYvd8Bg6WtfXoBeDG7yVzUJOtNtYiM+ZfjoYoHrQo98YlbElaRaWxLh+ZVl0Vpp0Q93JGaUdysWezsK90yZxhM+Q8XlkDw2U6ZQGUHm0nu3ugh6ZSuF p/qH6PfO uf+1TtrcGtzKJ3aYsiXyIbNnDGQ8B0eMJPBWFYLRXMHrQLfzRILVTPeCT9BSHjXhDaqPbqOh3b3SM9JUlzTMIPfewfBFvejcoZGaUzLy8IZ10a4ohxG33khWDIGtI6ihB6Khf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --55lyjcmxpait3n53 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v8 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on MIME-Version: 1.0 On Thu, May 01, 2025 at 09:04:42PM -0400, Waiman Long = wrote: > Modify the test_memcontrol.c to ignore low event in the 3rd child cgroup > with memory_recursiveprot on. >=20 > The 4th child cgroup has no memory usage and so has an effective > low of 0. It has no low event count because the mem_cgroup_below_low() > check in shrink_node_memcgs() is skipped as mem_cgroup_below_min() > returns true. If we ever change mem_cgroup_below_min() in such a way > that it no longer skips the no usage case, we will have to add code to > explicitly skip it. >=20 > With this patch applied, the test_memcg_low sub-test finishes > successfully without failure in most cases. Though both test_memcg_low > and test_memcg_min sub-tests may still fail occasionally if the > memory.current values fall outside of the expected ranges. >=20 > Suggested-by: Michal Koutn=FD > Signed-off-by: Waiman Long Acked-by: Michal Koutn=FD (Thank you. Not sure if this can be both with Suggested-by, so either of them alone is fine by me.) --55lyjcmxpait3n53 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaBSTpAAKCRAt3Wney77B SclRAP4sVLHHxS41vhM1p+JYRz4x68kM1ToNUs7M3I1xd7X9XQEA9Lg0Obh9pUcU RmcQibMDF9amuynS7EPQ0DQjGlQ+lQ0= =iotP -----END PGP SIGNATURE----- --55lyjcmxpait3n53--