From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A4FC48260 for ; Fri, 16 Feb 2024 16:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E02928D0010; Fri, 16 Feb 2024 11:39:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB2688D0002; Fri, 16 Feb 2024 11:39:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C535D8D0010; Fri, 16 Feb 2024 11:39:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B41E38D0002 for ; Fri, 16 Feb 2024 11:39:14 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 761941202A6 for ; Fri, 16 Feb 2024 16:39:14 +0000 (UTC) X-FDA: 81798227028.01.CC299DA Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf03.hostedemail.com (Postfix) with ESMTP id 8C60520003 for ; Fri, 16 Feb 2024 16:39:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="P/rHKmX3"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708101552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ykstDffvORkHR/QBul+dunCrpEbnMsgllsNmRKwgALQ=; b=1s57ydZo6N0F0Cc/BPwVYcWVwckZBCHRp4G06uLaEjVhP+EF6eHIyMqBUu138TV+PLSE1S kJGACA5sLUmsXcAMwxtaUOdcOD/aBWmiNlI2tu50RiRaPi6gvxHIzAAUVsrzY3WOSD0AIE /4rXK8fGxMi33c+UxAHy+BAbGKc4SlY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="P/rHKmX3"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708101552; a=rsa-sha256; cv=none; b=KZXoQnIuLOVmRL0WGORnyTn1S6FxiQ3GeFVAc7WYNYVWekorcWNm1yiyPGbM+jEpUpiUj/ qQ53nlW/7s7xRHh6ENBVfjvsq8AWVxgx1m1HJAbJ16dBKbqg4F9JhyDyfBLmZmuIVr839F 2GKThnXhIylYSvY70VY6aJ2kNrrXWoE= Date: Fri, 16 Feb 2024 11:38:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708101549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ykstDffvORkHR/QBul+dunCrpEbnMsgllsNmRKwgALQ=; b=P/rHKmX3j/prO7tgG2j74FOBqArykGjAD+QXCi/CNWHvRgoNUgOhhnMDCES9P7PyrRETo+ l/VeuBrESrdYcr+HcB7pGshKvMzuIAFjDfuOhDowTTeo3OT984nPcJzcavwvweaH8hU/1B 3Wof2PoerJMLJIVUnvZFOQj0zf3N6Rg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 21/35] mm/slab: add allocation accounting into slab allocation and free paths Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-22-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8C60520003 X-Stat-Signature: 6c4zifdq5omdo918tyisxa5pqyefcfr6 X-Rspam-User: X-HE-Tag: 1708101552-376079 X-HE-Meta: U2FsdGVkX1+Tpip7q+4gRNTmHNygo5/uKkrf66gbtqpOVPk8ISjdPnr+1oPNfpD3zFxhyhJKTniPeph9iL8NT7HpHMmVVRQdNB+QoQuSm8E710hk60/xBSb3Mb4xdgn0xMCU9FNVMeLgmc6QfImT2YhG2KkYkI+gywdxMajFkUE7gyOPMrNiIrl86odl45qmWjSsdcjOL+AGdoxDeqdoPKKTmRg5tVIn0UGz81ipM9NoT1hRxCFQebsZILIpolUxZ7JiDdHlxKoF7QuSYJPWFt1K6D2U9ATdrTWLjMIEi1W10dejTElK2RZLQTwUIl/YPxOSROaWWQ1RcTJ5qvR7EucSGuxqAIOyyU9I10tNV2K9IQMORuQZNJCQxZzX5IprQTOROZZmhQqO1XzkCxZY+TUaPay/StETCB+Uew0pPsn0Y4mlAiuhcHlenXIgC6wc58v7FIsX0sTPEPq8OE7U9iUqVgyYtSQwuMyur4hzt5nLT227ssLR200sFzni3HaAA2E64gT9zNAEtQ0D44KMRGETduWHyrNluOOM6xn9BzWvgHdqKEGUbFLGRcn+uf0RcqRA4ZA0sOaGuocWKT1X4OeVS791RH7HVRbfYcaHV8udNR97vMGx//RjGCGuccTSkUGtRXSVI6soIyB7fylpsUbzUSu+xel4tP/KwIfgh66oKWubLXdK5XcylSI/jI+3sIBTUerrfbe93IwwqxfchYSpaapa8hsK4MHHUNVzjA/WsBwozECqeyG+G1INa2BvyAyLt8N1ilqvFQW3m3X9xTYrp2mR+RuoVfiz2KHC93SXbDEtSOb1RVlIDeasy7k4R06ux/XtyQBzNFDHMq+jnX0r5KAxlGFfRk+RsbzXKT/xgr3IHobYW1I2ZwMUPop2DD569YRiH3pTtDM66om9kj4zJnBn5K65O84hzkbMjYu/0zfNB9d25bGWsH4aHEblkmroiGtaHc3LyNjHgJY regx6ZQB /ig5zph0ArjQBmZLH1DaNYYgXx1o8E03OySUDAVGBMjqK4QTLOd0kJP56YrSM4aMqgLO7un3DYTTVt7oioOslR4THAgRiD5kc/JxpFo73rvlN2fsuwKfBN1bU5pA83HW6HNXVGLf+mndJmxkp6X+qAr2mvpEDyKKW9AgOgyQM2yPkLCvjkmqJtFzhd/+AcLMByZcnuPe60ix9R7YTp5D5euFDUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 05:31:11PM +0100, Vlastimil Babka wrote: > On 2/12/24 22:39, Suren Baghdasaryan wrote: > > Account slab allocations using codetag reference embedded into slabobj_ext. > > > > Signed-off-by: Suren Baghdasaryan > > Co-developed-by: Kent Overstreet > > Signed-off-by: Kent Overstreet > > --- > > mm/slab.h | 26 ++++++++++++++++++++++++++ > > mm/slub.c | 5 +++++ > > 2 files changed, 31 insertions(+) > > > > diff --git a/mm/slab.h b/mm/slab.h > > index 224a4b2305fb..c4bd0d5348cb 100644 > > --- a/mm/slab.h > > +++ b/mm/slab.h > > @@ -629,6 +629,32 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > > > > #endif /* CONFIG_SLAB_OBJ_EXT */ > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + > > +static inline void alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, > > + void **p, int objects) > > +{ > > + struct slabobj_ext *obj_exts; > > + int i; > > + > > + obj_exts = slab_obj_exts(slab); > > + if (!obj_exts) > > + return; > > + > > + for (i = 0; i < objects; i++) { > > + unsigned int off = obj_to_index(s, slab, p[i]); > > + > > + alloc_tag_sub(&obj_exts[off].ref, s->size); > > + } > > +} > > + > > +#else > > + > > +static inline void alloc_tagging_slab_free_hook(struct kmem_cache *s, struct slab *slab, > > + void **p, int objects) {} > > + > > +#endif /* CONFIG_MEM_ALLOC_PROFILING */ > > You don't actually use the alloc_tagging_slab_free_hook() anywhere? I see > it's in the next patch, but logically should belong to this one. I don't think it makes any sense to quibble about introducing something in one patch that's not used until the next patch; often times, it's just easier to review that way.