From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9205FC3DA4A for ; Wed, 14 Aug 2024 21:41:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E80E46B009A; Wed, 14 Aug 2024 17:41:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E30396B00AA; Wed, 14 Aug 2024 17:41:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD17A6B00AC; Wed, 14 Aug 2024 17:41:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A411D6B009A for ; Wed, 14 Aug 2024 17:41:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E2ADA8435 for ; Wed, 14 Aug 2024 21:41:28 +0000 (UTC) X-FDA: 82452172656.14.8BC8DD6 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf17.hostedemail.com (Postfix) with ESMTP id 142DD4002A for ; Wed, 14 Aug 2024 21:41:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VtnBZ7+2; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723671673; a=rsa-sha256; cv=none; b=AsXOcWPB15hAf2mNakyTvFIlZrJs52OcE770wmgb5ZUz1t1c3b11yHB7F0b+HD4m7RjAVB eyi3nm4tHqLUWi/TdzP8hssQfWPAetXGYaNIQz3sNOf2ahJbaO1LSFYlQ5hvFYlJC5imHF v5KWGbHfoVbneMQNKoEdQrKotOxg7ck= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VtnBZ7+2; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723671673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XkZH7xVDbhk7zC0mNzM98IJtjGbzpC00H/rbbebB8o8=; b=W5wJv6FY+erBjGblvCikfykha3zHX+Y/ki05bfOQeXAAkdeElj6j4gdBGNf3dm9cZblH2k 8TlvHPgEdQF0ArHkAcaLdgqkyz+Lx07k09untf2lIHFk/N/v23gj9JnSjjytc6hfIUjl7Q WLSYMhdjcEIgYtIwFLhss8jGQMBzVok= Date: Wed, 14 Aug 2024 14:41:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723671681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XkZH7xVDbhk7zC0mNzM98IJtjGbzpC00H/rbbebB8o8=; b=VtnBZ7+2ryBAY6leshpfKVYYOcVSdoAq8sDcEJZgqhk5SIjS3N1KTxoF/B7BlzLGMzcgP5 cAS5xpwDMoSmtwlUXbcDI53hk1t1TQg8Gk0OA7bsUQxM3PcQT3EhZJwd/Yejk+rClxwbN3 Q1Kv6Gsk8RCpql7Nf1nIO+9pZSzWsjE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "T.J. Mercier" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH 3/4] memcg: initiate deprecation of oom_control Message-ID: References: <20240814202825.2694077-1-shakeel.butt@linux.dev> <20240814202825.2694077-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 142DD4002A X-Rspamd-Server: rspam01 X-Stat-Signature: k4z5kqwnaotr83zgjtyz5uboz8fzfwfc X-HE-Tag: 1723671684-472988 X-HE-Meta: U2FsdGVkX19XGi1sSgJOK7L1MatPTr5KK6zO3S+b6bs34wmX2+xZKjY3tH5JxkCUs/XcQMH+Yu0Ej0gv+EPyrdUHQlvuUEIVWS8nkQ82iGrMGvdlNztOq1o/xalM6uFhR8ipnmwI77NW8VllW0HMVNuirz69ITZ40x8qyix+bdhKRDDgQYiA9YJ3k1ESHOyayychlzHtP7RyFTdBPbCFtec/0A4brf5L5aOo27PS6cH0AuPRt4T5+soL0GJAKQDK7OQl0tOfjji/C0PKbrXbnu6b00sM2wCr2LTa3mrce2V3AXaTXmvSTyFn5C57sAOvnKmPykSgpNtQbRr3sqQSVCz4GLjqmtPwTCYj35sz/nEitBTe+kzWt6kh1s05siC+YH4MkjZAX8eY44LViPKZgwb/IcQ5QHX50e9GtL8MfDTNTgLQjjf4pQDejv/L0/5FtZ1enEGlT5dtVOcDLIZhtoCzZaDGfX8SY/rs1zWQ+yWzgkL3VWwg192Yw/Pk895XlQ5fvb0E4/GCotp86qiLtVZIuZy4N88m2kZIWxgFfUBy5jPytWQS8dM9gUZUNV7olmu7xk7eIGZLxJeZAc4RaJx+DEHfOyykT7nYy71x9d//arU3eVF8BOsgY3MTmYgZNxBq/wp3gu4jUNJssApF5XLXTycHSd/Mue9f2MC5pf168bqXwdfXYGW8tnAbAu8yxXW74+1I6FJvsT13A3VL8d5B7xBjKGN0lIjdpZ04Zrhnn4e7K9fX489h6KftwrO4QhCeELKqUsq5gH9+fQiON6G0tYKe0HJIHM1/xYvP3pa/AUoj2+VE9oZy+YXq2j7doaGejKgTjVFDJNaAaBmzOwdhsSKgkNapvVw+u2OrJ2mL0GMxUic1W78G2+4pLDJdSEDedTbbD+X27JMGCub1kf4+k8Og31CKL66rOONIYSCUHSaAOqasAd0ypfKIrKTm4G8+sypZl3NIPzltjCP dynXFErL KWPyEsGAJiafi3eG7IlZenD1J6mvWujZqudH7eaBJV1RYWaXT5mFeXY/OUPh3oVskUtEKPZr5vMt/2ginr2bocLlhPI5BkuVVwekqfs3doD4JSaAeRpK5KdnyoPfkgtBqb0nZimGXZ4934qi7A+KgUk0zRGkpW4sA92YVJJ9sD+XeQNxUi3yMeCV59p+ZcNTiV/xPv0p+WhcscjU75k9u3eaTzlFoWbgPD2UnGEsw6r5u9/pj6YAvrV1y8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 02:00:03PM GMT, T.J. Mercier wrote: > On Wed, Aug 14, 2024 at 1:29 PM Shakeel Butt wrote: > > > > The oom_control provides functionality to disable memcg oom-killer, > > notifications on oom-kill and reading the stats regarding oom-kills. > > This interface was mainly introduced to provide functionality for > > userspace oom-killers. However it is not robust enough and only supports > > OOM handling in the page fault path. > > > > For v2, the users can use the combination of memory.events notifications > > and memory.high interface to provide userspace OOM-killing functionality. > > Let's start the deprecation process for v1 and gather the info on how > > the current users are using this interface and work on providing a more > > robust functionality in v2. > > > > Signed-off-by: Shakeel Butt > > --- > > Documentation/admin-guide/cgroup-v1/memory.rst | 8 ++++++-- > > mm/memcontrol-v1.c | 7 +++++++ > > 2 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst > > index afe5e95e9f7b..74cea6712d06 100644 > > --- a/Documentation/admin-guide/cgroup-v1/memory.rst > > +++ b/Documentation/admin-guide/cgroup-v1/memory.rst > > @@ -92,6 +92,8 @@ Brief summary of control files. > > This knob is deprecated and shouldn't be > > used. > > memory.oom_control set/show oom controls. > > + This knob is deprecated and shouldn't be > > + used. > > memory.numa_stat show the number of memory usage per numa > > node > > memory.kmem.limit_in_bytes Deprecated knob to set and read the kernel > > @@ -846,8 +848,10 @@ It's applicable for root and non-root cgroup. > > > > .. _cgroup-v1-memory-oom-control: > > > > -10. OOM Control > > -=============== > > +10. OOM Control (DEPRECATED) > > +============================ > > + > > +THIS IS DEPRECATED! > > > > memory.oom_control file is for OOM notification and other controls. > > > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > > index e0bb54e42011..07343e338e4e 100644 > > --- a/mm/memcontrol-v1.c > > +++ b/mm/memcontrol-v1.c > > @@ -1907,6 +1907,9 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > > event->register_event = mem_cgroup_usage_register_event; > > event->unregister_event = mem_cgroup_usage_unregister_event; > > } else if (!strcmp(name, "memory.oom_control")) { > > + pr_warn_once("oom_control is deprecated and will be removed. " > > + "Please report your usecase to linux-mm-@kvack.org" > > + " if you depend on this functionality. \n"; > > Missing close paren? Ah, thanks for catching that. I compile tested the old version before moving text around. Anyways, will resend. > > > event->register_event = mem_cgroup_oom_register_event; > > event->unregister_event = mem_cgroup_oom_unregister_event; > > } else if (!strcmp(name, "memory.pressure_level")) { > > @@ -2754,6 +2757,10 @@ static int mem_cgroup_oom_control_write(struct cgroup_subsys_state *css, > > { > > struct mem_cgroup *memcg = mem_cgroup_from_css(css); > > > > + pr_warn_once("oom_control is deprecated and will be removed. " > > + "Please report your usecase to linux-mm-@kvack.org if you " > > + "depend on this functionality. \n"; > > + > > Missing close paren? > > > /* cannot set to root cgroup and only 0 and 1 are allowed */ > > if (mem_cgroup_is_root(memcg) || !((val == 0) || (val == 1))) > > return -EINVAL; > > -- > > 2.43.5 > > > >